Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195956/?format=api
{ "id": 2195956, "url": "http://patchwork.ozlabs.org/api/patches/2195956/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260212144015.3898750-1-vincent.stehle@arm.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212144015.3898750-1-vincent.stehle@arm.com>", "list_archive_url": null, "date": "2026-02-12T14:40:15", "name": "[v2] efi_loader: fix ecpt size computation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6c27211888881164435f3895ceea78289f3e9cb3", "submitter": { "id": 77169, "url": "http://patchwork.ozlabs.org/api/people/77169/?format=api", "name": "Vincent Stehlé", "email": "vincent.stehle@arm.com" }, "delegate": { "id": 68728, "url": "http://patchwork.ozlabs.org/api/users/68728/?format=api", "username": "xypron", "first_name": "Heinrich", "last_name": "Schuchardt", "email": "xypron.glpk@gmx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260212144015.3898750-1-vincent.stehle@arm.com/mbox/", "series": [ { "id": 491984, "url": "http://patchwork.ozlabs.org/api/series/491984/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=491984", "date": "2026-02-12T14:40:15", "name": "[v2] efi_loader: fix ecpt size computation", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491984/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195956/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195956/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=fail (p=none dis=none) header.from=arm.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n dmarc=fail (p=none dis=none) header.from=arm.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=vincent.stehle@arm.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBdJ93YWbz1xr1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 01:40:25 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8D2B38388D;\n\tThu, 12 Feb 2026 15:40:22 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 9BBCB83AAB; Thu, 12 Feb 2026 15:40:21 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by phobos.denx.de (Postfix) with ESMTP id 664B683015\n for <u-boot@lists.denx.de>; Thu, 12 Feb 2026 15:40:19 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4D146339;\n Thu, 12 Feb 2026 06:40:12 -0800 (PST)", "from debian (MacBookPro.nice.arm.com [10.34.124.48])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BCBFD3F632;\n Thu, 12 Feb 2026 06:40:17 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.9 required=5.0 tests=BAYES_00,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,\n RCVD_IN_VALIDITY_RPBL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "From": "=?utf-8?q?Vincent_Stehl=C3=A9?= <vincent.stehle@arm.com>", "To": "u-boot@lists.denx.de", "Cc": "=?utf-8?q?Vincent_Stehl=C3=A9?= <vincent.stehle@arm.com>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Tom Rini <trini@konsulko.com>, Jose Marinho <jose.marinho@arm.com>", "Subject": "[PATCH v2] efi_loader: fix ecpt size computation", "Date": "Thu, 12 Feb 2026 15:40:15 +0100", "Message-ID": "<20260212144015.3898750-1-vincent.stehle@arm.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260211093308.3265022-1-vincent.stehle@arm.com>", "References": "<20260211093308.3265022-1-vincent.stehle@arm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The size of the memory allocated for the EFI Conformance Profiles Table is\ncomputed with `num_entries' always equal to zero, which is incorrect when\nCONFIG_EFI_EBBR_2_1_CONFORMANCE is enabled.\n\nThis can be verified by allocating the ECPT memory with malloc() instead of\nefi_allocate_pool(), building u-boot with sandbox_defconfig and\nCONFIG_VALGRIND=y, and by finally running the following command:\n\n valgrind --suppressions=scripts/u-boot.supp \\\n ./u-boot -T -c 'efidebug tables'\n\nFix this by using an array of the supported profiles GUIDs instead, which\nshould also be easier to extend in the future as U-Boot should publish the\nGUIDs for all supported EBBR revisions.\n\nFixes: 6b92c1735205 (\"efi: Create ECPT table\")\nSuggested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>\nSigned-off-by: Vincent Stehlé <vincent.stehle@arm.com>\nCc: Ilias Apalodimas <ilias.apalodimas@linaro.org>\nCc: Tom Rini <trini@konsulko.com>\nCc: Jose Marinho <jose.marinho@arm.com>\n---\n\n\nChanges for v2:\n- Mention in the commit message that U-Boot should publish all supported\n EBBR GUIDs (suggested by Heinrich)\n- Move the array declaration into the function (suggested by Heinrich)\n\n\n lib/efi_loader/efi_conformance.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/efi_loader/efi_conformance.c b/lib/efi_loader/efi_conformance.c\nindex 2bae93a94bd..2d31800ccb8 100644\n--- a/lib/efi_loader/efi_conformance.c\n+++ b/lib/efi_loader/efi_conformance.c\n@@ -13,8 +13,6 @@\n #include <malloc.h>\n \n static const efi_guid_t efi_ecpt_guid = EFI_CONFORMANCE_PROFILES_TABLE_GUID;\n-static const efi_guid_t efi_ebbr_2_1_guid =\n-\tEFI_CONFORMANCE_PROFILE_EBBR_2_1_GUID;\n \n /**\n * efi_ecpt_register() - Install the ECPT system table.\n@@ -23,12 +21,17 @@ static const efi_guid_t efi_ebbr_2_1_guid =\n */\n efi_status_t efi_ecpt_register(void)\n {\n-\tu16 num_entries = 0;\n \tstruct efi_conformance_profiles_table *ecpt;\n \tefi_status_t ret;\n \tsize_t ecpt_size;\n \n-\tecpt_size = num_entries * sizeof(efi_guid_t)\n+\tstatic const efi_guid_t profiles[] = {\n+\t#if CONFIG_IS_ENABLED(EFI_EBBR_2_1_CONFORMANCE)\n+\t\tEFI_CONFORMANCE_PROFILE_EBBR_2_1_GUID,\n+\t#endif\n+\t};\n+\n+\tecpt_size = sizeof(profiles)\n \t\t+ sizeof(struct efi_conformance_profiles_table);\n \tret = efi_allocate_pool(EFI_BOOT_SERVICES_DATA, ecpt_size,\n \t\t\t\t(void **)&ecpt);\n@@ -39,12 +42,9 @@ efi_status_t efi_ecpt_register(void)\n \t\treturn ret;\n \t}\n \n-\tif (CONFIG_IS_ENABLED(EFI_EBBR_2_1_CONFORMANCE))\n-\t\tguidcpy(&ecpt->conformance_profiles[num_entries++],\n-\t\t\t&efi_ebbr_2_1_guid);\n-\n+\tmemcpy(ecpt->conformance_profiles, profiles, sizeof(profiles));\n \tecpt->version = EFI_CONFORMANCE_PROFILES_TABLE_VERSION;\n-\tecpt->number_of_profiles = num_entries;\n+\tecpt->number_of_profiles = ARRAY_SIZE(profiles);\n \n \t/* Install the ECPT in the system configuration table. */\n \tret = efi_install_configuration_table(&efi_ecpt_guid, (void *)ecpt);\n", "prefixes": [ "v2" ] }