Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195866/?format=api
{ "id": 2195866, "url": "http://patchwork.ozlabs.org/api/patches/2195866/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/27c3027a6cc22b565e2a741bbf5ee7d3382e80d7.1770882260.git.poros@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<27c3027a6cc22b565e2a741bbf5ee7d3382e80d7.1770882260.git.poros@redhat.com>", "list_archive_url": null, "date": "2026-02-12T07:53:11", "name": "[iwl-net,2/2] ice: use ice_update_eth_stats() for representor stats", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "497d2a91baa407ae03ac82779d23aa37b7dd7d62", "submitter": { "id": 74657, "url": "http://patchwork.ozlabs.org/api/people/74657/?format=api", "name": "Petr Oros", "email": "poros@redhat.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/27c3027a6cc22b565e2a741bbf5ee7d3382e80d7.1770882260.git.poros@redhat.com/mbox/", "series": [ { "id": 491939, "url": "http://patchwork.ozlabs.org/api/series/491939/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=491939", "date": "2026-02-12T07:53:09", "name": "ice: fix representor stats in switchdev mode", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491939/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195866/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195866/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=a7wxa3LI;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBSGv3hGxz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 12 Feb 2026 18:53:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 4B34841D2B;\n\tThu, 12 Feb 2026 07:53:40 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id WUKSsbYwBeNp; Thu, 12 Feb 2026 07:53:38 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 7565041D21;\n\tThu, 12 Feb 2026 07:53:38 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 5085523D\n for <intel-wired-lan@lists.osuosl.org>; Thu, 12 Feb 2026 07:53:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 355EF41D2E\n for <intel-wired-lan@lists.osuosl.org>; Thu, 12 Feb 2026 07:53:37 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Kwq-UNR2V_TT for <intel-wired-lan@lists.osuosl.org>;\n Thu, 12 Feb 2026 07:53:36 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 1BC3A41D2B\n for <intel-wired-lan@lists.osuosl.org>; Thu, 12 Feb 2026 07:53:35 +0000 (UTC)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-IZa6iHvwMAmhpUru4AhRoA-1; Thu,\n 12 Feb 2026 02:53:30 -0500", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id BB41E180047F; Thu, 12 Feb 2026 07:53:28 +0000 (UTC)", "from ShadowPeak.redhat.com (unknown [10.44.32.184])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 1C4B11956095; Thu, 12 Feb 2026 07:53:24 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7565041D21", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1BC3A41D2B" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1770882818;\n\tbh=zhLQvNUouK3UgiizfA4paeEoukfLjS3QOlBKKH84PkY=;\n\th=From:To:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=a7wxa3LI++f4L621bgo1MeXyIoe29JvUcFbLQowtnUlGDj9x2ESiRcgI/5Xx2J1KH\n\t yqw5XEdGFSCe1dXYTtnJmnWoe0N2paaVTieBFhHJ257iKVYQ65YDMm81ElFKxwqYia\n\t jwEtl98y+ShC5Z+lXLvobWD1mBAMHclPEQ8RNaFbQGKl80pQf94HWvDwB3IX8Zxt3M\n\t ljfasujn6keArfs2FNzWV+Q4lQ16ifOECCL0j9LkZ6vLbVBw5QMtJZ7gxOrAm94GEX\n\t BWLXnOmtFLtgpmfxLs981NB93BLCkxsxNaCLQI+V4ngjspK9as8fpxN6i74E2aejcv\n\t 6J2wEJ7FJXUdg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=poros@redhat.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 1BC3A41D2B", "X-MC-Unique": "IZa6iHvwMAmhpUru4AhRoA-1", "X-Mimecast-MFC-AGG-ID": "IZa6iHvwMAmhpUru4AhRoA_1770882808", "From": "Petr Oros <poros@redhat.com>", "To": "netdev@vger.kernel.org", "Date": "Thu, 12 Feb 2026 08:53:11 +0100", "Message-ID": "\n <27c3027a6cc22b565e2a741bbf5ee7d3382e80d7.1770882260.git.poros@redhat.com>", "In-Reply-To": "<cover.1770882260.git.poros@redhat.com>", "References": "<cover.1770882260.git.poros@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-MFC-PROC-ID": "jrs_BcMYU0KrcpsF0ibcg4I6dwiJ-pSrvWvhHGD8lFo_1770882808", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1770882814;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=zhLQvNUouK3UgiizfA4paeEoukfLjS3QOlBKKH84PkY=;\n b=QU7SuoMBXCUn1az8dQfCRUOtw4EL53ClKfrTpbxDgBu4HNYtjD1zr0OnXhxKR9uWPMz3cU\n c+QsLs/UPStIQoHusE33Hec77ajqtlyyOxslO7ExzAFzVdU1TAFXZWIRlzDtIT/BolT4uU\n vKxyq23cZ4s86A4iVkZdenKh7cLmHK8=", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "smtp4.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QU7SuoMB" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net 2/2] ice: use\n ice_update_eth_stats() for representor stats", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Wojciech Drewek <wojciech.drewek@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Eric Dumazet <edumazet@google.com>, linux-kernel@vger.kernel.org,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n Tony Nguyen <anthony.l.nguyen@intel.com>,\n Simon Horman <horms@kernel.org>,\n Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,\n Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,\n \"David S. Miller\" <davem@davemloft.net>, intel-wired-lan@lists.osuosl.org", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "ice_repr_get_stats64() and __ice_get_ethtool_stats() call\nice_update_vsi_stats() on the VF's src_vsi. This always returns early\nbecause ICE_VSI_DOWN is permanently set for VF VSIs — ice_up() is never\ncalled on them since queues are managed by iavf through virtchnl.\n\nIn __ice_get_ethtool_stats() the original code called\nice_update_vsi_stats() for all VSIs including representors, iterated\nover ice_gstrings_vsi_stats[] to populate the data, and then bailed out\nwith an early return before the per-queue ring stats section. That early\nreturn was necessary because representor VSIs have no rings on the PF\nside — the rings belong to the VF driver (iavf), so accessing per-queue\nstats would be invalid.\n\nMove the representor handling to the top of __ice_get_ethtool_stats()\nand call ice_update_eth_stats() directly to read the hardware GLV_*\ncounters. This matches ice_get_vf_stats() which already uses\nice_update_eth_stats() for the same VF VSI in legacy mode. Apply the\nsame fix to ice_repr_get_stats64().\n\nNote that ice_gstrings_vsi_stats[] contains five software ring counters\n(rx_buf_failed, rx_page_failed, tx_linearize, tx_busy, tx_restart) that\nare always zero for representors since the PF never processes packets on\nVF rings. This is pre-existing behavior unchanged by this patch.\n\nFixes: 7aae80cef7ba (\"ice: add port representor ethtool ops and stats\")\nSigned-off-by: Petr Oros <poros@redhat.com>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 14 +++++++++++---\n drivers/net/ethernet/intel/ice/ice_repr.c | 3 ++-\n 2 files changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 3565a5d96c6d18..0b8775621f1567 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -1926,6 +1926,17 @@ __ice_get_ethtool_stats(struct net_device *netdev,\n \tint i = 0;\n \tchar *p;\n \n+\tif (ice_is_port_repr_netdev(netdev)) {\n+\t\tice_update_eth_stats(vsi);\n+\n+\t\tfor (j = 0; j < ICE_VSI_STATS_LEN; j++) {\n+\t\t\tp = (char *)vsi + ice_gstrings_vsi_stats[j].stat_offset;\n+\t\t\tdata[i++] = (ice_gstrings_vsi_stats[j].sizeof_stat ==\n+\t\t\t\t sizeof(u64)) ? *(u64 *)p : *(u32 *)p;\n+\t\t}\n+\t\treturn;\n+\t}\n+\n \tice_update_pf_stats(pf);\n \tice_update_vsi_stats(vsi);\n \n@@ -1935,9 +1946,6 @@ __ice_get_ethtool_stats(struct net_device *netdev,\n \t\t\t sizeof(u64)) ? *(u64 *)p : *(u32 *)p;\n \t}\n \n-\tif (ice_is_port_repr_netdev(netdev))\n-\t\treturn;\n-\n \t/* populate per queue stats */\n \trcu_read_lock();\n \ndiff --git a/drivers/net/ethernet/intel/ice/ice_repr.c b/drivers/net/ethernet/intel/ice/ice_repr.c\nindex 2a84f656405828..f1e82ba155cff2 100644\n--- a/drivers/net/ethernet/intel/ice/ice_repr.c\n+++ b/drivers/net/ethernet/intel/ice/ice_repr.c\n@@ -2,6 +2,7 @@\n /* Copyright (C) 2019-2021, Intel Corporation. */\n \n #include \"ice.h\"\n+#include \"ice_lib.h\"\n #include \"ice_eswitch.h\"\n #include \"devlink/devlink.h\"\n #include \"devlink/port.h\"\n@@ -67,7 +68,7 @@ ice_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)\n \t\treturn;\n \tvsi = repr->src_vsi;\n \n-\tice_update_vsi_stats(vsi);\n+\tice_update_eth_stats(vsi);\n \teth_stats = &vsi->eth_stats;\n \n \tstats->tx_packets = eth_stats->tx_unicast + eth_stats->tx_broadcast +\n", "prefixes": [ "iwl-net", "2/2" ] }