Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195865/?format=api
{ "id": 2195865, "url": "http://patchwork.ozlabs.org/api/patches/2195865/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/a76096058dd9b6d0cccaa5c2c699458351d02cec.1770882260.git.poros@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<a76096058dd9b6d0cccaa5c2c699458351d02cec.1770882260.git.poros@redhat.com>", "list_archive_url": null, "date": "2026-02-12T07:53:10", "name": "[iwl-net,1/2] ice: fix inverted ready check for VF representors", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "c09f9bcff669029503e40394e81da06133c1cfff", "submitter": { "id": 74657, "url": "http://patchwork.ozlabs.org/api/people/74657/?format=api", "name": "Petr Oros", "email": "poros@redhat.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/a76096058dd9b6d0cccaa5c2c699458351d02cec.1770882260.git.poros@redhat.com/mbox/", "series": [ { "id": 491939, "url": "http://patchwork.ozlabs.org/api/series/491939/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=491939", "date": "2026-02-12T07:53:09", "name": "ice: fix representor stats in switchdev mode", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491939/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195865/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195865/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=Xp8Feb7L;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBSGq673Kz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 12 Feb 2026 18:53:39 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id D6B3641D24;\n\tThu, 12 Feb 2026 07:53:34 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id q8Q7raLxV_ce; Thu, 12 Feb 2026 07:53:32 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C804141D2B;\n\tThu, 12 Feb 2026 07:53:32 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 3F0951F6\n for <intel-wired-lan@lists.osuosl.org>; Thu, 12 Feb 2026 07:53:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 2D813611F0\n for <intel-wired-lan@lists.osuosl.org>; Thu, 12 Feb 2026 07:53:31 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id x00nmGofPxhE for <intel-wired-lan@lists.osuosl.org>;\n Thu, 12 Feb 2026 07:53:30 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 20440608DC\n for <intel-wired-lan@lists.osuosl.org>; Thu, 12 Feb 2026 07:53:29 +0000 (UTC)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-g6NO0SaEPuKom6REr-TJUA-1; Thu,\n 12 Feb 2026 02:53:27 -0500", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C2DE118003F5; Thu, 12 Feb 2026 07:53:24 +0000 (UTC)", "from ShadowPeak.redhat.com (unknown [10.44.32.184])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 2B34A1956095; Thu, 12 Feb 2026 07:53:19 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org C804141D2B", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 20440608DC" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1770882812;\n\tbh=Ut8Fsw1R4tT50gfU2dQi99Xi0AipmBKvrl6DGwx0NTU=;\n\th=From:To:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=Xp8Feb7LUqkeQ5hB7CjHb3RCFlXmQVSxI59AgXH8KiJxp2qtqPWHa3PNWk1BpMkbX\n\t rdWojq27S7fjY7cNeFNVht/WRRlPrRLiogzDibAWygXkuUfbQn+oP3EN3p2k3JeCXJ\n\t +hFQcNsN8rYNsLE/3oWs/04Gu52Rx8qWVzvmweMJG3Zhv+YgBWNa8fSueDkOX8J8xg\n\t gM+7PSFE0L6Vrj0POfFCHXeKjgHILLKRqG8ZK/+rWbn1drodw2pkgvok0irm6py/e4\n\t D7wvYubgJ0AeVTvXPJYmuZoOwULP1cXHQrwdGKxft7JlnmZjW7n2+k536ibOtF139u\n\t wwz7YeZUPBOhA==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=poros@redhat.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org 20440608DC", "X-MC-Unique": "g6NO0SaEPuKom6REr-TJUA-1", "X-Mimecast-MFC-AGG-ID": "g6NO0SaEPuKom6REr-TJUA_1770882805", "From": "Petr Oros <poros@redhat.com>", "To": "netdev@vger.kernel.org", "Date": "Thu, 12 Feb 2026 08:53:10 +0100", "Message-ID": "\n <a76096058dd9b6d0cccaa5c2c699458351d02cec.1770882260.git.poros@redhat.com>", "In-Reply-To": "<cover.1770882260.git.poros@redhat.com>", "References": "<cover.1770882260.git.poros@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-MFC-PROC-ID": "lu8gutjcY3xA_ZS3zCVxAmOoQoO2b21umPJ9dntdDyk_1770882805", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1770882808;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Ut8Fsw1R4tT50gfU2dQi99Xi0AipmBKvrl6DGwx0NTU=;\n b=i5ypynOdd3aP1k3ZOyM0/1XQaCv9RkbiTVGdG2udoa4YEQm9JpSpfRlfpcrt6kI4AXC32C\n hDEakIQDa8UmrbfCNKREXG159PtVF93eZ70+c2GzPs7FMgRrJsXxFYsidyuT6T8RjK6g89\n D92ChDj7l8dNIf4+Yu5cszKKjBfISWE=", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "smtp3.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=i5ypynOd" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net 1/2] ice: fix inverted ready check\n for VF representors", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Wojciech Drewek <wojciech.drewek@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Eric Dumazet <edumazet@google.com>, linux-kernel@vger.kernel.org,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n Tony Nguyen <anthony.l.nguyen@intel.com>,\n Simon Horman <horms@kernel.org>,\n Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,\n Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,\n \"David S. Miller\" <davem@davemloft.net>, intel-wired-lan@lists.osuosl.org", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Commit 0f00a897c9fcbd (\"ice: check if SF is ready in ethtool ops\")\nrefactored the VF readiness check into a generic repr->ops.ready()\ncallback but implemented ice_repr_ready_vf() with inverted logic:\n\n return !ice_check_vf_ready_for_cfg(repr->vf);\n\nice_check_vf_ready_for_cfg() returns 0 on success, so the negation\nmakes ready() return non-zero when the VF is ready. All callers treat\nnon-zero as \"not ready, skip\", causing ndo_get_stats64, get_drvinfo,\nget_strings and get_ethtool_stats to always bail out in switchdev mode.\n\nRemove the erroneous negation. The SF variant ice_repr_ready_sf() is\nalready correct (returns !active, i.e. non-zero when not active).\n\nFixes: 0f00a897c9fcbd (\"ice: check if SF is ready in ethtool ops\")\nSigned-off-by: Petr Oros <poros@redhat.com>\n---\n drivers/net/ethernet/intel/ice/ice_repr.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_repr.c b/drivers/net/ethernet/intel/ice/ice_repr.c\nindex cb08746556a670..2a84f656405828 100644\n--- a/drivers/net/ethernet/intel/ice/ice_repr.c\n+++ b/drivers/net/ethernet/intel/ice/ice_repr.c\n@@ -315,7 +315,7 @@ ice_repr_reg_netdev(struct net_device *netdev, const struct net_device_ops *ops)\n \n static int ice_repr_ready_vf(struct ice_repr *repr)\n {\n-\treturn !ice_check_vf_ready_for_cfg(repr->vf);\n+\treturn ice_check_vf_ready_for_cfg(repr->vf);\n }\n \n static int ice_repr_ready_sf(struct ice_repr *repr)\n", "prefixes": [ "iwl-net", "1/2" ] }