Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195856/?format=api
{ "id": 2195856, "url": "http://patchwork.ozlabs.org/api/patches/2195856/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212062522.99565-23-anisinha@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212062522.99565-23-anisinha@redhat.com>", "list_archive_url": null, "date": "2026-02-12T06:25:06", "name": "[v4,22/31] kvm/i8254: refactor pit initialization into a helper", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ca8a8f898fb5567f4e8d77f8027235c00636a4d2", "submitter": { "id": 86030, "url": "http://patchwork.ozlabs.org/api/people/86030/?format=api", "name": "Ani Sinha", "email": "anisinha@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212062522.99565-23-anisinha@redhat.com/mbox/", "series": [ { "id": 491935, "url": "http://patchwork.ozlabs.org/api/series/491935/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491935", "date": "2026-02-12T06:24:45", "name": "Introduce support for confidential guest reset (x86)", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/491935/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195856/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195856/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=E00qI7/x;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=oFKxr40o;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBQQ16XkRz1xvb\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 12 Feb 2026 17:29:45 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqQAl-0000aL-Ku; Thu, 12 Feb 2026 01:27:31 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <anisinha@redhat.com>)\n id 1vqQAJ-0000DF-3p\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 01:27:03 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <anisinha@redhat.com>)\n id 1vqQAH-0005L2-Ge\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 01:27:02 -0500", "from mail-pg1-f197.google.com (mail-pg1-f197.google.com\n [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-41-Vk9jKtBYPpK3MpMctRupRQ-1; Thu, 12 Feb 2026 01:26:59 -0500", "by mail-pg1-f197.google.com with SMTP id\n 41be03b00d2f7-c6de2c762aaso7163339a12.3\n for <qemu-devel@nongnu.org>; Wed, 11 Feb 2026 22:26:58 -0800 (PST)", "from rhel9-box.lan ([122.164.27.113])\n by smtp.googlemail.com with ESMTPSA id\n 98e67ed59e1d1-3567e7d95d8sm4894122a91.2.2026.02.11.22.26.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 11 Feb 2026 22:26:43 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770877620;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=UZjupKNTcRQ4mvrXCw54dQwnzt6+1apWExSeFIvKWxA=;\n b=E00qI7/xJTtascKmyzCFBaBkMvpssx986fI85uKZliYzrd0U6hYEKaONMHUvpAZxxq9f0k\n XSg5SVPCxFm0BBr7m1ZsIZM9sdxcLI++fVZlECNgwmx6Jq87QHd4OOLex60bNISu9sdqQd\n vhtZ3hEE1p3D7pl+ny77E3K3k3L1czw=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1770877618; x=1771482418; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=UZjupKNTcRQ4mvrXCw54dQwnzt6+1apWExSeFIvKWxA=;\n b=oFKxr40o7hbCh8RBA/iyGRHpymxTLoBJX/mSQWTG5NLY1NVeSexLTNmasjUxqNgn9v\n X0quYhi1Qu1e/C4M1AFCvAPhSpemrh5dzEgHmVbcNfTJBwhuduMEhMkuEP1RzfjoSggI\n UIRmrDcVbqBcqp3pg6OhR2FbVbjn2Vm7h9Ah66XEVqWAbPrXwXXIRdO1lvmKS1iKWJkt\n TAIus2QpIYU3lZXqRmpDh/s/58VtmXG686TpveDjzSoa5N6c7hpcHspKu9UVeKDIU71k\n negrqWqcAieHiIQgOQFn1rvxwA5TpR7ejzkAZmrayadJc30zaJj2yF3lMhsLSF7f0X5K\n 4DqQ==" ], "X-MC-Unique": "Vk9jKtBYPpK3MpMctRupRQ-1", "X-Mimecast-MFC-AGG-ID": "Vk9jKtBYPpK3MpMctRupRQ_1770877618", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770877618; x=1771482418;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=UZjupKNTcRQ4mvrXCw54dQwnzt6+1apWExSeFIvKWxA=;\n b=RcXDsK7ra9MjlodJ/mjg5/4Eqz+TcLLMcYFqR/r7gKMVMr9fXqvGEeYD2QDKNKXkYO\n ZhRhCm0byqrvBQnXfMCJUf+NUjckLigMIJZdyBpBi1R95TEfbF6tUg4UD/z9ycmrw1DC\n gYpNBUsDmvIIqwwkl55l7szMBUhpztnxmhJMrHouufnEuy4mXsSIYjxXXMwijYfGTnsh\n aSMgbwbOLefenRk6M/AZI1MVfLQsu8R/qVgleUyAvcjRSfWyfzFUaVDfm5k6BZw6HIol\n Cu0/oV0ScKoD2pSht3CQ3rGyTtL6YkSK7/EyrNnxTJ1GMQMEGu4AgZE4teg1PTHHSUfQ\n PK5Q==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCUbwYZdVGD1R7uW621/1olPJEk4zWRYlulDmW3BCxIVdbHyaBkALES8XMxnpo0u5iYB2F4XjyPyzSv1@nongnu.org", "X-Gm-Message-State": "AOJu0Yz72FgsDN1yxWVgiyJGCyeSohKW00Qp8JXsmNrlbtvTlQiEAvDB\n 0PQhqt1LAiP5p2BJdwl9h7EGLWloiSbsSVqMIfqHXnPB0iBXROii4bvDY23HHWOn7QORNUOA/bn\n 8d5ntOyk0+Q3l7KZ85lW4gJNXcLBQS4hVuNFIK4yAPZH+WYuzsjoNfHyn", "X-Gm-Gg": "AZuq6aKKd+L0W6BlGGpvHKfbC9eBy1Z1I2NNxdSrbYbaWc3POfO6HMz/ucxQpIAvsXj\n wvWPMHFgZRZIA1wI7gieJXYZ/1wiOFlnty+ihXUnLAqyThIPFnL3vBued/mEwdz9p7snJLYSrES\n +UKsdZZeq/hyzu5mhiJ8WZymqcdQffbjN0wJz44PLvPn10gEO0HCbDqPvTxRbZsSO9kdqgP97jq\n zC3kMM2bZg1UDs1I93SgkXglPIbQ1dkxikZgTYSwnlW2ozhDVqIlsAPSUgmnmUwDAe8qD6Ek0O/\n n+mqHOwKj2dnfqOG5D0h/YU67mPqg31mruptgAbLbI8fjR2X2KND+f4PWusikcgq5rV4C8pcS76\n ClyJQjAlI8C2nIWUfwpKUPoo9NuvJFV5hNR0pg2CeKsxfaG5TPoelUG0=", "X-Received": [ "by 2002:a05:6a21:9d83:b0:393:39a0:f1e5 with SMTP id\n adf61e73a8af0-39448833aecmr1749573637.48.1770877617872;\n Wed, 11 Feb 2026 22:26:57 -0800 (PST)", "by 2002:a05:6a21:9d83:b0:393:39a0:f1e5 with SMTP id\n adf61e73a8af0-39448833aecmr1749052637.48.1770877604107;\n Wed, 11 Feb 2026 22:26:44 -0800 (PST)" ], "From": "Ani Sinha <anisinha@redhat.com>", "To": "Paolo Bonzini <pbonzini@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Eduardo Habkost <eduardo@habkost.net>,\n \"Michael S. Tsirkin\" <mst@redhat.com>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>", "Cc": "kraxel@redhat.com, Ani Sinha <anisinha@redhat.com>, qemu-devel@nongnu.org", "Subject": "[PATCH v4 22/31] kvm/i8254: refactor pit initialization into a helper", "Date": "Thu, 12 Feb 2026 11:55:06 +0530", "Message-ID": "<20260212062522.99565-23-anisinha@redhat.com>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20260212062522.99565-1-anisinha@redhat.com>", "References": "<20260212062522.99565-1-anisinha@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=anisinha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The initialization code will be used again by VM file descriptor change\nnotifier callback in a subsequent change. So refactor common code into a new\nhelper function.\n\nSigned-off-by: Ani Sinha <anisinha@redhat.com>\n---\n hw/i386/kvm/i8254.c | 68 +++++++++++++++++++++++++--------------------\n 1 file changed, 38 insertions(+), 30 deletions(-)", "diff": "diff --git a/hw/i386/kvm/i8254.c b/hw/i386/kvm/i8254.c\nindex 81e742f866..255047458a 100644\n--- a/hw/i386/kvm/i8254.c\n+++ b/hw/i386/kvm/i8254.c\n@@ -60,6 +60,43 @@ struct KVMPITClass {\n DeviceRealize parent_realize;\n };\n \n+static void do_pit_initialize(KVMPITState *s, Error **errp)\n+{\n+ struct kvm_pit_config config = {\n+ .flags = 0,\n+ };\n+ int ret;\n+\n+ ret = kvm_vm_ioctl(kvm_state, KVM_CREATE_PIT2, &config);\n+ if (ret < 0) {\n+ error_setg(errp, \"Create kernel PIC irqchip failed: %s\",\n+ strerror(-ret));\n+ return;\n+ }\n+ switch (s->lost_tick_policy) {\n+ case LOST_TICK_POLICY_DELAY:\n+ break; /* enabled by default */\n+ case LOST_TICK_POLICY_DISCARD:\n+ if (kvm_check_extension(kvm_state, KVM_CAP_REINJECT_CONTROL)) {\n+ struct kvm_reinject_control control = { .pit_reinject = 0 };\n+\n+ ret = kvm_vm_ioctl(kvm_state, KVM_REINJECT_CONTROL, &control);\n+ if (ret < 0) {\n+ error_setg(errp,\n+ \"Can't disable in-kernel PIT reinjection: %s\",\n+ strerror(-ret));\n+ return;\n+ }\n+ }\n+ break;\n+ default:\n+ error_setg(errp, \"Lost tick policy not supported.\");\n+ return;\n+ }\n+\n+ return;\n+}\n+\n static void kvm_pit_update_clock_offset(KVMPITState *s)\n {\n int64_t offset, clock_offset;\n@@ -241,42 +278,13 @@ static void kvm_pit_realizefn(DeviceState *dev, Error **errp)\n PITCommonState *pit = PIT_COMMON(dev);\n KVMPITClass *kpc = KVM_PIT_GET_CLASS(dev);\n KVMPITState *s = KVM_PIT(pit);\n- struct kvm_pit_config config = {\n- .flags = 0,\n- };\n- int ret;\n \n if (!kvm_check_extension(kvm_state, KVM_CAP_PIT_STATE2) ||\n !kvm_check_extension(kvm_state, KVM_CAP_PIT2)) {\n error_setg(errp, \"In-kernel PIT not available\");\n }\n \n- ret = kvm_vm_ioctl(kvm_state, KVM_CREATE_PIT2, &config);\n- if (ret < 0) {\n- error_setg(errp, \"Create kernel PIC irqchip failed: %s\",\n- strerror(-ret));\n- return;\n- }\n- switch (s->lost_tick_policy) {\n- case LOST_TICK_POLICY_DELAY:\n- break; /* enabled by default */\n- case LOST_TICK_POLICY_DISCARD:\n- if (kvm_check_extension(kvm_state, KVM_CAP_REINJECT_CONTROL)) {\n- struct kvm_reinject_control control = { .pit_reinject = 0 };\n-\n- ret = kvm_vm_ioctl(kvm_state, KVM_REINJECT_CONTROL, &control);\n- if (ret < 0) {\n- error_setg(errp,\n- \"Can't disable in-kernel PIT reinjection: %s\",\n- strerror(-ret));\n- return;\n- }\n- }\n- break;\n- default:\n- error_setg(errp, \"Lost tick policy not supported.\");\n- return;\n- }\n+ do_pit_initialize(s, errp);\n \n memory_region_init_io(&pit->ioports, OBJECT(dev), NULL, NULL, \"kvm-pit\", 4);\n \n", "prefixes": [ "v4", "22/31" ] }