Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195850/?format=api
{ "id": 2195850, "url": "http://patchwork.ozlabs.org/api/patches/2195850/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212062522.99565-15-anisinha@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212062522.99565-15-anisinha@redhat.com>", "list_archive_url": null, "date": "2026-02-12T06:24:58", "name": "[v4,14/31] i386/tdx: refactor TDX firmware memory initialization code into a new function", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "217a6e0c47d57a55f17e811feb40c99844a5b313", "submitter": { "id": 86030, "url": "http://patchwork.ozlabs.org/api/people/86030/?format=api", "name": "Ani Sinha", "email": "anisinha@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212062522.99565-15-anisinha@redhat.com/mbox/", "series": [ { "id": 491935, "url": "http://patchwork.ozlabs.org/api/series/491935/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491935", "date": "2026-02-12T06:24:45", "name": "Introduce support for confidential guest reset (x86)", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/491935/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195850/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195850/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=fGRnX71G;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=exVYpTtF;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBQPS0pRrz1xvb\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 12 Feb 2026 17:29:16 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqQ9h-0007pR-Ge; Thu, 12 Feb 2026 01:26:25 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <anisinha@redhat.com>)\n id 1vqQ9g-0007of-0V\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 01:26:24 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <anisinha@redhat.com>)\n id 1vqQ9e-0005GJ-Jd\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 01:26:23 -0500", "from mail-pg1-f197.google.com (mail-pg1-f197.google.com\n [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-404-FzaEgHZUM0S_ONheAyyv-A-1; Thu, 12 Feb 2026 01:26:20 -0500", "by mail-pg1-f197.google.com with SMTP id\n 41be03b00d2f7-c6df833e1efso6933432a12.2\n for <qemu-devel@nongnu.org>; Wed, 11 Feb 2026 22:26:20 -0800 (PST)", "from rhel9-box.lan ([122.164.27.113])\n by smtp.googlemail.com with ESMTPSA id\n 98e67ed59e1d1-3567e7d95d8sm4894122a91.2.2026.02.11.22.26.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 11 Feb 2026 22:26:18 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770877582;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=r0oM0RRyjLelkT0G5RoaNy8SGcq/Mnkz7KKwnwr3WCA=;\n b=fGRnX71GZoCIBlz6/VE0TQ4CLRcX++ecFB5Sw5Lh8QDYjBgDPtk+hS04UiTKr5vIvPGB1m\n afbP0qEfczZ6Sp3fsf9B/ueO/LUZZbuU908ClhEGknCOxftXS8s2c00jzTccs7BqoVJAqj\n qPJGCIgIgWgrDPt2ld/5bdrGsOjsT6o=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1770877579; x=1771482379; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=r0oM0RRyjLelkT0G5RoaNy8SGcq/Mnkz7KKwnwr3WCA=;\n b=exVYpTtFNzpsX8XvIeRXRqEO5+bqRnQFiJh+7xWbq/tz7QRZf5lwzH1+te3gGpGAhz\n xkWLlDHuq4GL9sl/ZjOmlJG365AYdfn8AMoMVC73oU5qMgATKNp8dOac423/pzyX2RSJ\n P53+QfpXS5tmsHLQ+VI7XzsGtzlQpTUgX+HdW53qk5iVi51l/0VN+Z0ioBGwkFrkC0uA\n WK6/1OSrErosWbDHYAQl4A3r3qLNIsSSPD/y1tcAmQbW6zf1kHJ9qS/UlpmAyLAh6LCL\n j7Fn4bm4hQfAb98iKwY1/OLK3O/Wnx1niN4eeaJI6ElNccRSVqnsM0se8kSGHPoad0BC\n Ajew==" ], "X-MC-Unique": "FzaEgHZUM0S_ONheAyyv-A-1", "X-Mimecast-MFC-AGG-ID": "FzaEgHZUM0S_ONheAyyv-A_1770877579", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770877579; x=1771482379;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=r0oM0RRyjLelkT0G5RoaNy8SGcq/Mnkz7KKwnwr3WCA=;\n b=h8qv1rxKMv6No0VLQZwS/hac5y1L/SVFKeDx+lgPp/XGxmgJ2Uagmq6zSshGsQFeKW\n 7zoD/v5OPwYeidgNuKIL7hGANAADzyvA9bSB6kvePgK6dL5P7YJUGBk7bM6lKwg945fe\n qMaEkPEPfd1JHdjQHE1MEjGfsHj/t51sLITNRN3pPLOxot7vH4N/H063IZlEOF6BSYl1\n 27qyJN45sWTxBAv4s2VNFByUeUA3Ear3P8NNMARlYTYwDQMzuE4bO2kUVERb1NW4s+Bu\n DZRNMbkZ04o9nFL+nH5W9pbBj7KHCSB7651x2NMXodrTAhokMqXOYK7KlpBGrVUZidbb\n 1N3g==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCVRMTuEhTrITKc8I1FYxHMnsuSrFO0vrqFpYFA5RzKDRaNSRZEYaMJaHRdFPAz0ksfp5IiKWZt1UyHk@nongnu.org", "X-Gm-Message-State": "AOJu0YxtKZoiOe7cUylF5tXeR4uHt1A7CCC0puz1r+SqJXu62rBKtt/s\n +knpbUYLOfCQADVFBAq8PkmUMLRXIB32LXK/4NcjJnKYeoI+ghgmtDL80txra4bjEPHzgkHQQ80\n mZVxsltiotmW6oR6K7e4WKx2/hMtoAeXl9WGxV00UgjP2q+PS9Y8rR/4C", "X-Gm-Gg": "AZuq6aJIgt5EU3hhmhtNChyMECvEi8Hv878bULIMKGvr6vdJT/rucgdvDnYaF1nn+XT\n gT2D5+UUDD4WzpTsrjA6MTKvDy+KXN8FFcxcgzqVU1uDv+8wBiOKoPL0lie1xrHKLoOeB1lqlsB\n ORxlVEL3KLvUbFBaps4zxN3jdAdkAsxyKZB9beTWUo89s3eRe0V6aPFWgg+yTVpBuCaYol10UMl\n KR5ErXk7I3eOUqeTCRzGf1u5E6QnpeRn4ZhekQvmvZ5wGu/UKhYzF0K8OkBsfQKJr2PaufJG4AN\n CN+iwh7IH8LK4ekAxt52SfdwMT0lgPmuPVAkkXxvejjRF7+0qoLgfY3r2LqOZQaXtk1tVVBrq64\n 5CWUVaVAXpT24r2uDr4SYKk0QZgwIprjx3BcY6Ud6gOdJX+Fy3/0z9as=", "X-Received": [ "by 2002:a05:6a20:430c:b0:394:426b:6791 with SMTP id\n adf61e73a8af0-3944897ea20mr1572075637.79.1770877579384;\n Wed, 11 Feb 2026 22:26:19 -0800 (PST)", "by 2002:a05:6a20:430c:b0:394:426b:6791 with SMTP id\n adf61e73a8af0-3944897ea20mr1572056637.79.1770877579043;\n Wed, 11 Feb 2026 22:26:19 -0800 (PST)" ], "From": "Ani Sinha <anisinha@redhat.com>", "To": "Paolo Bonzini <pbonzini@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>", "Cc": "kraxel@redhat.com, Ani Sinha <anisinha@redhat.com>, kvm@vger.kernel.org,\n qemu-devel@nongnu.org", "Subject": "[PATCH v4 14/31] i386/tdx: refactor TDX firmware memory\n initialization code into a new function", "Date": "Thu, 12 Feb 2026 11:54:58 +0530", "Message-ID": "<20260212062522.99565-15-anisinha@redhat.com>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20260212062522.99565-1-anisinha@redhat.com>", "References": "<20260212062522.99565-1-anisinha@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=anisinha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "A new helper function is introduced that refactors all firmware memory\ninitialization code into a separate function. No functional change.\n\nSigned-off-by: Ani Sinha <anisinha@redhat.com>\n---\n target/i386/kvm/tdx.c | 73 ++++++++++++++++++++++++-------------------\n 1 file changed, 40 insertions(+), 33 deletions(-)", "diff": "diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c\nindex a3e81e1c0c..fd8e3de969 100644\n--- a/target/i386/kvm/tdx.c\n+++ b/target/i386/kvm/tdx.c\n@@ -295,14 +295,51 @@ static void tdx_post_init_vcpus(void)\n }\n }\n \n-static void tdx_finalize_vm(Notifier *notifier, void *unused)\n+static void tdx_init_fw_mem_region(void)\n {\n TdxFirmware *tdvf = &tdx_guest->tdvf;\n TdxFirmwareEntry *entry;\n- RAMBlock *ram_block;\n Error *local_err = NULL;\n int r;\n \n+ for_each_tdx_fw_entry(tdvf, entry) {\n+ struct kvm_tdx_init_mem_region region;\n+ uint32_t flags;\n+\n+ region = (struct kvm_tdx_init_mem_region) {\n+ .source_addr = (uintptr_t)entry->mem_ptr,\n+ .gpa = entry->address,\n+ .nr_pages = entry->size >> 12,\n+ };\n+\n+ flags = entry->attributes & TDVF_SECTION_ATTRIBUTES_MR_EXTEND ?\n+ KVM_TDX_MEASURE_MEMORY_REGION : 0;\n+\n+ do {\n+ error_free(local_err);\n+ local_err = NULL;\n+ r = tdx_vcpu_ioctl(first_cpu, KVM_TDX_INIT_MEM_REGION, flags,\n+ ®ion, &local_err);\n+ } while (r == -EAGAIN || r == -EINTR);\n+ if (r < 0) {\n+ error_report_err(local_err);\n+ exit(1);\n+ }\n+\n+ if (entry->type == TDVF_SECTION_TYPE_TD_HOB ||\n+ entry->type == TDVF_SECTION_TYPE_TEMP_MEM) {\n+ qemu_ram_munmap(-1, entry->mem_ptr, entry->size);\n+ entry->mem_ptr = NULL;\n+ }\n+ }\n+}\n+\n+static void tdx_finalize_vm(Notifier *notifier, void *unused)\n+{\n+ TdxFirmware *tdvf = &tdx_guest->tdvf;\n+ TdxFirmwareEntry *entry;\n+ RAMBlock *ram_block;\n+\n tdx_init_ram_entries();\n \n for_each_tdx_fw_entry(tdvf, entry) {\n@@ -339,37 +376,7 @@ static void tdx_finalize_vm(Notifier *notifier, void *unused)\n tdvf_hob_create(tdx_guest, tdx_get_hob_entry(tdx_guest));\n \n tdx_post_init_vcpus();\n-\n- for_each_tdx_fw_entry(tdvf, entry) {\n- struct kvm_tdx_init_mem_region region;\n- uint32_t flags;\n-\n- region = (struct kvm_tdx_init_mem_region) {\n- .source_addr = (uintptr_t)entry->mem_ptr,\n- .gpa = entry->address,\n- .nr_pages = entry->size >> 12,\n- };\n-\n- flags = entry->attributes & TDVF_SECTION_ATTRIBUTES_MR_EXTEND ?\n- KVM_TDX_MEASURE_MEMORY_REGION : 0;\n-\n- do {\n- error_free(local_err);\n- local_err = NULL;\n- r = tdx_vcpu_ioctl(first_cpu, KVM_TDX_INIT_MEM_REGION, flags,\n- ®ion, &local_err);\n- } while (r == -EAGAIN || r == -EINTR);\n- if (r < 0) {\n- error_report_err(local_err);\n- exit(1);\n- }\n-\n- if (entry->type == TDVF_SECTION_TYPE_TD_HOB ||\n- entry->type == TDVF_SECTION_TYPE_TEMP_MEM) {\n- qemu_ram_munmap(-1, entry->mem_ptr, entry->size);\n- entry->mem_ptr = NULL;\n- }\n- }\n+ tdx_init_fw_mem_region();\n \n /*\n * TDVF image has been copied into private region above via\n", "prefixes": [ "v4", "14/31" ] }