Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195815/?format=api
{ "id": 2195815, "url": "http://patchwork.ozlabs.org/api/patches/2195815/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212033435.3598-6-ltaylorsimpson@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212033435.3598-6-ltaylorsimpson@gmail.com>", "list_archive_url": null, "date": "2026-02-12T03:34:32", "name": "[5/8] Hexagon (target/hexagon) Check each opcode against current CPU version", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e313403326f26b99674982ed39db03d01cd5e72a", "submitter": { "id": 86757, "url": "http://patchwork.ozlabs.org/api/people/86757/?format=api", "name": "Taylor Simpson", "email": "ltaylorsimpson@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212033435.3598-6-ltaylorsimpson@gmail.com/mbox/", "series": [ { "id": 491930, "url": "http://patchwork.ozlabs.org/api/series/491930/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491930", "date": "2026-02-12T03:34:34", "name": "Hexagon (target/hexagon) Check opcodes versions", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491930/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195815/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195815/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=lCY9FB7P;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBLXv42q2z1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 12 Feb 2026 14:35:27 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqNTc-0007jF-KO; Wed, 11 Feb 2026 22:34:48 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <ltaylorsimpson@gmail.com>)\n id 1vqNTb-0007if-3x\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 22:34:47 -0500", "from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <ltaylorsimpson@gmail.com>)\n id 1vqNTZ-0008Hl-OY\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 22:34:46 -0500", "by mail-ot1-x32d.google.com with SMTP id\n 46e09a7af769-7d45d37f8e4so1500592a34.0\n for <qemu-devel@nongnu.org>; Wed, 11 Feb 2026 19:34:45 -0800 (PST)", "from taylor-ubuntu.. (c-67-172-136-152.hsd1.co.comcast.net.\n [67.172.136.152]) by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7d4a76e1b0csm2682858a34.14.2026.02.11.19.34.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 11 Feb 2026 19:34:44 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1770867284; x=1771472084; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=0C9mKY9bS8naSm+Nlm3pxudoZqNzxShH72AlppPstKs=;\n b=lCY9FB7PcEudwcpMVW62JnXEDrSsc0MSwkojFMokxHsPxNwX1jgnzxYYE98Cvl0Dpd\n uEwDAC6jJ+6c+nlpeac0uv25lugPl6LAoOXF9s+Y0AQXraD3leimwyvRrNatrE5XxvP+\n wi8DKVeBi5XPx6bNV7DNTMUJSAnqM/4gRxOL+1Ta9AifGDbYbqb+JZLflwR5OAMSzply\n X5SZRg3pd2Fr3hHfw6Gk2tT1f2fVgTH7ESiH1eDsThbsECEEy3Jk5eIFgcSCrbtAfxLP\n V0M9HGmg22fJw0BLd9NaDX7fgO1a+bkYvB8+tc6+/rDCX+a3vWV2tpLYqFuTpuZnNL+Q\n wMig==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770867284; x=1771472084;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=0C9mKY9bS8naSm+Nlm3pxudoZqNzxShH72AlppPstKs=;\n b=cJovOm8vOz+BWQvVUa7UW2J+m8G+m2X+0sAuVn0HvOWWxeRmr6M95vXkQZGtStaeRE\n RUcb80nvjVBm9gYYj7zBQm+sZChc6JGPM3x0P3pDgX325kWBLGaUEHjGBXdYcTUERJau\n FJoAqo5+89Rs6l+qxbylSIFqLbtaSozkiQInTSm8isZmLfOYTL+N5hoNAHwctCU8dZHT\n /7Htfl2WTnxXyi6Z7RT0nAMZA5Pfu+W5417bvAke80GpH0kd7xd5F82zpRsEyyCJP+ZY\n PdRkBB8kULz2EFxDKzfG7Yjji0j3hbdQUSK32KGmHnvl94sLe3dCpiyMIXyWDaW/ASOQ\n 74dg==", "X-Gm-Message-State": "AOJu0YzMaC92VayLunS435y06jgGwkXuWh39VEuEGq+9HZ8aN0RxP+wS\n I6+UutSXPxcTakof/6uIfvSSDA+pjBlZP+8D0boQCIjUjxNkttimgE1SHUaKfQ==", "X-Gm-Gg": "AZuq6aIWUQGvmCcP8vOJVgXYgomelO/utLkKykfZHU28cHfAVurFRPFHKDop7XbBoAu\n NhN8BdQqxXlgQVVWD4oaAL0t5dw7kNL4iJSXE2pfxGpU5Sv0tEieYj4PQbdz9OjBudxiUY+/n/E\n G4m6VBYEQhIhjYKyJpyFhYbOLY0xZxHw94qzdgbmYTiqSqYvaRMyrt6TwLb8B3CCmcay1OTeQrn\n VpyJNQIioIHDRyygpYmHbCwM7cEq/t2+e3aoowwqSHwGpPAgKQLmzm4EUtGJ5sYYnzomj0PAswU\n 1eaUOqC+0Hy0AO5wzIFxOQmo3Ds/ylxctjW00OmMN3rG6R3ipFug+TvlmoEQv7zP1AgSnDibtEo\n H7DBz1XO9fySZStn47nhm+QjXi17KB61Um/z2gZmX6+CLclrwSbGtXG0/bhqs60OXsaTGtfG3g8\n WQiS0z7pHeydNA0nfdY9szzIjZIVCTR6QpHqsKjsn3ZcA9hwTpJ9bECkbw1zqAIb6Mg/GgrABPZ\n 09LcuB/9SmD6Q0e", "X-Received": "by 2002:a05:6830:490c:b0:7cf:e32f:de72 with SMTP id\n 46e09a7af769-7d4b3ff6d3amr633366a34.6.1770867284440;\n Wed, 11 Feb 2026 19:34:44 -0800 (PST)", "From": "Taylor Simpson <ltaylorsimpson@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "brian.cain@oss.qualcomm.com, matheus.bernardino@oss.qualcomm.com,\n sid.manning@oss.qualcomm.com, marco.liebel@oss.qualcomm.com,\n richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng, anjo@rev.ng,\n ltaylorsimpson@gmail.com", "Subject": "[PATCH 5/8] Hexagon (target/hexagon) Check each opcode against\n current CPU version", "Date": "Wed, 11 Feb 2026 20:34:32 -0700", "Message-ID": "<20260212033435.3598-6-ltaylorsimpson@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260212033435.3598-1-ltaylorsimpson@gmail.com>", "References": "<20260212033435.3598-1-ltaylorsimpson@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::32d;\n envelope-from=ltaylorsimpson@gmail.com; helo=mail-ot1-x32d.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "During decoding, check that the opcode is supported in the current\nHexagon CPU version\n\nCo-authored-by: Matheus Tavares Bernardino <matheus.bernardino@oss.qualcomm.com>\nCo-authored-by: Brian Cain <brian.cain@oss.qualcomm.com>\nSigned-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>\n---\n target/hexagon/decode.c | 23 +++++++++++++++++++++++\n 1 file changed, 23 insertions(+)", "diff": "diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c\nindex b5ece60450..0cff15e890 100644\n--- a/target/hexagon/decode.c\n+++ b/target/hexagon/decode.c\n@@ -648,6 +648,18 @@ decode_set_slot_number(Packet *pkt)\n return has_valid_slot_assignment(pkt);\n }\n \n+static bool opcode_supported(uint16_t opcode, HexagonVersion hex_version)\n+{\n+#include \"tag_rev_info.c.inc\"\n+\n+ struct tag_rev_info info = tag_rev_info[opcode];\n+ if ((info.introduced && hex_version < info.introduced) ||\n+ (info.removed && hex_version >= info.removed)) {\n+ return false;\n+ }\n+ return true;\n+}\n+\n /*\n * decode_packet\n * Decodes packet with given words\n@@ -691,6 +703,17 @@ int decode_packet(DisasContext *ctx, int max_words, const uint32_t *words,\n /* Ran out of words! */\n return 0;\n }\n+\n+ /*\n+ * Check that all the opcodes are supported in this Hexagon version\n+ * If not, return decode error\n+ */\n+ for (i = 0; i < num_insns; i++) {\n+ if (!opcode_supported(pkt->insn[i].opcode, ctx->hex_version)) {\n+ return 0;\n+ }\n+ }\n+\n pkt->encod_pkt_size_in_bytes = words_read * 4;\n pkt->pkt_has_hvx = false;\n for (i = 0; i < num_insns; i++) {\n", "prefixes": [ "5/8" ] }