Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195814/?format=api
{ "id": 2195814, "url": "http://patchwork.ozlabs.org/api/patches/2195814/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212033435.3598-7-ltaylorsimpson@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212033435.3598-7-ltaylorsimpson@gmail.com>", "list_archive_url": null, "date": "2026-02-12T03:34:33", "name": "[6/8] Hexagon (linux-user/hexagon) Convert INVALID_PACKET into SIGILL", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6d7c240622cfb73bd0cc29ae44d68eddac61b294", "submitter": { "id": 86757, "url": "http://patchwork.ozlabs.org/api/people/86757/?format=api", "name": "Taylor Simpson", "email": "ltaylorsimpson@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212033435.3598-7-ltaylorsimpson@gmail.com/mbox/", "series": [ { "id": 491930, "url": "http://patchwork.ozlabs.org/api/series/491930/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491930", "date": "2026-02-12T03:34:34", "name": "Hexagon (target/hexagon) Check opcodes versions", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491930/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195814/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195814/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=mvI3c4OM;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBLXn0wPrz1xxF\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 12 Feb 2026 14:35:21 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqNTe-0007lG-2x; Wed, 11 Feb 2026 22:34:50 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <ltaylorsimpson@gmail.com>)\n id 1vqNTc-0007jH-Oi\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 22:34:48 -0500", "from mail-oi1-x22f.google.com ([2607:f8b0:4864:20::22f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <ltaylorsimpson@gmail.com>)\n id 1vqNTa-0008Hx-Uk\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 22:34:48 -0500", "by mail-oi1-x22f.google.com with SMTP id\n 5614622812f47-45f004e7d71so1040187b6e.1\n for <qemu-devel@nongnu.org>; Wed, 11 Feb 2026 19:34:46 -0800 (PST)", "from taylor-ubuntu.. (c-67-172-136-152.hsd1.co.comcast.net.\n [67.172.136.152]) by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7d4a76e1b0csm2682858a34.14.2026.02.11.19.34.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 11 Feb 2026 19:34:45 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1770867285; x=1771472085; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1vV/gFCM2s8n0DXOgCi7/aaN4xg+tYlUyC1onltEOpg=;\n b=mvI3c4OMYZ5M4M0wrmXmv4aipIQszeJ8b3xXjLG13JcuhXT2GdBLS/MEdSBD/cH2Nm\n V03eleCzMIAg3eLuctpSLFKqy4k4ZytmjAnut2b5r/iCPrvjkAKiCqa0QtQruf8hKkVJ\n Si4JngSX+dEBnAAf2mWPeaTVCwQsX/i1EnFmjXoEOqAhNqhQOczQ6zgZPc7amEAtk5sw\n tGalGIp3A0muZfphRD3MGN8/D/bJV6r3RYEqUEmc2xy6MaYA1AEqWBUeZieU9pfVvn10\n lIsFGrJqxPCzbllBkv3obqdgnhbONuRv6RUm2NdY0wkv93Fbq5deyfo29sm7B3+v4nHB\n P80Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770867285; x=1771472085;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=1vV/gFCM2s8n0DXOgCi7/aaN4xg+tYlUyC1onltEOpg=;\n b=D7vIJXFML6HbakHtN6n/Q0jltgHtg2Sp2Sd6AccudxTa7M/z9+x3O9ju8k15+C9mLl\n q79DIbHqjLijAhI1eERx7kqISeesFPXJEmHXPdhCIt5CRS7wnJ6S17DAIMttZOr/INfL\n HFblzj4ao0bHFM/YUHtK9pQHJiRUd6YhOGqUh16VjY5veYtHURHRp05CPau+VXGHVyus\n SZ6SM01cTB2SKa+G2Xes9NZc0/dji1PuT7bepgHux9RaXY96eQ8HN00JPCMrX2W51kDU\n 4i9UIgoAkp372bhtuWprBBb0xMBHLIAsZ2sIzh/fKowA5n+cKb+Ta1iAzvQV0XHbyMYd\n Qd0Q==", "X-Gm-Message-State": "AOJu0YxacakMsLGWe3+2FPfrgarUsM+zg9/hP9m6fznMopyoYahHV3DD\n YtYm1KVoLYDLrGz8rWkKv/7ehj0TNiBuyVZ6Le0f5diW/5B9YgL+T+qtZy0JBQ==", "X-Gm-Gg": "AZuq6aLjoINX+S3R7HsRQXhxgFKRTKWwrLgQwX5qIQY6HWa5E/1gxqNrpIJxSWuK36U\n Oz1PhCxJm2lTUe6GfBBJ0Rel4HxZmMa2DBfDkS4etXnEZ8X8DP+/CR9l4WV2mTIH6KJDLIl2v4U\n 7Qnq+mFSeIxaIvPgEJAWBGb8kFRtM9szbIpkayE5TshBQ49CyR+AODBLRjD4u6x6SWBZHjIIVzN\n dDB5PkzJydft3Ray+pZIF8idsKVSQSaaNKDqfPD15R2JvCB/Sq/HisVgmzNtT90AfvlvXc8V/ZY\n G8kH96YTKfmhFFZAXLiX0SSg6Fe1SrRFP2akRzYCKKKNnhHV6MWjzGppGiM6cUi5dmSuPGqOOLU\n Edf/BPABudBPI1jdoqrUSzQGp5GzzHbYccDe26bnX58DmKq91N4TeWnb8tmD3h7a8jtrR1MxR/4\n P+2JGg06amRwCONo9LKkxjZGZdTD92lzY4HY+b7jaVI2TY8K8gakFM7qHSuc0dcgEtmHwVY6UQt\n nqGE4mbORPETIwW", "X-Received": "by 2002:a05:6808:4fca:b0:43b:7b80:5cf2 with SMTP id\n 5614622812f47-4637dbbb583mr786348b6e.11.1770867285460;\n Wed, 11 Feb 2026 19:34:45 -0800 (PST)", "From": "Taylor Simpson <ltaylorsimpson@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "brian.cain@oss.qualcomm.com, matheus.bernardino@oss.qualcomm.com,\n sid.manning@oss.qualcomm.com, marco.liebel@oss.qualcomm.com,\n richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng, anjo@rev.ng,\n ltaylorsimpson@gmail.com", "Subject": "[PATCH 6/8] Hexagon (linux-user/hexagon) Convert INVALID_PACKET into\n SIGILL", "Date": "Wed, 11 Feb 2026 20:34:33 -0700", "Message-ID": "<20260212033435.3598-7-ltaylorsimpson@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260212033435.3598-1-ltaylorsimpson@gmail.com>", "References": "<20260212033435.3598-1-ltaylorsimpson@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::22f;\n envelope-from=ltaylorsimpson@gmail.com; helo=mail-oi1-x22f.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Brian Cain <brian.cain@oss.qualcomm.com>\n\ntests/tcg/hexagon: Handle SIGILL internally in invalid-slots test\n\nRewrite invalid-slots.c to catch and verify SIGILL using a sigaction\nhandler that modifies the ucontext, matching the pattern used by\ninvalid-encoding.c.\n\nCo-authored-by: Matheus Tavares Bernardino <matheus.bernardino@oss.qualcomm.com>\nCo-authored-by: Taylor Simpson <ltaylorsimpson@gmail.com>\nReviewed-by: Taylor Simpson <ltaylorsimpson@gmail.com>\nReviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\nSigned-off-by: Brian Cain <brian.cain@oss.qualcomm.com>\nSigned-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>\n---\n linux-user/hexagon/cpu_loop.c | 4 ++\n target/hexagon/translate.c | 19 +++++++-\n tests/tcg/hexagon/invalid-slots.c | 76 ++++++++++++++++++++++++-------\n tests/tcg/hexagon/Makefile.target | 6 ---\n 4 files changed, 80 insertions(+), 25 deletions(-)", "diff": "diff --git a/linux-user/hexagon/cpu_loop.c b/linux-user/hexagon/cpu_loop.c\nindex 1941f4c9c1..c0e1098e3f 100644\n--- a/linux-user/hexagon/cpu_loop.c\n+++ b/linux-user/hexagon/cpu_loop.c\n@@ -64,6 +64,10 @@ void cpu_loop(CPUHexagonState *env)\n force_sig_fault(TARGET_SIGBUS, TARGET_BUS_ADRALN,\n env->gpr[HEX_REG_R31]);\n break;\n+ case HEX_CAUSE_INVALID_PACKET:\n+ force_sig_fault(TARGET_SIGILL, TARGET_ILL_ILLOPC,\n+ env->gpr[HEX_REG_PC]);\n+ break;\n case EXCP_ATOMIC:\n cpu_exec_step_atomic(cs);\n break;\ndiff --git a/target/hexagon/translate.c b/target/hexagon/translate.c\nindex 9498cd4502..78e0d6c219 100644\n--- a/target/hexagon/translate.c\n+++ b/target/hexagon/translate.c\n@@ -198,6 +198,21 @@ static void gen_exception_end_tb(DisasContext *ctx, int excp)\n \n }\n \n+/*\n+ * Generate exception for decode failures. Unlike gen_exception_end_tb,\n+ * this is used when decode fails before ctx->next_PC is initialized.\n+ */\n+static void gen_exception_decode_fail(DisasContext *ctx, int nwords, int excp)\n+{\n+ target_ulong fail_pc = ctx->base.pc_next + nwords * sizeof(uint32_t);\n+\n+ gen_exec_counters(ctx);\n+ tcg_gen_movi_tl(hex_gpr[HEX_REG_PC], fail_pc);\n+ gen_exception_raw(excp);\n+ ctx->base.is_jmp = DISAS_NORETURN;\n+ ctx->base.pc_next = fail_pc;\n+}\n+\n static int read_packet_words(CPUHexagonState *env, DisasContext *ctx,\n uint32_t words[])\n {\n@@ -935,7 +950,7 @@ static void decode_and_translate_packet(CPUHexagonState *env, DisasContext *ctx)\n \n nwords = read_packet_words(env, ctx, words);\n if (!nwords) {\n- gen_exception_end_tb(ctx, HEX_CAUSE_INVALID_PACKET);\n+ gen_exception_decode_fail(ctx, 0, HEX_CAUSE_INVALID_PACKET);\n return;\n }\n \n@@ -950,7 +965,7 @@ static void decode_and_translate_packet(CPUHexagonState *env, DisasContext *ctx)\n gen_commit_packet(ctx);\n ctx->base.pc_next += pkt.encod_pkt_size_in_bytes;\n } else {\n- gen_exception_end_tb(ctx, HEX_CAUSE_INVALID_PACKET);\n+ gen_exception_decode_fail(ctx, nwords, HEX_CAUSE_INVALID_PACKET);\n }\n }\n \ndiff --git a/tests/tcg/hexagon/invalid-slots.c b/tests/tcg/hexagon/invalid-slots.c\nindex 366ce4f42f..607027f314 100644\n--- a/tests/tcg/hexagon/invalid-slots.c\n+++ b/tests/tcg/hexagon/invalid-slots.c\n@@ -1,29 +1,71 @@\n /*\n- * Copyright(c) 2023 Qualcomm Innovation Center, Inc. All Rights Reserved.\n+ * Test that invalid slot assignments are properly rejected.\n *\n- * This program is free software; you can redistribute it and/or modify\n- * it under the terms of the GNU General Public License as published by\n- * the Free Software Foundation; either version 2 of the License, or\n- * (at your option) any later version.\n- *\n- * This program is distributed in the hope that it will be useful,\n- * but WITHOUT ANY WARRANTY; without even the implied warranty of\n- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n- * GNU General Public License for more details.\n- *\n- * You should have received a copy of the GNU General Public License\n- * along with this program; if not, see <http://www.gnu.org/licenses/>.\n+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n */\n \n+#include <assert.h>\n+#include <signal.h>\n+#include <stdio.h>\n+#include <stdlib.h>\n+#include <string.h>\n+#include <unistd.h>\n+\n+static void *resume_pc;\n+\n+static void handle_sigill(int sig, siginfo_t *info, void *puc)\n+{\n+ ucontext_t *uc = (ucontext_t *)puc;\n+\n+ if (sig != SIGILL) {\n+ _exit(EXIT_FAILURE);\n+ }\n+\n+ uc->uc_mcontext.r0 = SIGILL;\n+ uc->uc_mcontext.pc = (unsigned long)resume_pc;\n+}\n+\n char mem[8] __attribute__((aligned(8)));\n \n-int main()\n+/*\n+ * Invalid packet with 2 instructions at slot 0:\n+ * - Word 0: 0xa1804100 = memw(r0) = r1\n+ * - Word 1: 0x28032804 = { r3 = #0; r4 = #0 }\n+ *\n+ * This should raise SIGILL due to the invalid slot assignment.\n+ */\n+static int test_invalid_slots(void)\n {\n+ int sig;\n+\n asm volatile(\n+ \"r0 = #0\\n\"\n+ \"r1 = ##1f\\n\"\n+ \"memw(%1) = r1\\n\"\n \"r0 = #mem\\n\"\n- /* Invalid packet (2 instructions at slot 0): */\n \".word 0xa1804100\\n\" /* { memw(r0) = r1; */\n \".word 0x28032804\\n\" /* r3 = #0; r4 = #0 } */\n- : : : \"r0\", \"r3\", \"r4\", \"memory\");\n- return 0;\n+ \"1:\\n\"\n+ \"%0 = r0\\n\"\n+ : \"=r\"(sig)\n+ : \"r\"(&resume_pc)\n+ : \"r0\", \"r1\", \"r3\", \"r4\", \"memory\");\n+\n+ return sig;\n+}\n+\n+int main()\n+{\n+ struct sigaction act;\n+\n+ memset(&act, 0, sizeof(act));\n+ act.sa_sigaction = handle_sigill;\n+ act.sa_flags = SA_SIGINFO;\n+ assert(sigaction(SIGILL, &act, NULL) == 0);\n+\n+ assert(test_invalid_slots() == SIGILL);\n+\n+ puts(\"PASS\");\n+ return EXIT_SUCCESS;\n }\ndiff --git a/tests/tcg/hexagon/Makefile.target b/tests/tcg/hexagon/Makefile.target\nindex e5182c01d8..8c9d48fc4d 100644\n--- a/tests/tcg/hexagon/Makefile.target\n+++ b/tests/tcg/hexagon/Makefile.target\n@@ -53,12 +53,6 @@ HEX_TESTS += hvx_histogram\n HEX_TESTS += invalid-slots\n HEX_TESTS += unaligned_pc\n \n-run-and-check-exception = $(call run-test,$2,$3 2>$2.stderr; \\\n-\ttest $$? -eq 1 && grep -q \"exception $(strip $1)\" $2.stderr)\n-\n-run-invalid-slots: invalid-slots\n-\t$(call run-and-check-exception, 0x15, $@, $(QEMU) $(QEMU_OPTS) $<)\n-\n HEX_TESTS += test_abs\n HEX_TESTS += test_bitcnt\n HEX_TESTS += test_bitsplit\n", "prefixes": [ "6/8" ] }