Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195793/?format=api
{ "id": 2195793, "url": "http://patchwork.ozlabs.org/api/patches/2195793/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260211221953.4099441-4-brian.cain@oss.qualcomm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260211221953.4099441-4-brian.cain@oss.qualcomm.com>", "list_archive_url": null, "date": "2026-02-11T22:19:52", "name": "[v4,3/4] tests/tcg/hexagon: Handle SIGILL internally in invalid-slots test", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0549c4fa415f2c99ae9c8949968280a563d3a894", "submitter": { "id": 89839, "url": "http://patchwork.ozlabs.org/api/people/89839/?format=api", "name": "Brian Cain", "email": "brian.cain@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260211221953.4099441-4-brian.cain@oss.qualcomm.com/mbox/", "series": [ { "id": 491915, "url": "http://patchwork.ozlabs.org/api/series/491915/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491915", "date": "2026-02-11T22:19:52", "name": "Handle some invalid encodings", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/491915/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195793/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195793/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=S/EZlsue;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=aNwKV2f9;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBCZ33W47z1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 12 Feb 2026 09:20:59 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqIZG-0005Mk-9l; Wed, 11 Feb 2026 17:20:18 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1vqIZ6-0005LN-Io\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 17:20:08 -0500", "from mx0a-0031df01.pphosted.com ([205.220.168.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1vqIZ2-00051K-9c\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 17:20:07 -0500", "from pps.filterd (m0279865.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61BIp5ic2546650\n for <qemu-devel@nongnu.org>; Wed, 11 Feb 2026 22:20:03 GMT", "from mail-dl1-f70.google.com (mail-dl1-f70.google.com\n [74.125.82.70])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c8ydn0hv5-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Wed, 11 Feb 2026 22:20:02 +0000 (GMT)", "by mail-dl1-f70.google.com with SMTP id\n a92af1059eb24-1247bb4db53so3588600c88.1\n for <qemu-devel@nongnu.org>; Wed, 11 Feb 2026 14:20:02 -0800 (PST)", "from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2ba9dbe123asm2588379eec.13.2026.02.11.14.20.00\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 11 Feb 2026 14:20:00 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n fnuus0A3VAM9HdlEwrG5U3dQzgzrHcUo5c/GhwFD6VI=; b=S/EZlsueSpOz/waY\n z9/z+5ht20op4svbsS5QqouUhGg3BvjZk51Pv+UK57RW6mItGWazPgAjknpcr/ZK\n HJxiNjAFIGEc7VO/HP8fBpB05AqQ4Ds3mXi41lgCdPPnc5/zIySccWmpjp5uOLLK\n iMrlmSv/lpgMs/MJ41ZZGE/jYHqyv/2D2ykYv9b33orgI9cOoGZJjYZwbiIm/RYl\n QknZ+1B+g+/Jb5zZuPcg9wLzr2nJo/2tXnliVlblCnon2Ed7eEVI9Xk5wCfmYFxn\n z4KOOh7TC1cHKRdyZUO1/XWn+irRDwoRw3wrId2V0SkXWErCYjgjDpOsh6CoKlDK\n tSHHuw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1770848402; x=1771453202; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fnuus0A3VAM9HdlEwrG5U3dQzgzrHcUo5c/GhwFD6VI=;\n b=aNwKV2f9ZFt24NL6ANNfbX2xL1q7oU9OPsOTtlvRgqwgaVSL8ASH8COBEiy6mqi6VU\n CU8Kf+wzU3Dtoi3naEJxZp+q2ig0vUXYvPqF8YGs4aD1DkFE/8z0AnfosZ70RjWhkyRr\n FtHm3zJb35p/bIqlb6/OvCEKV9wyJ902GsS6W/ahapD79KQW8Xp0FfHSUM09Ih1u5cnb\n ci96sV8ablDCN2zVEfbbljXTr4KTsGvnBygscKHFyhZkRLPIOoBTh+9MouHoIMJyb/KC\n 7cOFwskvPHJmIVT+ePCvoFR9+34gowu4pNPwczAUUnpZPV94eA8XC8FlTvQnS1H4WLSu\n O9bg==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770848402; x=1771453202;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=fnuus0A3VAM9HdlEwrG5U3dQzgzrHcUo5c/GhwFD6VI=;\n b=YaYNKxkr/liD8+5QCit6X9Dn3zMfZBOe36ZlzqeVP0A+4nS9pVQgkGIxcfQPE7EZOJ\n TONUlI7wlbff9+oj5koKa6eDVBhLRzOdieySNCQ+zrxD67VadY+njNX76bnSJHkGLKvk\n Vdjov8SPyW+52nnyv5gx2c9OFVrUlrMLi8ldktjVrvDYxP8awpUza3mmZQGOgPWGAxQf\n Zap5E8UPw9u0oZS0tRWvj8PnU2OxrEjneII3Sy7jfuRgBhaSRJepWEGoEWLYjH/GEGIb\n zJLRmIVtMCNqTx4meTUvMNPMttBqzK37yHgzCzEytXu1aNofBHfnl30hu1btYJdLalZ9\n eXrA==", "X-Gm-Message-State": "AOJu0YwYGuTQ2dMEMmsic/L3TkKMVi0mKx14v/yCpDhF1xRVif0AOiHh\n 974GHn0Zc4+yKE6ng51TKZ1eZV+SyqsoOFLcKZTPKwsZ5fxeKf+mf8mdvHs7iSvKdPmttmN/quv\n MysDVnH4JsNNLvLd/XFTQGWnUlzYvl9Oyv88hRDULr/HR7Gk2hSvSXLQiWFRfn7Bi8g==", "X-Gm-Gg": "AZuq6aJT7Zkuks6FyPRgEcHE1v42g/FiQmQCsmPeGjAY9hrTMO6fMVNkgvf+Fa6d/qz\n g3qf5sbTjtHHMDOdkt+SG+ff4evgUfCMFL6XoRH53pLHf3AZP964h+F9d4r6pisT3roQ3bkACUq\n B105T34Nui5bKAGmEXl6/6DT5qPfG3HFL6Eb1it1IN1uooXsEJz1WD6rSrvI0kuS+7TLCTJRtAh\n gk/sO+leWOQdqf/CvRAuZKLnfCJ2pzl/1zHmSkdsd/ccw3U9A/4D2rD0uHT8+lUERQMSCx9N576\n p3LSrMtgGnRMn7xhv9Cou0w9GGN5taefoIq19iXoATst/r1WSTaHR9oCJfR6TeZAvP0gvso1/rZ\n N+btY8xwMkH9py0ZTRuscmxCGo9S2t83olLM3xD6hSpX8RkKH6fL3Byk8eG7CyA8ZRTgpag==", "X-Received": [ "by 2002:a05:7022:2399:b0:123:361e:e87c with SMTP id\n a92af1059eb24-1273052046dmr114404c88.11.1770848402043;\n Wed, 11 Feb 2026 14:20:02 -0800 (PST)", "by 2002:a05:7022:2399:b0:123:361e:e87c with SMTP id\n a92af1059eb24-1273052046dmr114389c88.11.1770848401094;\n Wed, 11 Feb 2026 14:20:01 -0800 (PST)" ], "From": "Brian Cain <brian.cain@oss.qualcomm.com>", "To": "qemu-devel@nongnu.org", "Cc": "brian.cain@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex@alexrp.com,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>", "Subject": "[PATCH v4 3/4] tests/tcg/hexagon: Handle SIGILL internally in\n invalid-slots test", "Date": "Wed, 11 Feb 2026 14:19:52 -0800", "Message-Id": "<20260211221953.4099441-4-brian.cain@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260211221953.4099441-1-brian.cain@oss.qualcomm.com>", "References": "<20260211221953.4099441-1-brian.cain@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "X-Authority-Analysis": "v=2.4 cv=NLHYOk6g c=1 sm=1 tr=0 ts=698d0092 cx=c_pps\n a=SvEPeNj+VMjHSW//kvnxuw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22\n a=mDV3o1hIAAAA:8 a=pGLkceISAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8\n a=F0Jt1ehG-eUF7qKHwFUA:9 a=QEXdDO2ut3YA:10 a=Kq8ClHjjuc5pcCNDwlU0:22\n a=cvBusfyB2V15izCimMoJ:22", "X-Proofpoint-GUID": "eUdjd3xrhrwBnTAI7vzYC-dAfZtjIMgq", "X-Proofpoint-ORIG-GUID": "eUdjd3xrhrwBnTAI7vzYC-dAfZtjIMgq", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjExMDE3MSBTYWx0ZWRfX9ln2Qxw4jXVt\n lmJFQiKlAKyRq9+bRrHDUQSMnTjsrGq5DB2hyRZQhqrfdIWRqFFcpVtzD3s8PUVJ72UycayZfUB\n EwfnXzwhyWOBbpf9ljOBWLM7imh8XjThJag+gy7NdPimgermIOB/iVebDiQ6xwOg2f0yO6PCZrF\n V147SU8YCqV4nm9j9c36pw7JPSBlP9SmUaf/udxx8gUpLdaPGEjV0qF76qSiubmVJZhMu6rtU+e\n kaaKfsm+eBbpG8G5KVRtYwQfGAajuPOtsFfPCrFv6/lGA5MqT8Y+zozoqMrU6PFcPJ8Nxlw6cp5\n s5Dvvn5aHMDwx5p7HoDBylfF6iP9H5PaNpVWTOOcJfzDwywSDA7n7rhufEq41wlumH8tbvGdGha\n xyFoMl+E5Vd/vikgE1rLn3P7FXw8iwGiOotsFImkIV0hr7Z8FSamcgmLvCxfryGnclH1DV0hIyw\n JSKz3og+zNEcoAoOqLQ==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-11_03,2026-02-11_04,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n adultscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501\n impostorscore=0 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0\n suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602110171", "Received-SPF": "pass client-ip=205.220.168.131;\n envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Rewrite invalid-slots.c to catch and verify SIGILL using a sigaction\nhandler that modifies the ucontext, matching the pattern used by\ninvalid-encoding.c.\n\nReviewed-by: Taylor Simpson <ltaylorsimpson@gmail.com>\nReviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\nSigned-off-by: Brian Cain <brian.cain@oss.qualcomm.com>\n---\n tests/tcg/hexagon/Makefile.target | 6 ---\n tests/tcg/hexagon/invalid-slots.c | 76 ++++++++++++++++++++++++-------\n 2 files changed, 59 insertions(+), 23 deletions(-)", "diff": "diff --git a/tests/tcg/hexagon/Makefile.target b/tests/tcg/hexagon/Makefile.target\nindex 16669e04a8..d64aeba090 100644\n--- a/tests/tcg/hexagon/Makefile.target\n+++ b/tests/tcg/hexagon/Makefile.target\n@@ -54,12 +54,6 @@ HEX_TESTS += invalid-slots\n HEX_TESTS += invalid-encoding\n HEX_TESTS += unaligned_pc\n \n-run-and-check-exception = $(call run-test,$2,$3 2>$2.stderr; \\\n-\ttest $$? -eq 1 && grep -q \"exception $(strip $1)\" $2.stderr)\n-\n-run-invalid-slots: invalid-slots\n-\t$(call run-and-check-exception, 0x15, $@, $(QEMU) $(QEMU_OPTS) $<)\n-\n HEX_TESTS += test_abs\n HEX_TESTS += test_bitcnt\n HEX_TESTS += test_bitsplit\ndiff --git a/tests/tcg/hexagon/invalid-slots.c b/tests/tcg/hexagon/invalid-slots.c\nindex 366ce4f42f..607027f314 100644\n--- a/tests/tcg/hexagon/invalid-slots.c\n+++ b/tests/tcg/hexagon/invalid-slots.c\n@@ -1,29 +1,71 @@\n /*\n- * Copyright(c) 2023 Qualcomm Innovation Center, Inc. All Rights Reserved.\n+ * Test that invalid slot assignments are properly rejected.\n *\n- * This program is free software; you can redistribute it and/or modify\n- * it under the terms of the GNU General Public License as published by\n- * the Free Software Foundation; either version 2 of the License, or\n- * (at your option) any later version.\n- *\n- * This program is distributed in the hope that it will be useful,\n- * but WITHOUT ANY WARRANTY; without even the implied warranty of\n- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n- * GNU General Public License for more details.\n- *\n- * You should have received a copy of the GNU General Public License\n- * along with this program; if not, see <http://www.gnu.org/licenses/>.\n+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n */\n \n+#include <assert.h>\n+#include <signal.h>\n+#include <stdio.h>\n+#include <stdlib.h>\n+#include <string.h>\n+#include <unistd.h>\n+\n+static void *resume_pc;\n+\n+static void handle_sigill(int sig, siginfo_t *info, void *puc)\n+{\n+ ucontext_t *uc = (ucontext_t *)puc;\n+\n+ if (sig != SIGILL) {\n+ _exit(EXIT_FAILURE);\n+ }\n+\n+ uc->uc_mcontext.r0 = SIGILL;\n+ uc->uc_mcontext.pc = (unsigned long)resume_pc;\n+}\n+\n char mem[8] __attribute__((aligned(8)));\n \n-int main()\n+/*\n+ * Invalid packet with 2 instructions at slot 0:\n+ * - Word 0: 0xa1804100 = memw(r0) = r1\n+ * - Word 1: 0x28032804 = { r3 = #0; r4 = #0 }\n+ *\n+ * This should raise SIGILL due to the invalid slot assignment.\n+ */\n+static int test_invalid_slots(void)\n {\n+ int sig;\n+\n asm volatile(\n+ \"r0 = #0\\n\"\n+ \"r1 = ##1f\\n\"\n+ \"memw(%1) = r1\\n\"\n \"r0 = #mem\\n\"\n- /* Invalid packet (2 instructions at slot 0): */\n \".word 0xa1804100\\n\" /* { memw(r0) = r1; */\n \".word 0x28032804\\n\" /* r3 = #0; r4 = #0 } */\n- : : : \"r0\", \"r3\", \"r4\", \"memory\");\n- return 0;\n+ \"1:\\n\"\n+ \"%0 = r0\\n\"\n+ : \"=r\"(sig)\n+ : \"r\"(&resume_pc)\n+ : \"r0\", \"r1\", \"r3\", \"r4\", \"memory\");\n+\n+ return sig;\n+}\n+\n+int main()\n+{\n+ struct sigaction act;\n+\n+ memset(&act, 0, sizeof(act));\n+ act.sa_sigaction = handle_sigill;\n+ act.sa_flags = SA_SIGINFO;\n+ assert(sigaction(SIGILL, &act, NULL) == 0);\n+\n+ assert(test_invalid_slots() == SIGILL);\n+\n+ puts(\"PASS\");\n+ return EXIT_SUCCESS;\n }\n", "prefixes": [ "v4", "3/4" ] }