Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195646/?format=api
{ "id": 2195646, "url": "http://patchwork.ozlabs.org/api/patches/2195646/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260211152508.732487-21-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260211152508.732487-21-berrange@redhat.com>", "list_archive_url": null, "date": "2026-02-11T15:25:01", "name": "[v6,20/27] util: don't skip error prefixes when QMP is active", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e38c891d9b032cf37081d9606cd09c4ed72d22ea", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260211152508.732487-21-berrange@redhat.com/mbox/", "series": [ { "id": 491862, "url": "http://patchwork.ozlabs.org/api/series/491862/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491862", "date": "2026-02-11T15:24:41", "name": "util: sync error_report & qemu_log output more closely", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/491862/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195646/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195646/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=OMnx2xnC;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fB2Rd5bz0z1xtr\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 12 Feb 2026 02:29:48 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqC7s-00005H-9o; Wed, 11 Feb 2026 10:27:36 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1vqC7g-0007I3-EI\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 10:27:26 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1vqC7c-00065K-Bs\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 10:27:23 -0500", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-Y2Wf5-4YO6e9Q_Wy8Qnv-g-1; Wed,\n 11 Feb 2026 10:27:14 -0500", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 15D1D19560B2; Wed, 11 Feb 2026 15:27:10 +0000 (UTC)", "from toolbx.redhat.com (unknown [10.45.227.9])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 485AE30001A8; Wed, 11 Feb 2026 15:27:05 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770823638;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ids8ssbjyqIGdjv1hvc90z9LCMXzQg8S2+lPCiRENwA=;\n b=OMnx2xnCLYF7s7VrESJRTU8Iu1GVUquFx0AtqFD1oAFElGEcBbF9LJ0ROs+KMxBieVTEc4\n 6UakDlJghViJl4ey9+74+WQXz4TYsDQV3rONLaqeYFVzG7AFJxs0Ym1CFy4K1ts/Ey+X8q\n YG6HWzPh/wvvqFysjYcoJlvOALRo3YA=", "X-MC-Unique": "Y2Wf5-4YO6e9Q_Wy8Qnv-g-1", "X-Mimecast-MFC-AGG-ID": "Y2Wf5-4YO6e9Q_Wy8Qnv-g_1770823630", "From": "=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Stefan Weil <sw@weilnetz.de>, \"Dr. David Alan Gilbert\" <dave@treblig.org>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>, devel@lists.libvirt.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, =?utf-8?q?Marc?=\n\t=?utf-8?q?-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Hanna Reitz <hreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,\n qemu-block@nongnu.org, qemu-rust@nongnu.org,\n Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>,\n Gerd Hoffmann <kraxel@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Richard Henderson <richard.henderson@linaro.org>", "Subject": "[PATCH v6 20/27] util: don't skip error prefixes when QMP is active", "Date": "Wed, 11 Feb 2026 15:25:01 +0000", "Message-ID": "<20260211152508.732487-21-berrange@redhat.com>", "In-Reply-To": "<20260211152508.732487-1-berrange@redhat.com>", "References": "<20260211152508.732487-1-berrange@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The vreport() function will print to HMP if available, otherwise\nto stderr. In the event that vreport() is called during execution\nof a QMP command, it will print to stderr, but mistakenly omit the\nmessage prefixes (timestamp, guest name, program name).\n\nThis new usage of monitor_is_cur_qmp() from vreport() requires that\nwe add a stub to satisfy linking of non-system emulator binaries.\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>\n---\n stubs/monitor-core.c | 5 +++++\n tests/unit/test-util-sockets.c | 1 +\n util/error-report.c | 8 ++++++++\n 3 files changed, 14 insertions(+)", "diff": "diff --git a/stubs/monitor-core.c b/stubs/monitor-core.c\nindex a7c32297c9..078a5012e9 100644\n--- a/stubs/monitor-core.c\n+++ b/stubs/monitor-core.c\n@@ -7,6 +7,11 @@ Monitor *monitor_cur(void)\n return NULL;\n }\n \n+bool monitor_cur_is_qmp(void)\n+{\n+ return false;\n+}\n+\n Monitor *monitor_set_cur(Coroutine *co, Monitor *mon)\n {\n return NULL;\ndiff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c\nindex ee66d727c3..b9f2453e29 100644\n--- a/tests/unit/test-util-sockets.c\n+++ b/tests/unit/test-util-sockets.c\n@@ -74,6 +74,7 @@ int monitor_get_fd(Monitor *mon, const char *fdname, Error **errp)\n Monitor *monitor_cur(void) { return cur_mon; }\n Monitor *monitor_set_cur(Coroutine *co, Monitor *mon) { abort(); }\n int monitor_vprintf(Monitor *mon, const char *fmt, va_list ap) { abort(); }\n+bool monitor_cur_is_qmp(void) { abort(); };\n \n #ifndef _WIN32\n static void test_socket_fd_pass_name_good(void)\ndiff --git a/util/error-report.c b/util/error-report.c\nindex b34a2bc7bc..052f0f68b8 100644\n--- a/util/error-report.c\n+++ b/util/error-report.c\n@@ -227,6 +227,14 @@ static void vreport(report_type type, const char *fmt, va_list ap)\n Monitor *cur = monitor_cur();\n gchar *timestr;\n \n+ /*\n+ * When current monitor is QMP, messages must go to stderr\n+ * and have prefixes added\n+ */\n+ if (monitor_cur_is_qmp()) {\n+ cur = NULL;\n+ }\n+\n if (message_with_timestamp && !cur) {\n timestr = real_time_iso8601();\n fprintf(stderr, \"%s \", timestr);\n", "prefixes": [ "v6", "20/27" ] }