Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195578/?format=api
{ "id": 2195578, "url": "http://patchwork.ozlabs.org/api/patches/2195578/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260211124314.3406952-1-vincent.stehle@arm.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260211124314.3406952-1-vincent.stehle@arm.com>", "list_archive_url": null, "date": "2026-02-11T12:43:14", "name": "efi_loader: add missing EFI_CALL around tcg2 read_blocks calls", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "99ab49fd541f9fc9323a267fc4bc1e423bbaff5d", "submitter": { "id": 77169, "url": "http://patchwork.ozlabs.org/api/people/77169/?format=api", "name": "Vincent Stehlé", "email": "vincent.stehle@arm.com" }, "delegate": { "id": 68728, "url": "http://patchwork.ozlabs.org/api/users/68728/?format=api", "username": "xypron", "first_name": "Heinrich", "last_name": "Schuchardt", "email": "xypron.glpk@gmx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260211124314.3406952-1-vincent.stehle@arm.com/mbox/", "series": [ { "id": 491830, "url": "http://patchwork.ozlabs.org/api/series/491830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=491830", "date": "2026-02-11T12:43:14", "name": "efi_loader: add missing EFI_CALL around tcg2 read_blocks calls", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491830/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195578/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195578/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=fail (p=none dis=none) header.from=arm.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n dmarc=fail (p=none dis=none) header.from=arm.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=vincent.stehle@arm.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9yld56Sdz1xtr\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 23:43:25 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8AF8083CB5;\n\tWed, 11 Feb 2026 13:43:22 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 1D8C080FA1; Wed, 11 Feb 2026 13:43:21 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by phobos.denx.de (Postfix) with ESMTP id 60CC280FA1\n for <u-boot@lists.denx.de>; Wed, 11 Feb 2026 13:43:18 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 581F7339;\n Wed, 11 Feb 2026 04:43:11 -0800 (PST)", "from debian (MacBookPro.nice.Arm.com [10.34.111.21])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CB3E53F632;\n Wed, 11 Feb 2026 04:43:16 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.9 required=5.0 tests=BAYES_00,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,\n RCVD_IN_VALIDITY_RPBL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "From": "=?utf-8?q?Vincent_Stehl=C3=A9?= <vincent.stehle@arm.com>", "To": "u-boot@lists.denx.de", "Cc": "=?utf-8?q?Vincent_Stehl=C3=A9?= <vincent.stehle@arm.com>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Tom Rini <trini@konsulko.com>,\n Masahisa Kojima <kojima.masahisa@socionext.com>", "Subject": "[PATCH] efi_loader: add missing EFI_CALL around tcg2 read_blocks\n calls", "Date": "Wed, 11 Feb 2026 13:43:14 +0100", "Message-ID": "<20260211124314.3406952-1-vincent.stehle@arm.com>", "X-Mailer": "git-send-email 2.51.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The read_blocks() function from the Block IO protocol is a UEFI function;\nmake sure to call it from within U-Boot using the EFI_CALL() macro.\n\nTo demonstrate the issue on an AArch64 machine, define the DEBUG macro in\ninclude/efi_loader.h and build u-boot with sandbox_defconfig, then download\nand uncompress the ACS-DT image [1], and finally execute the following\ncommand:\n\n $ ./u-boot -T -c \" \\\n host bind 0 systemready-dt_acs_live_image.wic; \\\n setenv loadaddr 0x10000; \\\n load host 0 \\${loadaddr} EFI/BOOT/Shell.efi; \\\n bootefi \\${loadaddr} \\${fdtcontroladdr}\"\n\nThe following assertion should fail:\n\n lib/efi_loader/efi_net.c:858: efi_network_timer_notify: Assertion `__efi_entry_check()' failed.\n\nThis happens due to the following EFIAPI functions call chain:\n\n efi_start_image()\n efi_disk_read_blocks()\n (due to the missing EFI_CALL, entry_count == 2)\n efi_network_timer_notify()\n\nLink: https://github.com/ARM-software/arm-systemready/releases/download/v25.12_DT_3.1.1/systemready-dt_acs_live_image.wic.xz [1]\nFixes: ce3dbc5d080d (\"efi_loader: add UEFI GPT measurement\")\nSigned-off-by: Vincent Stehlé <vincent.stehle@arm.com>\nCc: Heinrich Schuchardt <xypron.glpk@gmx.de>\nCc: Ilias Apalodimas <ilias.apalodimas@linaro.org>\nCc: Tom Rini <trini@konsulko.com>\nCc: Masahisa Kojima <kojima.masahisa@socionext.com>\n---\n lib/efi_loader/efi_tcg2.c | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c\nindex bdf78897d47..1860dc50238 100644\n--- a/lib/efi_loader/efi_tcg2.c\n+++ b/lib/efi_loader/efi_tcg2.c\n@@ -1213,8 +1213,10 @@ tcg2_measure_gpt_data(struct udevice *dev,\n \t\tgoto out2;\n \t}\n \n-\tret = block_io->read_blocks(block_io, block_io->media->media_id, 1,\n-\t\t\t\t block_io->media->block_size, gpt_h);\n+\tret = EFI_CALL(block_io->read_blocks(block_io,\n+\t\t\t\t\t block_io->media->media_id, 1,\n+\t\t\t\t\t block_io->media->block_size,\n+\t\t\t\t\t gpt_h));\n \tif (ret != EFI_SUCCESS)\n \t\tgoto out2;\n \n@@ -1227,9 +1229,10 @@ tcg2_measure_gpt_data(struct udevice *dev,\n \t\tgoto out2;\n \t}\n \n-\tret = block_io->read_blocks(block_io, block_io->media->media_id,\n-\t\t\t\t gpt_h->partition_entry_lba,\n-\t\t\t\t total_gpt_entry_size, entry);\n+\tret = EFI_CALL(block_io->read_blocks(block_io,\n+\t\t\t\t\t block_io->media->media_id,\n+\t\t\t\t\t gpt_h->partition_entry_lba,\n+\t\t\t\t\t total_gpt_entry_size, entry));\n \tif (ret != EFI_SUCCESS)\n \t\tgoto out2;\n \n", "prefixes": [] }