Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195558/?format=api
{ "id": 2195558, "url": "http://patchwork.ozlabs.org/api/patches/2195558/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/1770798299-202288-4-git-send-email-shawn.lin@rock-chips.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1770798299-202288-4-git-send-email-shawn.lin@rock-chips.com>", "list_archive_url": null, "date": "2026-02-11T08:24:59", "name": "[v2,3/3] PCI/MSI: Add TODO comment about legacy pcim_enable_device() side-effect", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b63f17656b9744b1a2847c17f1c6e7feaa1f5cee", "submitter": { "id": 66993, "url": "http://patchwork.ozlabs.org/api/people/66993/?format=api", "name": "Shawn Lin", "email": "shawn.lin@rock-chips.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/1770798299-202288-4-git-send-email-shawn.lin@rock-chips.com/mbox/", "series": [ { "id": 491791, "url": "http://patchwork.ozlabs.org/api/series/491791/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=491791", "date": "2026-02-11T08:24:57", "name": "Clarify pci_free_irq_vectors() usage constraints", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491791/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195558/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195558/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-47172-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=rock-chips.com header.i=@rock-chips.com\n header.a=rsa-sha256 header.s=default header.b=UIp9g7gh;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-47172-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com\n header.b=\"UIp9g7gh\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=45.254.49.251", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=rock-chips.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=rock-chips.com" ], "Received": [ "from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9xgY24YHz1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 22:54:49 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 1E7C43004CB3\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 11:54:46 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E6D9E314A67;\n\tWed, 11 Feb 2026 11:54:44 +0000 (UTC)", "from mail-m49251.qiye.163.com (mail-m49251.qiye.163.com\n [45.254.49.251])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B5D8314D07;\n\tWed, 11 Feb 2026 11:54:40 +0000 (UTC)", "from localhost.localdomain (unknown [58.22.7.114])\n\tby smtp.qiye.163.com (Hmail) with ESMTP id 33d86957e;\n\tWed, 11 Feb 2026 16:25:19 +0800 (GMT+08:00)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1770810884; cv=none;\n b=CEZEXMJ8yky7ayCqPjT1HQpipAaVpzKeS2EvYKggt5HJ5MMVjVEKI6B3wE1TKe+Yco5uM+3b/CnBEy1qsiSXMascABsii3x+71AiHqkVAFQvJIV+lF/TSoNxMMa3W646yOvpu7lY8tf6x5SotEa8uCPdfWod2xYz87dwfNVGR1c=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1770810884; c=relaxed/simple;\n\tbh=UVFhv5Z7BlBBKfH8QaYu3fxEmBpx7rK85du1nEWo4Ls=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References;\n b=VnOMY6vM/ghuSeCgZe+VM0z+WI7z1OPVgeZuEod16XqMtSvJQqwoNcp8u7t5hIRX6h4z21dqK2MqN+WkJZG2UTmMaPCjps8dWzXRFhWBTeIO2R0FteAdaR/HJYzAY9iYtfZIuXt8nHWYHe60KFEDM2ChkeP5NERtpCRfQipE9Kk=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=rock-chips.com;\n spf=pass smtp.mailfrom=rock-chips.com;\n dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com\n header.b=UIp9g7gh; arc=none smtp.client-ip=45.254.49.251", "From": "Shawn Lin <shawn.lin@rock-chips.com>", "To": "Bjorn Helgaas <bhelgaas@google.com>", "Cc": "linux-pci@vger.kernel.org,\n\tlinux-doc@vger.kernel.org,\n\tPhilipp Stanner <phasta@kernel.org>,\n\tShawn Lin <shawn.lin@rock-chips.com>", "Subject": "[PATCH v2 3/3] PCI/MSI: Add TODO comment about legacy\n pcim_enable_device() side-effect", "Date": "Wed, 11 Feb 2026 16:24:59 +0800", "Message-Id": "<1770798299-202288-4-git-send-email-shawn.lin@rock-chips.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1770798299-202288-1-git-send-email-shawn.lin@rock-chips.com>", "References": "<1770798299-202288-1-git-send-email-shawn.lin@rock-chips.com>", "X-HM-Tid": "0a9c4bce081409cckunm6cb3bb0ee19cd", "X-HM-MType": "1", "X-HM-Spam-Status": "e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly\n\ttZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGhkfSFYfSR5DTR0YShgeTElWFRQJFh\n\toXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0\n\thVSktLVUpCS0tZBg++", "DKIM-Signature": "a=rsa-sha256;\n\tb=UIp9g7ghBfQGQZ/3okgBqWjahEVRpOtzhoVw/oMnzmr8wntmjpYyvuG/D3PeBpnwvseClvlb7lSwRIFvQauk9xdRxJuqFUvb/AYDUy+8I9M73lO+Q4XUMo0+riMG50H00/SjiXEOPQdwj0rtNNoyB0mtO50yB5IldeC/1V+A0HE=;\n s=default; c=relaxed/relaxed; d=rock-chips.com; v=1;\n\tbh=wXzM0K0CcUqD2rLTcHZcO8hNOKAiCR32tUQai7tG7qY=;\n\th=date:mime-version:subject:message-id:from;", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>" }, "content": "Add a TODO comment in pci/msi/msi.c to document that the automatic IRQ\nvector management activated by pcim_enable_device() is a dangerous and\nconfusing.\n\nThe comment is placed near pcim_setup_msi_release() where the automatic\nmanagement is implemented, serving as a marker for future cleanup work.\n\nSuggested-by: Philipp Stanner <phasta@kernel.org>\nSigned-off-by: Shawn Lin <shawn.lin@rock-chips.com>\n\n---\n\nChanges in v2: None\n\n drivers/pci/msi/msi.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c\nindex e241217..81d24a2 100644\n--- a/drivers/pci/msi/msi.c\n+++ b/drivers/pci/msi/msi.c\n@@ -77,6 +77,16 @@ static void pcim_msi_release(void *pcidev)\n /*\n * Needs to be separate from pcim_release to prevent an ordering problem\n * vs. msi_device_data_release() in the MSI core code.\n+ *\n+ * TODO: Remove the legacy side-effect of pcim_enable_device() that\n+ * activates automatic IRQ vector management. This design is dangerous\n+ * and confusing because it switches normally un-managed functions\n+ * into managed mode. Drivers should explicitly manage their IRQ vectors\n+ * without this implicit behavior.\n+ *\n+ * The current implementation uses both pdev->is_managed and\n+ * pdev->is_msi_managed flags, which adds unnecessary complexity.\n+ * This should be simplified in a future kernel version.\n */\n static int pcim_setup_msi_release(struct pci_dev *dev)\n {\n", "prefixes": [ "v2", "3/3" ] }