Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195518/?format=api
{ "id": 2195518, "url": "http://patchwork.ozlabs.org/api/patches/2195518/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260211-cleanups-v1-6-e63c96572389@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260211-cleanups-v1-6-e63c96572389@redhat.com>", "list_archive_url": null, "date": "2026-02-11T10:01:46", "name": "[6/7] ui: drop legacy spice < 0.15 support code", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "16d496dd182ff50f44656f8069d68d563c5b66f0", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260211-cleanups-v1-6-e63c96572389@redhat.com/mbox/", "series": [ { "id": 491807, "url": "http://patchwork.ozlabs.org/api/series/491807/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491807", "date": "2026-02-11T10:01:40", "name": "Some cleanups (mostly ui/audio)", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491807/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195518/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195518/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QmViMrMm;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9vBn0q2gz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 21:03:13 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vq73e-0001xs-5t; Wed, 11 Feb 2026 05:02:54 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vq73c-0001v3-Bs\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 05:02:52 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vq73a-0002zy-DD\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 05:02:52 -0500", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-QTMDxZAhNsGxjWG0IwCrrw-1; Wed,\n 11 Feb 2026 05:02:46 -0500", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5659E1956052; Wed, 11 Feb 2026 10:02:45 +0000 (UTC)", "from localhost (unknown [10.45.242.6])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 48273180066D; Wed, 11 Feb 2026 10:02:42 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770804169;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=5XFLgcgIJf4ihDQXzUgzIhmbnKsdK8VFUYV10YosG7M=;\n b=QmViMrMmWpcPAso/+/9vpln7KSEvEF6QulyBZr5WszH6J62diPWc1l3AUcu8i0unvEpEer\n XODlfKXDFA6WJJEOnq+2GUZyBKm2HneMO/TrQhkrrnumCYXz6NEkqXM8/C4H1VEfK0xW+d\n 76RoHEN3ZyptIfrAqE6dTq6GYwRx1Pw=", "X-MC-Unique": "QTMDxZAhNsGxjWG0IwCrrw-1", "X-Mimecast-MFC-AGG-ID": "QTMDxZAhNsGxjWG0IwCrrw_1770804165", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Wed, 11 Feb 2026 14:01:46 +0400", "Subject": "[PATCH 6/7] ui: drop legacy spice < 0.15 support code", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260211-cleanups-v1-6-e63c96572389@redhat.com>", "References": "<20260211-cleanups-v1-0-e63c96572389@redhat.com>", "In-Reply-To": "<20260211-cleanups-v1-0-e63c96572389@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, John Snow <jsnow@redhat.com>,\n Cleber Rosa <crosa@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, =?utf-8?q?Marc-And?=\n\t=?utf-8?q?r=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=6349;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=FbhCL/V8MMmRvoZlhK350xscVaqM6HdtTqLFN8kGI6o=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpjFOVnrZZqAuTaDC35hlaVzyQc3G3nSKF4W6x6\n 7CUQl3S4OeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaYxTlQAKCRDa6OEJdZac\n 5ZCtD/9CloayJtH+t0robP/k21MYK1wzECtkQuDHAlJdhbTfntXktRypT51WO/hy6DURLm5O91Y\n ByuH9g4FWOLBzguFjQBH0AdJ0m2fqonncUvsO/zKeJr/JLYw/gd8x/BUjY55XPQ48JH4s0+VB5I\n YvHCHQpOhP9tDSg0GVUERl9jZ2zNSrAJDZoVU+QYNmolVBdaWNgpPbjIR97kNjk9teQ/yBjIQcF\n WO3dhLoU0ko6YHgsFMULVST9By1xRdk3mlzXN5Gh+Kl3+CpskZI59uaq6+YRGB6InZFcp/xs4/V\n oIGUAaoWjyDgt5qLZkQK7iU6K3HVlK8eqF8D/NHi/uOInuc6/CCBVTKpMSxOPLTxTwBJUT5sY92\n s0LHyHl7L6olAttipcoMqCitBMgJW8jcl4q/1q8yCZb+Qprzcdk2K+JO1wRhRbIwWbxmNiGCB8p\n IADjec/btM89FHLzzH0tI+9SDOERL2C5rv0Qfk8ZAOvzpziwLZ4CrabNVj2Zoo/09+w2oazAXhK\n 7b2fxoEwUIv/kRhmhT4aJETFvDqqdZ3EVL1gH9J7kAQuUAnygAj1lm73qPWILSBhvfZ2PF+Lfi3\n Jku1QrghbrtBFiir/jqcVkPPtIgVxadklI8WMSxvxgr9rZ549/+OTCEvGBCD3ct359gSoVAtlQW\n WNObSqLfgY0Qxmw==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n include/ui/qemu-spice.h | 6 ------\n chardev/spice.c | 6 ------\n hw/display/qxl.c | 23 ++---------------------\n ui/spice-display.c | 15 ---------------\n 4 files changed, 2 insertions(+), 48 deletions(-)", "diff": "diff --git a/include/ui/qemu-spice.h b/include/ui/qemu-spice.h\nindex b7d493742c4..111a09ceca3 100644\n--- a/include/ui/qemu-spice.h\n+++ b/include/ui/qemu-spice.h\n@@ -34,12 +34,6 @@ int qemu_spice_add_display_interface(QXLInstance *qxlin, QemuConsole *con);\n int qemu_spice_migrate_info(const char *hostname, int port, int tls_port,\n const char *subject);\n \n-#if SPICE_SERVER_VERSION >= 0x000f00 /* release 0.15.0 */\n-#define SPICE_HAS_ATTACHED_WORKER 1\n-#else\n-#define SPICE_HAS_ATTACHED_WORKER 0\n-#endif\n-\n #else /* CONFIG_SPICE */\n \n #include \"qemu/error-report.h\"\ndiff --git a/chardev/spice.c b/chardev/spice.c\nindex db53b49da26..39b79d60fb4 100644\n--- a/chardev/spice.c\n+++ b/chardev/spice.c\n@@ -278,12 +278,6 @@ static void qemu_chr_open_spice_vmc(Chardev *chr,\n }\n \n *be_opened = false;\n-#if SPICE_SERVER_VERSION < 0x000e02\n- /* Spice < 0.14.2 doesn't explicitly open smartcard chardev */\n- if (strcmp(type, \"smartcard\") == 0) {\n- *be_opened = true;\n- }\n-#endif\n chr_open(chr, type);\n }\n \ndiff --git a/hw/display/qxl.c b/hw/display/qxl.c\nindex f29b736722c..0551b38230b 100644\n--- a/hw/display/qxl.c\n+++ b/hw/display/qxl.c\n@@ -261,11 +261,6 @@ static void qxl_spice_monitors_config_async(PCIQXLDevice *qxl, int replay)\n QXL_COOKIE_TYPE_POST_LOAD_MONITORS_CONFIG,\n 0));\n } else {\n-#if SPICE_SERVER_VERSION < 0x000e02 /* release 0.14.2 */\n- if (qxl->max_outputs) {\n- spice_qxl_set_max_monitors(&qxl->ssd.qxl, qxl->max_outputs);\n- }\n-#endif\n qxl->guest_monitors_config = qxl->ram->monitors_config;\n spice_qxl_monitors_config_async(&qxl->ssd.qxl,\n qxl->ram->monitors_config,\n@@ -535,13 +530,6 @@ static void interface_attached_worker(QXLInstance *sin)\n trace_qxl_interface_attach_worker(qxl->id);\n }\n \n-#if !(SPICE_HAS_ATTACHED_WORKER)\n-static void interface_attach_worker(QXLInstance *sin, QXLWorker *qxl_worker)\n-{\n- interface_attached_worker(sin);\n-}\n-#endif\n-\n static void interface_set_compression_level(QXLInstance *sin, int level)\n {\n PCIQXLDevice *qxl = container_of(sin, PCIQXLDevice, ssd.qxl);\n@@ -1136,12 +1124,7 @@ static const QXLInterface qxl_interface = {\n .base.major_version = SPICE_INTERFACE_QXL_MAJOR,\n .base.minor_version = SPICE_INTERFACE_QXL_MINOR,\n \n-#if SPICE_HAS_ATTACHED_WORKER\n .attached_worker = interface_attached_worker,\n-#else\n- .attache_worker = interface_attach_worker,\n-#endif\n-\n .set_compression_level = interface_set_compression_level,\n .get_init_info = interface_get_init_info,\n \n@@ -2109,6 +2092,8 @@ static void qxl_realize_common(PCIQXLDevice *qxl, Error **errp)\n uint8_t* config = qxl->pci.config;\n uint32_t pci_device_rev;\n uint32_t io_size;\n+ Error *err = NULL;\n+ char device_address[256] = \"\";\n \n qemu_spice_display_init_common(&qxl->ssd);\n qxl->mode = QXL_MODE_UNDEFINED;\n@@ -2208,9 +2193,6 @@ static void qxl_realize_common(PCIQXLDevice *qxl, Error **errp)\n return;\n }\n \n-#if SPICE_SERVER_VERSION >= 0x000e02 /* release 0.14.2 */\n- Error *err = NULL;\n- char device_address[256] = \"\";\n if (qemu_console_fill_device_address(qxl->vga.con,\n device_address, sizeof(device_address),\n &err)) {\n@@ -2221,7 +2203,6 @@ static void qxl_realize_common(PCIQXLDevice *qxl, Error **errp)\n } else {\n error_report_err(err);\n }\n-#endif\n \n qemu_add_vm_change_state_handler(qxl_vm_change_state_handler, qxl);\n \ndiff --git a/ui/spice-display.c b/ui/spice-display.c\nindex db71e866f89..6b76b9dcecd 100644\n--- a/ui/spice-display.c\n+++ b/ui/spice-display.c\n@@ -507,17 +507,10 @@ void qemu_spice_display_refresh(SimpleSpiceDisplay *ssd)\n \n /* spice display interface callbacks */\n \n-#if SPICE_HAS_ATTACHED_WORKER\n static void interface_attached_worker(QXLInstance *sin)\n {\n /* nothing to do */\n }\n-#else\n-static void interface_attach_worker(QXLInstance *sin, QXLWorker *qxl_worker)\n-{\n- /* nothing to do */\n-}\n-#endif\n \n static void interface_set_compression_level(QXLInstance *sin, int level)\n {\n@@ -689,13 +682,11 @@ static int interface_client_monitors_config(QXLInstance *sin,\n if (mc->num_of_monitors > head) {\n info.width = mc->monitors[head].width;\n info.height = mc->monitors[head].height;\n-#if SPICE_SERVER_VERSION >= 0x000e04 /* release 0.14.4 */\n if (mc->flags & VD_AGENT_CONFIG_MONITORS_FLAG_PHYSICAL_SIZE) {\n VDAgentMonitorMM *mm = (void *)&mc->monitors[mc->num_of_monitors];\n info.width_mm = mm[head].width;\n info.height_mm = mm[head].height;\n }\n-#endif\n }\n \n trace_qemu_spice_ui_info(ssd->qxl.id, info.width, info.height);\n@@ -709,11 +700,7 @@ static const QXLInterface dpy_interface = {\n .base.major_version = SPICE_INTERFACE_QXL_MAJOR,\n .base.minor_version = SPICE_INTERFACE_QXL_MINOR,\n \n-#if SPICE_HAS_ATTACHED_WORKER\n .attached_worker = interface_attached_worker,\n-#else\n- .attache_worker = interface_attach_worker,\n-#endif\n .set_compression_level = interface_set_compression_level,\n .get_init_info = interface_get_init_info,\n \n@@ -1414,7 +1401,6 @@ static void qemu_spice_display_init_one(QemuConsole *con)\n ssd->qxl.base.sif = &dpy_interface.base;\n qemu_spice_add_display_interface(&ssd->qxl, con);\n \n-#if SPICE_SERVER_VERSION >= 0x000e02 /* release 0.14.2 */\n Error *err = NULL;\n char device_address[256] = \"\";\n if (qemu_console_fill_device_address(con, device_address, 256, &err)) {\n@@ -1425,7 +1411,6 @@ static void qemu_spice_display_init_one(QemuConsole *con)\n } else {\n error_report_err(err);\n }\n-#endif\n \n qemu_spice_create_host_memslot(ssd);\n \n", "prefixes": [ "6/7" ] }