Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195517/?format=api
{ "id": 2195517, "url": "http://patchwork.ozlabs.org/api/patches/2195517/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260211-cleanups-v1-5-e63c96572389@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260211-cleanups-v1-5-e63c96572389@redhat.com>", "list_archive_url": null, "date": "2026-02-11T10:01:45", "name": "[5/7] audio: require spice >= 0.15", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "563893b871a632537de168b91972cbf1a2412c5f", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260211-cleanups-v1-5-e63c96572389@redhat.com/mbox/", "series": [ { "id": 491807, "url": "http://patchwork.ozlabs.org/api/series/491807/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491807", "date": "2026-02-11T10:01:40", "name": "Some cleanups (mostly ui/audio)", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491807/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195517/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195517/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=YD1IvgrG;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9vBg6Bjmz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 21:03:07 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vq73Z-0001UX-DG; Wed, 11 Feb 2026 05:02:49 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vq73V-00015A-Rx\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 05:02:45 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vq73U-0002zo-7E\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 05:02:45 -0500", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-hiKoJu7hP_OgXtG0Qrf9tg-1; Wed,\n 11 Feb 2026 05:02:40 -0500", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 43D5A18003F6; Wed, 11 Feb 2026 10:02:39 +0000 (UTC)", "from localhost (unknown [10.45.242.6])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D85601956053; Wed, 11 Feb 2026 10:02:37 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770804163;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=O1yPiV6/tD/XRWgMlrMoMoyq+hWEGWK4xROVUU6ku/s=;\n b=YD1IvgrGzvXs6bGViHWizyEqmBI3XVfZA85rdV5VWC+n/84sm/ocPFXihghbB9rmqtZaJs\n kxaB92obrsE3Lf4nZmZ7sHVgpaEJDieYlcfgKlna+61c+uSRDTgM4medY2ChINgL7/DE1l\n XlrUFzoihponB50TDk3bXsuBkVvflzQ=", "X-MC-Unique": "hiKoJu7hP_OgXtG0Qrf9tg-1", "X-Mimecast-MFC-AGG-ID": "hiKoJu7hP_OgXtG0Qrf9tg_1770804159", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Wed, 11 Feb 2026 14:01:45 +0400", "Subject": "[PATCH 5/7] audio: require spice >= 0.15", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260211-cleanups-v1-5-e63c96572389@redhat.com>", "References": "<20260211-cleanups-v1-0-e63c96572389@redhat.com>", "In-Reply-To": "<20260211-cleanups-v1-0-e63c96572389@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, John Snow <jsnow@redhat.com>,\n Cleber Rosa <crosa@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, =?utf-8?q?Marc-And?=\n\t=?utf-8?q?r=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=5284;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=u9Xu4eBPvh5df7XfEv+bIF6n0ePy5VZVQtW0TQCzngk=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpjFOV0MMlWEqlYTVEyz32xN6cynqy3bpSkWaW7\n hZS+9xOlkyJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaYxTlQAKCRDa6OEJdZac\n 5Z9eEAC30tXbDmxK1fT1rfU/1ClMbQMg4H0ln6G9J94wLZTzhwjAmSciRFhMD4uZi3IJrJf1HJ6\n F+AVDWSUlJ4+wrNuP824yodxkBRS14YXfj+irFHRhn+bwGSxnMH9QRox6zHeWlC4YWVQ+XAcRKl\n 18DaCaIFH5z8uGjLR65UZi3MFqmnyrttZuz++N2VY6D486U2zBoWk6fhdEdYSRt8k+92LevDQ2W\n gwxs65zIl3bR0kS+N8aACHBe6tDsql5aheje7chnvAw/f4kP2Gholw2QNGdMkWEBVGl7q8osPHD\n q8cUyLs7B1EQQ/T8J016tK6UJoBbDgQEsozfMFxmB3IfrF5mvsIHBl/bsrEobQig4L95OGKpSK8\n WV4z2w1UeVSJCqs7nUJmU7pFkhgUgeCIERimMZOEhTDIArYlnkzjhlwb6pwHTxRCUDaFC4NY+1F\n 9lMAZtNnAc7MvHLXHK1Nr0Pxc0clnPZzBuAcbO+Q92h28eOVJZGeY494fHQ73zVuV5zBC+vhLsd\n SoLVzhwkRSYlV+kIa1WdhQuVU2AFMwr3l1CL2KNy15ulgKWezVBBLUVopapxQoEJ/oeDjfw8hpK\n oGbrd7nVV/xWfRDBce3y3vhd1aVsVl0y+mXZ1uVnm/zjn/DIRMz+z6QxUA/WBs6m2+XAriQWkKG\n dkM8jN20KIrO3jw==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Spice server 0.15.0 was released on 2021-04-16. It is part of all our\nsupported distro (except CentOS 9, which doesn't include it).\n\nIt has all the new required audio APIs/interfaces.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n meson.build | 2 +-\n audio/spiceaudio.c | 30 ------------------------------\n 2 files changed, 1 insertion(+), 31 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex fb89fbd1cc5..5c3e138309f 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -1320,7 +1320,7 @@ if get_option('spice') \\\n .require(pixman.found(),\n error_message: 'cannot enable SPICE if pixman is not available') \\\n .allowed()\n- spice = dependency('spice-server', version: '>=0.14.0',\n+ spice = dependency('spice-server', version: '>=0.15.0',\n required: get_option('spice'),\n method: 'pkg-config')\n endif\ndiff --git a/audio/spiceaudio.c b/audio/spiceaudio.c\nindex 7db2d1f0dfd..9974e038574 100644\n--- a/audio/spiceaudio.c\n+++ b/audio/spiceaudio.c\n@@ -29,17 +29,8 @@\n #include \"qemu/audio.h\"\n #include \"audio_int.h\"\n \n-#if SPICE_INTERFACE_PLAYBACK_MAJOR > 1 || SPICE_INTERFACE_PLAYBACK_MINOR >= 3\n #define LINE_OUT_SAMPLES (480 * 4)\n-#else\n-#define LINE_OUT_SAMPLES (256 * 4)\n-#endif\n-\n-#if SPICE_INTERFACE_RECORD_MAJOR > 2 || SPICE_INTERFACE_RECORD_MINOR >= 3\n #define LINE_IN_SAMPLES (480 * 4)\n-#else\n-#define LINE_IN_SAMPLES (256 * 4)\n-#endif\n \n typedef struct SpiceVoiceOut {\n HWVoiceOut hw;\n@@ -95,11 +86,7 @@ static int line_out_init(HWVoiceOut *hw, struct audsettings *as,\n SpiceVoiceOut *out = container_of (hw, SpiceVoiceOut, hw);\n struct audsettings settings;\n \n-#if SPICE_INTERFACE_PLAYBACK_MAJOR > 1 || SPICE_INTERFACE_PLAYBACK_MINOR >= 3\n settings.freq = spice_server_get_best_playback_rate(NULL);\n-#else\n- settings.freq = SPICE_INTERFACE_PLAYBACK_FREQ;\n-#endif\n settings.nchannels = SPICE_INTERFACE_PLAYBACK_CHAN;\n settings.fmt = AUDIO_FORMAT_S16;\n settings.endianness = HOST_BIG_ENDIAN;\n@@ -110,9 +97,7 @@ static int line_out_init(HWVoiceOut *hw, struct audsettings *as,\n \n out->sin.base.sif = &playback_sif.base;\n qemu_spice.add_interface(&out->sin.base);\n-#if SPICE_INTERFACE_PLAYBACK_MAJOR > 1 || SPICE_INTERFACE_PLAYBACK_MINOR >= 3\n spice_server_set_playback_rate(&out->sin, settings.freq);\n-#endif\n return 0;\n }\n \n@@ -190,7 +175,6 @@ static void line_out_enable(HWVoiceOut *hw, bool enable)\n }\n }\n \n-#if ((SPICE_INTERFACE_PLAYBACK_MAJOR >= 1) && (SPICE_INTERFACE_PLAYBACK_MINOR >= 2))\n static void line_out_volume(HWVoiceOut *hw, Volume *vol)\n {\n SpiceVoiceOut *out = container_of(hw, SpiceVoiceOut, hw);\n@@ -202,7 +186,6 @@ static void line_out_volume(HWVoiceOut *hw, Volume *vol)\n spice_server_playback_set_volume(&out->sin, 2, svol);\n spice_server_playback_set_mute(&out->sin, vol->mute);\n }\n-#endif\n \n /* record */\n \n@@ -211,11 +194,7 @@ static int line_in_init(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque)\n SpiceVoiceIn *in = container_of (hw, SpiceVoiceIn, hw);\n struct audsettings settings;\n \n-#if SPICE_INTERFACE_RECORD_MAJOR > 2 || SPICE_INTERFACE_RECORD_MINOR >= 3\n settings.freq = spice_server_get_best_record_rate(NULL);\n-#else\n- settings.freq = SPICE_INTERFACE_RECORD_FREQ;\n-#endif\n settings.nchannels = SPICE_INTERFACE_RECORD_CHAN;\n settings.fmt = AUDIO_FORMAT_S16;\n settings.endianness = HOST_BIG_ENDIAN;\n@@ -226,9 +205,7 @@ static int line_in_init(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque)\n \n in->sin.base.sif = &record_sif.base;\n qemu_spice.add_interface(&in->sin.base);\n-#if SPICE_INTERFACE_RECORD_MAJOR > 2 || SPICE_INTERFACE_RECORD_MINOR >= 3\n spice_server_set_record_rate(&in->sin, settings.freq);\n-#endif\n return 0;\n }\n \n@@ -277,7 +254,6 @@ static void line_in_enable(HWVoiceIn *hw, bool enable)\n }\n }\n \n-#if ((SPICE_INTERFACE_RECORD_MAJOR >= 2) && (SPICE_INTERFACE_RECORD_MINOR >= 2))\n static void line_in_volume(HWVoiceIn *hw, Volume *vol)\n {\n SpiceVoiceIn *in = container_of(hw, SpiceVoiceIn, hw);\n@@ -289,7 +265,6 @@ static void line_in_volume(HWVoiceIn *hw, Volume *vol)\n spice_server_record_set_volume(&in->sin, 2, svol);\n spice_server_record_set_mute(&in->sin, vol->mute);\n }\n-#endif\n \n static struct audio_pcm_ops audio_callbacks = {\n .init_out = line_out_init,\n@@ -299,19 +274,14 @@ static struct audio_pcm_ops audio_callbacks = {\n .get_buffer_out = line_out_get_buffer,\n .put_buffer_out = line_out_put_buffer,\n .enable_out = line_out_enable,\n-#if (SPICE_INTERFACE_PLAYBACK_MAJOR >= 1) && \\\n- (SPICE_INTERFACE_PLAYBACK_MINOR >= 2)\n .volume_out = line_out_volume,\n-#endif\n \n .init_in = line_in_init,\n .fini_in = line_in_fini,\n .read = line_in_read,\n .run_buffer_in = audio_generic_run_buffer_in,\n .enable_in = line_in_enable,\n-#if ((SPICE_INTERFACE_RECORD_MAJOR >= 2) && (SPICE_INTERFACE_RECORD_MINOR >= 2))\n .volume_in = line_in_volume,\n-#endif\n };\n \n static struct audio_driver spice_audio_driver = {\n", "prefixes": [ "5/7" ] }