Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195510/?format=api
{ "id": 2195510, "url": "http://patchwork.ozlabs.org/api/patches/2195510/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260211091140.236389-1-michal.swiatkowski@linux.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260211091140.236389-1-michal.swiatkowski@linux.intel.com>", "list_archive_url": null, "date": "2026-02-11T09:11:40", "name": "[iwl-net,v1] libie: don't unroll if fwlog isn't supported", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "36ff18cdad09345cb6a9ac0984dcd5c02b85afc1", "submitter": { "id": 81972, "url": "http://patchwork.ozlabs.org/api/people/81972/?format=api", "name": "Michal Swiatkowski", "email": "michal.swiatkowski@linux.intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260211091140.236389-1-michal.swiatkowski@linux.intel.com/mbox/", "series": [ { "id": 491805, "url": "http://patchwork.ozlabs.org/api/series/491805/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=491805", "date": "2026-02-11T09:11:40", "name": "[iwl-net,v1] libie: don't unroll if fwlog isn't supported", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491805/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195510/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195510/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=W5lQkXZ0;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9tmF6Pbfz1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 20:43:41 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id D8DD360621;\n\tWed, 11 Feb 2026 09:43:39 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id CIpxreLljdZH; Wed, 11 Feb 2026 09:43:38 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 239D4605DD;\n\tWed, 11 Feb 2026 09:43:38 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 9219A23D\n for <intel-wired-lan@lists.osuosl.org>; Wed, 11 Feb 2026 09:43:36 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 8043E40C35\n for <intel-wired-lan@lists.osuosl.org>; Wed, 11 Feb 2026 09:43:36 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id uDrp7PYnDgtu for <intel-wired-lan@lists.osuosl.org>;\n Wed, 11 Feb 2026 09:43:36 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.17])\n by smtp4.osuosl.org (Postfix) with ESMTPS id CB21740AFD\n for <intel-wired-lan@lists.osuosl.org>; Wed, 11 Feb 2026 09:43:35 +0000 (UTC)", "from fmviesa010.fm.intel.com ([10.60.135.150])\n by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Feb 2026 01:43:35 -0800", "from os-delivery.igk.intel.com ([10.102.21.165])\n by fmviesa010.fm.intel.com with ESMTP; 11 Feb 2026 01:43:34 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 239D4605DD", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org CB21740AFD" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1770803018;\n\tbh=f6m/Z0v3sTVc+mnIfQUCOqmdpZxyPTAXi6nT/CAuviE=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=W5lQkXZ0pkR2LTnUZzgGnStZz61hharyolCTGYEdf2JWGcav480Ywk+Qad/DuGw/d\n\t JV0sxANbkBEEKDiuFT30ENlypAV+Cf+leMjyMXyxJ/H0DbtBniB7ioa587FnevzxoO\n\t dn0dAk4uzLJikm3y75lXsHHlouFG1Oj/raUP6TBjtVWI0wY2Grs99sP402WV6Mo6fe\n\t KJPznLDneb5///vvbp0B6jyHzSlACFwG11cx4dv/wSt4BEP11KdH34ZG3RQKVumGbY\n\t TZQEBAXFQAaC4MFUH2vQew7g7EB3oyJq4HHnnjCyWvGKv3DE939mRyHsjYSSXaWVNv\n\t GYWyaOq8n6lEg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.17;\n helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org CB21740AFD", "X-CSE-ConnectionGUID": [ "ybvmOiM3QMWIPRiPmi0edw==", "1Feq19IFQUuQkHJ/wzguJA==" ], "X-CSE-MsgGUID": [ "KGy+MrEXT3OfbXZXs+K4gQ==", "8D3a+89OQ1SWV7f1wzmaQA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11697\"; a=\"71844143\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"71844143\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"211599160\"" ], "X-ExtLoop1": "1", "From": "Michal Swiatkowski <michal.swiatkowski@linux.intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org,\n Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Date": "Wed, 11 Feb 2026 10:11:40 +0100", "Message-ID": "<20260211091140.236389-1-michal.swiatkowski@linux.intel.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1770803016; x=1802339016;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=3R2gvJlYg2fkGJs2L5r+sIWjeFpGyp7Xsc71mVtw76k=;\n b=IhKZWvQIYn8Wgi0aKYtdwmsf5eAmzNl4mIelhLYcDNH2Mo08hLoMyWK/\n G2ocY8dlgtZY96/nEMY58jcap6lPUJJug2uB04FGnqPzAXXH4fZI5roBw\n 2vrCrtEDum8Wqu5TrdAy8MpLX1Vtvp+Xjzl1NrZs3CENtG0gGeWSSm62X\n dbgNdjD7IxtWKmWSSZ5iZ7dPvPHVC2mFXhjSXo1THA5UWaOq9TOVCHvbt\n Ke7tSSd5C07Y8pREXpd79Kx/pA2CUUVHbH2voTOdKE/xi/nh3gIT9x6Sn\n oBdiZwGsFsmIKpFvDpHvJ5CnqjIU3fBPdwQHAPgczi+rdhcNHadlXBBsD\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=IhKZWvQI" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v1] libie: don't unroll if fwlog\n isn't supported", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The libie_fwlog_deinit() function can be called during driver unload\neven when firmware logging was never properly initialized. This led to call\ntrace:\n\n[ 148.576156] Oops: Oops: 0000 [#1] SMP NOPTI\n[ 148.576167] CPU: 80 UID: 0 PID: 12843 Comm: rmmod Kdump: loaded Not tainted 6.17.0-rc7next-queue-3oct-01915-g06d79d51cf51 #1 PREEMPT(full)\n[ 148.576177] Hardware name: HPE ProLiant DL385 Gen10 Plus/ProLiant DL385 Gen10 Plus, BIOS A42 07/18/2020\n[ 148.576182] RIP: 0010:__dev_printk+0x16/0x70\n[ 148.576196] Code: 1f 44 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 0f 1f 44 00 00 41 55 41 54 49 89 d4 55 48 89 fd 53 48 85 f6 74 3c <4c> 8b 6e 50 48 89 f3 4d 85 ed 75 03 4c 8b 2e 48 89 df e8 f3 27 98\n[ 148.576204] RSP: 0018:ffffd2fd7ea17a48 EFLAGS: 00010202\n[ 148.576211] RAX: ffffd2fd7ea17aa0 RBX: ffff8eb288ae2000 RCX: 0000000000000000\n[ 148.576217] RDX: ffffd2fd7ea17a70 RSI: 00000000000000c8 RDI: ffffffffb68d3d88\n[ 148.576222] RBP: ffffffffb68d3d88 R08: 0000000000000000 R09: 0000000000000000\n[ 148.576227] R10: 00000000000000c8 R11: ffff8eb2b1a49400 R12: ffffd2fd7ea17a70\n[ 148.576231] R13: ffff8eb3141fb000 R14: ffffffffc1215b48 R15: ffffffffc1215bd8\n[ 148.576236] FS: 00007f5666ba6740(0000) GS:ffff8eb2472b9000(0000) knlGS:0000000000000000\n[ 148.576242] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n[ 148.576247] CR2: 0000000000000118 CR3: 000000011ad17000 CR4: 0000000000350ef0\n[ 148.576252] Call Trace:\n[ 148.576258] <TASK>\n[ 148.576269] _dev_warn+0x7c/0x96\n[ 148.576290] libie_fwlog_deinit+0x112/0x117 [libie_fwlog]\n[ 148.576303] ixgbe_remove+0x63/0x290 [ixgbe]\n[ 148.576342] pci_device_remove+0x42/0xb0\n[ 148.576354] device_release_driver_internal+0x19c/0x200\n[ 148.576365] driver_detach+0x48/0x90\n[ 148.576372] bus_remove_driver+0x6d/0xf0\n[ 148.576383] pci_unregister_driver+0x2e/0xb0\n[ 148.576393] ixgbe_exit_module+0x1c/0xd50 [ixgbe]\n[ 148.576430] __do_sys_delete_module.isra.0+0x1bc/0x2e0\n[ 148.576446] do_syscall_64+0x7f/0x980\n\nIt can be reproduced by trying to unload ixgbe driver in recovery mode.\n\nFix that by checking if fwlog is supported before doing unroll.\n\nFixes: 641585bc978e (\"ixgbe: fwlog support for e610\")\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nSigned-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>\n---\n drivers/net/ethernet/intel/libie/fwlog.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/libie/fwlog.c b/drivers/net/ethernet/intel/libie/fwlog.c\nindex f39cc11cb7c5..5d890d9d3c4d 100644\n--- a/drivers/net/ethernet/intel/libie/fwlog.c\n+++ b/drivers/net/ethernet/intel/libie/fwlog.c\n@@ -1051,6 +1051,10 @@ void libie_fwlog_deinit(struct libie_fwlog *fwlog)\n {\n \tint status;\n \n+\t/* if FW logging isn't supported it means no configuration was done */\n+\tif (!libie_fwlog_supported(fwlog))\n+\t\treturn;\n+\n \t/* make sure FW logging is disabled to not put the FW in a weird state\n \t * for the next driver load\n \t */\n", "prefixes": [ "iwl-net", "v1" ] }