Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195509/?format=api
{ "id": 2195509, "url": "http://patchwork.ozlabs.org/api/patches/2195509/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260211091008.236185-1-michal.swiatkowski@linux.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260211091008.236185-1-michal.swiatkowski@linux.intel.com>", "list_archive_url": null, "date": "2026-02-11T09:10:08", "name": "[iwl-net,v1] libie: prevent memleak in fwlog code", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "5a5576537f2d1ac3894a3f7cfec6c818cc5aba73", "submitter": { "id": 81972, "url": "http://patchwork.ozlabs.org/api/people/81972/?format=api", "name": "Michal Swiatkowski", "email": "michal.swiatkowski@linux.intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260211091008.236185-1-michal.swiatkowski@linux.intel.com/mbox/", "series": [ { "id": 491804, "url": "http://patchwork.ozlabs.org/api/series/491804/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=491804", "date": "2026-02-11T09:10:08", "name": "[iwl-net,v1] libie: prevent memleak in fwlog code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491804/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195509/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195509/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=8Z7r4PpW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9tkY5R6mz1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 20:42:13 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 2F39083C07;\n\tWed, 11 Feb 2026 09:42:12 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id NlEN4IVKqjtw; Wed, 11 Feb 2026 09:42:11 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 5FDDC83794;\n\tWed, 11 Feb 2026 09:42:11 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id B76C123D\n for <intel-wired-lan@lists.osuosl.org>; Wed, 11 Feb 2026 09:42:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 9CD6C408A5\n for <intel-wired-lan@lists.osuosl.org>; Wed, 11 Feb 2026 09:42:09 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id x69efEQPH2z9 for <intel-wired-lan@lists.osuosl.org>;\n Wed, 11 Feb 2026 09:42:09 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.18])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 84A25404E5\n for <intel-wired-lan@lists.osuosl.org>; Wed, 11 Feb 2026 09:42:08 +0000 (UTC)", "from orviesa003.jf.intel.com ([10.64.159.143])\n by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Feb 2026 01:42:08 -0800", "from os-delivery.igk.intel.com ([10.102.21.165])\n by orviesa003.jf.intel.com with ESMTP; 11 Feb 2026 01:42:06 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5FDDC83794", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 84A25404E5" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1770802931;\n\tbh=H9Wo1s6YuhSxjy+y8OwETdrybA3+q7mRorb9/+lKJek=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=8Z7r4PpW7oycYHOvj6vuC8067sbgI9fcsM5g5wwTlW6Js7aIa1VS//5PgyJiueLp7\n\t 1y5aqEBy38okgo6n9ZEEuEiPzBitq90TyrRDohlBLfta6UiUT0KDBWMBILiDfHNdaV\n\t 6871H3+WhmFgHMJxaJylRqM6Kb3UFIUcgUoTI5ECUq6hQMQvNZsHJhd1JHLtLxfPyF\n\t xvHh7MoaKxoFLsp5EqVNN01K/ibfiqu7c/oLzt9oVdUa+/mcaZSEBAAeEwyvdq/5/o\n\t /VQa+fC1LsM5VVs80Sp0zOju1TvD3pLv26ApVhaN01r/xO9HrGZRDiNcYOmAdcfafY\n\t qP3X/V66ztMnw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.18;\n helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 84A25404E5", "X-CSE-ConnectionGUID": [ "80opTlIiSSGsiS3JGNbTfg==", "uKKN/ziCREmnXY7XgyPUWA==" ], "X-CSE-MsgGUID": [ "mqKBIoFiQAqO35WpRx6llA==", "2YM07DmfTvmIWwAzO3RPxA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11697\"; a=\"71988515\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"71988515\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"216361856\"" ], "X-ExtLoop1": "1", "From": "Michal Swiatkowski <michal.swiatkowski@linux.intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org,\n Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Date": "Wed, 11 Feb 2026 10:10:08 +0100", "Message-ID": "<20260211091008.236185-1-michal.swiatkowski@linux.intel.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1770802928; x=1802338928;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=APntsk4MTWEO9YuK7mDQRF5/+R2iKfmtOW+Sf2X1qt4=;\n b=DUqQm8tu8QWZWjWjtjEZn4EqVA0IhhUNmZqu5SJPeQWm72pr2h1N/Jva\n 9dX+km2LLM5QTx9yZMqVyBlROU73mJIYbk9BINHL9SziFObL3gnJ4099z\n pZFUATZoPF8nj1bPVXgnSlYtKh2Bj3bLFXylv9od645k/lmE5to3c6QN4\n +iw8ze8PeDqt1mAU9cwIlj2SaZqdwqA9slIgdMgWv+Eis7fEpWaHsoCCF\n Venp2DNdoWxTQGDWo+kOP1k4g6Cp7RGcci7mYzxetAEOrMkCC3SdIsRzY\n S9OinJFJwEimvfT4jNOFG7TyIPPY2iiAQaNSDtxNVb/S1KfAbhDateCOA\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=DUqQm8tu" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v1] libie: prevent memleak in\n fwlog code", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "All cmd_buf buffers are allocated and need to be freed after usage.\nAdd an error unwinding path that properly frees these buffers.\n\nThe memory leak happens whenever fwlog configuration is changed. For\nexample:\n\n$echo 256K > /sys/kernel/debug/ixgbe/0000\\:32\\:00.0/fwlog/log_size\n\nFixes: 96a9a9341cda (\"ice: configure FW logging\")\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nSigned-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>\n---\n drivers/net/ethernet/intel/libie/fwlog.c | 49 +++++++++++++++++-------\n 1 file changed, 36 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/libie/fwlog.c b/drivers/net/ethernet/intel/libie/fwlog.c\nindex f39cc11cb7c5..30a6bd095f18 100644\n--- a/drivers/net/ethernet/intel/libie/fwlog.c\n+++ b/drivers/net/ethernet/intel/libie/fwlog.c\n@@ -433,17 +433,21 @@ libie_debugfs_module_write(struct file *filp, const char __user *buf,\n \tmodule = libie_find_module_by_dentry(fwlog->debugfs_modules, dentry);\n \tif (module < 0) {\n \t\tdev_info(dev, \"unknown module\\n\");\n-\t\treturn -EINVAL;\n+\t\tcount = -EINVAL;\n+\t\tgoto free_cmd_buf;\n \t}\n \n \tcnt = sscanf(cmd_buf, \"%s\", user_val);\n-\tif (cnt != 1)\n-\t\treturn -EINVAL;\n+\tif (cnt != 1) {\n+\t\tcount = -EINVAL;\n+\t\tgoto free_cmd_buf;\n+\t}\n \n \tlog_level = sysfs_match_string(libie_fwlog_level_string, user_val);\n \tif (log_level < 0) {\n \t\tdev_info(dev, \"unknown log level '%s'\\n\", user_val);\n-\t\treturn -EINVAL;\n+\t\tcount = -EINVAL;\n+\t\tgoto free_cmd_buf;\n \t}\n \n \tif (module != LIBIE_AQC_FW_LOG_ID_MAX) {\n@@ -458,6 +462,9 @@ libie_debugfs_module_write(struct file *filp, const char __user *buf,\n \t\t\tfwlog->cfg.module_entries[i].log_level = log_level;\n \t}\n \n+free_cmd_buf:\n+\tkfree(cmd_buf);\n+\n \treturn count;\n }\n \n@@ -515,23 +522,31 @@ libie_debugfs_nr_messages_write(struct file *filp, const char __user *buf,\n \t\treturn PTR_ERR(cmd_buf);\n \n \tret = sscanf(cmd_buf, \"%s\", user_val);\n-\tif (ret != 1)\n-\t\treturn -EINVAL;\n+\tif (ret != 1) {\n+\t\tcount = -EINVAL;\n+\t\tgoto free_cmd_buf;\n+\t}\n \n \tret = kstrtos16(user_val, 0, &nr_messages);\n-\tif (ret)\n-\t\treturn ret;\n+\tif (ret) {\n+\t\tcount = ret;\n+\t\tgoto free_cmd_buf;\n+\t}\n \n \tif (nr_messages < LIBIE_AQC_FW_LOG_MIN_RESOLUTION ||\n \t nr_messages > LIBIE_AQC_FW_LOG_MAX_RESOLUTION) {\n \t\tdev_err(dev, \"Invalid FW log number of messages %d, value must be between %d - %d\\n\",\n \t\t\tnr_messages, LIBIE_AQC_FW_LOG_MIN_RESOLUTION,\n \t\t\tLIBIE_AQC_FW_LOG_MAX_RESOLUTION);\n-\t\treturn -EINVAL;\n+\t\tcount = -EINVAL;\n+\t\tgoto free_cmd_buf;\n \t}\n \n \tfwlog->cfg.log_resolution = nr_messages;\n \n+free_cmd_buf:\n+\tkfree(cmd_buf);\n+\n \treturn count;\n }\n \n@@ -588,8 +603,10 @@ libie_debugfs_enable_write(struct file *filp, const char __user *buf,\n \t\treturn PTR_ERR(cmd_buf);\n \n \tret = sscanf(cmd_buf, \"%s\", user_val);\n-\tif (ret != 1)\n-\t\treturn -EINVAL;\n+\tif (ret != 1) {\n+\t\tret = -EINVAL;\n+\t\tgoto free_cmd_buf;\n+\t}\n \n \tret = kstrtobool(user_val, &enable);\n \tif (ret)\n@@ -624,6 +641,8 @@ libie_debugfs_enable_write(struct file *filp, const char __user *buf,\n \t */\n \tif (WARN_ON(ret != (ssize_t)count && ret >= 0))\n \t\tret = -EIO;\n+free_cmd_buf:\n+\tkfree(cmd_buf);\n \n \treturn ret;\n }\n@@ -682,8 +701,10 @@ libie_debugfs_log_size_write(struct file *filp, const char __user *buf,\n \t\treturn PTR_ERR(cmd_buf);\n \n \tret = sscanf(cmd_buf, \"%s\", user_val);\n-\tif (ret != 1)\n-\t\treturn -EINVAL;\n+\tif (ret != 1) {\n+\t\tret = -EINVAL;\n+\t\tgoto free_cmd_buf;\n+\t}\n \n \tindex = sysfs_match_string(libie_fwlog_log_size, user_val);\n \tif (index < 0) {\n@@ -712,6 +733,8 @@ libie_debugfs_log_size_write(struct file *filp, const char __user *buf,\n \t */\n \tif (WARN_ON(ret != (ssize_t)count && ret >= 0))\n \t\tret = -EIO;\n+free_cmd_buf:\n+\tkfree(cmd_buf);\n \n \treturn ret;\n }\n", "prefixes": [ "iwl-net", "v1" ] }