Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195347/?format=api
{ "id": 2195347, "url": "http://patchwork.ozlabs.org/api/patches/2195347/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210201344.1403613-3-pierrick.bouvier@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210201344.1403613-3-pierrick.bouvier@linaro.org>", "list_archive_url": null, "date": "2026-02-10T20:13:42", "name": "[2/4] contrib/plugins/uftrace: add ops for walking frame pointers chain", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5adc7bfe1dfa645b4ba2eb48d9a07c46f894260e", "submitter": { "id": 85798, "url": "http://patchwork.ozlabs.org/api/people/85798/?format=api", "name": "Pierrick Bouvier", "email": "pierrick.bouvier@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210201344.1403613-3-pierrick.bouvier@linaro.org/mbox/", "series": [ { "id": 491734, "url": "http://patchwork.ozlabs.org/api/series/491734/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491734", "date": "2026-02-10T20:13:44", "name": "contrib/plugins/uftrace: add riscv64 support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491734/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195347/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195347/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=byyrD16t;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9Xph26clz1xxJ\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 07:14:36 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpu7X-0005ox-2d; Tue, 10 Feb 2026 15:14:03 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1vpu7V-0005nX-5i\n for qemu-devel@nongnu.org; Tue, 10 Feb 2026 15:14:01 -0500", "from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1vpu7T-0007nU-0b\n for qemu-devel@nongnu.org; Tue, 10 Feb 2026 15:14:00 -0500", "by mail-pl1-x62c.google.com with SMTP id\n d9443c01a7336-2aae4816912so18824215ad.2\n for <qemu-devel@nongnu.org>; Tue, 10 Feb 2026 12:13:58 -0800 (PST)", "from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c6dcb5e3e8csm13930031a12.21.2026.02.10.12.13.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 10 Feb 2026 12:13:57 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1770754437; x=1771359237; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=f6lfjFGTpP9sqItRbR9rxD4pmFfc0wMz2+PxtkzkfnQ=;\n b=byyrD16t911RaHKcTnnf4F34A/v6HvcCCX7bwBq4thWDJ/xm8PW9IiIM5KcDjQ+zX7\n Cdy/zUQvurvDJgpl+NNuVCFkFHAe68TxzHyLaJhtKOqND/+lEReTa+V4y7vsQKdgPLAe\n d6/79+dYo0K+BzmFCkKqxjlhSxOqZQ4Rj9DEZdw06f946trJUKFiCgWcHnfLcwvk5Sq3\n hKFOLr3o93WNr9I+13PBNWl15lW8e4sey3Z5eAj70+fp+9vrQ8TuqRAo42zY/eXMb/Mh\n JZhUsoLS2BPsJ3oDgST81MpRTMSK0/lHp1xTQvRHjeUrZugN3or3MLCEQlM6QdbFUzd5\n C7tw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770754437; x=1771359237;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=f6lfjFGTpP9sqItRbR9rxD4pmFfc0wMz2+PxtkzkfnQ=;\n b=G6RlZU5XQcU/9/Aspq3WXh2QLTh30h1EF+43L9LR/Zh04t6blygiyb0Lluev2cqznX\n SYtaIMwkdYQi7UPZRwC9HM/4OkCTX43urXCnAUNYsFfZDvRW745sswwAUsrXRN7dEHOF\n jeYGntwIpDGZe48PDWEe5ag5usKOoUJwkc/ZuTU6XHMBYFjdzkGVnR63tNNmwUHHz3dJ\n 7yuL6NQXHHi7aK2ngSKvm82yQuwvFaO5u6sZtWV5yoRfE6gUWN3E2icCgvuD0ewJpad7\n qmtpOt9Wb5iomCnt0U1HH8eq9xiAG1PqFCAV2S1Rb3hiFub2rzeb6ZUeiJpRVMayoDv9\n qC4w==", "X-Gm-Message-State": "AOJu0Yyvgs3Px4debkCnMe3JJU3ZPUhVfvEiEfhvo2jTOLNgNndEz7Mk\n rmAol37vCLbR88rr1tKoGqyeT+Sw0BNNdhg7izPsgwDEWwgIAFnwnhMiNKwNZvfrHgfmzjT+a9a\n iIw6j", "X-Gm-Gg": "AZuq6aKpUr1iVNm3P8xk8Wb7j/qrnz8j10sU3KuQwPXMD2kt9aaUeYVEiqNmlTctZe4\n 6p3DYgtht5AtLfKPDtRJYasD/fhwzdOym2aQqPaXL6VrafVvUWdZ5SXhuQ5pUxWV0GWQ3lgqNul\n y/n9TuViCjoGnWe+VdR3s4hsBZPTyNiGtIjxUAzNQDIYe+ic5R4q02dyXcj9nCZ1ZT5EKwWVi9e\n ophswsZuyWEixpo8yohQfq5Vls27yRFfmveCoLN2M3uTy/xXTEHNacWEg12c2waZPJaP4BYe0nn\n 65mSb5qes4gT0Vcc4ESRX9GS2CkUKGmoeGRtqjGIZ6eZBm9Jcxmkmn57Z8yVfAwg+cupveVezhH\n CVJ61N1VfmcAWVF8ygKySqxe6MBgUu6r5+1mOR1+vkyk7Dif4/ZUQxmFX3oMyxk8q7MaIL9Sn9j\n AZEWt9ziNqnvrNZvR9Il5QIXFLVuW43pstfiozCjJtJQdk7b8X7w6DxVTbg+NhnKA3bL7S5+y29\n T3im7+6LKwPEEc=", "X-Received": "by 2002:a17:903:b46:b0:2aa:f43d:7c42 with SMTP id\n d9443c01a7336-2ab27d13dd8mr2959015ad.24.1770754437398;\n Tue, 10 Feb 2026 12:13:57 -0800 (PST)", "From": "Pierrick Bouvier <pierrick.bouvier@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Alexandre Iooss <erdnaxe@crans.org>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>, alistair.francis@wdc.com,\n Mahmoud Mandour <ma.mandourr@gmail.com>, manos.pitsidianakis@linaro.org,\n philmd@linaro.org, anjo@rev.ng, brian.cain@oss.qualcomm.com", "Subject": "[PATCH 2/4] contrib/plugins/uftrace: add ops for walking frame\n pointers chain", "Date": "Tue, 10 Feb 2026 12:13:42 -0800", "Message-ID": "<20260210201344.1403613-3-pierrick.bouvier@linaro.org>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260210201344.1403613-1-pierrick.bouvier@linaro.org>", "References": "<20260210201344.1403613-1-pierrick.bouvier@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::62c;\n envelope-from=pierrick.bouvier@linaro.org; helo=mail-pl1-x62c.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "x86_64 and aarch64 use same stack layout. However, other architectures\nmight use different offset for return address and next frame pointer.\n\nSigned-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\n---\n contrib/plugins/uftrace.c | 38 ++++++++++++++++++++++++++++++++------\n 1 file changed, 32 insertions(+), 6 deletions(-)", "diff": "diff --git a/contrib/plugins/uftrace.c b/contrib/plugins/uftrace.c\nindex 1ed982999ed..21ac1402047 100644\n--- a/contrib/plugins/uftrace.c\n+++ b/contrib/plugins/uftrace.c\n@@ -46,6 +46,8 @@ typedef struct {\n void (*init)(Cpu *cpu);\n void (*end)(Cpu *cpu);\n uint64_t (*get_frame_pointer)(Cpu *cpu);\n+ uint64_t (*get_next_frame_pointer)(Cpu *cpu, uint64_t fp);\n+ uint64_t (*get_next_return_address)(Cpu *cpu, uint64_t fp);\n uint8_t (*get_privilege_level)(Cpu *cpu);\n uint8_t (*num_privilege_levels)(void);\n const char *(*get_privilege_level_name)(uint8_t pl);\n@@ -421,7 +423,9 @@ static uint32_t cpu_read_register32(Cpu *cpu, struct qemu_plugin_register *reg)\n \n static uint64_t cpu_read_memory64(Cpu *cpu, uint64_t addr)\n {\n- g_assert(addr);\n+ if (!addr) {\n+ return 0;\n+ }\n GByteArray *buf = cpu->buf;\n g_byte_array_set_size(buf, 0);\n bool read = qemu_plugin_read_memory_vaddr(addr, buf, 8);\n@@ -449,10 +453,8 @@ static void cpu_unwind_stack(Cpu *cpu, uint64_t frame_pointer, uint64_t pc)\n CallstackEntry e = {.frame_pointer = frame_pointer, .pc = pc};\n unwind[depth] = e;\n depth++;\n- if (frame_pointer) {\n- frame_pointer = cpu_read_memory64(cpu, frame_pointer);\n- }\n- pc = cpu_read_memory64(cpu, frame_pointer + 8); /* read previous lr */\n+ frame_pointer = cpu->ops.get_next_frame_pointer(cpu, frame_pointer);\n+ pc = cpu->ops.get_next_return_address(cpu, frame_pointer);\n } while (frame_pointer && pc && depth < UNWIND_STACK_MAX_DEPTH);\n #undef UNWIND_STACK_MAX_DEPTH\n \n@@ -545,6 +547,16 @@ static uint64_t aarch64_get_frame_pointer(Cpu *cpu_)\n return cpu_read_register64(cpu_, cpu->reg_fp);\n }\n \n+static uint64_t aarch64_get_next_frame_pointer(Cpu *cpu_, uint64_t fp)\n+{\n+ return cpu_read_memory64(cpu_, fp);\n+}\n+\n+static uint64_t aarch64_get_next_return_address(Cpu *cpu_, uint64_t fp)\n+{\n+ return cpu_read_memory64(cpu_, fp + 8);\n+}\n+\n static void aarch64_init(Cpu *cpu_)\n {\n Aarch64Cpu *cpu = g_new0(Aarch64Cpu, 1);\n@@ -580,6 +592,8 @@ static CpuOps aarch64_ops = {\n .init = aarch64_init,\n .end = aarch64_end,\n .get_frame_pointer = aarch64_get_frame_pointer,\n+ .get_next_frame_pointer = aarch64_get_next_frame_pointer,\n+ .get_next_return_address = aarch64_get_next_return_address,\n .get_privilege_level = aarch64_get_privilege_level,\n .num_privilege_levels = aarch64_num_privilege_levels,\n .get_privilege_level_name = aarch64_get_privilege_level_name,\n@@ -623,6 +637,16 @@ static uint64_t x64_get_frame_pointer(Cpu *cpu_)\n return cpu_read_register64(cpu_, cpu->reg_rbp);\n }\n \n+static uint64_t x64_get_next_frame_pointer(Cpu *cpu_, uint64_t fp)\n+{\n+ return cpu_read_memory64(cpu_, fp);\n+}\n+\n+static uint64_t x64_get_next_return_address(Cpu *cpu_, uint64_t fp)\n+{\n+ return cpu_read_memory64(cpu_, fp + 8);\n+}\n+\n static void x64_init(Cpu *cpu_)\n {\n X64Cpu *cpu = g_new0(X64Cpu, 1);\n@@ -649,6 +673,8 @@ static CpuOps x64_ops = {\n .init = x64_init,\n .end = x64_end,\n .get_frame_pointer = x64_get_frame_pointer,\n+ .get_next_frame_pointer = x64_get_next_frame_pointer,\n+ .get_next_return_address = x64_get_next_return_address,\n .get_privilege_level = x64_get_privilege_level,\n .num_privilege_levels = x64_num_privilege_levels,\n .get_privilege_level_name = x64_get_privilege_level_name,\n@@ -710,7 +736,7 @@ static void track_callstack(unsigned int cpu_index, void *udata)\n return;\n }\n \n- uint64_t caller_fp = fp ? cpu_read_memory64(cpu, fp) : 0;\n+ uint64_t caller_fp = cpu->ops.get_next_frame_pointer(cpu, fp);\n if (caller_fp == top.frame_pointer) {\n /* call */\n callstack_push(cs, (CallstackEntry){.frame_pointer = fp, .pc = pc});\n", "prefixes": [ "2/4" ] }