Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195342/?format=api
{ "id": 2195342, "url": "http://patchwork.ozlabs.org/api/patches/2195342/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/d2407882ecc62a51781dec51791c91d331802fa3.1770753117.git.balaton@eik.bme.hu/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<d2407882ecc62a51781dec51791c91d331802fa3.1770753117.git.balaton@eik.bme.hu>", "list_archive_url": null, "date": "2026-02-10T20:02:14", "name": "[v3,6/6] hw/xtensa/xtfpga: Fix leaking memory region", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "149a2b7055a936aa5d83eab5e166c10bc5ad049c", "submitter": { "id": 16148, "url": "http://patchwork.ozlabs.org/api/people/16148/?format=api", "name": "BALATON Zoltan", "email": "balaton@eik.bme.hu" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/d2407882ecc62a51781dec51791c91d331802fa3.1770753117.git.balaton@eik.bme.hu/mbox/", "series": [ { "id": 491733, "url": "http://patchwork.ozlabs.org/api/series/491733/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491733", "date": "2026-02-10T20:02:11", "name": "Implement memory_region_new_* functions", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/491733/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195342/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195342/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9XZD4Ct4z1xvg\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 07:03:48 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vptwZ-0000uC-13; Tue, 10 Feb 2026 15:02:43 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <balaton@eik.bme.hu>)\n id 1vptwG-0000p0-AZ\n for qemu-devel@nongnu.org; Tue, 10 Feb 2026 15:02:25 -0500", "from zero.eik.bme.hu ([2001:738:2001:2001::2001])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <balaton@eik.bme.hu>)\n id 1vptwE-00052F-3H\n for qemu-devel@nongnu.org; Tue, 10 Feb 2026 15:02:23 -0500", "from localhost (localhost [127.0.0.1])\n by zero.eik.bme.hu (Postfix) with ESMTP id 8526E596E9E;\n Tue, 10 Feb 2026 21:02:16 +0100 (CET)", "from zero.eik.bme.hu ([127.0.0.1])\n by localhost (zero.eik.bme.hu [127.0.0.1]) (amavis, port 10028) with ESMTP\n id RXhpb9tbmoVs; Tue, 10 Feb 2026 21:02:14 +0100 (CET)", "by zero.eik.bme.hu (Postfix, from userid 432)\n id 82FEC596E91; Tue, 10 Feb 2026 21:02:14 +0100 (CET)" ], "X-Virus-Scanned": "amavis at eik.bme.hu", "Message-ID": "\n <d2407882ecc62a51781dec51791c91d331802fa3.1770753117.git.balaton@eik.bme.hu>", "In-Reply-To": "<cover.1770753117.git.balaton@eik.bme.hu>", "References": "<cover.1770753117.git.balaton@eik.bme.hu>", "From": "BALATON Zoltan <balaton@eik.bme.hu>", "Subject": "[PATCH v3 6/6] hw/xtensa/xtfpga: Fix leaking memory region", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "To": "qemu-devel@nongnu.org", "Cc": "Peter Xu <peterx@redhat.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Paolo Bonzini <pbonzini@redhat.com>,\n Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,\n Gerd Hoffmann <kraxel@redhat.com>, Max Filippov <jcmvbkbc@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>", "Date": "Tue, 10 Feb 2026 21:02:14 +0100 (CET)", "Received-SPF": "pass client-ip=2001:738:2001:2001::2001;\n envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Use memory_region_new_ram to avoid leaking memory region. This would\nbe a migration break but the machines using this don't seem to support\nmigration and even if they did we make no compatibility guarantee for\nthese machines.\n\nSigned-off-by: BALATON Zoltan <balaton@eik.bme.hu>\n---\n hw/xtensa/xtfpga.c | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c\nindex b025cc53a8..b8ae1994d8 100644\n--- a/hw/xtensa/xtfpga.c\n+++ b/hw/xtensa/xtfpga.c\n@@ -50,7 +50,6 @@\n #include \"xtensa_memory.h\"\n #include \"hw/xtensa/mx_pic.h\"\n #include \"exec/cpu-common.h\"\n-#include \"migration/vmstate.h\"\n \n typedef struct XtfpgaFlashDesc {\n hwaddr base;\n@@ -162,10 +161,8 @@ static void xtfpga_net_init(MemoryRegion *address_space,\n memory_region_add_subregion(address_space, descriptors,\n sysbus_mmio_get_region(s, 1));\n \n- ram = g_malloc(sizeof(*ram));\n- memory_region_init_ram_flags_nomigrate(ram, OBJECT(s), \"open_eth.ram\",\n- 16 * KiB, 0, &error_fatal);\n- vmstate_register_ram_global(ram);\n+ ram = memory_region_new_ram(OBJECT(s), \"open_eth.ram\", 16 * KiB,\n+ &error_fatal);\n memory_region_add_subregion(address_space, buffers, ram);\n }\n \n", "prefixes": [ "v3", "6/6" ] }