Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195321/?format=api
{ "id": 2195321, "url": "http://patchwork.ozlabs.org/api/patches/2195321/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210-freebsd-inotify-v2-1-66e7142b9b2a@bsdimp.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210-freebsd-inotify-v2-1-66e7142b9b2a@bsdimp.com>", "list_archive_url": null, "date": "2026-02-10T18:27:17", "name": "[v2] freebsd: FreeBSD 15 has native inotify", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3e3b7afe678bdadf27f70457af43e6f88e637a83", "submitter": { "id": 1896, "url": "http://patchwork.ozlabs.org/api/people/1896/?format=api", "name": "Warner Losh", "email": "imp@bsdimp.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210-freebsd-inotify-v2-1-66e7142b9b2a@bsdimp.com/mbox/", "series": [ { "id": 491726, "url": "http://patchwork.ozlabs.org/api/series/491726/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491726", "date": "2026-02-10T18:27:17", "name": "[v2] freebsd: FreeBSD 15 has native inotify", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491726/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195321/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195321/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bsdimp-com.20230601.gappssmtp.com\n header.i=@bsdimp-com.20230601.gappssmtp.com header.a=rsa-sha256\n header.s=20230601 header.b=sprgLlAM;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9VRc6Lz3z1xtr\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 05:27:56 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpsSb-0000ii-Vb; Tue, 10 Feb 2026 13:27:42 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <imp@bsdimp.com>) id 1vpsSY-0000i2-Cm\n for qemu-devel@nongnu.org; Tue, 10 Feb 2026 13:27:38 -0500", "from mail-oa1-x2b.google.com ([2001:4860:4864:20::2b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <imp@bsdimp.com>) id 1vpsSR-0006ML-S4\n for qemu-devel@nongnu.org; Tue, 10 Feb 2026 13:27:35 -0500", "by mail-oa1-x2b.google.com with SMTP id\n 586e51a60fabf-40423dbe98bso1957594fac.2\n for <qemu-devel@nongnu.org>; Tue, 10 Feb 2026 10:27:31 -0800 (PST)", "from rebo.bsdimp.com ([50.253.99.174])\n by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-40a992edd71sm10823091fac.5.2026.02.10.10.27.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 10 Feb 2026 10:27:29 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1770748050; x=1771352850;\n darn=nongnu.org;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:from:to:cc:subject:date:message-id:reply-to;\n bh=FiPZF9v5rJnmwRrEkyINv1aceYVWIObbfvU4wbxGh6g=;\n b=sprgLlAM0PrhHwSoWibyIVNgKgDVC9Yq58zd9xJ+4f8r9yzUCPQUrEYMw7/xkcBnci\n DV2ynH1e8MH/H34O9zqs0QYS6hdj3sQWO7gpLhi85eLlxEp3nkkPJ1mUf11xwL8xQZn/\n 6hGGscfkpw0rY7qS1rOulr+bI5HKR11sEnrytlcrhJibYIUskw9olltK/8W37nk5pXgJ\n 1TQZBK3zDJFSC2scV+0m3Vawf2F9eGCmlFUk/rZb3pTEGj3tnMZyoSbMT0KBb4ZSTnx/\n D4Bn2LYnsyx3WCntXugrTDUi96/nZAC/MOzApzVMVt0RC1+5nB6Tk1uwjOGnqrchcb6y\n NHfA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770748050; x=1771352850;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FiPZF9v5rJnmwRrEkyINv1aceYVWIObbfvU4wbxGh6g=;\n b=J32DmlsT0LrM4skzIr0vxyPnyYQcLsiDpu0YCAeBvqRngB1YAJ/ZrIYYcejoAy/voi\n rJcn9ENLKGnb9jXPSIUrREUTObHG3O4zLZfYqDanMc4ImsyC4zqPVBurjWJf3hm17mRv\n bOLLW+vfHY1kb4v4tK+D7r7eldIHvQ6vO2hPm0Abbuc8I8cHlfHq3W3Pg99UTZJFRNcn\n pOOBsMPcQE4LtOv9ifSDnIGOGFwB/LssLAYfevOxJHw3LGOW59GAQznD4T9x8DnOKxNf\n /uZF2ONNVBOu+go1gpSv2x77kZRHkPj9uVs334Jf6kw5hB16trEz+Z9hX9tsaoemP5wR\n hNOg==", "X-Gm-Message-State": "AOJu0YzpJNnsdyTYq9ZEfS7mg4MhbB70j/m5TbBx8I357HZvl9uA71Du\n ymU9orMjtkGys0B1Jp2vhLhb7Vn+Wu2SlZS7tGC8I/hEYNp0flyh5Fbr7opysf9ZiRw=", "X-Gm-Gg": "AZuq6aLpBZUAUG6BtK+qMsH7E4H8ac7DC3fpDklpLDOHYP3h09vzNYv/NCoCyP7AFeL\n fn4VeLbpJHni7XRZaxDWMy4aBycdjqL1e7Sv0xmTOwmslw7BIzSqMKRRMxk0EDVuM6iQOkc1eo2\n eNOI0gfEqtPEpXjz0oQhnW8sHAfq/CSAi2YxTcCTZZf9d/CRrig0annBmMZVZyeoe39kJDelEvH\n i7FyoAHR7PZFRQxgnYsxRK2MjjBA9julfCtNkfzaU3KnUdEX6TbzIqRnWMMiYYW6J6bukShfKx3\n e65WFNzXOr2nZz3odCxBBiifr/GyFuoYEHInBoOV6PP2b/XklE4qUcbZaBs4U4FjK/r6LHYRnOC\n NTMZ7FrSZi6ZllMvCLOH2h+ArlXvgTuUS+Z/h+gp4svSgJ1WqDmqFa1WOIR1TGIBlgSfdrNKHd4\n HKxISqkH8PIw==", "X-Received": "by 2002:a05:6870:d18b:b0:3f5:d285:9342 with SMTP id\n 586e51a60fabf-40ea960dbe1mr110571fac.45.1770748050075;\n Tue, 10 Feb 2026 10:27:30 -0800 (PST)", "From": "Warner Losh <imp@bsdimp.com>", "Date": "Tue, 10 Feb 2026 11:27:17 -0700", "Subject": "[PATCH v2] freebsd: FreeBSD 15 has native inotify", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260210-freebsd-inotify-v2-1-66e7142b9b2a@bsdimp.com>", "X-B4-Tracking": "v=1; b=H4sIAIR4i2kC/3WNwQ6CMBBEf4Xs2TW7hSh68j8MB0sX2QOUtKSRk\n P67lbvHN5N5s0OUoBLhXu0QJGlUPxcwpwr68TW/BdUVBkPmQoYJhyBio0Od/arDhq11dLWmbxv\n HUFZLkEE/h/HZFR41rj5sx0HiX/rflRgZiW5NTcwt1/WjtDot595P0OWcv9Tvhi+vAAAA", "X-Change-ID": "20260210-freebsd-inotify-8bd07b2c84d1", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Warner Losh <imp@bsdimp.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2843; i=imp@bsdimp.com;\n h=from:subject:message-id; bh=aXxsLm6JPypjgBm81zrUWHJL9A2zoWPpHSubVV43Jys=;\n b=owEBbQKS/ZANAwAKAWwc0Sh9sBEAAcsmYgBpi3iJxxCMBJREtAH8N61Bv4JMJhBDFfn4FG/Cx\n MbcaeSXpP2JAjMEAAEKAB0WIQQgNfiUsAqjz3zN4bdsHNEofbARAAUCaYt4iQAKCRBsHNEofbAR\n AFWaD/954rGDBk7Mvdynn3ku+ukEvuR73ten/GphXPbgGGgPP9XmMoCqkODndOH5QgUDvHpf0Ux\n dqF19xJx47Tngsjd61jiXC5V9gGY76iP79OkSlxbcK2E9ShvrxuNlZchX0VNTaTH/FWYxTFfOBU\n iHnMvaphpcbNU2wviw+Tl1pZPTawopy8rBW8nhOk6PZGNfDxxvOZsXutSr2e+Phz7ctzLQFFOX1\n ipc15FfPtw0h+yKeAtQ74l9oujToerynRukRfJRpaWI7Aa8uzu/0qFwkZS+PRZgtLA7W/SwnS4+\n bCmlf6h7AunwOedUFn3KtLOsDpoY4OuyIKjWIBKTh9QbvgDpLMvC2BkvR2LNjtLs7YgU6lS8xfE\n UWYM6vA02mk8SJqa38frtDxg1n70Yf9DMs8sovfq+CTOoEznwKNlhyeCcrdRIRl7DskDXOvsDB5\n nMkRlRdHOGySfOMA9OywMEGmzoUKolJgVDf9hb5y+0yx18YKgypn33HDyyZldQFi8HPYxNCyOgI\n ArZcLFX7SjGyvADWhZePQ401VxH8zFp4VBVszb/WPRLXrwASErGOB7eGR4Uu/h6OCS0hjH5e6W9\n 9VriEwN1SAW3H3tjCd7FfE7r8YP5U4YjeW8rdNeqPZI2Ts8RDY2b539kkUYDINuilcbjJKhBN+9\n PpPBBzuV2Ko/yJA==", "X-Developer-Key": "i=imp@bsdimp.com; a=openpgp;\n fpr=2035F894B00AA3CF7CCDE1B76C1CD1287DB01100", "Received-SPF": "none client-ip=2001:4860:4864:20::2b;\n envelope-from=imp@bsdimp.com; helo=mail-oa1-x2b.google.com", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_NONE=0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Check to make sure that we have inotify in libc, before looking for it\nin libinotify.\n\nCc: Paolo Bonzini <pbonzini@redhat.com>\nCc: Marc-André Lureau <marcandre.lureau@redhat.com>\nCc: Daniel P. Berrange <berrange@redhat.com>\nCc: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Warner Losh <imp@bsdimp.com>\n---\nFreeBSD 15 and newer now has a native inotify implementation. Check for\nit before checking for the wrapper libinotify library which is needed in\nFreeBSD 14 and earlier. Make the check dependent on symbols, not host\nversion.\n\nSeparate series because it's really independent of the two other\npatch series I have submitted and it is more important.\n---\nChanges in v2:\n- Make simplifications suggested by Bonzini.\n- Link to v1: https://lore.kernel.org/qemu-devel/20260210-freebsd-inotify-v1-1-009430118133@bsdimp.com\n---\n meson.build | 14 +++++---------\n util/meson.build | 6 +-----\n 2 files changed, 6 insertions(+), 14 deletions(-)\n\n\n---\nbase-commit: 0b91040d23dc8820724a60c811223b777f3bc6b7\nchange-id: 20260210-freebsd-inotify-8bd07b2c84d1\n\nBest regards,", "diff": "diff --git a/meson.build b/meson.build\nindex 2d114e9018..191266d9be 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -2658,18 +2658,14 @@ else\n endif\n config_host_data.set('CONFIG_ASAN_IFACE_FIBER', have_asan_fiber)\n \n+inotify = not_found\n have_inotify_init = cc.has_header_symbol('sys/inotify.h', 'inotify_init')\n have_inotify_init1 = cc.has_header_symbol('sys/inotify.h', 'inotify_init1')\n-inotify = not_found\n-if (have_inotify_init or have_inotify_init1) and host_os == 'freebsd'\n- # libinotify-kqueue\n+if (have_inotify_init or have_inotify_init1) and not cc.has_function('inotify_init1')\n+ # FreeBSD 14 and older need libinotify-kqueue wrapper\n inotify = cc.find_library('inotify')\n- if have_inotify_init\n- have_inotify_init = inotify.found()\n- endif\n- if have_inotify_init1\n- have_inotify_init1 = inotify.found()\n- endif\n+ have_inotify_init = have_inotify_init and inotify.found()\n+ have_inotify_init1 = have_inotify_init1 and inotify.found()\n endif\n config_host_data.set('CONFIG_INOTIFY', have_inotify_init)\n config_host_data.set('CONFIG_INOTIFY1', have_inotify_init1)\ndiff --git a/util/meson.build b/util/meson.build\nindex 7c9445615d..e7a2a2a64c 100644\n--- a/util/meson.build\n+++ b/util/meson.build\n@@ -102,11 +102,7 @@ if have_block\n util_ss.add(files('throttle.c'))\n util_ss.add(files('timed-average.c'))\n if config_host_data.get('CONFIG_INOTIFY1')\n- freebsd_dep = []\n- if host_os == 'freebsd'\n- freebsd_dep = inotify\n- endif\n- util_ss.add(files('filemonitor-inotify.c'), freebsd_dep)\n+ util_ss.add(files('filemonitor-inotify.c'), inotify)\n else\n util_ss.add(files('filemonitor-stub.c'))\n endif\n", "prefixes": [ "v2" ] }