Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195248/?format=api
{ "id": 2195248, "url": "http://patchwork.ozlabs.org/api/patches/2195248/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260210-ufs-ufs_hba_ops-cleanup-v2-1-dd73da21aa92@baylibre.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210-ufs-ufs_hba_ops-cleanup-v2-1-dd73da21aa92@baylibre.com>", "list_archive_url": null, "date": "2026-02-10T16:22:43", "name": "[v2,1/3] drivers: ufs: handle return values of ufs_hba_ops callbacks", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3d5aec1680edfedfa2c291982ad4d5c4de67605e", "submitter": { "id": 84831, "url": "http://patchwork.ozlabs.org/api/people/84831/?format=api", "name": "Julien Stephan", "email": "jstephan@baylibre.com" }, "delegate": { "id": 84350, "url": "http://patchwork.ozlabs.org/api/users/84350/?format=api", "username": "narmstrong", "first_name": "Neil", "last_name": "Armstrong", "email": "narmstrong@baylibre.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260210-ufs-ufs_hba_ops-cleanup-v2-1-dd73da21aa92@baylibre.com/mbox/", "series": [ { "id": 491703, "url": "http://patchwork.ozlabs.org/api/series/491703/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=491703", "date": "2026-02-10T16:22:42", "name": "drivers: ufs: ufs_hba_ops callbacks cleanup", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491703/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195248/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195248/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20230601.gappssmtp.com\n header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256\n header.s=20230601 header.b=g0CsYq4B;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20230601.gappssmtp.com\n header.i=@baylibre-com.20230601.gappssmtp.com header.b=\"g0CsYq4B\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=jstephan@baylibre.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9RgV3PtXz1xwG\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 03:23:02 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0594783D9C;\n\tTue, 10 Feb 2026 17:22:54 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 0352583DB6; Tue, 10 Feb 2026 17:22:52 +0100 (CET)", "from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n [IPv6:2a00:1450:4864:20::434])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 0D45283CE3\n for <u-boot@lists.denx.de>; Tue, 10 Feb 2026 17:22:50 +0100 (CET)", "by mail-wr1-x434.google.com with SMTP id\n ffacd0b85a97d-4359a302794so2818143f8f.1\n for <u-boot@lists.denx.de>; Tue, 10 Feb 2026 08:22:50 -0800 (PST)", "from [192.168.1.100]\n (2a02-842a-d52e-6101-43a2-d2f0-c793-0a1b.rev.sfr.net.\n [2a02:842a:d52e:6101:43a2:d2f0:c793:a1b])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-436296bd4a1sm35185402f8f.17.2026.02.10.08.22.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 10 Feb 2026 08:22:49 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1770740569;\n x=1771345369;\n darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=JNC/SVtbbF1gjifGF7rhJALkr26J0MzAHs+IK1Bd9cs=;\n b=g0CsYq4BDvLMmIRNCRAqilw83+N4YxdIkCobrcxmukUvafxk45p4XKwMc/HbAHlPe7\n 9ExcjpfhIjz3WWPvpZrqAEylQ3Ffd8+Ktvg4Fcl+Towijz38HZQxLJAqPU7pyw6MuVhc\n cirsrXY6S1sINwfdlxwfG8hbYO9zUldmMhW2vFBTmUN/mLVa91a4sYQ215K+NV4q9MWi\n oS32jKcG6+6vwQmyIlWkiv0hvD86wtF/kghowM11K0M1KzAHl1oYci5JtfEjoF2RH507\n t52WNMzbXGryvk+5jqBRaT+TsqMDFJ4nKfCWQVZPkfMPD/bwOPIU6cbKDSMBH3T7i/a0\n I7IA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770740569; x=1771345369;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=JNC/SVtbbF1gjifGF7rhJALkr26J0MzAHs+IK1Bd9cs=;\n b=XRZgTqjPyTInegMAF7JnUwKVlvtIq+AUL7xdCh6J4QZ5TKUk4I4RLfpwhZj9mEvClQ\n 1xEbsLb0JKWKpnVygaYxDsR40nhS+dHhXQBogqbttEXX1X+q7qHx65a5ZJBe3hUrAJu5\n zWzP5xprixEDO3/lcEHkviwbsjlO6u/HWwjJOib2Jt0Vh+6Lts93tcsGG+I2ajY4FQzO\n lOgnF5TesOuHNjYk/4H4rE7uQ1cb0borGwTC12tReEWfSsFu5xyDm+vlKxNNnyIc+sol\n pwuw1QdrHLcFVScKv+KUEBgeQ/EOJjq7PR4uuo6LRk04jr4bqm/AdYlbTjaN4gvI8Oct\n SH8g==", "X-Gm-Message-State": "AOJu0YwQMatVHpkmDPtDkA53l1JfmtS5d4QRcbSZvsAn1qOjUib1u+ls\n 0dkkA5WlieqRdbq1y6edajr6YQELNlRseokPlBMsj/KBIrD4MrfLdrqoIz9I/1+WXn4=", "X-Gm-Gg": "AZuq6aJ0h8f6Oz4ymi2jz1KAN3j1woncrxoW33Fopof7BwBCW43BWs7iNkRDJ20gL4u\n AYXMVbo87iXqI9g948h44D7mt+92EQRcFYdSCKMd6nYnnzkhQcEBNXy4cuoFWL0RD4tY3/CprM4\n P7zwumk5Twx698SOfMU1qMKd/1oMwXN0ZXfilXO99HVRim8A2Y0iy4H0ciKjZ47uLAgZkaE9YLi\n 9PNmn8j9K8zwNlxKB+dgyNdCZVbwKxWlOzWAbwiTS6QCGOy90moUYe+waKkvhlaGY2P2YR9+kUV\n tsmDjiRLRIqm6aQe7kXL8hK9NtByIIG34oTYTVcxXNUjl1tn3iyiRhIINsyqy18WFWyYCkgRhzi\n amBdNk/NbASrWCyItFoaR7lKuIwm28j3PmjEk0r3kS3VcULS5OpfW2UqFRKeICR2mjDFpZRuj7v\n oAPKwe4hgJ4z8KqrFurH8Kk/zAuVqJht7eRLB7NItO8aFODY+zWHXKKsRgXjVNe4NVAbVR8bWLc\n GWQDUrDnkLWh5nnQtsyGQ==", "X-Received": "by 2002:a05:6000:2c08:b0:437:6dac:4580 with SMTP id\n ffacd0b85a97d-4376dac47cdmr11563778f8f.62.1770740569422;\n Tue, 10 Feb 2026 08:22:49 -0800 (PST)", "From": "Julien Stephan <jstephan@baylibre.com>", "Date": "Tue, 10 Feb 2026 17:22:43 +0100", "Subject": "[PATCH v2 1/3] drivers: ufs: handle return values of ufs_hba_ops\n callbacks", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260210-ufs-ufs_hba_ops-cleanup-v2-1-dd73da21aa92@baylibre.com>", "References": "<20260210-ufs-ufs_hba_ops-cleanup-v2-0-dd73da21aa92@baylibre.com>", "In-Reply-To": "<20260210-ufs-ufs_hba_ops-cleanup-v2-0-dd73da21aa92@baylibre.com>", "To": "u-boot@lists.denx.de", "Cc": "GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,\n Neil Armstrong <neil.armstrong@linaro.org>,\n Bhupesh Sharma <bhupesh.linux@gmail.com>,\n Neha Malcom Francis <n-francis@ti.com>, Tom Rini <trini@konsulko.com>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n Simon Glass <sjg@chromium.org>, Philipp Tomsich <philipp.tomsich@vrull.eu>,\n Kever Yang <kever.yang@rock-chips.com>,\n Shawn Lin <shawn.lin@rock-chips.com>, Bryan Brattlof <bb@ti.com>,\n Udit Kumar <u-kumar1@ti.com>, Jared McArthur <j-mcarthur@ti.com>,\n Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,\n Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>,\n Michal Simek <michal.simek@amd.com>, dlechner@baylibre.com,\n Julien Stephan <jstephan@baylibre.com>", "X-Mailer": "b4 0.14.3", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The return values of ufshcd_ops_link_startup_notify(),\nufshcd_ops_hce_enable_notify(), ufshcd_ops_init(), and\nufshcd_device_reset() are currently ignored.\n\nCheck and propagate these return values properly and emit appropriate\nerror messages on error.\n\nWhile at it, remove the ufshcd_device_reset() wrapper, which just call\nufshcd_device_reset().\n\nSigned-off-by: Julien Stephan <jstephan@baylibre.com>\n---\n drivers/ufs/ufs-uclass.c | 36 ++++++++++++++++++++++++++----------\n 1 file changed, 26 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/ufs/ufs-uclass.c b/drivers/ufs/ufs-uclass.c\nindex 3c8e4299259..c09f61aa420 100644\n--- a/drivers/ufs/ufs-uclass.c\n+++ b/drivers/ufs/ufs-uclass.c\n@@ -127,11 +127,6 @@ static void ufshcd_print_pwr_info(struct ufs_hba *hba)\n \t\thba->pwr_info.hs_rate);\n }\n \n-static void ufshcd_device_reset(struct ufs_hba *hba)\n-{\n-\tufshcd_vops_device_reset(hba);\n-}\n-\n /**\n * ufshcd_ready_for_uic_cmd - Check if controller is ready\n * to accept UIC commands\n@@ -512,7 +507,9 @@ static int ufshcd_link_startup(struct ufs_hba *hba)\n \tint retries = DME_LINKSTARTUP_RETRIES;\n \n \tdo {\n-\t\tufshcd_ops_link_startup_notify(hba, PRE_CHANGE);\n+\t\tret = ufshcd_ops_link_startup_notify(hba, PRE_CHANGE);\n+\t\tif (ret)\n+\t\t\tgoto out;\n \n \t\tret = ufshcd_dme_link_startup(hba);\n \n@@ -598,12 +595,18 @@ static inline void ufshcd_hba_start(struct ufs_hba *hba)\n static int ufshcd_hba_enable(struct ufs_hba *hba)\n {\n \tint retry;\n+\tint ret;\n \n \tif (!ufshcd_is_hba_active(hba))\n \t\t/* change controller state to \"reset state\" */\n \t\tufshcd_hba_stop(hba);\n \n-\tufshcd_ops_hce_enable_notify(hba, PRE_CHANGE);\n+\tret = ufshcd_ops_hce_enable_notify(hba, PRE_CHANGE);\n+\tif (ret) {\n+\t\tdev_err(hba->dev, \"Controller enable notify PRE_CHANGE failed: %i\\n\",\n+\t\t\tret);\n+\t\treturn ret;\n+\t}\n \n \t/* start controller initialization sequence */\n \tufshcd_hba_start(hba);\n@@ -635,7 +638,12 @@ static int ufshcd_hba_enable(struct ufs_hba *hba)\n \t/* enable UIC related interrupts */\n \tufshcd_enable_intr(hba, UFSHCD_UIC_MASK);\n \n-\tufshcd_ops_hce_enable_notify(hba, POST_CHANGE);\n+\tret = ufshcd_ops_hce_enable_notify(hba, POST_CHANGE);\n+\tif (ret) {\n+\t\tdev_err(hba->dev, \"Controller enable notify POST_CHANGE failed: %i\\n\",\n+\t\t\tret);\n+\t\treturn ret;\n+\t}\n \n \treturn 0;\n }\n@@ -2182,7 +2190,11 @@ int ufshcd_probe(struct udevice *ufs_dev, struct ufs_hba_ops *hba_ops)\n \t/* Set descriptor lengths to specification defaults */\n \tufshcd_def_desc_sizes(hba);\n \n-\tufshcd_ops_init(hba);\n+\terr = ufshcd_ops_init(hba);\n+\tif (err) {\n+\t\tdev_err(hba->dev, \"Host controller init failed: %i\\n\", err);\n+\t\treturn err;\n+\t}\n \n \t/* Read capabilities registers */\n \thba->capabilities = ufshcd_readl(hba, REG_CONTROLLER_CAPABILITIES);\n@@ -2226,7 +2238,11 @@ int ufshcd_probe(struct udevice *ufs_dev, struct ufs_hba_ops *hba_ops)\n \tmb(); /* flush previous writes */\n \n \t/* Reset the attached device */\n-\tufshcd_device_reset(hba);\n+\terr = ufshcd_vops_device_reset(hba);\n+\tif (err) {\n+\t\tdev_err(hba->dev, \"Failed to reset attached device: %i\\n\", err);\n+\t\treturn err;\n+\t}\n \n \terr = ufshcd_hba_enable(hba);\n \tif (err) {\n", "prefixes": [ "v2", "1/3" ] }