Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195240/?format=api
{ "id": 2195240, "url": "http://patchwork.ozlabs.org/api/patches/2195240/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260210160649.2946-1-gerris.rs@gmail.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210160649.2946-1-gerris.rs@gmail.com>", "list_archive_url": null, "date": "2026-02-10T16:06:49", "name": "[gccrs,COMMIT] gccrs : TypeCheck : Enhance missing fields error message", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d5284b6e02a521499aebe0cf89084b4ebd1ec38e", "submitter": { "id": 92092, "url": "http://patchwork.ozlabs.org/api/people/92092/?format=api", "name": null, "email": "gerris.rs@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260210160649.2946-1-gerris.rs@gmail.com/mbox/", "series": [ { "id": 491700, "url": "http://patchwork.ozlabs.org/api/series/491700/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=491700", "date": "2026-02-10T16:06:49", "name": "[gccrs,COMMIT] gccrs : TypeCheck : Enhance missing fields error message", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491700/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195240/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195240/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=YZMEJLh0;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=YZMEJLh0", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "sourceware.org; spf=pass smtp.mailfrom=gmail.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.222.170" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9RKl6BCwz1xwG\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 03:07:39 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id DA8D94BA2E08\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 16:07:37 +0000 (GMT)", "from mail-qk1-f170.google.com (mail-qk1-f170.google.com\n [209.85.222.170])\n by sourceware.org (Postfix) with ESMTPS id 083F54BA2E3D\n for <gcc-patches@gcc.gnu.org>; Tue, 10 Feb 2026 16:06:52 +0000 (GMT)", "by mail-qk1-f170.google.com with SMTP id\n af79cd13be357-8c5389c3cd2so101640885a.0\n for <gcc-patches@gcc.gnu.org>; Tue, 10 Feb 2026 08:06:52 -0800 (PST)", "from\n runnervmwffz4.ajpjuzvd0pcu5m1ughqrvmkcxa.bx.internal.cloudapp.net\n ([74.235.126.82]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8caf9eea0c0sm1076995385a.42.2026.02.10.08.06.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 10 Feb 2026 08:06:50 -0800 (PST)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org DA8D94BA2E08", "OpenDKIM Filter v2.11.0 sourceware.org 083F54BA2E3D" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 083F54BA2E3D", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 083F54BA2E3D", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770739612; cv=none;\n b=S3Q8Q8CYZ8nzglHdNcizh4YU8hqMD/TOAay1trYOUAM5U281v8MUZokKneFSmjxkAPK+qSVjP2vtbEa7CFeSBXWNy4ZUiyt8JwweCmqd7wNN5t+rBYnMGxI0Jl2F6Carx9EKekmZHgAY1untZgW2yrHCqmHe6LUZ7T4PmJ/scrU=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1770739612; c=relaxed/simple;\n bh=nAU7c03bIUitUA9GI3vM4dk5vslx5Qm5QJDRgWLAH+4=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=uCynSHk6LYgBHpv6uBkJP925schaZ8LPwLSCzVDG8m/qcJ+HQ99mJ/TSxcFvZVGBC8LfbrnHnTdLi82OikxMP4HL+/EU+soAE28n8Dsn2yJ5e+X3YFsey8Hhkh8L6Kk/l96zwlVBrVAE/WUUbiaqYnvo46bEnulMeRV5hPDFYMo=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1770739611; x=1771344411; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=Jr+1ywlqAVv2zVlg5qZ3/Q9Pn43ZvSNIzZFjI1eHBKs=;\n b=YZMEJLh0aDs2m6nwZ3feY3KcyzdGbj6nhzDfAPvUI01+D91woSR6eJF1iaGrJEe1P6\n x2VQUFjapbsCHcW9xECAse9DkOP8NEAfWdop7p4zAhX/dpaaOwXzM5bsRew33W0glFJK\n th6icHM/DYsB39xqJvnymHOm8FOgEWSCDGfFZLQ82qs4a+k7GPxgAE3baBWoAVCDWQ1B\n 21J7nzBmCfl3zVkDIqUagO2XvVFHBWSeqoW4Y4fysLmF3rPTGyo/Fc9HRK8h+1YL3Hwd\n rRJpyZb4ElW6WNt2IzjsEl526mL8uzksevtFvm873BNFpzQwovSXO3LBtw+s/NuHWs5/\n e/nA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770739611; x=1771344411;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Jr+1ywlqAVv2zVlg5qZ3/Q9Pn43ZvSNIzZFjI1eHBKs=;\n b=CLJ1VJaQyt3sGwb/CgUYYIB2eBnhy7VaTcpczQPOQe0SwK4qCE2SsEbnAp4ryZP78u\n z3RW7I9sifsG++tkrN4K3LSsjCvd5kpAwJumX66IeygOngmEXp09K49V7SXvDp+6O0cX\n 989+FtoIbwB2d1TqS9IdHFkFgi0wa+qWMS8QYMaLuz/5++D9Y1jX1XyYZrLWpgVRlZFI\n CnVCSTomP+tfUjHBb2EIH3fgibp4+EvFaT3MDaQgTb9Ae3XvzkFELZCHh9VS614WqEsK\n k9LHGATVFWEfiHKz9fXeeXAi9GFG4GqK58KdeAGFPR4O/GiXUcDng2ye5+O5UtIDKPr8\n 7Epw==", "X-Gm-Message-State": "AOJu0YwU1fwxSb2PvIAT1lFdS0OT18n6F4MUIsgmQAPjGBA6upD1DPmG\n W7t1LIZvHcSxecyBEOXIHI3g6QoCQH1zN0KezSLXWHnfLBzQGu/0V3NvO8nZcqOM", "X-Gm-Gg": "AZuq6aL8nY7t+9ebTsqJ9ae9eiDExrntutg1qcb1AcA4ruwHti0DofyzapYizgipvpZ\n 9svDqBAgVCxmMvf8zK91Zx9s4xYLV5uPfIkIcIcoZj/RtHInA32XS3yoWAflLYNFPPFUIn0Y/Zk\n MJYGy7FNvQzD6IHLQLpuTnKxnOKTylK45RFElbLoGZoL0CR5Ddx4Ks4ehL0df72sAYJNbxXIXn1\n LUKvNPOvmDfriD88R02NVD1CEICuSiTqDh1sDr0sSBXDdltXa1rZuf9HjqMf8vJq/4oKXPnZHak\n tEEq43FvryQj3ahDi4Bk7zlF4V7ZcI0tclhtUMHSbzs+3LD5cF83Y9FOYnt+Y4jB/XBHXfy+/FA\n TN5a75jt1eh4X6nH/SiFY4YwPg2RCf7kGs42HaqKU0K6xvxR+KIhFto3xOW76ll0pXC9k0Nsndz\n 2n9ULXMd2XvNf4g1XSI3TQTXTS36RYbmgyw8EnSN86v4gIxD7hJagr+jbvnvRl/WAzQ0mgQqTbt\n a4DD2MkYJn+h6fLAGp5", "X-Received": "by 2002:a05:620a:4553:b0:8c6:e8f6:2c7 with SMTP id\n af79cd13be357-8caefcc9f16mr2082025685a.38.1770739611103;\n Tue, 10 Feb 2026 08:06:51 -0800 (PST)", "From": "gerris.rs@gmail.com", "To": "gcc-patches@gcc.gnu.org,\n\tgcc-rust@gcc.gnu.org", "Cc": "pierre-emmanuel.patry@embecosm.com, arthur.cohen@embecosm.com,\n dkm+gccrs@kataplop.net, Islam-Imad <islamimad404@gmail.com>", "Subject": "[gccrs COMMIT] gccrs : TypeCheck : Enhance missing fields error\n message", "Date": "Tue, 10 Feb 2026 16:06:49 +0000", "Message-ID": "<20260210160649.2946-1-gerris.rs@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "From: Islam-Imad <islamimad404@gmail.com>\n\nimproved the error message from \"a, b, c\" to \"'a', 'b' and 'c'\"\n\ngcc/rust/ChangeLog:\n\n\t* typecheck/rust-hir-type-check-struct.cc: enhance missing fields error message\n\ngcc/testsuite/ChangeLog:\n\n\t* rust/compile/missing_constructor_fields.rs: update to match the new error message\n\nSigned-off-by: Islam-Imad <islamimad404@gmail.com>\n---\nThis change was merged into the gccrs repository and is posted here for\nupstream visibility and potential drive-by review, as requested by GCC\nrelease managers.\nEach commit email contains a link to its details on github from where you can\nfind the Pull-Request and associated discussions.\n\n\nCommit on github: https://github.com/Rust-GCC/gccrs/commit/1c6d3bf074b947fcd3aa5521651cec86eb5c3ac9\n\nThe commit has been mentioned in the following pull-request(s):\n - https://github.com/Rust-GCC/gccrs/pull/4429\n\n .../typecheck/rust-hir-type-check-struct.cc | 24 ++++++++++++-------\n .../compile/missing_constructor_fields.rs | 6 ++---\n 2 files changed, 18 insertions(+), 12 deletions(-)\n\n\nbase-commit: f24240c2b2aad3e28586033e89ff3627162d3aa7", "diff": "diff --git a/gcc/rust/typecheck/rust-hir-type-check-struct.cc b/gcc/rust/typecheck/rust-hir-type-check-struct.cc\nindex 5707b678a..b6ea1028f 100644\n--- a/gcc/rust/typecheck/rust-hir-type-check-struct.cc\n+++ b/gcc/rust/typecheck/rust-hir-type-check-struct.cc\n@@ -16,6 +16,7 @@\n // along with GCC; see the file COPYING3. If not see\n // <http://www.gnu.org/licenses/>.\n \n+#include \"rust-diagnostics.h\"\n #include \"rust-hir-type-check.h\"\n #include \"rust-hir-type-check-expr.h\"\n #include \"rust-hir-type-check-struct-field.h\"\n@@ -416,21 +417,26 @@ TypeCheckStructExpr::make_missing_field_error (\n if (missing_field_names.size () == 1)\n {\n return Error (locus, ErrorCode::E0063,\n-\t\t \"missing field %s in initializer of %qs\",\n+\t\t \"missing field %qs in initializer of %qs\",\n \t\t missing_field_names[0].c_str (), struct_name.c_str ());\n }\n // Make comma separated string for display\n std::stringstream display_field_names;\n- bool first = true;\n- for (auto &name : missing_field_names)\n+ size_t field_count = missing_field_names.size ();\n+ for (size_t i = 0; i + 2 < field_count; ++i)\n {\n- if (!first)\n-\t{\n-\t display_field_names << \", \";\n-\t}\n- first = false;\n- display_field_names << name;\n+ const auto &field_name = missing_field_names[i];\n+ display_field_names << rust_open_quote () << field_name\n+\t\t\t << rust_close_quote () << \", \";\n }\n+ display_field_names << rust_open_quote ()\n+\t\t << missing_field_names[field_count - 2]\n+\t\t << rust_close_quote ();\n+ display_field_names << \" and \";\n+ display_field_names << rust_open_quote ()\n+\t\t << missing_field_names[field_count - 1]\n+\t\t << rust_close_quote ();\n+\n return Error (locus, ErrorCode::E0063,\n \t\t\"missing fields %s in initializer of %qs\",\n \t\tdisplay_field_names.str ().c_str (), struct_name.c_str ());\ndiff --git a/gcc/testsuite/rust/compile/missing_constructor_fields.rs b/gcc/testsuite/rust/compile/missing_constructor_fields.rs\nindex fcfa17d06..2d373d224 100644\n--- a/gcc/testsuite/rust/compile/missing_constructor_fields.rs\n+++ b/gcc/testsuite/rust/compile/missing_constructor_fields.rs\n@@ -9,7 +9,7 @@ struct Foo {\n }\n \n fn main() {\n- let z = Foo { x: 0 , y:1 }; // { dg-error \"missing field z in initializer of 'Foo'\" }\n- let xz = Foo { y:1 }; // { dg-error \"missing fields x, z in initializer of 'Foo'\" }\n- let xyz = Foo { }; // { dg-error \"missing fields x, y, z in initializer of 'Foo'\" }\n+ let z = Foo { x: 0 , y:1 }; // { dg-error \"missing field 'z' in initializer of 'Foo'\" }\n+ let xz = Foo { y:1 }; // { dg-error \"missing fields 'x' and 'z' in initializer of 'Foo'\" }\n+ let xyz = Foo { }; // { dg-error \"missing fields 'x', 'y' and 'z' in initializer of 'Foo'\" }\n }\n", "prefixes": [ "gccrs", "COMMIT" ] }