Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195231/?format=api
{ "id": 2195231, "url": "http://patchwork.ozlabs.org/api/patches/2195231/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210154801.1662032-4-stefanb@linux.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210154801.1662032-4-stefanb@linux.ibm.com>", "list_archive_url": null, "date": "2026-02-10T15:48:01", "name": "[PULL,v1,3/3] tpm_emulator: tpm_emulator_set_state_blobs(): move to boolean return", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6b93468019d80b2c4a06fa618d97a378eee0fea0", "submitter": { "id": 75097, "url": "http://patchwork.ozlabs.org/api/people/75097/?format=api", "name": "Stefan Berger", "email": "stefanb@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210154801.1662032-4-stefanb@linux.ibm.com/mbox/", "series": [ { "id": 491693, "url": "http://patchwork.ozlabs.org/api/series/491693/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491693", "date": "2026-02-10T15:47:59", "name": "[PULL,v1,1/3] tpm_emulator: print error on error-ignore path", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491693/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195231/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195231/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=S0CHuwxQ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9R2f41wMz1xwG\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 02:54:34 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpq3T-0001vu-DA; Tue, 10 Feb 2026 10:53:35 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <stefanb@linux.ibm.com>)\n id 1vpq31-0001dR-OJ\n for qemu-devel@nongnu.org; Tue, 10 Feb 2026 10:53:09 -0500", "from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <stefanb@linux.ibm.com>)\n id 1vpq2c-0003hP-Aa\n for qemu-devel@nongnu.org; Tue, 10 Feb 2026 10:53:07 -0500", "from pps.filterd (m0356517.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61A7sdRb4037824; Tue, 10 Feb 2026 15:48:07 GMT", "from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696ucybt-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 10 Feb 2026 15:48:07 +0000 (GMT)", "from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 61AFJPmI012626;\n Tue, 10 Feb 2026 15:48:06 GMT", "from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69])\n by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4c6h7k9ta1-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 10 Feb 2026 15:48:06 +0000", "from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 61AFm5c231261190\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 10 Feb 2026 15:48:05 GMT", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 999CE5805D;\n Tue, 10 Feb 2026 15:48:05 +0000 (GMT)", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 10CC858054;\n Tue, 10 Feb 2026 15:48:05 +0000 (GMT)", "from sbct-3.pok.ibm.com (unknown [9.47.158.153])\n by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Tue, 10 Feb 2026 15:48:04 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=xIdojgdoOljs4P6nj\n z5PtnLP4GK0cKaa4WDRpbEmoes=; b=S0CHuwxQ50XJcLeIi77eGsVfILh9BV7Pt\n KMllNDTtKlYw9+lQPq5R+Z3TjJbX/qIIReE9oJLaD5cnIAWayUJxifpMFIDGLG31\n y3zSgsO5JknPhPbvd3jkGO93jnGrgtGJ0yhqseT/6BOXQmeC/e37CdfFxZKwyX/v\n RvRLqEx1v4Lf2Dnp3FtoBZxxj3tA8keX3cdC40IPOVK20ZXicvalVMU/fVbJFtLl\n IFkjNMgmixllz34yA+siLrLHdAJvJsuJT1n3tbd4WE3ra0PSCY92P88Dw3+9BZdk\n yAKlSOWY8W/Kx6JOymy+iDTypnJNgf9nOXB6SSjnK/pb9PtmZuL/w==", "From": "Stefan Berger <stefanb@linux.ibm.com>", "To": "qemu-devel@nongnu.org", "Cc": "peter.maydell@linaro.org,\n Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,\n Stefan Berger <stefanb@linux.ibm.com>,\n Markus Armbruster <armbru@redhat.com>", "Subject": "[PULL v1 3/3] tpm_emulator: tpm_emulator_set_state_blobs(): move to\n boolean return", "Date": "Tue, 10 Feb 2026 10:48:01 -0500", "Message-ID": "<20260210154801.1662032-4-stefanb@linux.ibm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260210154801.1662032-1-stefanb@linux.ibm.com>", "References": "<20260210154801.1662032-1-stefanb@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Authority-Analysis": "v=2.4 cv=YZiwJgRf c=1 sm=1 tr=0 ts=698b5337 cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n a=GgsMoib0sEa3-_RKJdDe:22 a=6R7veym_AAAA:8 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8\n a=CJagtSCr96gRjeXOXogA:9 a=ILCOIF4F_8SzUMnO7jNM:22", "X-Proofpoint-ORIG-GUID": "ju2MT2_ofNCDfDOAYFYEkSLHfICZWpnD", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEwMDEzMiBTYWx0ZWRfXyPC9EXoXbwaP\n qsNT8QWzhasBGek+8MRfP+rM5h1LO0maWhrYct9ZqUbcdA3UjAi0xazg3q54/NubCSvBHIJAnq+\n hpPVY9JLhWKSVeCi88uOTEVpX4z19vQMRaYZ8JgCzxCf843Xxsyx0S1P/110PYyrxqqqmLMPi1M\n 7BZv3VNh5d5RgJfS66fv9545Og5aIozRgVDvRM3ZmtDudV156Vs1y18Fkkl+kGT/znQjY8sK3gc\n XGuz60eAKT/FAfP00GzGMwSQgdCwAUanoQfa2jMnbEPaZ6k0r9CShtZINe9jQPVnSPwbJZkUFkQ\n c5vBjuHfvkB2+Eq55Aiftl3OYZd/S5RmL1r8HndrVt9lnxrH8DfaNBy0ucUdqc5W9gPxDc4r/lW\n TOFCFvVYGRBGNAWpJaVySp+N6IXNfzcssdyQU+9tWUyUGlD6yBZN8mlovWAYeUV0aRSV8qMcnfA\n O85yCtkQxYsR7EnzGTA==", "X-Proofpoint-GUID": "ju2MT2_ofNCDfDOAYFYEkSLHfICZWpnD", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-10_01,2026-02-10_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 spamscore=0 impostorscore=0 suspectscore=0 malwarescore=0\n phishscore=0 bulkscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602100132", "Received-SPF": "pass client-ip=148.163.156.1;\n envelope-from=stefanb@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com", "X-Spam_score_int": "-19", "X-Spam_score": "-2.0", "X-Spam_bar": "--", "X-Spam_report": "(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n\nThe returned error is only used to check for success, so no reason\nto use specific errno values.\n\nAlso, this is the only function with -errno contract in the file,\nso converting it simplifies the whole file from three types of\ncontract (0/-1, 0/-errno, true/false) to only two (0/-1, true/false).\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\nReviewed-by: Stefan Berger <stefanb@linux.ibm.com>\nReviewed-by: Markus Armbruster <armbru@redhat.com>\nSigned-off-by: Stefan Berger <stefanb@linux.ibm.com>\n---\n backends/tpm/tpm_emulator.c | 14 +++++---------\n 1 file changed, 5 insertions(+), 9 deletions(-)", "diff": "diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c\nindex dc84380b13..75c33d290e 100644\n--- a/backends/tpm/tpm_emulator.c\n+++ b/backends/tpm/tpm_emulator.c\n@@ -885,10 +885,8 @@ static int tpm_emulator_set_state_blob(TPMEmulator *tpm_emu,\n \n /*\n * Set all the TPM state blobs.\n- *\n- * Returns a negative errno code in case of error.\n */\n-static int tpm_emulator_set_state_blobs(TPMBackend *tb, Error **errp)\n+static bool tpm_emulator_set_state_blobs(TPMBackend *tb, Error **errp)\n {\n TPMEmulator *tpm_emu = TPM_EMULATOR(tb);\n TPMBlobBuffers *state_blobs = &tpm_emu->state_blobs;\n@@ -897,7 +895,7 @@ static int tpm_emulator_set_state_blobs(TPMBackend *tb, Error **errp)\n \n if (tpm_emulator_stop_tpm(tb, errp) < 0) {\n trace_tpm_emulator_set_state_blobs_error(\"Could not stop TPM\");\n- return -EIO;\n+ return false;\n }\n \n if (tpm_emulator_set_state_blob(tpm_emu, PTM_BLOB_TYPE_PERMANENT,\n@@ -909,12 +907,12 @@ static int tpm_emulator_set_state_blobs(TPMBackend *tb, Error **errp)\n tpm_emulator_set_state_blob(tpm_emu, PTM_BLOB_TYPE_SAVESTATE,\n &state_blobs->savestate,\n state_blobs->savestate_flags, errp) < 0) {\n- return -EIO;\n+ return false;\n }\n \n trace_tpm_emulator_set_state_blobs_done();\n \n- return 0;\n+ return true;\n }\n \n static int tpm_emulator_pre_save(void *opaque)\n@@ -957,10 +955,8 @@ static void tpm_emulator_vm_state_change(void *opaque, bool running,\n static bool tpm_emulator_post_load(void *opaque, int version_id, Error **errp)\n {\n TPMBackend *tb = opaque;\n- int ret;\n \n- ret = tpm_emulator_set_state_blobs(tb, errp);\n- if (ret < 0) {\n+ if (!tpm_emulator_set_state_blobs(tb, errp)) {\n return false;\n }\n \n", "prefixes": [ "PULL", "v1", "3/3" ] }