Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195180/?format=api
{ "id": 2195180, "url": "http://patchwork.ozlabs.org/api/patches/2195180/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260210141219.1573869-1-arnd@kernel.org/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210141219.1573869-1-arnd@kernel.org>", "list_archive_url": null, "date": "2026-02-10T14:12:05", "name": "ksmbd: fix non-IPv6 build", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "31d75f1ad7c1c63140bd0712b06fc481451e1aa5", "submitter": { "id": 80402, "url": "http://patchwork.ozlabs.org/api/people/80402/?format=api", "name": "Arnd Bergmann", "email": "arnd@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260210141219.1573869-1-arnd@kernel.org/mbox/", "series": [ { "id": 491683, "url": "http://patchwork.ozlabs.org/api/series/491683/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=491683", "date": "2026-02-10T14:12:05", "name": "ksmbd: fix non-IPv6 build", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491683/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195180/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195180/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-cifs+bounces-9307-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=hQm38ks1;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-9307-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"hQm38ks1\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9NqT2p13z1xtr\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 01:14:45 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 0CE373046076\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 14:12:26 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 41A6936682C;\n\tTue, 10 Feb 2026 14:12:25 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E60D1CAA7D;\n\tTue, 10 Feb 2026 14:12:25 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 553C0C116C6;\n\tTue, 10 Feb 2026 14:12:22 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1770732745; cv=none;\n b=BFs7Y/P1thtlpZY1YVFk2TjKx3iB37rRIP2zU3obWCTuKC+NQjOYnWFQxDCdKzHWJiusgu21dOBD+JNRSnUrFA4vNiFH7JUZvwmH1n93nkCZ0BQ5Jqk82V1v9+Mv33LBwECHIdUEEijPClMipcVIfURKMXYj5SFFNEQg2CJydOQ=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1770732745; c=relaxed/simple;\n\tbh=wJj0MQ31kzyA4d66mGVJoEAuoD4w9Rwh3HxHLDxZC20=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=YbBa6dGRS+cx5+t6PYlS5+GlL3Zq9zUWreXG7m3RbfVlPY2tNxKvz2Z4u673gJ+n5McIv1UMtWOSwFsP7cfgRB17ZI9NCttEZKoaQk6KVpBZb0fJqla53AYmKaJTW096s+wuI9NOOqUE3FpzE6uyYHpoZW0QPwj2J0zwog05AmY=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=hQm38ks1; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1770732745;\n\tbh=wJj0MQ31kzyA4d66mGVJoEAuoD4w9Rwh3HxHLDxZC20=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=hQm38ks1bnFheH1XAS9wLlRN6N3gAtN+gkrc/aey/X7dRDVFSYiPgPX4TJgVb6BDS\n\t I3BnSJJg14PBYsAWj0ipSciRFPm+9CKbI+XU5bGV+KrAIvra7hVzCADnGpcO0X5pl6\n\t S994JyF016ODzysrBkbp5/3B+v9onXuxAFGv8c+BGhHjBO7qDoLDtlUcnl67rSGFRA\n\t KYgPbgn9Qa9YmnVxR9m9sQAZagkeW9/kmAkQlxpGqXwQvJe5FyLU2+3kaPA3W6gc1A\n\t OhOkzrmQyi8pyDaEFRV/qaLEPo3AtHD3lGXFC/EQXmnL0OfELo86i9h0kzw2zcKkyE\n\t 2ZkNd7TvBzWLg==", "From": "Arnd Bergmann <arnd@kernel.org>", "To": "Namjae Jeon <linkinjeon@kernel.org>,\n\tSteve French <smfrench@gmail.com>,\n\tSang-Soo Lee <constant.lee@samsung.com>,\n\tBahubali B Gumaji <bahubali.bg@samsung.com>,\n\tHyunchul Lee <hyc.lee@gmail.com>", "Cc": "Arnd Bergmann <arnd@arndb.de>,\n\tSergey Senozhatsky <senozhatsky@chromium.org>,\n\tTom Talpey <tom@talpey.com>,\n\tStefan Metzmacher <metze@samba.org>,\n\tChenXiaoSong <chenxiaosong@kylinos.cn>,\n\tDavid Howells <dhowells@redhat.com>,\n\tlinux-cifs@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org", "Subject": "[PATCH] ksmbd: fix non-IPv6 build", "Date": "Tue, 10 Feb 2026 15:12:05 +0100", "Message-Id": "<20260210141219.1573869-1-arnd@kernel.org>", "X-Mailer": "git-send-email 2.39.5", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "From: Arnd Bergmann <arnd@arndb.de>\n\nThe newly added procfs code fails to build when CONFIG_IPv6 is disabled:\n\nfs/smb/server/connection.c: In function 'proc_show_clients':\nfs/smb/server/connection.c:47:58: error: 'struct ksmbd_conn' has no member named 'inet6_addr'; did you mean 'inet_addr'?\n 47 | seq_printf(m, \"%-20pI6c\", &conn->inet6_addr);\n | ^~~~~~~~~~\n | inet_addr\nmake[7]: *** [scripts/Makefile.build:279: fs/smb/server/connection.o] Error 1\nfs/smb/server/mgmt/user_session.c: In function 'show_proc_sessions':\nfs/smb/server/mgmt/user_session.c:215:65: error: 'struct ksmbd_conn' has no member named 'inet6_addr'; did you mean 'inet_addr'?\n 215 | seq_printf(m, \" %-40pI6c\", &chan->conn->inet6_addr);\n | ^~~~~~~~~~\n | inet_addr\n\nRearrange the condition to allow adding a simple preprocessor conditional.\n\nFixes: b38f99c1217a (\"ksmbd: add procfs interface for runtime monitoring and statistics\")\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\n---\nAlternatively, the corresponding check in the ksmbd_conn could be removed,\nwhich would waste a few bytes per connection but avoid the #ifdef.\n---\n fs/smb/server/connection.c | 8 +++++---\n fs/smb/server/mgmt/user_session.c | 8 +++++---\n 2 files changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/fs/smb/server/connection.c b/fs/smb/server/connection.c\nindex f0bd244e7d55..e7e3e77006b1 100644\n--- a/fs/smb/server/connection.c\n+++ b/fs/smb/server/connection.c\n@@ -41,10 +41,12 @@ static int proc_show_clients(struct seq_file *m, void *v)\n \t\tjiffies_to_timespec64(jiffies - conn->last_active, &t);\n \t\tktime_get_real_ts64(&now);\n \t\tt = timespec64_sub(now, t);\n-\t\tif (conn->inet_addr)\n-\t\t\tseq_printf(m, \"%-20pI4\", &conn->inet_addr);\n-\t\telse\n+#if IS_ENABLED(CONFIG_IPV6)\n+\t\tif (!conn->inet_addr)\n \t\t\tseq_printf(m, \"%-20pI6c\", &conn->inet6_addr);\n+\t\telse\n+#endif\n+\t\t\tseq_printf(m, \"%-20pI4\", &conn->inet_addr);\n \t\tseq_printf(m, \" 0x%-10x %-10u %-12d %-10d %ptT\\n\",\n \t\t\t conn->dialect,\n \t\t\t conn->total_credits,\ndiff --git a/fs/smb/server/mgmt/user_session.c b/fs/smb/server/mgmt/user_session.c\nindex 68b3e0cb54d3..47ce759c231e 100644\n--- a/fs/smb/server/mgmt/user_session.c\n+++ b/fs/smb/server/mgmt/user_session.c\n@@ -209,10 +209,12 @@ static int show_proc_sessions(struct seq_file *m, void *v)\n \t\tdown_read(&chan->conn->session_lock);\n \t\tksmbd_user_session_get(session);\n \n-\t\tif (chan->conn->inet_addr)\n-\t\t\tseq_printf(m, \" %-40pI4\", &chan->conn->inet_addr);\n-\t\telse\n+#if IS_ENABLED(CONFIG_IPV6)\n+\t\tif (!chan->conn->inet_addr)\n \t\t\tseq_printf(m, \" %-40pI6c\", &chan->conn->inet6_addr);\n+\t\telse\n+#endif\n+\t\t\tseq_printf(m, \" %-40pI4\", &chan->conn->inet_addr);\n \t\tseq_printf(m, \" %-15s %-10llu %-10s\\n\",\n \t\t\t session_user_name(session),\n \t\t\t session->id,\n", "prefixes": [] }