Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195154/?format=api
{ "id": 2195154, "url": "http://patchwork.ozlabs.org/api/patches/2195154/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210135206.229528-16-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210135206.229528-16-peter.maydell@linaro.org>", "list_archive_url": null, "date": "2026-02-10T13:51:55", "name": "[PULL,15/26] whpx: change memory management logic", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "5f83f3527094c8223c4b256b743d42bac9be70a4", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210135206.229528-16-peter.maydell@linaro.org/mbox/", "series": [ { "id": 491680, "url": "http://patchwork.ozlabs.org/api/series/491680/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491680", "date": "2026-02-10T13:51:40", "name": "[PULL,01/26] target/arm/kvm: add constants for new PSCI versions", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491680/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195154/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=H7ZFiOXl;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9NLb4J68z1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 00:53:11 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpoAD-00026O-Ot; Tue, 10 Feb 2026 08:52:25 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1vpoAC-00022p-Ts\n for qemu-devel@nongnu.org; Tue, 10 Feb 2026 08:52:24 -0500", "from mail-wm1-x333.google.com ([2a00:1450:4864:20::333])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1vpoAB-0006Lp-9S\n for qemu-devel@nongnu.org; Tue, 10 Feb 2026 08:52:24 -0500", "by mail-wm1-x333.google.com with SMTP id\n 5b1f17b1804b1-4801c2fae63so46995605e9.2\n for <qemu-devel@nongnu.org>; Tue, 10 Feb 2026 05:52:21 -0800 (PST)", "from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4834d5d77f9sm64344875e9.3.2026.02.10.05.52.19\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 10 Feb 2026 05:52:19 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1770731541; x=1771336341; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=73Gszeg/ABaJHBRXvm523fWNFo3Mo1lJgEc7Wi/TY9M=;\n b=H7ZFiOXlf6v7R5KUS3avqXKuCAzCcw6qNOqoBvAGF3d6JHNw0EuIRh6zyHk2AlssPr\n zNPCyFFEbNAKfzwczRE2EDd82O+StZ4PvH2hsEv6AiTkRyi43cfDlWERwz7VDXGCxw5a\n kldNqapabjNMO3BD/0Hmw11akIo9boGfxSJuvSEF/UqbPl6k4v/uno+onNbvJl5efwY9\n MaRTCv1kK8MT+5ysdW9KAtZZgP+q/mvouAiE3MqSFR+EYN3URT4ZMZOV9pb0urc/tf11\n MLYJ1XEESRhiH4WgiD2xP/mvAAxyRn/ns/rBbEjWzwN3416GDGZVpNxlr1BZCqgOJzej\n jpmA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770731541; x=1771336341;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=73Gszeg/ABaJHBRXvm523fWNFo3Mo1lJgEc7Wi/TY9M=;\n b=BEEdWbr741bjVePZScFCeXeY7EXqKb9iQhicI4ZjflzSmVDEfZ885+KwNZbYF9t8be\n eWkUZBT0Rn4hL4KJodIvbFxo1lwhKPuqXWdY3UPOLqb7VcqCtulf9SWVJlYGyqpqXh+u\n KnyZ6fj5ZnsmM7IwhOiphgCJY5oM3RQb6TucjeTbjCG8sd6GY/rZs5oeVNhXvX2BjkhF\n g2h7hVgvLKGCB3HBPAf7w8v93baHeEphe8+vB2i5ACJP19oUvtrtkPNP4NH0whNFqBns\n G5fcsBr0glyBlFJ/oam0qhH+x1m35qqWX7X1PzLpmmnFVTNI4UGt7wgErO+wgUT7+EIy\n bXVA==", "X-Gm-Message-State": "AOJu0YyCdHpGLJ6nPXXdk4G16siaFhg0nA/V31ROxZ26CuwS4q7KyPz5\n 6bOwa2jD27f/zDmhk1ybDlTAr9NTipGskMY4IH1DaTwuGr8Dtm6e1FFaDjryPiMGXg0YTxHSuQN\n BJQeK", "X-Gm-Gg": "AZuq6aLf6QMjdzZR1TO0b9919p7U3wCXsqLNClSKxs2qVl2oOX56/jKjqJZDskrEpat\n d7WKZZLGntaPfkB3xnN/q2mZaGy9lCqNyZaZqPxWd/qS4CIsbkV+ZinvinW55k+UJ1iTVhWR4Iu\n PNOvwj1xkG0Y3oGsPZBi3sNd0iLmE4T91nebunjLGQ9t9gbUbcFjtR3iGipTk99eH3+u5sBMP+t\n 0pPnFQyV6p5jn+KwoSCASd9aiJsNigPR2rsAIiO9aVgDK4SLCw4Pr31q7+BnMHKLRY4+6spkkYG\n JEWsAhseA/xEt7BQls0wU73lfVXcPKorO3IzPLl8vlwwdB+HUtlH6/0Bb518EzE41a0+zQPfcuZ\n TiOJbcMm6xQG3pH41dwBLhQdiphOHu1Nl4rBwqF/Qji08tdTZ44w4SagNoXLC7Sv08ULuP+pKHF\n QFBb9QW4iiu8YlySdFBHERkl7/QbAfLNLFyAng805SZM11XYfTGnopPPu4s8ncszH2lxbKAvSL/\n b5MpJvuqm8BdLPsmWbnt+nYQxBn+l4=", "X-Received": "by 2002:a05:600c:8b12:b0:480:4be7:4f53 with SMTP id\n 5b1f17b1804b1-4835083392dmr35903785e9.31.1770731540462;\n Tue, 10 Feb 2026 05:52:20 -0800 (PST)", "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PULL 15/26] whpx: change memory management logic", "Date": "Tue, 10 Feb 2026 13:51:55 +0000", "Message-ID": "<20260210135206.229528-16-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260210135206.229528-1-peter.maydell@linaro.org>", "References": "<20260210135206.229528-1-peter.maydell@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::333;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x333.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Mohamed Mediouni <mohamed@unpredictable.fr>\n\nThis allows edk2 to work on Arm, although u-boot is still not functional.\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\nReviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\n---\n accel/whpx/whpx-common.c | 99 +++++++++++++++-------------------------\n 1 file changed, 37 insertions(+), 62 deletions(-)", "diff": "diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c\nindex 827f50f3e0..f018a8f5c7 100644\n--- a/accel/whpx/whpx-common.c\n+++ b/accel/whpx/whpx-common.c\n@@ -255,89 +255,64 @@ void whpx_vcpu_kick(CPUState *cpu)\n * Memory support.\n */\n \n-static void whpx_update_mapping(hwaddr start_pa, ram_addr_t size,\n- void *host_va, int add, int rom,\n- const char *name)\n+static void whpx_set_phys_mem(MemoryRegionSection *section, bool add)\n {\n struct whpx_state *whpx = &whpx_global;\n+ MemoryRegion *area = section->mr;\n+ bool writable = !area->readonly && !area->rom_device;\n+ WHV_MAP_GPA_RANGE_FLAGS flags;\n+ uint64_t page_size = qemu_real_host_page_size();\n+ uint64_t gva = section->offset_within_address_space;\n+ uint64_t size = int128_get64(section->size);\n HRESULT hr;\n+ void *mem;\n \n- /*\n- if (add) {\n- printf(\"WHPX: ADD PA:%p Size:%p, Host:%p, %s, '%s'\\n\",\n- (void*)start_pa, (void*)size, host_va,\n- (rom ? \"ROM\" : \"RAM\"), name);\n- } else {\n- printf(\"WHPX: DEL PA:%p Size:%p, Host:%p, '%s'\\n\",\n- (void*)start_pa, (void*)size, host_va, name);\n+ if (!memory_region_is_ram(area)) {\n+ if (writable) {\n+ return;\n+ } else if (!memory_region_is_romd(area)) {\n+ add = false;\n+ }\n }\n- */\n \n- if (add) {\n- hr = whp_dispatch.WHvMapGpaRange(whpx->partition,\n- host_va,\n- start_pa,\n- size,\n- (WHvMapGpaRangeFlagRead |\n- WHvMapGpaRangeFlagExecute |\n- (rom ? 0 : WHvMapGpaRangeFlagWrite)));\n- } else {\n+ if (!QEMU_IS_ALIGNED(size, page_size) ||\n+ !QEMU_IS_ALIGNED(gva, page_size)) {\n+ /* Not page aligned, so we can not map as RAM */\n+ add = false;\n+ }\n+\n+ if (!add) {\n hr = whp_dispatch.WHvUnmapGpaRange(whpx->partition,\n- start_pa,\n- size);\n+ gva, size);\n+ if (FAILED(hr)) {\n+ error_report(\"WHPX: failed to unmap GPA range\");\n+ abort();\n+ }\n+ return;\n }\n \n+ flags = WHvMapGpaRangeFlagRead | WHvMapGpaRangeFlagExecute\n+ | (writable ? WHvMapGpaRangeFlagWrite : 0);\n+ mem = memory_region_get_ram_ptr(area) + section->offset_within_region;\n+\n+ hr = whp_dispatch.WHvMapGpaRange(whpx->partition,\n+ mem, gva, size, flags);\n if (FAILED(hr)) {\n- error_report(\"WHPX: Failed to %s GPA range '%s' PA:%p, Size:%p bytes,\"\n- \" Host:%p, hr=%08lx\",\n- (add ? \"MAP\" : \"UNMAP\"), name,\n- (void *)(uintptr_t)start_pa, (void *)size, host_va, hr);\n+ error_report(\"WHPX: failed to map GPA range\");\n+ abort();\n }\n }\n \n-static void whpx_process_section(MemoryRegionSection *section, int add)\n-{\n- MemoryRegion *mr = section->mr;\n- hwaddr start_pa = section->offset_within_address_space;\n- ram_addr_t size = int128_get64(section->size);\n- unsigned int delta;\n- uint64_t host_va;\n-\n- if (!memory_region_is_ram(mr)) {\n- return;\n- }\n-\n- delta = qemu_real_host_page_size() - (start_pa & ~qemu_real_host_page_mask());\n- delta &= ~qemu_real_host_page_mask();\n- if (delta > size) {\n- return;\n- }\n- start_pa += delta;\n- size -= delta;\n- size &= qemu_real_host_page_mask();\n- if (!size || (start_pa & ~qemu_real_host_page_mask())) {\n- return;\n- }\n-\n- host_va = (uintptr_t)memory_region_get_ram_ptr(mr)\n- + section->offset_within_region + delta;\n-\n- whpx_update_mapping(start_pa, size, (void *)(uintptr_t)host_va, add,\n- memory_region_is_rom(mr), mr->name);\n-}\n-\n static void whpx_region_add(MemoryListener *listener,\n MemoryRegionSection *section)\n {\n- memory_region_ref(section->mr);\n- whpx_process_section(section, 1);\n+ whpx_set_phys_mem(section, true);\n }\n \n static void whpx_region_del(MemoryListener *listener,\n MemoryRegionSection *section)\n {\n- whpx_process_section(section, 0);\n- memory_region_unref(section->mr);\n+ whpx_set_phys_mem(section, false);\n }\n \n static void whpx_transaction_begin(MemoryListener *listener)\n", "prefixes": [ "PULL", "15/26" ] }