Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195139/?format=api
{ "id": 2195139, "url": "http://patchwork.ozlabs.org/api/patches/2195139/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260210134110.1515322-7-saif.abrar@linux.vnet.ibm.com/", "project": { "id": 69, "url": "http://patchwork.ozlabs.org/api/projects/69/?format=api", "name": "QEMU powerpc development", "link_name": "qemu-ppc", "list_id": "qemu-ppc.nongnu.org", "list_email": "qemu-ppc@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210134110.1515322-7-saif.abrar@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2026-02-10T13:40:56", "name": "[v3,6/9] pnv/phb4: Set link-active status in HPSTAT and LMR registers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6c9196ab1cac6a948c0c77d69ffabc649ff2a5e4", "submitter": { "id": 87200, "url": "http://patchwork.ozlabs.org/api/people/87200/?format=api", "name": "Saif Abrar", "email": "saif.abrar@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260210134110.1515322-7-saif.abrar@linux.vnet.ibm.com/mbox/", "series": [ { "id": 491676, "url": "http://patchwork.ozlabs.org/api/series/491676/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=491676", "date": "2026-02-10T13:40:52", "name": "[v3,1/9] qtest/phb4: Add testbench for PHB4", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/491676/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195139/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195139/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=k5FHKLKw;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9N7l0GjSz1xvb\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 00:43:47 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-ppc-bounces@nongnu.org>)\n\tid 1vpo0l-0002Mu-8h; Tue, 10 Feb 2026 08:42:39 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <saif.abrar@linux.vnet.ibm.com>)\n id 1vpo0j-0002KP-Rf; Tue, 10 Feb 2026 08:42:37 -0500", "from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <saif.abrar@linux.vnet.ibm.com>)\n id 1vpo0i-0003Hy-4M; Tue, 10 Feb 2026 08:42:37 -0500", "from pps.filterd (m0353729.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61ABwtuf501539; Tue, 10 Feb 2026 13:42:27 GMT", "from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696w4euu-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 10 Feb 2026 13:42:26 +0000 (GMT)", "from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 61ADITOZ002635;\n Tue, 10 Feb 2026 13:42:26 GMT", "from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68])\n by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4c6fqshnq4-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 10 Feb 2026 13:42:25 +0000", "from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 61ADgONP5767972\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 10 Feb 2026 13:42:24 GMT", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 07BB95805D;\n Tue, 10 Feb 2026 13:42:24 +0000 (GMT)", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id C684658054;\n Tue, 10 Feb 2026 13:42:22 +0000 (GMT)", "from gfwr526.rchland.ibm.com (unknown [9.10.239.119])\n by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Tue, 10 Feb 2026 13:42:22 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=qxQJzP1/6E8GYWUza\n ILV/2Lg+XdZWAPa0N+uDJZFGnY=; b=k5FHKLKwwQF6t7mtvJ8WgjgncegYm8duT\n 8ii9I4mUeTyQyoFGCcgmcnrRgsCPKZl44ocCRk+bVrcfketouo1AHU4HPOR60YRX\n AjY2+V99O5a3InLYCQ5bDGBNZW4rrLf9HGB+qD5f0lST6kQXiC6AEDD+xPWZZ56g\n 56PglnhIe2nUmxPd0QuEa5oTWXYI5OZVH3lVNUmI/ysoKGSIwHzHfisXW0F6a2Ee\n i8YuZYrl6JEJMjsyTdbBQeEVDTvTyTOB60JiWSzyYdX7ny65rv00pRLGYojpLcc2\n ANCjs8WZdwEz/5/M5PmAkDby4VveR44hbOLTolx/WHIFQutuoovqw==", "From": "Saif Abrar <saif.abrar@linux.vnet.ibm.com>", "To": "qemu-ppc@nongnu.org, qemu-devel@nongnu.org", "Cc": "clg@kaod.org, npiggin@gmail.com, fbarrat@linux.ibm.com, mst@redhat.com,\n marcel.apfelbaum@gmail.com, cohuck@redhat.com, pbonzini@redhat.com,\n thuth@redhat.com, lvivier@redhat.com, danielhb413@gmail.com,\n saif.abrar@linux.vnet.ibm.com", "Subject": "[PATCH v3 6/9] pnv/phb4: Set link-active status in HPSTAT and LMR\n registers", "Date": "Tue, 10 Feb 2026 07:40:56 -0600", "Message-ID": "<20260210134110.1515322-7-saif.abrar@linux.vnet.ibm.com>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260210134110.1515322-1-saif.abrar@linux.vnet.ibm.com>", "References": "<20251230102156.886288-1-saif.abrar@linux.vnet.ibm.com>\n <20260210134110.1515322-1-saif.abrar@linux.vnet.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Reinject": "loops=2 maxloops=12", "X-Authority-Analysis": "v=2.4 cv=YeCwJgRf c=1 sm=1 tr=0 ts=698b35c3 cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8 a=E9s9Sk2w9S_N8XOcZ00A:9", "X-Proofpoint-GUID": "_scJS16wOugyqyhp7N-PvDmKy8-Mx97z", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEwMDExMiBTYWx0ZWRfX9lYDIFfbeS/3\n G9fvnINwk6f/6Rn7q8uF/D5NTBQyOTZCKmBTQDOWYv2BTA+hfv9CBt2PnHXENXkGX4qfFwBipH4\n k8PdutPO67AzNrDt2ay2qTRfR+tuZHXCrB5oKSLdUTANZakZR7QQZc+/KhwFQ+fnayWAZoT8saF\n nunGbDRHuQbOKTi8ZQR9CxoyLi7I1KS22vJ8FJ19UzZZgubU9i7/BVvmgPoVZTKa4blNOZoTtNi\n znnaGPlCqZbvAQiENNnNcd9/AySf9go50sUr0u+sbWB0k04EPeC1VWSYMcU3E38XA38/IJTpDW5\n +kvowfw8siXWHQLPReIr3xY0MSNrN0aHge4BQGJ8aJ9UrHmNT6hUcyyGLJ+RSrk9qZkDeo0uYIv\n C/BclxkYDbeY6Adc/bOvSU2LzKjSOsGyj4iGGuoODDzJlimqnCX9Kui76U0lPvwULkxzig9/moR\n JzRnZ0Ge0RxXL0Vwr/w==", "X-Proofpoint-ORIG-GUID": "c7vRcfQUygkuy1cihp-9GaHTRpTP56na", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-10_01,2026-02-10_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0\n priorityscore=1501 lowpriorityscore=0 clxscore=1015 impostorscore=0\n spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602100112", "Received-SPF": "none client-ip=148.163.156.1;\n envelope-from=saif.abrar@linux.vnet.ibm.com; helo=mx0a-001b2d01.pphosted.com", "X-Spam_score_int": "-19", "X-Spam_score": "-2.0", "X-Spam_bar": "--", "X-Spam_report": "(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-ppc@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-ppc.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-ppc>", "List-Post": "<mailto:qemu-ppc@nongnu.org>", "List-Help": "<mailto:qemu-ppc-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Config-read the link-status register in the PCI-E macro,\nDepending on the link-active bit, set the link-active status\nin the HOTPLUG_STATUS and LINK_MANAGEMENT registers\nAlso, clear the Presence-status active low bit in HOTPLUG_STATUS reg\nafter config-reading the slot-status in the PCI-E macro.\n\nSigned-off-by: Saif Abrar <saif.abrar@linux.vnet.ibm.com>\n---\nv3: Updates for coding guidelines.\n\n\n hw/pci-host/pnv_phb4.c | 60 +++++++++++++++++++++++++++++++++++++++++-\n 1 file changed, 59 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c\nindex c044e9d2a3..ebbdaf77b3 100644\n--- a/hw/pci-host/pnv_phb4.c\n+++ b/hw/pci-host/pnv_phb4.c\n@@ -510,6 +510,20 @@ static uint32_t get_exp_offset(PCIDevice *pdev)\n return rpc->exp_offset;\n }\n \n+/*\n+ * Config-read the link-status register in the PCI-E macro,\n+ * convert to LE and check the link-active bit.\n+ */\n+static uint32_t is_link_active(PnvPHB4 *phb)\n+{\n+ PCIHostState *pci = PCI_HOST_BRIDGE(phb->phb_base);\n+ PCIDevice *pdev = pci_find_device(pci->bus, 0, 0);\n+ uint32_t exp_offset = get_exp_offset(pdev);\n+\n+ return (bswap32(pnv_phb4_rc_config_read(phb, exp_offset + PCI_EXP_LNKSTA, 4)\n+ ) & PCI_EXP_LNKSTA_DLLLA);\n+}\n+\n /*\n * Apply sticky-mask 's' to the reset-value 'v' and write to the address 'a'.\n * RC-config space values and masks are LE.\n@@ -728,6 +742,11 @@ static void pnv_phb4_reg_write(void *opaque, hwaddr off, uint64_t val,\n val = 0;\n break;\n \n+ case PHB_PCIE_HOTPLUG_STATUS:\n+ /* For normal operations, Simspeed diagnostic bit is always zero */\n+ val &= PHB_PCIE_HPSTAT_SIMDIAG;\n+ break;\n+\n /* Read only registers */\n case PHB_CPU_LOADSTORE_STATUS:\n case PHB_ETU_ERR_SUMMARY:\n@@ -943,8 +962,42 @@ static uint64_t pnv_phb4_reg_read(void *opaque, hwaddr off, unsigned size)\n val |= PHB_PCIE_DLP_INBAND_PRESENCE | PHB_PCIE_DLP_TL_LINKACT;\n return val;\n \n+ /*\n+ * Read PCI-E registers and set status for:\n+ * - Card present (active low bit 10)\n+ * - Link active (bit 12)\n+ */\n case PHB_PCIE_HOTPLUG_STATUS:\n- /* Clear write-only bit */\n+ /*\n+ * Presence-status bit hpi_present_n is active-low, with reset value 1.\n+ * Start by setting this bit to 1, indicating the card is not present.\n+ * Then check the PCI-E register and clear the bit if card is present.\n+ */\n+ val |= PHB_PCIE_HPSTAT_PRESENCE;\n+\n+ /* Get the PCI-E capability offset from the root-port */\n+ PCIHostState *pci = PCI_HOST_BRIDGE(phb->phb_base);\n+ PCIDevice *pdev = pci_find_device(pci->bus, 0, 0);\n+ uint32_t exp_base = get_exp_offset(pdev);\n+\n+ /*\n+ * Config-read the PCI-E macro register for slot-status.\n+ * Method for config-read converts to BE value.\n+ * To check actual bit in the PCI-E register,\n+ * convert the value back to LE using bswap32().\n+ * Clear the Presence-status active low bit.\n+ */\n+ if (bswap32(pnv_phb4_rc_config_read(phb, exp_base + PCI_EXP_SLTSTA, 4))\n+ & PCI_EXP_SLTSTA_PDS) {\n+ val &= ~PHB_PCIE_HPSTAT_PRESENCE;\n+ }\n+\n+ /* Check if link is active and set the bit */\n+ if (is_link_active(phb)) {\n+ val |= PHB_PCIE_HPSTAT_LINKACTIVE;\n+ }\n+\n+ /* Clear write-only resample-bit */\n val &= ~PHB_PCIE_HPSTAT_RESAMPLE;\n return val;\n \n@@ -952,6 +1005,11 @@ static uint64_t pnv_phb4_reg_read(void *opaque, hwaddr off, unsigned size)\n case PHB_PCIE_LMR:\n /* These write-only bits always read as 0 */\n val &= ~(PHB_PCIE_LMR_CHANGELW | PHB_PCIE_LMR_RETRAINLINK);\n+\n+ /* Check if link is active and set the bit */\n+ if (is_link_active(phb)) {\n+ val |= PHB_PCIE_LMR_LINKACTIVE;\n+ }\n return val;\n \n /* Silent simple reads */\n", "prefixes": [ "v3", "6/9" ] }