Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195138/?format=api
{ "id": 2195138, "url": "http://patchwork.ozlabs.org/api/patches/2195138/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210134110.1515322-8-saif.abrar@linux.vnet.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210134110.1515322-8-saif.abrar@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2026-02-10T13:40:57", "name": "[v3,7/9] pnv/phb4: Set link speed and width in the DLP training control register", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b2a075327138d9a6d50df21b9abe520ca094ad04", "submitter": { "id": 87200, "url": "http://patchwork.ozlabs.org/api/people/87200/?format=api", "name": "Saif Abrar", "email": "saif.abrar@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210134110.1515322-8-saif.abrar@linux.vnet.ibm.com/mbox/", "series": [ { "id": 491677, "url": "http://patchwork.ozlabs.org/api/series/491677/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491677", "date": "2026-02-10T13:40:52", "name": ": pnv/phb4: Update PHB4 to the latest PHB5 spec", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/491677/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195138/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195138/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=TS3XaRsV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9N7W4sBQz1xvb\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 00:43:35 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpo0n-0002R1-T6; Tue, 10 Feb 2026 08:42:41 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <saif.abrar@linux.vnet.ibm.com>)\n id 1vpo0l-0002NI-Gz; Tue, 10 Feb 2026 08:42:39 -0500", "from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <saif.abrar@linux.vnet.ibm.com>)\n id 1vpo0j-0003IU-TM; Tue, 10 Feb 2026 08:42:39 -0500", "from pps.filterd (m0360083.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61AAMfpc348378; Tue, 10 Feb 2026 13:42:34 GMT", "from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696ucfy2-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 10 Feb 2026 13:42:33 +0000 (GMT)", "from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 61AAEfno001408;\n Tue, 10 Feb 2026 13:42:32 GMT", "from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4])\n by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4c6gqn1ge8-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 10 Feb 2026 13:42:32 +0000", "from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 61ADgVE326804800\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 10 Feb 2026 13:42:31 GMT", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 039E85805A;\n Tue, 10 Feb 2026 13:42:31 +0000 (GMT)", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id CB5BA58054;\n Tue, 10 Feb 2026 13:42:29 +0000 (GMT)", "from gfwr526.rchland.ibm.com (unknown [9.10.239.119])\n by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Tue, 10 Feb 2026 13:42:29 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=pp1; bh=N+ZjMg\n ZgtOzJcKLQl5aGQ8nA57L7MuJwiF0xXpPfGj8=; b=TS3XaRsVSU3G+lU4fUWh0o\n ozfkKz+N63gNxWsAPEhO96tm29zDekbB/U9UW6S5HGqgqMZ2o5tJw5s0KTQa0U07\n zM/0Je6WIoiNbSO0DxTZ4qUO21vdFnRGQDZxdQcII5KfuVWAK8+iPKyR/pgUF1GO\n uPXFMSo/mu6gL87eS1fnxrkA+DnAaiJJmNt7+0ouZihcHiIb02ih1cVQ/vc7CUFy\n yw/BZUBuWYmQzsqF+7hLSrAXdkE9nD9xvLQqH2lT5dJ7DiF5x/8XjMBuMyNtzY0e\n WMgtlhGiPL+av3FxuOxtU9FVed/5XevN/J0sGFzdeubO82x/Y99CnfXVPc1sHdyA\n ==", "From": "Saif Abrar <saif.abrar@linux.vnet.ibm.com>", "To": "qemu-ppc@nongnu.org, qemu-devel@nongnu.org", "Cc": "clg@kaod.org, npiggin@gmail.com, fbarrat@linux.ibm.com, mst@redhat.com,\n marcel.apfelbaum@gmail.com, cohuck@redhat.com, pbonzini@redhat.com,\n thuth@redhat.com, lvivier@redhat.com, danielhb413@gmail.com,\n saif.abrar@linux.vnet.ibm.com", "Subject": "[PATCH v3 7/9] pnv/phb4: Set link speed and width in the DLP training\n control register", "Date": "Tue, 10 Feb 2026 07:40:57 -0600", "Message-ID": "<20260210134110.1515322-8-saif.abrar@linux.vnet.ibm.com>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260210134110.1515322-1-saif.abrar@linux.vnet.ibm.com>", "References": "<20251230102156.886288-1-saif.abrar@linux.vnet.ibm.com>\n <20260210134110.1515322-1-saif.abrar@linux.vnet.ibm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Reinject": "loops=2 maxloops=12", "X-Authority-Analysis": "v=2.4 cv=KZnfcAYD c=1 sm=1 tr=0 ts=698b35ca cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22\n a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8\n a=aow-egSQAAAA:8 a=VOsU92DsAUPXpT8d5pYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10\n a=gFNbaldVC-z-bsjSTzMo:22", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEwMDExMiBTYWx0ZWRfXxX73PoROAgV8\n /pz598h90Mc7JjAKZvRkQtsWBrNb6l6k6a+Kv/9aenbbDEhOPAv2Qc/ZldYr4oLwLkWEHJ5EdeJ\n 2va2Iax+jaSPqWLaF1y8lAwxVK99SkN8wtsTBeMFkDPg4cuuZ41mTJ9GvERYQadLlYYP2B41xV9\n 0nGLL87yRiYIKCgUMA2dr1+1AJeIHlsFrZPVHWiD/FZ0VVBLQjDPE24qnXvlTxsBWQ8q3HZQqUh\n ah4PeRHLIl1OsNsV0ph+yk/HblQa8avp3AU+//Rddi8bU3EtwNjqo4W8h9KdC4MpjpEVLAFSjOX\n qF405MuG34GPsqjohptb+Z4d0ctB1EoHYfpCyvP2n87aUnOxeRu/206znl25ZbILqk1+/po3HCz\n Y5uAFnfqkPbd7K0110XhZKkJsWNArBIdNbgb2o1R65WCduW6Qqz/oxSqIDPflNWae7Nx2SzED9m\n sQof4PdX+kobtPKalJw==", "X-Proofpoint-ORIG-GUID": "zbHz562PC_RSXIl8XlflyxgV7RaWqlpg", "X-Proofpoint-GUID": "xjFOCeCCnzjD_8cPWMQ_resZHAjKLNgB", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-10_01,2026-02-10_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n spamscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 adultscore=0\n clxscore=1015 suspectscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602100112", "Received-SPF": "none client-ip=148.163.156.1;\n envelope-from=saif.abrar@linux.vnet.ibm.com; helo=mx0a-001b2d01.pphosted.com", "X-Spam_score_int": "-19", "X-Spam_score": "-2.0", "X-Spam_bar": "--", "X-Spam_report": "(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Get the current link-status from PCIE macro.\nExtract link-speed and link-width from the link-status\nand set in the DLP training control (PCIE_DLP_TCR) register.\n\nSigned-off-by: Saif Abrar <saif.abrar@linux.vnet.ibm.com>\nReviewed-by: Cédric Le Goater <clg@kaod.org>\n---\nv3: Updates for coding guidelines.\n\n\n hw/pci-host/pnv_phb4.c | 34 +++++++++++++++++++++++++++-------\n 1 file changed, 27 insertions(+), 7 deletions(-)", "diff": "diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c\nindex ebbdaf77b3..a7a4ba46db 100644\n--- a/hw/pci-host/pnv_phb4.c\n+++ b/hw/pci-host/pnv_phb4.c\n@@ -956,10 +956,30 @@ static uint64_t pnv_phb4_reg_read(void *opaque, hwaddr off, unsigned size)\n val |= PHB_PCIE_SCR_PLW_X16; /* RO bit */\n break;\n \n- /* Link training always appears trained */\n case PHB_PCIE_DLP_TRAIN_CTL:\n- /* TODO: Do something sensible with speed ? */\n+ /* Get the current link-status from PCIE */\n+ PCIHostState *pci = PCI_HOST_BRIDGE(phb->phb_base);\n+ PCIDevice *pdev = pci_find_device(pci->bus, 0, 0);\n+ uint32_t exp_offset = get_exp_offset(pdev);\n+ uint32_t lnkstatus = bswap32(pnv_phb4_rc_config_read(phb,\n+ exp_offset + PCI_EXP_LNKSTA, 4));\n+\n+ /* Extract link-speed from the link-status */\n+ uint32_t v = lnkstatus & PCI_EXP_LNKSTA_CLS;\n+\n+ /* Link training always appears trained */\n val |= PHB_PCIE_DLP_INBAND_PRESENCE | PHB_PCIE_DLP_TL_LINKACT;\n+\n+ /* Set the current link-speed at the LINK_SPEED position */\n+ val = SETFIELD(PHB_PCIE_DLP_LINK_SPEED, val, v);\n+\n+ /*\n+ * Extract link-width from the link-status,\n+ * after shifting the required bitfields.\n+ */\n+ v = (lnkstatus & PCI_EXP_LNKSTA_NLW) >> PCI_EXP_LNKSTA_NLW_SHIFT;\n+ /* Set the current link-width at the LINK_WIDTH position */\n+ val = SETFIELD(PHB_PCIE_DLP_LINK_WIDTH, val, v);\n return val;\n \n /*\n@@ -968,6 +988,11 @@ static uint64_t pnv_phb4_reg_read(void *opaque, hwaddr off, unsigned size)\n * - Link active (bit 12)\n */\n case PHB_PCIE_HOTPLUG_STATUS:\n+ /* Get the PCI-E capability offset from the root-port */\n+ pci = PCI_HOST_BRIDGE(phb->phb_base);\n+ pdev = pci_find_device(pci->bus, 0, 0);\n+ uint32_t exp_base = get_exp_offset(pdev);\n+\n /*\n * Presence-status bit hpi_present_n is active-low, with reset value 1.\n * Start by setting this bit to 1, indicating the card is not present.\n@@ -975,11 +1000,6 @@ static uint64_t pnv_phb4_reg_read(void *opaque, hwaddr off, unsigned size)\n */\n val |= PHB_PCIE_HPSTAT_PRESENCE;\n \n- /* Get the PCI-E capability offset from the root-port */\n- PCIHostState *pci = PCI_HOST_BRIDGE(phb->phb_base);\n- PCIDevice *pdev = pci_find_device(pci->bus, 0, 0);\n- uint32_t exp_base = get_exp_offset(pdev);\n-\n /*\n * Config-read the PCI-E macro register for slot-status.\n * Method for config-read converts to BE value.\n", "prefixes": [ "v3", "7/9" ] }