Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195128/?format=api
{ "id": 2195128, "url": "http://patchwork.ozlabs.org/api/patches/2195128/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260210134110.1515322-2-saif.abrar@linux.vnet.ibm.com/", "project": { "id": 69, "url": "http://patchwork.ozlabs.org/api/projects/69/?format=api", "name": "QEMU powerpc development", "link_name": "qemu-ppc", "list_id": "qemu-ppc.nongnu.org", "list_email": "qemu-ppc@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210134110.1515322-2-saif.abrar@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2026-02-10T13:40:51", "name": "[v3,1/9] qtest/phb4: Add testbench for PHB4", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4ff1b54b4a1d32efad28bf98469e883c05467355", "submitter": { "id": 87200, "url": "http://patchwork.ozlabs.org/api/people/87200/?format=api", "name": "Saif Abrar", "email": "saif.abrar@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260210134110.1515322-2-saif.abrar@linux.vnet.ibm.com/mbox/", "series": [ { "id": 491676, "url": "http://patchwork.ozlabs.org/api/series/491676/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=491676", "date": "2026-02-10T13:40:52", "name": "[v3,1/9] qtest/phb4: Add testbench for PHB4", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/491676/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195128/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195128/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=rYWPeTgN;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9N6w3ZJFz1xvb\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 00:43:04 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-ppc-bounces@nongnu.org>)\n\tid 1vpo04-00018q-3i; Tue, 10 Feb 2026 08:41:56 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <saif.abrar@linux.vnet.ibm.com>)\n id 1vpnzw-00013h-7n; Tue, 10 Feb 2026 08:41:48 -0500", "from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <saif.abrar@linux.vnet.ibm.com>)\n id 1vpnzu-00034j-Ae; Tue, 10 Feb 2026 08:41:47 -0500", "from pps.filterd (m0360083.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 619IxNhT1915889; Tue, 10 Feb 2026 13:41:37 GMT", "from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696ucfv3-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 10 Feb 2026 13:41:36 +0000 (GMT)", "from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 61A9g5hY001471;\n Tue, 10 Feb 2026 13:41:35 GMT", "from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70])\n by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4c6gqn1gbt-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 10 Feb 2026 13:41:35 +0000", "from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 61ADfEIg23986840\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 10 Feb 2026 13:41:14 GMT", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 2DA745805C;\n Tue, 10 Feb 2026 13:41:34 +0000 (GMT)", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 01F6258054;\n Tue, 10 Feb 2026 13:41:33 +0000 (GMT)", "from gfwr526.rchland.ibm.com (unknown [9.10.239.119])\n by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Tue, 10 Feb 2026 13:41:32 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=pp1; bh=H8mHFG\n TieOahfb67i6yRuO7Y/g80NWvwNIA6BFKycbk=; b=rYWPeTgNceIh+Z3WgKgpTB\n Y6yy6hDuFxyjYbnFrbz0bSM5zb8co3Dm3EzWIzJU1V2z5L1zcKQRGDYPFwUnoa60\n mFZgnym2cSw+emz1aDD18OpITOdFAlOFjBT2w0MSld9GdwkhPXcovqmdB810AdcP\n YAZM6Goubka84UZTIOpWWvJxDOfq26o53+smvBfxYSJVCblGoRCS9ssgx9TLIyoB\n 8sFpRcxNl9ph5h8JxZFooIHOYpuuJGoMSTrQOo025oMVUeKCSDUtL9Iuu9jqyGzq\n FVsXYRLINaVrwiOo/d5WoWxX2QJ6+xCmbYT6X0QD1gwAZ0YySRA64NRp3N/+gdTg\n ==", "From": "Saif Abrar <saif.abrar@linux.vnet.ibm.com>", "To": "qemu-ppc@nongnu.org, qemu-devel@nongnu.org", "Cc": "clg@kaod.org, npiggin@gmail.com, fbarrat@linux.ibm.com, mst@redhat.com,\n marcel.apfelbaum@gmail.com, cohuck@redhat.com, pbonzini@redhat.com,\n thuth@redhat.com, lvivier@redhat.com, danielhb413@gmail.com,\n saif.abrar@linux.vnet.ibm.com", "Subject": "[PATCH v3 1/9] qtest/phb4: Add testbench for PHB4", "Date": "Tue, 10 Feb 2026 07:40:51 -0600", "Message-ID": "<20260210134110.1515322-2-saif.abrar@linux.vnet.ibm.com>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260210134110.1515322-1-saif.abrar@linux.vnet.ibm.com>", "References": "<20251230102156.886288-1-saif.abrar@linux.vnet.ibm.com>\n <20260210134110.1515322-1-saif.abrar@linux.vnet.ibm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Reinject": "loops=2 maxloops=12", "X-Authority-Analysis": "v=2.4 cv=KZnfcAYD c=1 sm=1 tr=0 ts=698b3591 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22\n a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8\n a=aow-egSQAAAA:8 a=IezeUUPc-1SGbE2r020A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10\n a=gFNbaldVC-z-bsjSTzMo:22", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEwMDExMiBTYWx0ZWRfXx/glpVvo7Gyu\n i/32HHclLQ4IOp0Fptp3IJ1ZUTGCUkMit2RFY8a491m4giCnWT1Dkr0rEDSQ9gsYlBX9njLUW89\n ssm5jGup7dte4Iv3uBWtIw98oe9wWEQhUK+WbUS39cDzp+leYbSN/ItoXVjBaeW2tj5T6dwhQTN\n dl3GuSsXodZZfUfY0PTXAGld/d7DevoUGI0FPLgOQemKd/YzZ4mrquHl67vqJpkddp0Lb/nR1mG\n Wma3RZJBmdOunmAlquTNcKUVrn+FndHIbjTrH7Gu5+aWjYbaGGI5YfkuZwAeOitFz/AILd/35h8\n 4hJdqExOeXBbAnxcjvm/5GiXKaLlxB30vg8WRZQs4DeWKhpFj0YwJtFAaX65D07lh0h1E8SRvME\n AmGLBHH0SYl22qWefBAN850cVIrw3N30d5uExkbS/pO4WYkh06sKs6G7erDT+qGPDgC7M8QuPB/\n L2hDL2Ncb+qzST3TbGg==", "X-Proofpoint-ORIG-GUID": "mXsPg1T8bzbm_55dO7vE2jjcGKcUmzcx", "X-Proofpoint-GUID": "xiaObr088Jn7_RngN_-OFEvYWWLD_ARF", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-10_01,2026-02-10_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n spamscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 adultscore=0\n clxscore=1015 suspectscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602100112", "Received-SPF": "none client-ip=148.163.156.1;\n envelope-from=saif.abrar@linux.vnet.ibm.com; helo=mx0a-001b2d01.pphosted.com", "X-Spam_score_int": "-19", "X-Spam_score": "-2.0", "X-Spam_bar": "--", "X-Spam_report": "(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-ppc@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-ppc.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-ppc>", "List-Post": "<mailto:qemu-ppc@nongnu.org>", "List-Help": "<mailto:qemu-ppc-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "New qtest testbench added for PHB[345].\nTestbench reads PHB Version register and asserts that\nbits[24:31] have value 0xA3, 0xA4 and 0xA5 respectively.\n\nSigned-off-by: Saif Abrar <saif.abrar@linux.vnet.ibm.com>\nReviewed-by: Cédric Le Goater <clg@kaod.org>\n---\nv3: Updates for coding guidelines.\n\nv2: Added version check for PHB3 and PHB4 also.\n\n tests/qtest/meson.build | 1 +\n tests/qtest/pnv-phb4-test.c | 98 +++++++++++++++++++++++++++++++++++++\n 2 files changed, 99 insertions(+)\n create mode 100644 tests/qtest/pnv-phb4-test.c", "diff": "diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build\nindex dfb83650c6..593c3c4560 100644\n--- a/tests/qtest/meson.build\n+++ b/tests/qtest/meson.build\n@@ -184,6 +184,7 @@ qtests_ppc64 = \\\n (config_all_devices.has_key('CONFIG_POWERNV') ? ['pnv-xive2-test'] : []) + \\\n (config_all_devices.has_key('CONFIG_POWERNV') ? ['pnv-spi-seeprom-test'] : []) + \\\n (config_all_devices.has_key('CONFIG_POWERNV') ? ['pnv-host-i2c-test'] : []) + \\\n+ (config_all_devices.has_key('CONFIG_POWERNV') ? ['pnv-phb4-test'] : []) + \\\n (config_all_devices.has_key('CONFIG_PSERIES') ? ['numa-test'] : []) + \\\n (config_all_devices.has_key('CONFIG_PSERIES') ? ['rtas-test'] : []) + \\\n (slirp.found() ? ['pxe-test'] : []) + \\\ndiff --git a/tests/qtest/pnv-phb4-test.c b/tests/qtest/pnv-phb4-test.c\nnew file mode 100644\nindex 0000000000..797f6b6c87\n--- /dev/null\n+++ b/tests/qtest/pnv-phb4-test.c\n@@ -0,0 +1,98 @@\n+/*\n+ * QTest testcase for PowerNV PHB4\n+ *\n+ * Copyright (c) 2025, IBM Corporation.\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ *\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"libqtest.h\"\n+#include \"hw/pci-host/pnv_phb4_regs.h\"\n+#include \"pnv-xscom.h\"\n+\n+#define PPC_BIT(bit) (0x8000000000000000ULL >> (bit))\n+#define PPC_BITMASK(bs, be) ((PPC_BIT(bs) - PPC_BIT(be)) | PPC_BIT(bs))\n+\n+#define PHB3_PBCQ_SPCI_ASB_ADDR 0x0\n+#define PHB3_PBCQ_SPCI_ASB_DATA 0x2\n+\n+/* Index of PNV_CHIP_POWER10 in pnv_chips[] within \"pnv-xscom.h\" */\n+#define PNV_P10_CHIP_INDEX 3\n+#define PHB4_XSCOM 0x40084800ull\n+\n+/*\n+ * Indirect XSCOM read::\n+ * - Write 'Indirect Address Register' with register-offset to read.\n+ * - Read 'Indirect Data Register' to get the value.\n+ */\n+static uint64_t pnv_phb_xscom_read(QTestState *qts, const PnvChip *chip,\n+ uint64_t scom, uint32_t indirect_addr, uint32_t indirect_data,\n+ uint64_t reg)\n+{\n+ qtest_writeq(qts, pnv_xscom_addr(chip, (scom >> 3) + indirect_addr), reg);\n+ return qtest_readq(qts, pnv_xscom_addr(chip, (scom >> 3) + indirect_data));\n+}\n+\n+/* Assert that 'PHB - Version Register' bits[24:31] are as expected */\n+static void phb_version_test(const void *data)\n+{\n+ const PnvChip *chip = (PnvChip *)data;\n+ QTestState *qts;\n+ const char *machine = \"powernv8\";\n+ uint64_t phb_xscom = 0x4809e000;\n+ uint64_t reg_phb_version = PHB_VERSION;\n+ uint32_t indirect_addr = PHB3_PBCQ_SPCI_ASB_ADDR;\n+ uint32_t indirect_data = PHB3_PBCQ_SPCI_ASB_DATA;\n+ uint32_t expected_ver = 0xA3;\n+ uint64_t ver;\n+\n+ if (chip->chip_type == PNV_CHIP_POWER9) {\n+ machine = \"powernv9\";\n+ phb_xscom = 0x68084800;\n+ indirect_addr = PHB_SCOM_HV_IND_ADDR;\n+ indirect_data = PHB_SCOM_HV_IND_DATA;\n+ reg_phb_version |= PPC_BIT(0);\n+ expected_ver = 0xA4;\n+ } else if (chip->chip_type == PNV_CHIP_POWER10) {\n+ machine = \"powernv10\";\n+ phb_xscom = PHB4_XSCOM;\n+ indirect_addr = PHB_SCOM_HV_IND_ADDR;\n+ indirect_data = PHB_SCOM_HV_IND_DATA;\n+ reg_phb_version |= PPC_BIT(0);\n+ expected_ver = 0xA5;\n+ }\n+\n+ qts = qtest_initf(\"-M %s -accel tcg -cpu %s\", machine, chip->cpu_model);\n+\n+ ver = pnv_phb_xscom_read(qts, chip, phb_xscom,\n+ indirect_addr, indirect_data, reg_phb_version);\n+\n+ /* PHB Version register bits [24:31] */\n+ ver = ver >> (63 - 31);\n+ g_assert_cmpuint(ver, ==, expected_ver);\n+\n+ qtest_quit(qts);\n+}\n+\n+/* Verify versions of all supported PHB's */\n+static void add_phbX_version_test(void)\n+{\n+ for (int i = 0; i < ARRAY_SIZE(pnv_chips); i++) {\n+ char *tname = g_strdup_printf(\"pnv-phb/%s\",\n+ pnv_chips[i].cpu_model);\n+ qtest_add_data_func(tname, &pnv_chips[i], phb_version_test);\n+ g_free(tname);\n+ }\n+}\n+\n+int main(int argc, char **argv)\n+{\n+ g_test_init(&argc, &argv, NULL);\n+\n+ /* PHB[345] tests */\n+ add_phbX_version_test();\n+\n+ return g_test_run();\n+}\n", "prefixes": [ "v3", "1/9" ] }