Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195116/?format=api
{ "id": 2195116, "url": "http://patchwork.ozlabs.org/api/patches/2195116/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210133355.16093-3-brian.cain@oss.qualcomm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210133355.16093-3-brian.cain@oss.qualcomm.com>", "list_archive_url": null, "date": "2026-02-10T13:33:52", "name": "[v3,2/4] target/hexagon: Return decode failure for invalid non-duplex encodings", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1411f77f0cdb74617edb2a8003783c663d1725b9", "submitter": { "id": 89839, "url": "http://patchwork.ozlabs.org/api/people/89839/?format=api", "name": "Brian Cain", "email": "brian.cain@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210133355.16093-3-brian.cain@oss.qualcomm.com/mbox/", "series": [ { "id": 491673, "url": "http://patchwork.ozlabs.org/api/series/491673/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491673", "date": "2026-02-10T13:33:53", "name": "Handle some invalid encodings", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/491673/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195116/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195116/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=mkJtRSBS;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=EMhKYVjY;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9Mxq5j3Wz1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 11 Feb 2026 00:35:11 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpnsr-0005f5-JY; Tue, 10 Feb 2026 08:34:29 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1vpnsn-0005e1-0l\n for qemu-devel@nongnu.org; Tue, 10 Feb 2026 08:34:25 -0500", "from mx0a-0031df01.pphosted.com ([205.220.168.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1vpnsj-0001nd-Nc\n for qemu-devel@nongnu.org; Tue, 10 Feb 2026 08:34:24 -0500", "from pps.filterd (m0279867.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61A6jRRr442377\n for <qemu-devel@nongnu.org>; Tue, 10 Feb 2026 13:34:19 GMT", "from mail-dy1-f199.google.com (mail-dy1-f199.google.com\n [74.125.82.199])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c7qp9jqv0-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Tue, 10 Feb 2026 13:34:18 +0000 (GMT)", "by mail-dy1-f199.google.com with SMTP id\n 5a478bee46e88-2ba745f54c6so5132967eec.0\n for <qemu-devel@nongnu.org>; Tue, 10 Feb 2026 05:34:18 -0800 (PST)", "from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2ba7e149c58sm2716162eec.26.2026.02.10.05.34.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 10 Feb 2026 05:34:17 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n GexMtmgfGvMqUlr405tGcNusaInSecWFUKDx3/DCuI8=; b=mkJtRSBSlB+8+7pZ\n hmeJZk6inWTkDtR1a+SuX5VzyR9NNZmjjC2gZ+KcH1svuvSe5BFli4q15TfMvbFZ\n awCAutNA9/bArvVMDaD6GYQw+3k1GGJLtqfj8pVpHA7jVDbWlaXhBC//bdIhPID3\n n183vx5wdVkQhXSX1b55GMpTec9vSmu21STpsuSCXw+uwBQ3ScNPxLqznSfAp6vw\n KPH5+DrgkYdQkGOZ/ExD8ebcAyyAam0jFbqMC6jB1E6K5h4mzcGM+IEwHJsaUSwE\n mX3LNXt3mVdt3eXDogJOFlIx/Q3lA1WK1wwwz2HIj3VZdbZztbpg+tn7jn3GYXfh\n R/iiqA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1770730458; x=1771335258; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=GexMtmgfGvMqUlr405tGcNusaInSecWFUKDx3/DCuI8=;\n b=EMhKYVjY0rFijeJi6jW1sSGE+t5ehvgtUo8lXe2Q9mq4NFigBiXKOKGJ/eaKvqlIIp\n vsN0pZ5IC1rgw/9rXSxcs4KsTN6uluzx1D8Y7s8x2UpLXgt1+0+Wx+dWsqw15vrcchW1\n F/2DxxG40NA4J6bZ9NGMN8aY2zmnprSvLHggk+0gvmxbZgWa8h5SWs23f2X5fXX3jtp2\n SSG83bZMkA/tthxxbhUvUTOB1Ioz5yHmf9gV9ycpyGPsnn6fUxRFcH8/B/UoLP6IK3sA\n 1l1LNM+dppaip/whiiHL6zpNcUsR8tIsxFnSD32MpTqPLYM/9iYAGJxryW5sl2kI/fRa\n bBTA==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770730458; x=1771335258;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=GexMtmgfGvMqUlr405tGcNusaInSecWFUKDx3/DCuI8=;\n b=P2AwZQZ0PjVZXxLw0FxxVLmRhVuyGtthxZoWtJsLnPKjckkacMvKBOiFpTN6Uc75lH\n 2zOCkTJGRkOJK/7k2SXob3XnOxCYYLJppfO/GIs8hzmpbwIBQuvygSTJp3FOQ9BxwsMN\n sHYr85psXerU1UckqizaGuF2UwMogZ4/Fv2+h3rbDnmiKqRZEipHxkE3WS+jrOHzZPpc\n q9Is7UeXHVJfwu8aLMbIAukTKUOdxgFVnbQrbU9PJGvYF6OV0Gt8jJyeSq1omMdw/Vvf\n WzkhD+2QCa4ESN9iQJ+eMQ9au8o3HUfImGSTH5vG6gwQmMvl6SK6rR74hLtf4Anvtsg1\n zvqg==", "X-Gm-Message-State": "AOJu0YxThM7yJ2DdgyhIuaZGaZ+OiF5cQf99s3mXTJGYYcCb3r1cswMH\n hPV7siSCFZ3PCrmms6fYmCUwoLAK8bIuKzNQkaAyTi5uhM5MLKfTj0mezDOaxk0mrwS6GMyhbUR\n QXXzV3xBenMMX0wbGJ8skh8Ck3lWynGqFEkUaRamDc0nuqD7BC+mS9XXRdAHNqlz8Zg==", "X-Gm-Gg": "AZuq6aJSO1hUOGMRmqy1cuZurHSTVZtnCEbnynXGPLZN5wbwbQnkledEhAhbyabZwgi\n kTNhFkdix0T10OPF63+0XXbBUBxK5xh15pUDzsb5pUk4hDq0GE4+Dt3V8Zs4Fm9jEi5s8I4yLii\n 0DAw07pUpigpTRwuuB4MAWcNtZbmE5n2RQVZjpsVnkWfYcbjNm9kpeBbBbSrFG9om+ZfJ+aGv8I\n Yu/M6fRJ7jCmj1bWsRHK8zNBfXZpYnMrHBcC4hJ/JMo9lAHPuAOewJk+TPjx8/2rkZGltsgUwCz\n FqDZNiNBXqA004phQrT1knmq4nk32JOCP+sor1UIxteCQkf4Fhlm1j0HvUDTrIX1EKD3gt2fmb0\n CRRldMC7ZKoeOl+HH40+ahrS4DxRtG/W+2DtKoBR/51166nNoKUt4wDpE4lqiYprkUagBjQ==", "X-Received": [ "by 2002:a05:693c:37c7:b0:2b6:c617:f795 with SMTP id\n 5a478bee46e88-2b856486ab7mr6821721eec.17.1770730457955;\n Tue, 10 Feb 2026 05:34:17 -0800 (PST)", "by 2002:a05:693c:37c7:b0:2b6:c617:f795 with SMTP id\n 5a478bee46e88-2b856486ab7mr6821704eec.17.1770730457442;\n Tue, 10 Feb 2026 05:34:17 -0800 (PST)" ], "From": "Brian Cain <brian.cain@oss.qualcomm.com>", "To": "qemu-devel@nongnu.org", "Cc": "brian.cain@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex@alexrp.com,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>", "Subject": "[PATCH v3 2/4] target/hexagon: Return decode failure for invalid\n non-duplex encodings", "Date": "Tue, 10 Feb 2026 05:33:52 -0800", "Message-Id": "<20260210133355.16093-3-brian.cain@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260210133355.16093-1-brian.cain@oss.qualcomm.com>", "References": "<20260210133355.16093-1-brian.cain@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "X-Proofpoint-GUID": "9qw5PkAqcubCNGmDbsp3NtbiKwyMBv0s", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEwMDExNCBTYWx0ZWRfX/mTXFx9oHJFX\n rJTthrIPLtfJWU74yjx5rVKVlpVw1xg39DVAHQB8pWwpNnRWiR++IlQQ1XgLhNslMTDxRbW5lzG\n bC867KIO5jNl0VOWPriDy6RoVi5aMXuOTFeAO2/9jZPBPIgQcJ1Lo6CSgjVUMzbve5XovHDU1qz\n eBdbKYy1ikUxUwF+OcV0Nyj0UDJwKpZ4paLoBK16HGNb0/9C/523y4JiOu72ioCXoxH+M6nwK1R\n llJGNm8f63MW3fAW6RKQoGoBNMe/+bM/qRV24QFFnyfDlkiG6aJT1nHmTC9b9QuiBdH10Gf12v6\n wg2Q7EvFUV245EHEvo9e6mFdwe6NPeXK9Ucja1LSVEy6RKdqvsWoL2Mj9LuBxEJfE15sLB+XKkN\n 4c8Z3DUQJPUJ79phWfz2XiYr5Og4b693BZmSXYRdlwx6tcMnSrD1eQSr33j3lQzugiwSF4H2cGq\n Ft/LE1TeOAnphxRQypQ==", "X-Authority-Analysis": "v=2.4 cv=dP2rWeZb c=1 sm=1 tr=0 ts=698b33da cx=c_pps\n a=cFYjgdjTJScbgFmBucgdfQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22\n a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=D67r-eMCZ0zeLs--bqkA:9\n a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 a=cvBusfyB2V15izCimMoJ:22", "X-Proofpoint-ORIG-GUID": "9qw5PkAqcubCNGmDbsp3NtbiKwyMBv0s", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-10_01,2026-02-10_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0\n spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602100114", "Received-SPF": "pass client-ip=205.220.168.131;\n envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "When a non-duplex encoding (parse_bits != 0) fails both decode_normal()\nand decode_hvx(), the decoder hit an unreachable. Instead, handle\nthe decode failure and raise an exception.\n\nReviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\nReviewed-by: Taylor Simpson <ltaylorsimpson@gmail.com>\nSigned-off-by: Brian Cain <brian.cain@oss.qualcomm.com>\n---\n target/hexagon/decode.c | 3 ++-\n tests/tcg/hexagon/invalid-encoding.c | 25 +++++++++++++++++++++++++\n 2 files changed, 27 insertions(+), 1 deletion(-)", "diff": "diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c\nindex 69ba1ec96c..33ad60c5b4 100644\n--- a/target/hexagon/decode.c\n+++ b/target/hexagon/decode.c\n@@ -489,7 +489,8 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t encoding)\n insn->iclass = iclass_bits(encoding);\n return 1;\n }\n- g_assert_not_reached();\n+ /* Invalid non-duplex encoding */\n+ return 0;\n } else {\n uint32_t iclass = get_duplex_iclass(encoding);\n unsigned int slot0_subinsn = get_slot0_subinsn(encoding);\ndiff --git a/tests/tcg/hexagon/invalid-encoding.c b/tests/tcg/hexagon/invalid-encoding.c\nindex 010a5eb741..639d7f2495 100644\n--- a/tests/tcg/hexagon/invalid-encoding.c\n+++ b/tests/tcg/hexagon/invalid-encoding.c\n@@ -65,6 +65,30 @@ static int test_invalid_duplex(void)\n return sig;\n }\n \n+/*\n+ * Invalid non-duplex encoding:\n+ * The encoding 0xffffc000 has parse bits [15:14] = 0b11, making it a\n+ * non-duplex instruction and packet end. The remaining bits do not match\n+ * any valid normal or HVX instruction encoding, so this should raise SIGILL.\n+ */\n+static int test_invalid_nonduplex(void)\n+{\n+ int sig;\n+\n+ asm volatile(\n+ \"r0 = #0\\n\"\n+ \"r1 = ##1f\\n\"\n+ \"memw(%1) = r1\\n\"\n+ \".word 0xffffc000\\n\"\n+ \"1:\\n\"\n+ \"%0 = r0\\n\"\n+ : \"=r\"(sig)\n+ : \"r\"(&resume_pc)\n+ : \"r0\", \"r1\", \"memory\");\n+\n+ return sig;\n+}\n+\n int main()\n {\n struct sigaction act;\n@@ -75,6 +99,7 @@ int main()\n assert(sigaction(SIGILL, &act, NULL) == 0);\n \n assert(test_invalid_duplex() == SIGILL);\n+ assert(test_invalid_nonduplex() == SIGILL);\n \n puts(\"PASS\");\n return EXIT_SUCCESS;\n", "prefixes": [ "v3", "2/4" ] }