Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195106/?format=api
{ "id": 2195106, "url": "http://patchwork.ozlabs.org/api/patches/2195106/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/patch/20260210125749.702695-1-amusil@redhat.com/", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210125749.702695-1-amusil@redhat.com>", "list_archive_url": null, "date": "2026-02-10T12:57:49", "name": "[ovs-dev] neighbor: Skip Advertised MAC bindings with NULL logical ports.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d68f30d68eb21109b65a490705fdb87390bdc79a", "submitter": { "id": 83634, "url": "http://patchwork.ozlabs.org/api/people/83634/?format=api", "name": "Ales Musil", "email": "amusil@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ovn/patch/20260210125749.702695-1-amusil@redhat.com/mbox/", "series": [ { "id": 491670, "url": "http://patchwork.ozlabs.org/api/series/491670/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/list/?series=491670", "date": "2026-02-10T12:57:49", "name": "[ovs-dev] neighbor: Skip Advertised MAC bindings with NULL logical ports.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491670/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195106/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/2195106/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KeA4IiS+;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)", "smtp3.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KeA4IiS+", "smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "smtp2.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=KeA4IiS+" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9M6y4V64z1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 23:58:02 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 9EFF060B10;\n\tTue, 10 Feb 2026 12:58:00 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id vRQI09yWzxu7; Tue, 10 Feb 2026 12:57:59 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 156BE60AB8;\n\tTue, 10 Feb 2026 12:57:59 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id D446DC077F;\n\tTue, 10 Feb 2026 12:57:58 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id E7DE3C077E\n for <dev@openvswitch.org>; Tue, 10 Feb 2026 12:57:57 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id D7E3240751\n for <dev@openvswitch.org>; Tue, 10 Feb 2026 12:57:57 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id sX1HIbcHliHf for <dev@openvswitch.org>;\n Tue, 10 Feb 2026 12:57:57 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp2.osuosl.org (Postfix) with ESMTPS id B9E1E40166\n for <dev@openvswitch.org>; Tue, 10 Feb 2026 12:57:55 +0000 (UTC)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-424-a5W01ce3OgiZByzur5qCYA-1; Tue,\n 10 Feb 2026 07:57:53 -0500", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 421C71956088\n for <dev@openvswitch.org>; Tue, 10 Feb 2026 12:57:52 +0000 (UTC)", "from amusil.brq.redhat.com (unknown [10.43.17.233])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 26E8130001A8; Tue, 10 Feb 2026 12:57:50 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 156BE60AB8", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org B9E1E40166" ], "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=amusil@redhat.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org B9E1E40166", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770728274;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=L3CWa+rHH9AW6dCujXkAyRbGJ4h5qSNweFMQe3+my5c=;\n b=KeA4IiS+FQyQ5QTdl9UpHxMTWmmTc7dBg01E4nFi2mLdP1pmtorzezjH634ZRIsvf76PPS\n U+WnuZa0EJDtGIbyk8M1KHst0AvsrDzrJLBDBpq8EQDSt4fJl+TaUmjyT8d14kTnT1/YGL\n OpI5KksqRGfIQ5q4i/mGRNr7ub42x7A=", "X-MC-Unique": "a5W01ce3OgiZByzur5qCYA-1", "X-Mimecast-MFC-AGG-ID": "a5W01ce3OgiZByzur5qCYA_1770728272", "To": "dev@openvswitch.org", "Date": "Tue, 10 Feb 2026 13:57:49 +0100", "Message-ID": "<20260210125749.702695-1-amusil@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "sPpPkE8iZwJFyfWCZBzMaoRja3xnV5RVnHsCzYUVm98_1770728272", "X-Mimecast-Originator": "redhat.com", "Subject": "[ovs-dev] [PATCH ovn] neighbor: Skip Advertised MAC bindings with\n NULL logical ports.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "From": "Ales Musil via dev <ovs-dev@openvswitch.org>", "Reply-To": "Ales Musil <amusil@redhat.com>", "Cc": "dceara@redhat.com", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "The logical ports are always populated at the database level.\nHowever, when conditional monitoring is enabled it can happen\nafter ovn-controller starts that we will get Advertised MAC\nbinding rows with LSPs that are not yet monitored. This results\nin IDL setting the pointer as NULL. Which results in a crash\nas we try to deref the NULL pointer:\n\n\tneighbor_get_relevant_port_binding.lto_priv.0 (ovn-controller + 0x4fc8f)\n en_neighbor_run.lto_priv.0 (ovn-controller + 0x87512)\n engine_recompute (ovn-controller + 0xc9e20)\n engine_run (ovn-controller + 0xca175)\n main (ovn-controller + 0x289aa)\n\nTo prevent that skip the entries with NULL logical_port, we will\nrun the node again when the LSPs are actually monitored.\n\nFixes: 499ddafbf160 (\"controller: Advertise local EVPN type2 routes in ovn-controller.\")\nReported-at: https://issues.redhat.com/browse/FDP-3100\nSigned-off-by: Ales Musil <amusil@redhat.com>\n---\n controller/neighbor.c | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/controller/neighbor.c b/controller/neighbor.c\nindex e77b41d29..eae5eadb2 100644\n--- a/controller/neighbor.c\n+++ b/controller/neighbor.c\n@@ -314,6 +314,13 @@ neighbor_collect_ip_mac_to_advertise(\n const struct sbrec_advertised_mac_binding *adv_mb;\n SBREC_ADVERTISED_MAC_BINDING_FOR_EACH_EQUAL (adv_mb, target,\n n_ctx_in->sbrec_amb_by_dp) {\n+ if (!adv_mb->logical_port) {\n+ /* Skip the NULL logical_port, this can happen in some cases\n+ * during controller startup. See\n+ * https://issues.redhat.com/browse/FDP-3114 for more details. */\n+ continue;\n+ }\n+\n const struct sbrec_port_binding *pb =\n neighbor_get_relevant_port_binding(n_ctx_in->sbrec_pb_by_name,\n adv_mb->logical_port);\n", "prefixes": [ "ovs-dev" ] }