Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195085/?format=api
{ "id": 2195085, "url": "http://patchwork.ozlabs.org/api/patches/2195085/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210121657.69363-5-mjt@tls.msk.ru/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210121657.69363-5-mjt@tls.msk.ru>", "list_archive_url": null, "date": "2026-02-10T12:16:38", "name": "[Stable-10.0.8,74/85] hw/i2c/aspeed: Fix wrong I2CC_DMA_LEN when I2CM_DMA_TX/RX_ADDR set first", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "364b233b9446f60c73738323ae9d2ef1acfceb27", "submitter": { "id": 183, "url": "http://patchwork.ozlabs.org/api/people/183/?format=api", "name": "Michael Tokarev", "email": "mjt@tls.msk.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210121657.69363-5-mjt@tls.msk.ru/mbox/", "series": [ { "id": 491663, "url": "http://patchwork.ozlabs.org/api/series/491663/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491663", "date": "2026-02-10T12:16:40", "name": "Patch Round-up for stable 10.0.8, freeze on 2026-02-10 (frozen)", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491663/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195085/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195085/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9LNK1dlqz1xtr\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 23:24:33 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpmjb-0002wv-4O; Tue, 10 Feb 2026 07:20:51 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mjt@tls.msk.ru>)\n id 1vpmiB-0007WC-UC; Tue, 10 Feb 2026 07:19:31 -0500", "from isrv.corpit.ru ([212.248.84.144])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mjt@tls.msk.ru>)\n id 1vpmi9-0001c0-1v; Tue, 10 Feb 2026 07:19:23 -0500", "from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2])\n by isrv.corpit.ru (Postfix) with ESMTP id 8CADD187DDE;\n Tue, 10 Feb 2026 15:16:17 +0300 (MSK)", "from think4mjt.tls.msk.ru (mjtthink.wg.tls.msk.ru [192.168.177.146])\n by tsrv.corpit.ru (Postfix) with ESMTP id 29ECC360CF2;\n Tue, 10 Feb 2026 15:17:13 +0300 (MSK)" ], "From": "Michael Tokarev <mjt@tls.msk.ru>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-stable@nongnu.org, Jamin Lin <jamin_lin@aspeedtech.com>,\n\t=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@redhat.com>,\n Michael Tokarev <mjt@tls.msk.ru>", "Subject": "[Stable-10.0.8 74/85] hw/i2c/aspeed: Fix wrong I2CC_DMA_LEN when\n I2CM_DMA_TX/RX_ADDR set first", "Date": "Tue, 10 Feb 2026 15:16:38 +0300", "Message-ID": "<20260210121657.69363-5-mjt@tls.msk.ru>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<qemu-stable-10.0.8-20260210151548@cover.tls.msk.ru>", "References": "<qemu-stable-10.0.8-20260210151548@cover.tls.msk.ru>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru;\n helo=isrv.corpit.ru", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Jamin Lin <jamin_lin@aspeedtech.com>\n\nIn the previous design, the I2C model would update I2CC_DMA_LEN (0x54) based on\nthe value of I2CM_DMA_LEN (0x1C) when the firmware set either I2CM_DMA_TX_ADDR\n(0x30) or I2CM_DMA_RX_ADDR (0x34). However, this only worked correctly if the\nfirmware set I2CM_DMA_LEN before setting I2CM_DMA_TX_ADDR or I2CM_DMA_RX_ADDR.\n\nIf the firmware instead set I2CM_DMA_TX_ADDR or I2CM_DMA_RX_ADDR before setting\nI2CM_DMA_LEN, the value written to I2CC_DMA_LEN would be incorrect.\n\nTo fix this issue, the model should be updated to set I2CC_DMA_LEN when the\nfirmware writes to the I2CM_DMA_LEN register, rather than when it writes to the\nI2CM_DMA_RX_ADDR and I2CM_DMA_TX_ADDR registers.\n\nSigned-off-by: Jamin Lin <jamin_lin@aspeedtech.com>\nFixes: ba2cccd64e90 (\"aspeed: i2c: Add new mode support\")\nReviewed-by: Cédric Le Goater <clg@redhat.com>\nLink: https://lore.kernel.org/qemu-devel/20260102090746.1130033-4-jamin_lin@aspeedtech.com\nSigned-off-by: Cédric Le Goater <clg@redhat.com>\n(cherry picked from commit 9cbd8ee7f67fceee51d3c993a282e5adc397b6b9)\nSigned-off-by: Michael Tokarev <mjt@tls.msk.ru>", "diff": "diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c\nindex 127f8b8a0d..3f2e23f457 100644\n--- a/hw/i2c/aspeed_i2c.c\n+++ b/hw/i2c/aspeed_i2c.c\n@@ -660,8 +660,6 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus, hwaddr offset,\n bus->dma_dram_offset =\n deposit64(bus->dma_dram_offset, 0, 32,\n FIELD_EX32(value, I2CM_DMA_TX_ADDR, ADDR));\n- bus->regs[R_I2CC_DMA_LEN] = ARRAY_FIELD_EX32(bus->regs, I2CM_DMA_LEN,\n- TX_BUF_LEN) + 1;\n break;\n case A_I2CM_DMA_RX_ADDR:\n bus->regs[R_I2CM_DMA_RX_ADDR] = FIELD_EX32(value, I2CM_DMA_RX_ADDR,\n@@ -669,8 +667,6 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus, hwaddr offset,\n bus->dma_dram_offset =\n deposit64(bus->dma_dram_offset, 0, 32,\n FIELD_EX32(value, I2CM_DMA_RX_ADDR, ADDR));\n- bus->regs[R_I2CC_DMA_LEN] = ARRAY_FIELD_EX32(bus->regs, I2CM_DMA_LEN,\n- RX_BUF_LEN) + 1;\n break;\n case A_I2CM_DMA_LEN:\n w1t = FIELD_EX32(value, I2CM_DMA_LEN, RX_BUF_LEN_W1T) ||\n@@ -683,10 +679,16 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus, hwaddr offset,\n if (FIELD_EX32(value, I2CM_DMA_LEN, RX_BUF_LEN_W1T)) {\n ARRAY_FIELD_DP32(bus->regs, I2CM_DMA_LEN, RX_BUF_LEN,\n FIELD_EX32(value, I2CM_DMA_LEN, RX_BUF_LEN));\n+ bus->regs[R_I2CC_DMA_LEN] = ARRAY_FIELD_EX32(bus->regs,\n+ I2CM_DMA_LEN,\n+ RX_BUF_LEN) + 1;\n }\n if (FIELD_EX32(value, I2CM_DMA_LEN, TX_BUF_LEN_W1T)) {\n ARRAY_FIELD_DP32(bus->regs, I2CM_DMA_LEN, TX_BUF_LEN,\n FIELD_EX32(value, I2CM_DMA_LEN, TX_BUF_LEN));\n+ bus->regs[R_I2CC_DMA_LEN] = ARRAY_FIELD_EX32(bus->regs,\n+ I2CM_DMA_LEN,\n+ TX_BUF_LEN) + 1;\n }\n break;\n case A_I2CM_DMA_LEN_STS:\n", "prefixes": [ "Stable-10.0.8", "74/85" ] }