Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195079/?format=api
{ "id": 2195079, "url": "http://patchwork.ozlabs.org/api/patches/2195079/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210121526.68598-3-mjt@tls.msk.ru/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210121526.68598-3-mjt@tls.msk.ru>", "list_archive_url": null, "date": "2026-02-10T12:14:59", "name": "[Stable-10.1.4,77/95] hw/adc: Fix out-of-bounds write in Aspeed ADC model", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0154c3fa95fcb06071501177a3632164e51ddd14", "submitter": { "id": 183, "url": "http://patchwork.ozlabs.org/api/people/183/?format=api", "name": "Michael Tokarev", "email": "mjt@tls.msk.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210121526.68598-3-mjt@tls.msk.ru/mbox/", "series": [ { "id": 491662, "url": "http://patchwork.ozlabs.org/api/series/491662/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491662", "date": "2026-02-10T12:14:58", "name": "Patch Round-up for stable 10.1.4, freeze on 2026-02-10 (frozen)", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491662/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195079/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195079/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9LLt4WyLz1xtr\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 23:23:18 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpmhh-0006N9-Ls; Tue, 10 Feb 2026 07:18:54 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mjt@tls.msk.ru>)\n id 1vpmff-0002LK-L5; Tue, 10 Feb 2026 07:16:51 -0500", "from isrv.corpit.ru ([212.248.84.144])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mjt@tls.msk.ru>)\n id 1vpmfc-0000YT-1x; Tue, 10 Feb 2026 07:16:47 -0500", "from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2])\n by isrv.corpit.ru (Postfix) with ESMTP id 44590187DB5;\n Tue, 10 Feb 2026 15:14:46 +0300 (MSK)", "from think4mjt.tls.msk.ru (mjtthink.wg.tls.msk.ru [192.168.177.146])\n by tsrv.corpit.ru (Postfix) with ESMTP id D3F09360CDA;\n Tue, 10 Feb 2026 15:15:41 +0300 (MSK)" ], "From": "Michael Tokarev <mjt@tls.msk.ru>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-stable@nongnu.org,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@redhat.com>,\n Elhrj Saad <saadelhrj@gmail.com>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Michael Tokarev <mjt@tls.msk.ru>", "Subject": "[Stable-10.1.4 77/95] hw/adc: Fix out-of-bounds write in Aspeed ADC\n model", "Date": "Tue, 10 Feb 2026 15:14:59 +0300", "Message-ID": "<20260210121526.68598-3-mjt@tls.msk.ru>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<qemu-stable-10.1.4-20260210151454@cover.tls.msk.ru>", "References": "<qemu-stable-10.1.4-20260210151454@cover.tls.msk.ru>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru;\n helo=isrv.corpit.ru", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Cédric Le Goater <clg@redhat.com>\n\nThe 'regs' array has ASPEED_ADC_NR_REGS (52) elements, while the\nmemory region covers offsets 0x00-0xFC. The aspeed_adc_engine_write()\nfunction has an out-of-bounds write vulnerability when accessing\nunimplemented registers.\n\nFix this by using 'return' instead of 'break' in the default case,\nwhich prevents execution from reaching the s->regs[reg] assignment for\nunimplemented registers.\n\nReported-by: Elhrj Saad <saadelhrj@gmail.com>\nFixes: 5857974d5d11 (\"hw/adc: Add basic Aspeed ADC model\")\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nLink: https://lore.kernel.org/qemu-devel/20260126141820.719492-1-clg@redhat.com\nSigned-off-by: Cédric Le Goater <clg@redhat.com>\n(cherry picked from commit 4c6521296d2b6820ab1f8c59d3a80cd0c138b2d8)\nSigned-off-by: Michael Tokarev <mjt@tls.msk.ru>", "diff": "diff --git a/hw/adc/aspeed_adc.c b/hw/adc/aspeed_adc.c\nindex 3e820cae1e..5f2b8566f5 100644\n--- a/hw/adc/aspeed_adc.c\n+++ b/hw/adc/aspeed_adc.c\n@@ -228,7 +228,8 @@ static void aspeed_adc_engine_write(void *opaque, hwaddr addr, uint64_t value,\n qemu_log_mask(LOG_UNIMP, \"%s: engine[%u]: \"\n \"0x%\" HWADDR_PRIx \" 0x%\" PRIx64 \"\\n\",\n __func__, s->engine_id, addr, value);\n- break;\n+ /* Do not update the regs[] array */\n+ return;\n }\n \n s->regs[reg] = value;\n", "prefixes": [ "Stable-10.1.4", "77/95" ] }