Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2195053/?format=api
{ "id": 2195053, "url": "http://patchwork.ozlabs.org/api/patches/2195053/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210121438.67781-17-mjt@tls.msk.ru/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210121438.67781-17-mjt@tls.msk.ru>", "list_archive_url": null, "date": "2026-02-10T12:14:26", "name": "[Stable-10.2.1,73/78] virtio-gpu: fix error handling in virgl_cmd_resource_create_blob", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7e38fab10803ec3c40b44a11b9f9252e96943289", "submitter": { "id": 183, "url": "http://patchwork.ozlabs.org/api/people/183/?format=api", "name": "Michael Tokarev", "email": "mjt@tls.msk.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210121438.67781-17-mjt@tls.msk.ru/mbox/", "series": [ { "id": 491661, "url": "http://patchwork.ozlabs.org/api/series/491661/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491661", "date": "2026-02-10T12:14:13", "name": "Patch Round-up for stable 10.2.1, freeze on 2026-02-10 (frozen)", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491661/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2195053/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2195053/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9LGz312Rz1xwN\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 23:19:55 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpmfU-0002Bm-K3; Tue, 10 Feb 2026 07:16:41 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mjt@tls.msk.ru>)\n id 1vpmev-0001ZX-3p; Tue, 10 Feb 2026 07:16:02 -0500", "from isrv.corpit.ru ([212.248.84.144])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mjt@tls.msk.ru>)\n id 1vpmet-0000JZ-CY; Tue, 10 Feb 2026 07:16:00 -0500", "from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2])\n by isrv.corpit.ru (Postfix) with ESMTP id C9906187DAB;\n Tue, 10 Feb 2026 15:13:52 +0300 (MSK)", "from think4mjt.tls.msk.ru (mjtthink.wg.tls.msk.ru [192.168.177.146])\n by tsrv.corpit.ru (Postfix) with ESMTP id 619D8360CCD;\n Tue, 10 Feb 2026 15:14:48 +0300 (MSK)" ], "From": "Michael Tokarev <mjt@tls.msk.ru>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-stable@nongnu.org, Honglei Huang <honghuan@amd.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Dmitry Osipenko <dmitry.osipenko@collabora.com>, =?utf-8?q?Philippe_Mathieu?=\n\t=?utf-8?q?-Daud=C3=A9?= <philmd@linaro.org>,\n \"Michael S. Tsirkin\" <mst@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>", "Subject": "[Stable-10.2.1 73/78] virtio-gpu: fix error handling in\n virgl_cmd_resource_create_blob", "Date": "Tue, 10 Feb 2026 15:14:26 +0300", "Message-ID": "<20260210121438.67781-17-mjt@tls.msk.ru>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<qemu-stable-10.2.1-20260210151332@cover.tls.msk.ru>", "References": "<qemu-stable-10.2.1-20260210151332@cover.tls.msk.ru>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru;\n helo=isrv.corpit.ru", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Honglei Huang <honghuan@amd.com>\n\nFix inverted error check in virgl_cmd_resource_create_blob() that causes\nthe function to return error when virtio_gpu_create_mapping_iov() succeeds.\n\nvirtio_gpu_create_mapping_iov() returns 0 on success and negative values\non error. The check 'if (!ret)' incorrectly treats success (ret=0) as an\nerror condition, causing the function to fail when it should succeed.\n\nChange the condition to 'if (ret != 0)' to properly detect errors.\n\nFixes: 7c092f17ccee (\"virtio-gpu: Handle resource blob commands\")\nSigned-off-by: Honglei Huang <honghuan@amd.com>\nReviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>\nReviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Michael S. Tsirkin <mst@redhat.com>\nSigned-off-by: Michael S. Tsirkin <mst@redhat.com>\nMessage-Id: <20260113015203.3643608-2-honghuan@amd.com>\n(cherry picked from commit 3560b51979577afc3ab937fd8b02597515bdfbae)\nSigned-off-by: Michael Tokarev <mjt@tls.msk.ru>", "diff": "diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c\nindex 6a83fb63c8..741728cabb 100644\n--- a/hw/display/virtio-gpu-virgl.c\n+++ b/hw/display/virtio-gpu-virgl.c\n@@ -705,7 +705,7 @@ static void virgl_cmd_resource_create_blob(VirtIOGPU *g,\n ret = virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(cblob),\n cmd, &res->base.addrs,\n &res->base.iov, &res->base.iov_cnt);\n- if (!ret) {\n+ if (ret != 0) {\n cmd->error = VIRTIO_GPU_RESP_ERR_UNSPEC;\n return;\n }\n", "prefixes": [ "Stable-10.2.1", "73/78" ] }