Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194883/?format=api
{ "id": 2194883, "url": "http://patchwork.ozlabs.org/api/patches/2194883/?format=api", "web_url": "http://patchwork.ozlabs.org/project/fwts/patch/20260210062704.124073-1-ivan.hu@canonical.com/", "project": { "id": 24, "url": "http://patchwork.ozlabs.org/api/projects/24/?format=api", "name": "Firmware Test Suite development", "link_name": "fwts", "list_id": "fwts-devel.lists.ubuntu.com", "list_email": "fwts-devel@lists.ubuntu.com", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210062704.124073-1-ivan.hu@canonical.com>", "list_archive_url": null, "date": "2026-02-10T06:27:04", "name": "acpi: srat: Fix Memory Affinity Structure flags validation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c904ca32b18cd74fd79ec1117137af69cb8b0da1", "submitter": { "id": 14061, "url": "http://patchwork.ozlabs.org/api/people/14061/?format=api", "name": "Ivan Hu", "email": "ivan.hu@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/fwts/patch/20260210062704.124073-1-ivan.hu@canonical.com/mbox/", "series": [ { "id": 491610, "url": "http://patchwork.ozlabs.org/api/series/491610/?format=api", "web_url": "http://patchwork.ozlabs.org/project/fwts/list/?series=491610", "date": "2026-02-10T06:27:04", "name": "acpi: srat: Fix Memory Affinity Structure flags validation", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491610/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194883/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194883/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<fwts-devel-bounces@lists.ubuntu.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=UbO2/wxV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=fwts-devel-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f9BS73XL0z1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 17:27:18 +1100 (AEDT)", "from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from <fwts-devel-bounces@lists.ubuntu.com>)\n\tid 1vphDJ-0005zQ-Bn; Tue, 10 Feb 2026 06:27:09 +0000", "from smtp-relay-internal-0.internal ([10.131.114.225]\n helo=smtp-relay-internal-0.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from <ivan.hu@canonical.com>)\n id 1vphDI-0005zJ-F1\n for fwts-devel@lists.ubuntu.com; Tue, 10 Feb 2026 06:27:08 +0000", "from mail-pj1-f72.google.com (mail-pj1-f72.google.com\n [209.85.216.72])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 588363F164\n for <fwts-devel@lists.ubuntu.com>; Tue, 10 Feb 2026 06:27:08 +0000 (UTC)", "by mail-pj1-f72.google.com with SMTP id\n 98e67ed59e1d1-352de7a89e1so583005a91.1\n for <fwts-devel@lists.ubuntu.com>; Mon, 09 Feb 2026 22:27:08 -0800 (PST)", "from canonical.com (118-163-61-247.hinet-ip.hinet.net.\n [118.163.61.247]) by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c6dcb4fb24dsm10299324a12.7.2026.02.09.22.27.05\n for <fwts-devel@lists.ubuntu.com>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 09 Feb 2026 22:27:06 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1770704828;\n bh=6LsOm2TTlfeYUf2kMCb42QZcpM/eI+hjnW1BqANxfzE=;\n h=From:To:Subject:Date:Message-ID:MIME-Version;\n b=UbO2/wxV0ElAWmu1A1fbZTcMbQhbUsoV5qoFX5sPQnrLluV7iUjFwy8nZMXuqb5eR\n wrTkrc4pnhOJj5ZHJuEjWRYIeHwLNXCTZV2754ejsRxjMUdnN2wOysLXdizVSNtglX\n 8SewRxw5rSoujGr68o7/NzDb1E5/GDKY3repAIM4oA8dSLgEKDDXJ7v18wYC0vep5e\n XWT37o1wTEsl4jt60C9/i9NAaK86sXhivItXu02WUG8pNfy1zU89kuYn/zEpluV53i\n jJOI0j8W/zvpYBYzcCiTLvtlg7W6ZOcumuPynAgf57C2TX2j14cLWeUVYO31aFCaoq\n eRnc64qBOew0dKpWGK6iWvAZFql+7A6/GbO3SWXW8LoAK1OsJyDrGS/ATuDkA6vM5S\n N3GTjy9bgn5V5xm4SII/5mcmXw9rWwLyN3+OUh+mPKqjbjYyQG00duVFR2m/01z8jR\n KzpAVwyOObs5bb4eneyhOY4HpjyJASVigh9J6n+ucEyHHUuda99XRZ/2U1BSIz60mA\n wShy7Yy8+cxDSUVISkPsuxyoA+MUzDmlYMZAHoNBpMP6g9c1VLq8/kn7dJforQ1ZxP\n 9lpJ8osVlIq2U69Xr6a/HkTb2dOKmmjAISCGfzLxIBwn5WZSlunfubPiLlwJIzMTn0\n Jq8T9v05Vrt6+X5fPdXZPskM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770704827; x=1771309627;\n h=content-transfer-encoding:mime-version:message-id:date:subject:to\n :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=6LsOm2TTlfeYUf2kMCb42QZcpM/eI+hjnW1BqANxfzE=;\n b=QBI/YkjMtsh1wfgo3tH7TjgM7nXJXmA4t9ewmQQdQVLjTNzKCTfV8GJditIU+4MDtb\n +bxUU9lyxCVq8Vp/raYmvD0K4m8vMBdYU6KYFLdMImuRFZ9DLgW24uysVWcb0AgvE7CR\n QV0n92lzWMPXrDq67B7dTdrTRuOcAKnMXKJa/XcwkXSf8C7OjIaOvWkc17DfDYP5ObCi\n Uswr2oqPN5sn4p5fJkuzS+0Hn/BkKRe62J0rOha9vS2fy900UltKvu9m+joozbhIUbw9\n kIhFauj0ECA+SjFBEd9lRWgSp6HBARYsWBiZUfiamItBJV2vBi4o//9NuR+1qp+2SiFe\n tklA==", "X-Gm-Message-State": "AOJu0Yy2NTJ9jRLN98rm5eyXDkv2yBeNfTsFRnPBkdKIHBfwCU04K+DN\n oD/X7wQkI7M4suFYReXfxincAtvMmUky9OWgPt+JQ7pvdm0HfW2hz9++hfcTlJRlp9PVKRqMxQq\n Bpla99sxE0DrMb8tHG+QxzjMB/o7DwxXzVmdYYYqO31OWNuxcxMriZSkENfCa338/+ezt0P5O/B\n Tcvb1Q4Spjctxg", "X-Gm-Gg": "AZuq6aL5FqO8nMJydqBwRrynh8AGWSI1q1rJNG31SHgY6gyPr/rR7ZFyIgO+H3eV8jx\n yQnwzrcSwGp1B3uLAKRgzOiVNjBgRkQ5Cnw8P7SPC9Vw3ld4PMCYzu9IuHJ7GtVd4pSYKLxVa6r\n jMt+Y+dauERSFdUha7mYDciosLAjiqOYm7E9JjqEip2XKMatuo23F3KBA6GN5NOl6VjxkS3mwwe\n rfYJf3/pLFp33B0uvXJe80QnhmX3DH+CB72Dg0GMO5nqsM/QZu+98xTC/uOe071yLzWVca/4NFl\n 9LegvJ8Ocuh3oukss/Gw81lO/D/pWGe+gBr/37CQGq05DNKh+51KfyK5jfG7X8DPAQFbI+5T+Eb\n xyC3IqzLRx6Xay9fO4yb8L4vNTsYjGsIOjMNQfhHJXXg8qou0y/Y6BCJ8I+L3bQ==", "X-Received": [ "by 2002:a17:90b:2d44:b0:355:35b0:8b83 with SMTP id\n 98e67ed59e1d1-35535b08eefmr8346931a91.33.1770704826826;\n Mon, 09 Feb 2026 22:27:06 -0800 (PST)", "by 2002:a17:90b:2d44:b0:355:35b0:8b83 with SMTP id\n 98e67ed59e1d1-35535b08eefmr8346923a91.33.1770704826449;\n Mon, 09 Feb 2026 22:27:06 -0800 (PST)" ], "From": "Ivan Hu <ivan.hu@canonical.com>", "To": "fwts-devel@lists.ubuntu.com", "Subject": "[PATCH] acpi: srat: Fix Memory Affinity Structure flags validation", "Date": "Tue, 10 Feb 2026 14:27:04 +0800", "Message-ID": "<20260210062704.124073-1-ivan.hu@canonical.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "X-BeenThere": "fwts-devel@lists.ubuntu.com", "X-Mailman-Version": "2.1.20", "Precedence": "list", "List-Id": "Firmware Test Suite Development <fwts-devel.lists.ubuntu.com>", "List-Unsubscribe": "<https://lists.ubuntu.com/mailman/options/fwts-devel>,\n <mailto:fwts-devel-request@lists.ubuntu.com?subject=unsubscribe>", "List-Archive": "<https://lists.ubuntu.com/archives/fwts-devel>", "List-Post": "<mailto:fwts-devel@lists.ubuntu.com>", "List-Help": "<mailto:fwts-devel-request@lists.ubuntu.com?subject=help>", "List-Subscribe": "<https://lists.ubuntu.com/mailman/listinfo/fwts-devel>,\n <mailto:fwts-devel-request@lists.ubuntu.com?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "fwts-devel-bounces@lists.ubuntu.com", "Sender": "\"fwts-devel\" <fwts-devel-bounces@lists.ubuntu.com>" }, "content": "BugLink: https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/2138894\n\nIn ACPI spec 6.6, bit 3 of the Memory Affinity Structure Flags field\nis defined as 'Specific-Purpose' and is not reserved. This bit indicates\nwhether memory is intended for specific-purpose usage, which is\nfunctionally analogous to the UEFI EFI_MEMORY_SP attribute.\n\nUpdate the reserved bits check to start from bit 4 instead of bit 3,\nallowing bit 3 to be set without triggering a false failure.\n\nThe flags field bits are now:\n- Bit 0: Enabled\n- Bit 1: Hot-pluggable\n- Bit 2: Non-volatile\n- Bit 3: Specific-Purpose (new in ACPI 6.6)\n- Bits 4-31: Reserved\n\nSigned-off-by: Ivan Hu <ivan.hu@canonical.com>\n---\n src/acpi/srat/srat.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/acpi/srat/srat.c b/src/acpi/srat/srat.c\nindex 926008b9..2ebc195c 100644\n--- a/src/acpi/srat/srat.c\n+++ b/src/acpi/srat/srat.c\n@@ -122,7 +122,7 @@ static void srat_check_memory_affinity(\n \tfwts_log_info_simp_int(fw, \" Reserved: \", affinity->reserved3);\n \tfwts_log_nl(fw);\n \n-\tfwts_acpi_reserved_bits(\"SRAT\", \"Memory Affinity Flags\", affinity->flags, 3, 31, passed);\n+\tfwts_acpi_reserved_bits(\"SRAT\", \"Memory Affinity Flags\", affinity->flags, 4, 31, passed);\n \n done:\n \t*length -= sizeof(fwts_acpi_table_memory_affinity);\n", "prefixes": [] }