Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194852/?format=api
{ "id": 2194852, "url": "http://patchwork.ozlabs.org/api/patches/2194852/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-13-zhao1.liu@intel.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210032348.987549-13-zhao1.liu@intel.com>", "list_archive_url": null, "date": "2026-02-10T03:23:39", "name": "[v2,12/21] qom/object_interfaces: mark properties set from qdict & keyval as USER_SET", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2ea5d9d9665d78fb4e2e9ad41683c3063b1b3f53", "submitter": { "id": 86545, "url": "http://patchwork.ozlabs.org/api/people/86545/?format=api", "name": "Zhao Liu", "email": "zhao1.liu@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-13-zhao1.liu@intel.com/mbox/", "series": [ { "id": 491594, "url": "http://patchwork.ozlabs.org/api/series/491594/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491594", "date": "2026-02-10T03:23:28", "name": "qom: introduce property flags to track external user input", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491594/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194852/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194852/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=fm3vlcMf;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f95sg3NCfz1xvb\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 14:00:39 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpdyV-0008Ap-LL; Mon, 09 Feb 2026 21:59:39 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdyC-0007cW-78\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:59:23 -0500", "from mgamail.intel.com ([198.175.65.14])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdy4-00049n-HP\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:59:14 -0500", "from orviesa008.jf.intel.com ([10.64.159.148])\n by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Feb 2026 18:59:11 -0800", "from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.39])\n by orviesa008.jf.intel.com with ESMTP; 09 Feb 2026 18:59:07 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1770692352; x=1802228352;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=rAeHvQ95Jt0xFH0E5qmmEaDICDO2TzPR3PyWD5EoqLc=;\n b=fm3vlcMfkhZU9o6NQkuzhrTyTK00+1ocnP7MyEIfBydKoEMgj4XRVJoi\n KQMQkc3POfKcLvzgPFIyAFqZ5B9cXGzWd72N17pza8UkQWXeosaKndnuV\n 9mphdnaUna4HTjFRd4/zYQIbNDwEqo6atPUx2GOGHTB0q6CW67X8rXJNd\n idtfXoCxALwsAyNqsSUZD7SMcYRlH8d/lrPAJrO54eXLZ3TOIZJofL+/+\n odL2x7U1kdEr+s3DphoK8Fk/NdGMXaizyn1dGCwGr3cfkU0amPDNyFVoI\n GxP9BRDMTpg9plm7c9JuoqaD/gGEnSoDKaXyEe7wF2FZIHJTx20nBWEY9 g==;", "X-CSE-ConnectionGUID": [ "2F4fN9u8QaOkbmtk43reYw==", "mPc096nsQw6f2k2CIWWXkg==" ], "X-CSE-MsgGUID": [ "aoMPVT5GTwytirNpUde92Q==", "uPjqpBA5TT2tIveyVnwgwQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11696\"; a=\"75659928\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"75659928\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"211800661\"" ], "X-ExtLoop1": "1", "From": "Zhao Liu <zhao1.liu@intel.com>", "To": "Paolo Bonzini <pbonzini@redhat.com>, =?utf-8?q?Daniel_P_=2E_Berrang?=\n\t=?utf-8?q?=C3=A9?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Markus Armbruster <armbru@redhat.com>,\n Thomas Huth <thuth@redhat.com>, Igor Mammedov <imammedo@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n \"Michael S . Tsirkin\" <mst@redhat.com>,\n BALATON Zoltan <balaton@eik.bme.hu>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Zide Chen <zide.chen@intel.com>, Dapeng Mi <dapeng1.mi@linux.intel.com>,\n Zhao Liu <zhao1.liu@intel.com>, qemu-devel@nongnu.org,\n devel@lists.libvirt.org", "Subject": "[PATCH v2 12/21] qom/object_interfaces: mark properties set from\n qdict & keyval as USER_SET", "Date": "Tue, 10 Feb 2026 11:23:39 +0800", "Message-Id": "<20260210032348.987549-13-zhao1.liu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260210032348.987549-1-zhao1.liu@intel.com>", "References": "<20260210032348.987549-1-zhao1.liu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=198.175.65.14; envelope-from=zhao1.liu@intel.com;\n helo=mgamail.intel.com", "X-Spam_score_int": "-43", "X-Spam_score": "-4.4", "X-Spam_bar": "----", "X-Spam_report": "(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "object_set_properties_from_qdict() serves as the common entry point for\nparsing and setting properties from qdict (and keyval).\n\nThis function is primarily utilized for external user configuration:\n\n1. User Creatable Objects (via user_creatable_add_type()):\n - QMP: object-add\n - HMP: object_add\n - CLI: -object (qemu), --object (qemu-img * / qemu-io / qemu-nbd /\n qemu-storage-daemon)\n - Authz list files (\"authz-list-file\")\n\n2. Device and Machine creation (keyval-based):\n - CLI: -machine / -device\n - QMP/HMP: device_add\n - Failover devices: virtio_net parses user's \"qdict\" in\n failover_add_primary().\n\n3. Built-in default machine options (MachineClass::default_machine_opts):\n - These hardcoded defaults simulate CLI arguments and are parsed via\n sugar property way or keyval. Treating them as USER_SET is\n acceptable as they emulate user behavior.\n\nThere are a few internal corner cases where devices are created using an\ninternal qdict:\n - Xen USB (usbback_portid_add())\n - Intel HDA (intel_hda_and_codec_init())\n\nCreating devices via internal qdict should be considered as legacy\ntechnical debt and this should be refactored in future work. For these\ncases, applying the USER_SET flag is a temporary and acceptable side\neffect.\n\nTherefor, update object_set_properties_from_qdict() to explicitly mark\nproperties as USER_SET.\n\nSigned-off-by: Zhao Liu <zhao1.liu@intel.com>\n---\n qom/object_interfaces.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c\nindex 415cbee8c5cf..f0d5f9d84300 100644\n--- a/qom/object_interfaces.c\n+++ b/qom/object_interfaces.c\n@@ -56,6 +56,11 @@ static void object_set_properties_from_qdict(Object *obj, const QDict *qdict,\n if (!object_property_set(obj, e->key, v, errp)) {\n goto out;\n }\n+\n+ if (!object_property_set_flags(obj, e->key,\n+ OBJ_PROP_FLAG_USER_SET, errp)) {\n+ goto out;\n+ }\n }\n visit_check_struct(v, errp);\n out:\n", "prefixes": [ "v2", "12/21" ] }