Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194850/?format=api
{ "id": 2194850, "url": "http://patchwork.ozlabs.org/api/patches/2194850/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-9-zhao1.liu@intel.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210032348.987549-9-zhao1.liu@intel.com>", "list_archive_url": null, "date": "2026-02-10T03:23:35", "name": "[v2,08/21] qom/object: add from_user argument in object_property_parse()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9f1546150d9ec89fa340b292b2a3b97d65ba9a36", "submitter": { "id": 86545, "url": "http://patchwork.ozlabs.org/api/people/86545/?format=api", "name": "Zhao Liu", "email": "zhao1.liu@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-9-zhao1.liu@intel.com/mbox/", "series": [ { "id": 491594, "url": "http://patchwork.ozlabs.org/api/series/491594/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491594", "date": "2026-02-10T03:23:28", "name": "qom: introduce property flags to track external user input", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491594/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194850/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194850/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=f1xZ6l/u;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f95sY0J5bz1xvb\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 14:00:33 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpdxs-000708-5K; Mon, 09 Feb 2026 21:59:00 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdxq-0006xL-0Y\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:58:58 -0500", "from mgamail.intel.com ([198.175.65.14])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdxo-00049n-7i\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:58:57 -0500", "from orviesa008.jf.intel.com ([10.64.159.148])\n by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Feb 2026 18:58:53 -0800", "from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.39])\n by orviesa008.jf.intel.com with ESMTP; 09 Feb 2026 18:58:48 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1770692336; x=1802228336;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=YNyb/e63nn9O7NosP48x3bb0jJDEX6gcU+lAI5zDmV0=;\n b=f1xZ6l/uqN5juZVhnGP93MSYObXwtABIA0TNQ3pQntJMU40FrRZKi/5q\n XmTSglYH/KjgYfsvPn1pdCJxnzwCTxcMcYCU49ZZb1Xub4fe1ZCyaLIrq\n Wlvk0H7+PmM/hd/zcYoZXfSwwL81TPX0kYtW3XLtUrG7YIyeevOsaxo81\n bvFF+jg4QCpQOB7ewl6BEI/Q7nuJsXvkYoq+GaFN4BdAt4lddBl3Wo60H\n wUh6OjMANPeaEfgEx8yYdjeAj8j0kpQf4eQbLgruLG4vBcvTvvWtYapxP\n vVQG2UowbbiBt8F78U2fiozhxAGQIsQ1M7FaIaRz7fYAKEqITc2xZXPxB Q==;", "X-CSE-ConnectionGUID": [ "6nQEATuuQgO4X4bAqojWOQ==", "oO+KYwW8RCqr4J9DDEk/fA==" ], "X-CSE-MsgGUID": [ "WRqUruB7RVWKSr7Den66tg==", "sW9euM07SAeKSoWUTl8kcw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11696\"; a=\"75659874\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"75659874\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"211800570\"" ], "X-ExtLoop1": "1", "From": "Zhao Liu <zhao1.liu@intel.com>", "To": "Paolo Bonzini <pbonzini@redhat.com>, =?utf-8?q?Daniel_P_=2E_Berrang?=\n\t=?utf-8?q?=C3=A9?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Markus Armbruster <armbru@redhat.com>,\n Thomas Huth <thuth@redhat.com>, Igor Mammedov <imammedo@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n \"Michael S . Tsirkin\" <mst@redhat.com>,\n BALATON Zoltan <balaton@eik.bme.hu>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Zide Chen <zide.chen@intel.com>, Dapeng Mi <dapeng1.mi@linux.intel.com>,\n Zhao Liu <zhao1.liu@intel.com>, qemu-devel@nongnu.org,\n devel@lists.libvirt.org", "Subject": "[PATCH v2 08/21] qom/object: add from_user argument in\n object_property_parse()", "Date": "Tue, 10 Feb 2026 11:23:35 +0800", "Message-Id": "<20260210032348.987549-9-zhao1.liu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260210032348.987549-1-zhao1.liu@intel.com>", "References": "<20260210032348.987549-1-zhao1.liu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=198.175.65.14; envelope-from=zhao1.liu@intel.com;\n helo=mgamail.intel.com", "X-Spam_score_int": "-43", "X-Spam_score": "-4.4", "X-Spam_bar": "----", "X-Spam_report": "(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Currently, object_property_parse() is used for both internal property\nsettings and external user configurations (e.g., via HMP or global\nproperties).\n\nTo properly manage property flags (specifically OBJ_PROP_FLAG_USER_SET),\nit is necessary to identify the source of the property setting.\n\nUpdate object_property_parse() to accept a 'from_user' argument and\nset the USER_SET flag for the property if 'from_user=true'.\n\nAs a first step, all existing callers are updated to have 'from_user=\nfalse'. Next the cases set by specific external user will be identified\n(like HMP and global properties) and will update 'from_user' argument to\n'true'.\n\nSigned-off-by: Zhao Liu <zhao1.liu@intel.com>\n---\n hw/i386/sgx.c | 2 +-\n include/qom/object.h | 5 +++--\n qom/object.c | 20 +++++++++++++++-----\n qom/qom-hmp-cmds.c | 2 +-\n system/vl.c | 2 +-\n target/i386/cpu.c | 4 ++--\n 6 files changed, 23 insertions(+), 12 deletions(-)", "diff": "diff --git a/hw/i386/sgx.c b/hw/i386/sgx.c\nindex 5e792e8e6e96..8cb71be689ff 100644\n--- a/hw/i386/sgx.c\n+++ b/hw/i386/sgx.c\n@@ -316,7 +316,7 @@ void pc_machine_init_sgx_epc(PCMachineState *pcms)\n \n /* set the memdev link with memory backend */\n object_property_parse(OBJECT(dev), SGX_EPC_MEMDEV_PROP,\n- list->value->memdev, &error_fatal);\n+ list->value->memdev, false, &error_fatal);\n /* set the numa node property for sgx epc object */\n object_property_set_uint(OBJECT(dev), SGX_EPC_NUMA_NODE_PROP,\n list->value->node, &error_fatal);\ndiff --git a/include/qom/object.h b/include/qom/object.h\nindex 1b77429aa28b..c78e1c03a106 100644\n--- a/include/qom/object.h\n+++ b/include/qom/object.h\n@@ -1655,14 +1655,15 @@ bool object_property_set(Object *obj, const char *name, Visitor *v,\n * @obj: the object\n * @name: the name of the property\n * @string: the string that will be used to parse the property value.\n+ * @from_user: whether the property is being set by a external user.\n * @errp: returns an error if this function fails\n *\n * Parses a string and writes the result into a property of an object.\n *\n * Returns: %true on success, %false on failure.\n */\n-bool object_property_parse(Object *obj, const char *name,\n- const char *string, Error **errp);\n+bool object_property_parse(Object *obj, const char *name, const char *string,\n+ bool from_user, Error **errp);\n \n /**\n * object_property_print:\ndiff --git a/qom/object.c b/qom/object.c\nindex 75a1fe7ea1d3..7140e3f629aa 100644\n--- a/qom/object.c\n+++ b/qom/object.c\n@@ -460,7 +460,7 @@ bool object_apply_global_props(Object *obj, const GPtrArray *props,\n continue;\n }\n p->used = true;\n- if (!object_property_parse(obj, p->property, p->value, &err)) {\n+ if (!object_property_parse(obj, p->property, p->value, false, &err)) {\n error_prepend(&err, \"can't apply global %s.%s=%s: \",\n p->driver, p->property, p->value);\n /*\n@@ -882,7 +882,7 @@ bool object_set_propv(Object *obj,\n const char *value = va_arg(vargs, char *);\n \n g_assert(value != NULL);\n- if (!object_property_parse(obj, propname, value, errp)) {\n+ if (!object_property_parse(obj, propname, value, false, errp)) {\n return false;\n }\n propname = va_arg(vargs, char *);\n@@ -1802,13 +1802,23 @@ int object_property_get_enum(Object *obj, const char *name,\n return ret;\n }\n \n-bool object_property_parse(Object *obj, const char *name,\n- const char *string, Error **errp)\n+bool object_property_parse(Object *obj, const char *name, const char *string,\n+ bool from_user, Error **errp)\n {\n Visitor *v = string_input_visitor_new(string);\n- bool ok = object_property_set(obj, name, v, errp);\n+ bool ok;\n \n+ ok = object_property_set(obj, name, v, errp);\n visit_free(v);\n+\n+ if (!ok) {\n+ return false;\n+ }\n+\n+ if (from_user) {\n+ ok = object_property_set_flags(obj, name,\n+ OBJ_PROP_FLAG_USER_SET, errp);\n+ }\n return ok;\n }\n \ndiff --git a/qom/qom-hmp-cmds.c b/qom/qom-hmp-cmds.c\nindex 32e40630c96a..6bdb241e54bd 100644\n--- a/qom/qom-hmp-cmds.c\n+++ b/qom/qom-hmp-cmds.c\n@@ -58,7 +58,7 @@ void hmp_qom_set(Monitor *mon, const QDict *qdict)\n error_set(&err, ERROR_CLASS_DEVICE_NOT_FOUND,\n \"Device '%s' not found\", path);\n } else {\n- object_property_parse(obj, property, value, &err);\n+ object_property_parse(obj, property, value, false, &err);\n }\n } else {\n QObject *obj = qobject_from_json(value, &err);\ndiff --git a/system/vl.c b/system/vl.c\nindex aa9a15504174..6d8167a50006 100644\n--- a/system/vl.c\n+++ b/system/vl.c\n@@ -1708,7 +1708,7 @@ static int object_parse_property_opt(Object *obj,\n return 0;\n }\n \n- if (!object_property_parse(obj, name, value, errp)) {\n+ if (!object_property_parse(obj, name, value, false, errp)) {\n return -1;\n }\n \ndiff --git a/target/i386/cpu.c b/target/i386/cpu.c\nindex 0a7b884528ea..94a9dcde1eb1 100644\n--- a/target/i386/cpu.c\n+++ b/target/i386/cpu.c\n@@ -8089,7 +8089,7 @@ void x86_cpu_apply_props(X86CPU *cpu, PropValue *props)\n continue;\n }\n object_property_parse(OBJECT(cpu), pv->prop, pv->value,\n- &error_abort);\n+ false, &error_abort);\n }\n }\n \n@@ -8112,7 +8112,7 @@ static void x86_cpu_apply_version_props(X86CPU *cpu, const X86CPUModel *model)\n \n for (p = vdef->props; p && p->prop; p++) {\n object_property_parse(OBJECT(cpu), p->prop, p->value,\n- &error_abort);\n+ false, &error_abort);\n }\n \n if (vdef->version == version) {\n", "prefixes": [ "v2", "08/21" ] }