Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194842/?format=api
{ "id": 2194842, "url": "http://patchwork.ozlabs.org/api/patches/2194842/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-15-zhao1.liu@intel.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210032348.987549-15-zhao1.liu@intel.com>", "list_archive_url": null, "date": "2026-02-10T03:23:41", "name": "[v2,14/21] hw/core/qdev-properties: allow qdev properties accept flags", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "228a31c5f1c35a2c4d94584f2b5b2277bf993a7f", "submitter": { "id": 86545, "url": "http://patchwork.ozlabs.org/api/people/86545/?format=api", "name": "Zhao Liu", "email": "zhao1.liu@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-15-zhao1.liu@intel.com/mbox/", "series": [ { "id": 491594, "url": "http://patchwork.ozlabs.org/api/series/491594/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491594", "date": "2026-02-10T03:23:28", "name": "qom: introduce property flags to track external user input", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491594/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194842/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194842/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=WXoJ2Mv5;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f95rh3VqNz1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 13:59:48 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpdyW-0008RD-Lw; Mon, 09 Feb 2026 21:59:40 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdyF-0007cg-7v\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:59:24 -0500", "from mgamail.intel.com ([198.175.65.14])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdyD-00049n-5S\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:59:22 -0500", "from orviesa008.jf.intel.com ([10.64.159.148])\n by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Feb 2026 18:59:20 -0800", "from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.39])\n by orviesa008.jf.intel.com with ESMTP; 09 Feb 2026 18:59:16 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1770692361; x=1802228361;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=yalC0/aqWFr4iSafee5JGmouLwexJcSFVL+H5tixrSc=;\n b=WXoJ2Mv55mX2hWRf+e+PmNPqNuJfxndLHOK4z3icsfsnTqxOzb9+is5V\n q+i7h+YmSu4B1b4J9kjsxh186EBFH3viSAgXIzPTCDyYuHecwZKsFfA4N\n m3FIXvKuCRYox4DYWUPb0vlqFZ4JdqhLZu43FjM4ZNdbG3RtcoOxa+i60\n 9ljkzSwLtpP4WmWdLQ5FpECit+Cg6G4s5V563UtQuGfpXPRTxlS+o2Exe\n o6mvkhsjyI5zpUdZ9bkfA5OhmQe7JObdm6MEo2NwMKXmqXanIcWJAiXGc\n rDR2UAambunowWIb+6UhLi0OVWH/UA5U27/2vnbLP/5wZQmI/eXJFQM+O w==;", "X-CSE-ConnectionGUID": [ "75px56qeRoG6y9FpJo2Pag==", "2oZcElVlRq2Nr5RMhkLzSw==" ], "X-CSE-MsgGUID": [ "dUp9vm1/TqGtdHHA9yBudw==", "xM69DtmVS4mG5gcpkoBh9A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11696\"; a=\"75659951\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"75659951\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"211800693\"" ], "X-ExtLoop1": "1", "From": "Zhao Liu <zhao1.liu@intel.com>", "To": "Paolo Bonzini <pbonzini@redhat.com>, =?utf-8?q?Daniel_P_=2E_Berrang?=\n\t=?utf-8?q?=C3=A9?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Markus Armbruster <armbru@redhat.com>,\n Thomas Huth <thuth@redhat.com>, Igor Mammedov <imammedo@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n \"Michael S . Tsirkin\" <mst@redhat.com>,\n BALATON Zoltan <balaton@eik.bme.hu>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Zide Chen <zide.chen@intel.com>, Dapeng Mi <dapeng1.mi@linux.intel.com>,\n Zhao Liu <zhao1.liu@intel.com>, qemu-devel@nongnu.org,\n devel@lists.libvirt.org", "Subject": "[PATCH v2 14/21] hw/core/qdev-properties: allow qdev properties\n accept flags", "Date": "Tue, 10 Feb 2026 11:23:41 +0800", "Message-Id": "<20260210032348.987549-15-zhao1.liu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260210032348.987549-1-zhao1.liu@intel.com>", "References": "<20260210032348.987549-1-zhao1.liu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=198.175.65.14; envelope-from=zhao1.liu@intel.com;\n helo=mgamail.intel.com", "X-Spam_score_int": "-43", "X-Spam_score": "-4.4", "X-Spam_bar": "----", "X-Spam_report": "(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Update qdev property interfaces (qdev_property_add_static() and\nqdev_class_add_property()) to accept and pass 'ObjectPropertyFlags'.\nThis enables marking qdev properties with flags such as DEPRECATED or\nINTERNAL.\n\nTo facilitate this at the definition level, extend the boolean and\nuint8_t property macros (as the examples) to accept variable arguments\n(VA_ARGS). This allows callers to optionally specify flags in the\nproperty definition.\n\nExample:\n\nDEFINE_PROP_UINT8(\"version\", IOAPICCommonState, version, IOAPIC_VER_DEF,\n .flags = OBJECT_PROPERTY_DEPRECATED),\n\nSigned-off-by: Zhao Liu <zhao1.liu@intel.com>\n---\n hw/core/qdev-properties.c | 26 +++++++++++++++-----------\n include/hw/core/qdev-properties.h | 24 ++++++++++++++----------\n 2 files changed, 29 insertions(+), 21 deletions(-)", "diff": "diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c\nindex 696dc5f201d6..91c4010e7dc9 100644\n--- a/hw/core/qdev-properties.c\n+++ b/hw/core/qdev-properties.c\n@@ -1071,11 +1071,13 @@ void qdev_property_add_static(DeviceState *dev, const Property *prop)\n \n assert(!prop->info->create);\n \n- op = object_property_add(obj, prop->name, prop->info->type,\n- field_prop_getter(prop->info),\n- field_prop_setter(prop->info),\n- prop->info->release,\n- (Property *)prop);\n+ op = object_property_add_full(obj, prop->name, prop->info->type,\n+ field_prop_getter(prop->info),\n+ field_prop_setter(prop->info),\n+ prop->info->release,\n+ prop->flags,\n+ (Property *)prop,\n+ &error_abort);\n \n object_property_set_description(obj, prop->name,\n prop->info->description);\n@@ -1097,12 +1099,14 @@ static void qdev_class_add_property(DeviceClass *klass, const char *name,\n if (prop->info->create) {\n op = prop->info->create(oc, name, prop);\n } else {\n- op = object_class_property_add(oc,\n- name, prop->info->type,\n- field_prop_getter(prop->info),\n- field_prop_setter(prop->info),\n- prop->info->release,\n- (Property *)prop);\n+ op = object_class_property_add_full(oc,\n+ name, prop->info->type,\n+ field_prop_getter(prop->info),\n+ field_prop_setter(prop->info),\n+ prop->info->release,\n+ prop->flags,\n+ (Property *)prop,\n+ &error_abort);\n }\n if (prop->set_default) {\n prop->info->set_default_value(op, prop);\ndiff --git a/include/hw/core/qdev-properties.h b/include/hw/core/qdev-properties.h\nindex d8745d4c65f1..c06de37b1e9d 100644\n--- a/include/hw/core/qdev-properties.h\n+++ b/include/hw/core/qdev-properties.h\n@@ -11,6 +11,7 @@\n * and the field retains whatever value it was given by instance_init).\n * @defval: default value for the property. This is used only if @set_default\n * is true.\n+ * @flags: property flags to control uses.\n */\n struct Property {\n const char *name;\n@@ -27,6 +28,7 @@ struct Property {\n int arrayfieldsize;\n uint8_t bitnr;\n bool set_default;\n+ uint8_t flags;\n };\n \n struct PropertyInfo {\n@@ -97,10 +99,11 @@ extern const PropertyInfo qdev_prop_link;\n .set_default = true, \\\n .defval.u = (bool)_defval)\n \n-#define DEFINE_PROP_UNSIGNED(_name, _state, _field, _defval, _prop, _type) \\\n- DEFINE_PROP(_name, _state, _field, _prop, _type, \\\n- .set_default = true, \\\n- .defval.u = (_type)_defval)\n+#define DEFINE_PROP_UNSIGNED(_name, _state, _field, _defval, _prop, _type, ...) \\\n+ DEFINE_PROP(_name, _state, _field, _prop, _type, \\\n+ .set_default = true, \\\n+ .defval.u = (_type)_defval, \\\n+ ##__VA_ARGS__)\n \n #define DEFINE_PROP_UNSIGNED_NODEFAULT(_name, _state, _field, _prop, _type) \\\n DEFINE_PROP(_name, _state, _field, _prop, _type)\n@@ -118,10 +121,11 @@ extern const PropertyInfo qdev_prop_link;\n .set_default = true, \\\n .defval.i = (OnOffAuto)_defval)\n \n-#define DEFINE_PROP_BOOL(_name, _state, _field, _defval) \\\n- DEFINE_PROP(_name, _state, _field, qdev_prop_bool, bool, \\\n- .set_default = true, \\\n- .defval.u = (bool)_defval)\n+#define DEFINE_PROP_BOOL(_name, _state, _field, _defval, ...) \\\n+ DEFINE_PROP(_name, _state, _field, qdev_prop_bool, bool, \\\n+ .set_default = true, \\\n+ .defval.u = (bool)_defval, \\\n+ ##__VA_ARGS__)\n \n /**\n * The DEFINE_PROP_UINT64_CHECKMASK macro checks a user-supplied value\n@@ -168,8 +172,8 @@ extern const PropertyInfo qdev_prop_link;\n DEFINE_PROP(_name, _state, _field, qdev_prop_link, _ptr_type, \\\n .link_type = _type)\n \n-#define DEFINE_PROP_UINT8(_n, _s, _f, _d) \\\n- DEFINE_PROP_UNSIGNED(_n, _s, _f, _d, qdev_prop_uint8, uint8_t)\n+#define DEFINE_PROP_UINT8(_n, _s, _f, _d, ...) \\\n+ DEFINE_PROP_UNSIGNED(_n, _s, _f, _d, qdev_prop_uint8, uint8_t, ##__VA_ARGS__)\n #define DEFINE_PROP_UINT16(_n, _s, _f, _d) \\\n DEFINE_PROP_UNSIGNED(_n, _s, _f, _d, qdev_prop_uint16, uint16_t)\n #define DEFINE_PROP_UINT32(_n, _s, _f, _d) \\\n", "prefixes": [ "v2", "14/21" ] }