Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194840/?format=api
{ "id": 2194840, "url": "http://patchwork.ozlabs.org/api/patches/2194840/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-7-zhao1.liu@intel.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210032348.987549-7-zhao1.liu@intel.com>", "list_archive_url": null, "date": "2026-02-10T03:23:33", "name": "[v2,06/21] qom/object: add helpers to set/get/clear property flags", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6b00b2ee8fba5f691ddf05366b580fd8fd23513c", "submitter": { "id": 86545, "url": "http://patchwork.ozlabs.org/api/people/86545/?format=api", "name": "Zhao Liu", "email": "zhao1.liu@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-7-zhao1.liu@intel.com/mbox/", "series": [ { "id": 491594, "url": "http://patchwork.ozlabs.org/api/series/491594/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491594", "date": "2026-02-10T03:23:28", "name": "qom: introduce property flags to track external user input", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491594/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194840/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194840/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=C6wL2jnb;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f95rV2jpZz1xwH\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 13:59:38 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpdxg-0006ae-R3; Mon, 09 Feb 2026 21:58:50 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdxf-0006VC-AY\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:58:47 -0500", "from mgamail.intel.com ([198.175.65.18])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdxd-00046a-5I\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:58:47 -0500", "from orviesa008.jf.intel.com ([10.64.159.148])\n by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Feb 2026 18:58:44 -0800", "from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.39])\n by orviesa008.jf.intel.com with ESMTP; 09 Feb 2026 18:58:38 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1770692325; x=1802228325;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Cn71uR3nTCNArFKWH13gLj0SrrAGpnRKcH4TTQALhvw=;\n b=C6wL2jnbaeHrzPKAVm77osNFlSo3qRp0qqTjCB/6x2+NrKymv+cXuZws\n M9hHdCTG6PQW9ReorvxPjGm114PtgbPpx/8r7IHsw5nqqEIgIJLzHMyzE\n 7ZDB+t8PpxCgvjAblsJuKnPQVOlFJE1LGxEbNOWo5KFEk4F3M/T+5kKIO\n I5o6Q03kIxdA3+cjov0QurWPAbQil0BlJH+n6ab4kjSk/mbCIfumVye+W\n wL1q/qPzD26ioxDPq44IwLuk68KvTiGHy+cewnjuZRKk8RhWNdlV/HD5e\n /Lfjv/ma6ohkpafK+mMZwVcNn9Vv/J4Qbv2zAHgIzj/Tab5u32Pi663qQ w==;", "X-CSE-ConnectionGUID": [ "gt+a51iGT4uSZGEz8OpotA==", "F7BhuGCCQSq1hrHdVoI2Yw==" ], "X-CSE-MsgGUID": [ "Rw0VesatS0yqp2QHGDTe/g==", "gjiw+kI7SyqQLCZQ2c+vJA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11696\"; a=\"71854288\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"71854288\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"211800527\"" ], "X-ExtLoop1": "1", "From": "Zhao Liu <zhao1.liu@intel.com>", "To": "Paolo Bonzini <pbonzini@redhat.com>, =?utf-8?q?Daniel_P_=2E_Berrang?=\n\t=?utf-8?q?=C3=A9?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Markus Armbruster <armbru@redhat.com>,\n Thomas Huth <thuth@redhat.com>, Igor Mammedov <imammedo@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n \"Michael S . Tsirkin\" <mst@redhat.com>,\n BALATON Zoltan <balaton@eik.bme.hu>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Zide Chen <zide.chen@intel.com>, Dapeng Mi <dapeng1.mi@linux.intel.com>,\n Zhao Liu <zhao1.liu@intel.com>, qemu-devel@nongnu.org,\n devel@lists.libvirt.org", "Subject": "[PATCH v2 06/21] qom/object: add helpers to set/get/clear property\n flags", "Date": "Tue, 10 Feb 2026 11:23:33 +0800", "Message-Id": "<20260210032348.987549-7-zhao1.liu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260210032348.987549-1-zhao1.liu@intel.com>", "References": "<20260210032348.987549-1-zhao1.liu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=198.175.65.18; envelope-from=zhao1.liu@intel.com;\n helo=mgamail.intel.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Introduce four helper functions to operate object property flags:\nobject_property_set_flags(), object_property_get_flags(),\nobject_property_check_flags() and object_property_clear_flags().\n\nAmong them, object_property_check_flags() is a complement to\nobject_property_get_flags(), because sometimes it's needed to check\nwhether certain flags are set without returning all flags.\n\nThis encapsulates and separates the flag management logic, avoiding\ndirect access to ObjectProperty internals in call sites.\n\nSuggested-by: Igor Mammedov <imammedo@redhat.com>\nSigned-off-by: Zhao Liu <zhao1.liu@intel.com>\n---\n include/qom/object.h | 64 ++++++++++++++++++++++++++++++++++++++++++++\n qom/object.c | 63 +++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 127 insertions(+)", "diff": "diff --git a/include/qom/object.h b/include/qom/object.h\nindex 30c9f20b1d18..856b12e7289c 100644\n--- a/include/qom/object.h\n+++ b/include/qom/object.h\n@@ -1086,6 +1086,70 @@ Object *object_ref(void *obj);\n */\n void object_unref(void *obj);\n \n+/**\n+ * object_property_set_flags:\n+ * @obj: the object.\n+ * @name: the name of the property.\n+ * @flags: the flags to be set for the property.\n+ * @errp: pointer to error object.\n+ *\n+ * Set the @flags to the property. Existing flags are preserved.\n+ *\n+ * Returns: %true on success, %false on failure.\n+ */\n+bool object_property_set_flags(Object *obj, const char *name,\n+ ObjectPropertyFlags flags,\n+ Error **errp);\n+\n+/**\n+ * object_property_get_flags:\n+ * @obj: the object.\n+ * @name: the name of the property.\n+ * @flags: pointer to a location to store the retrieved flags. Must not be\n+ * NULL.\n+ * @errp: pointer to error object.\n+ *\n+ * Get the current flags of the specified property.\n+ *\n+ * Returns: %true on success, %false on failure.\n+ */\n+bool object_property_get_flags(Object *obj, const char *name,\n+ ObjectPropertyFlags *flags,\n+ Error **errp);\n+\n+/**\n+ * object_property_check_flags:\n+ * @obj: the object.\n+ * @name: the name of the property.\n+ * @flags: the flags to check for on the property.\n+ * @errp: pointer to error object.\n+ *\n+ * Check whether the specified property has all bits in @flags set.\n+ * This is useful for detecting if a property has been explicitly set\n+ * by the user (e.g. with %OBJ_PROP_FLAG_USER_SET).\n+ *\n+ * Returns: 1 if all @flags are set, 0 if not all @flags are set,\n+ * or -1 on failure (property not found).\n+ */\n+int object_property_check_flags(Object *obj, const char *name,\n+ ObjectPropertyFlags flags,\n+ Error **errp);\n+\n+/**\n+ * object_property_clear_flags:\n+ * @obj: the object.\n+ * @name: the name of the property.\n+ * @flags: the flags to be removed from the property.\n+ * @errp: pointer to error object\n+ *\n+ * Clear the @flags from the property. Other flags remain unchanged.\n+ *\n+ * Returns: %true on success, %false on failure.\n+ */\n+bool object_property_clear_flags(Object *obj, const char *name,\n+ ObjectPropertyFlags flags,\n+ Error **errp);\n+\n /**\n * object_property_add_full:\n * @obj: the object to add a property to\ndiff --git a/qom/object.c b/qom/object.c\nindex c1a1e5ff3fbe..49ef99a299b6 100644\n--- a/qom/object.c\n+++ b/qom/object.c\n@@ -1233,6 +1233,69 @@ void object_unref(void *objptr)\n }\n }\n \n+bool object_property_set_flags(Object *obj, const char *name,\n+ ObjectPropertyFlags flags,\n+ Error **errp)\n+{\n+ ObjectProperty *prop = object_property_find_err(obj, name, errp);\n+ if (!prop) {\n+ return false;\n+ }\n+\n+ prop->flags |= flags;\n+ return true;\n+}\n+\n+bool object_property_get_flags(Object *obj, const char *name,\n+ ObjectPropertyFlags *flags,\n+ Error **errp)\n+{\n+ ObjectProperty *prop;\n+\n+ if (!flags) {\n+ error_setg(errp, \"invalid argument: flags is NULL\");\n+ return false;\n+ }\n+\n+ prop = object_property_find_err(obj, name, errp);\n+ if (!prop) {\n+ return false;\n+ }\n+\n+ *flags = prop->flags;\n+ return true;\n+}\n+\n+int object_property_check_flags(Object *obj, const char *name,\n+ ObjectPropertyFlags flags,\n+ Error **errp)\n+{\n+ ObjectPropertyFlags prop_flags;\n+\n+ if (!object_property_get_flags(obj, name, &prop_flags, errp)) {\n+ return -1;\n+ }\n+\n+ if ((prop_flags & flags) == flags) {\n+ return 1;\n+ }\n+\n+ return 0;\n+}\n+\n+bool object_property_clear_flags(Object *obj, const char *name,\n+ ObjectPropertyFlags flags,\n+ Error **errp)\n+{\n+ ObjectProperty *prop = object_property_find_err(obj, name, errp);\n+ if (!prop) {\n+ return false;\n+ }\n+\n+ prop->flags &= ~flags;\n+ return true;\n+}\n+\n static inline void object_property_flags_init(ObjectProperty *prop,\n ObjectPropertyFlags flags)\n {\n", "prefixes": [ "v2", "06/21" ] }