Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194837/?format=api
{ "id": 2194837, "url": "http://patchwork.ozlabs.org/api/patches/2194837/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-10-zhao1.liu@intel.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210032348.987549-10-zhao1.liu@intel.com>", "list_archive_url": null, "date": "2026-02-10T03:23:36", "name": "[v2,09/21] qom/object: mark global property set from CLI as USER_SET", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a69d6b17cbece11aeb8276f9c2d9ab1c5bc8b093", "submitter": { "id": 86545, "url": "http://patchwork.ozlabs.org/api/people/86545/?format=api", "name": "Zhao Liu", "email": "zhao1.liu@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-10-zhao1.liu@intel.com/mbox/", "series": [ { "id": 491594, "url": "http://patchwork.ozlabs.org/api/series/491594/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491594", "date": "2026-02-10T03:23:28", "name": "qom: introduce property flags to track external user input", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491594/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194837/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194837/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=RKky6QJD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f95r51FJzz1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 13:59:17 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpdxw-0007Ax-I8; Mon, 09 Feb 2026 21:59:04 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdxs-00071G-PF\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:59:01 -0500", "from mgamail.intel.com ([198.175.65.14])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdxr-00049n-3T\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:59:00 -0500", "from orviesa008.jf.intel.com ([10.64.159.148])\n by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Feb 2026 18:58:57 -0800", "from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.39])\n by orviesa008.jf.intel.com with ESMTP; 09 Feb 2026 18:58:53 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1770692339; x=1802228339;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=FxBUkSvbGuB1vBs3AIUiH7+IqEBydGey1Vi/I25uNSQ=;\n b=RKky6QJDefmPLZ7thBp3fxMwI+G4gUWFOESdZBzmjs9VME1nmBYscOji\n +T2uHKYA5DXeBFlgMEOwXAR1cTSazXMXTLeRsCMrDvXKWG3uj7y3xBEHa\n 4nBX7Py/fZ832K5hkGRyavh7gtEoUyb/U0ySdEmdjMOBlX/3blAvNQV4g\n N90mJlop23/Qdf8v9Nx9+d1sj9SXhdiLtuBZc8eTPGr+WQfEXE+mFSgTj\n BWhvmP5dFucS1fxdGk2D4eCOLqAVLLL14qecETSD3KrRPS63PMsJeLyGB\n 5dJjg2FJ9O1G8czR5irOTmILWQZAFiP2EBxfj6fr9jqMkS25ZvGhW6VuX w==;", "X-CSE-ConnectionGUID": [ "BlND7lESTjqhScfVeWapag==", "c5czF4V8Qa6Xe0gLHud71Q==" ], "X-CSE-MsgGUID": [ "GeT9GQeCQIuhocU3J7VDfg==", "5FPuJl0BQQy1SPmrXlAIPQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11696\"; a=\"75659892\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"75659892\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"211800584\"" ], "X-ExtLoop1": "1", "From": "Zhao Liu <zhao1.liu@intel.com>", "To": "Paolo Bonzini <pbonzini@redhat.com>, =?utf-8?q?Daniel_P_=2E_Berrang?=\n\t=?utf-8?q?=C3=A9?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Markus Armbruster <armbru@redhat.com>,\n Thomas Huth <thuth@redhat.com>, Igor Mammedov <imammedo@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n \"Michael S . Tsirkin\" <mst@redhat.com>,\n BALATON Zoltan <balaton@eik.bme.hu>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Zide Chen <zide.chen@intel.com>, Dapeng Mi <dapeng1.mi@linux.intel.com>,\n Zhao Liu <zhao1.liu@intel.com>, qemu-devel@nongnu.org,\n devel@lists.libvirt.org", "Subject": "[PATCH v2 09/21] qom/object: mark global property set from CLI as\n USER_SET", "Date": "Tue, 10 Feb 2026 11:23:36 +0800", "Message-Id": "<20260210032348.987549-10-zhao1.liu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260210032348.987549-1-zhao1.liu@intel.com>", "References": "<20260210032348.987549-1-zhao1.liu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=198.175.65.14; envelope-from=zhao1.liu@intel.com;\n helo=mgamail.intel.com", "X-Spam_score_int": "-43", "X-Spam_score": "-4.4", "X-Spam_bar": "----", "X-Spam_report": "(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "There are now two major categories of global properties:\n\nOne category consists of true global properties collected in\nglobal_props(), sourced from CLI options like `-global` and CPU features\nlike `-cpu`.\n\nThe other category comprises compat properties derived from\nobject_compat_props[]. Within this, object_compat_props[0] and\nobject_compat_props[1] represent compat properties for accelerators and\nmachines, respectively. Meanwhile, object_compat_props[2] collects sugar\nproperties from the CLI.\n\nAlthough sugar properties are also applied for legacy machine options\n(MachineClass::default_machine_opts), considerring those hardcoded\ndefaults simulate CLI arguments, so treating them as USER_SET is\nacceptable as they emulate user behavior.\n\nTherefore, among all global properties, only those in global_props() and\nobject_compat_props[2] originate from external users. Consequently, when\napplying global properties via object_apply_global_props(), these two\ncategories of user-provided properties are marked as USER_SET by passing\n\"from_user=true\" to object_property_parse().\n\nSigned-off-by: Zhao Liu <zhao1.liu@intel.com>\n---\n hw/core/qdev-properties.c | 2 +-\n include/qom/object.h | 2 +-\n qom/object.c | 6 ++++--\n 3 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c\nindex c96ccfb26353..696dc5f201d6 100644\n--- a/hw/core/qdev-properties.c\n+++ b/hw/core/qdev-properties.c\n@@ -1017,7 +1017,7 @@ int qdev_prop_check_globals(void)\n \n void qdev_prop_set_globals(DeviceState *dev)\n {\n- object_apply_global_props(OBJECT(dev), global_props(),\n+ object_apply_global_props(OBJECT(dev), global_props(), true,\n dev->hotplugged ? NULL : &error_fatal);\n }\n \ndiff --git a/include/qom/object.h b/include/qom/object.h\nindex c78e1c03a106..b621803f61bb 100644\n--- a/include/qom/object.h\n+++ b/include/qom/object.h\n@@ -751,7 +751,7 @@ Object *object_new_with_propv(const char *typename,\n va_list vargs);\n \n bool object_apply_global_props(Object *obj, const GPtrArray *props,\n- Error **errp);\n+ bool from_user, Error **errp);\n void object_set_machine_compat_props(GPtrArray *compat_props);\n void object_set_accelerator_compat_props(GPtrArray *compat_props);\n void object_register_sugar_prop(const char *driver, const char *prop,\ndiff --git a/qom/object.c b/qom/object.c\nindex 7140e3f629aa..4ead0befb351 100644\n--- a/qom/object.c\n+++ b/qom/object.c\n@@ -441,7 +441,7 @@ static void object_post_init_with_type(Object *obj, TypeImpl *ti)\n }\n \n bool object_apply_global_props(Object *obj, const GPtrArray *props,\n- Error **errp)\n+ bool from_user, Error **errp)\n {\n int i;\n \n@@ -460,7 +460,8 @@ bool object_apply_global_props(Object *obj, const GPtrArray *props,\n continue;\n }\n p->used = true;\n- if (!object_property_parse(obj, p->property, p->value, false, &err)) {\n+ if (!object_property_parse(obj, p->property, p->value,\n+ from_user, &err)) {\n error_prepend(&err, \"can't apply global %s.%s=%s: \",\n p->driver, p->property, p->value);\n /*\n@@ -536,6 +537,7 @@ void object_apply_compat_props(Object *obj)\n \n for (i = 0; i < ARRAY_SIZE(object_compat_props); i++) {\n object_apply_global_props(obj, object_compat_props[i],\n+ i == 2 ? true : false,\n i == 2 ? &error_fatal : &error_abort);\n }\n }\n", "prefixes": [ "v2", "09/21" ] }