Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194836/?format=api
{ "id": 2194836, "url": "http://patchwork.ozlabs.org/api/patches/2194836/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-3-zhao1.liu@intel.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210032348.987549-3-zhao1.liu@intel.com>", "list_archive_url": null, "date": "2026-02-10T03:23:29", "name": "[v2,02/21] qom/object: cache ObjectPropertyFlags in ObjectProperty", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "77d4f808c0a5a96725228d5800775de0008af390", "submitter": { "id": 86545, "url": "http://patchwork.ozlabs.org/api/people/86545/?format=api", "name": "Zhao Liu", "email": "zhao1.liu@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-3-zhao1.liu@intel.com/mbox/", "series": [ { "id": 491594, "url": "http://patchwork.ozlabs.org/api/series/491594/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491594", "date": "2026-02-10T03:23:28", "name": "qom: introduce property flags to track external user input", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491594/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194836/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194836/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=DCZfstVp;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f95qr2H0qz1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 13:59:04 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpdxO-00062J-8W; Mon, 09 Feb 2026 21:58:30 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdxM-00061w-Cj\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:58:28 -0500", "from mgamail.intel.com ([198.175.65.18])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdxK-00046a-Ig\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:58:28 -0500", "from orviesa008.jf.intel.com ([10.64.159.148])\n by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Feb 2026 18:58:25 -0800", "from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.39])\n by orviesa008.jf.intel.com with ESMTP; 09 Feb 2026 18:58:19 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1770692307; x=1802228307;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=3N/SwZLpsJhPnT1hj2JLd5OJ+UF0eDFP2x5yKTQlPEg=;\n b=DCZfstVpGBvqzrv1qmMkUOnqzHdJZS58ttK3ChBT2cfRbMhYCtkv/6D4\n lWW3rWngkT/Eu8OuXzreOaibHW+SFyT7jzoz212xuX0tmT8d5gtgVaSjc\n WlYUU+xVlXhRk5Y4WYSqrM9RF6cubU4tj/0igtj/7aeK8njICo5hLTjNb\n wcHGPp71mZiE7HsN+ek8gKog37tn0+A4dtc0Vj9vl+f1h5572a2AJ37gY\n BOXKS1nHOmQRMFHmjsDzA6yeFOUJdyr2uIL69SVp2PwbJEh4NzwSGQAJn\n GRFkHAi05LAyuaqXJeMFwiGd1jPZSQAWmFgl5QFJzr+lC1eg7+RVs8BlX g==;", "X-CSE-ConnectionGUID": [ "cUrpRaNqQaKM2OdUVEd37g==", "Kh4wfJ2nRp2esYlklM4GwA==" ], "X-CSE-MsgGUID": [ "l6MibZx7RzyEikh+S5jfFg==", "zoSKirtdQNSWvFThDGGnHg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11696\"; a=\"71854237\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"71854237\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"211800442\"" ], "X-ExtLoop1": "1", "From": "Zhao Liu <zhao1.liu@intel.com>", "To": "Paolo Bonzini <pbonzini@redhat.com>, =?utf-8?q?Daniel_P_=2E_Berrang?=\n\t=?utf-8?q?=C3=A9?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Markus Armbruster <armbru@redhat.com>,\n Thomas Huth <thuth@redhat.com>, Igor Mammedov <imammedo@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n \"Michael S . Tsirkin\" <mst@redhat.com>,\n BALATON Zoltan <balaton@eik.bme.hu>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Zide Chen <zide.chen@intel.com>, Dapeng Mi <dapeng1.mi@linux.intel.com>,\n Zhao Liu <zhao1.liu@intel.com>, qemu-devel@nongnu.org,\n devel@lists.libvirt.org", "Subject": "[PATCH v2 02/21] qom/object: cache ObjectPropertyFlags in\n ObjectProperty", "Date": "Tue, 10 Feb 2026 11:23:29 +0800", "Message-Id": "<20260210032348.987549-3-zhao1.liu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260210032348.987549-1-zhao1.liu@intel.com>", "References": "<20260210032348.987549-1-zhao1.liu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=198.175.65.18; envelope-from=zhao1.liu@intel.com;\n helo=mgamail.intel.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Introduce a 'flags' field in the ObjectProperty structure to store\nproperty-specific behavior modifiers.\n\nCurrently, ObjectPropertyFlags (READ/WRITE) are only used for property\ncreation (e.g., initialize accessors for pointer properties).\n\nBy caching these flags directly in ObjectProperty, we can:\n1. Preserve the initial access intent (read/write) of the property.\n * the READ/WRITE flags cached in ObjectProperty have no effect for\n now, but they may be useful for cases need write-once, if needed.\n\n2. Reuse existing ObjectPropertyFlags and provide a foundation for\n future flags (e.g., to track if a property was explicitly set by\n external user).\n\nTo avoid \"incomplete type\" error, move ObjectPropertyFlags before\nObjectProperty definition, and polish the comment of ObjectPropertyFlags\nto clarify how READ/WRITE flags work for general properties.\n\nSuggested-by: Igor Mammedov <imammedo@redhat.com>\nSigned-off-by: Zhao Liu <zhao1.liu@intel.com>\n---\n include/qom/object.h | 34 +++++++++++++++++++++++++---------\n qom/object.c | 16 +++++++++++++++-\n 2 files changed, 40 insertions(+), 10 deletions(-)", "diff": "diff --git a/include/qom/object.h b/include/qom/object.h\nindex 6226b88c1eda..05706d4d7e3a 100644\n--- a/include/qom/object.h\n+++ b/include/qom/object.h\n@@ -87,6 +87,30 @@ typedef void (ObjectPropertyRelease)(Object *obj,\n */\n typedef void (ObjectPropertyInit)(Object *obj, ObjectProperty *prop);\n \n+typedef enum {\n+ /*\n+ * The property is readable and has a getter.\n+ *\n+ * For pointer property, this flag (set in object_{class_}property_add_*_ptr())\n+ * will automatically add a getter to this property.\n+ */\n+ OBJ_PROP_FLAG_READ = BIT(0),\n+ /*\n+ * The property is writable and has a setter.\n+ *\n+ * For pointer property, this flag (set in object_{class_}property_add_*_ptr())\n+ * will automatically add a setter to this property.\n+ */\n+ OBJ_PROP_FLAG_WRITE = BIT(1),\n+ /*\n+ * The property is readable and writable, as well as has a getter and a setter.\n+ *\n+ * For pointer property, this flag (set in object_{class_}property_add_*_ptr())\n+ * will automatically add a getter and a setter to this property.\n+ */\n+ OBJ_PROP_FLAG_READWRITE = (OBJ_PROP_FLAG_READ | OBJ_PROP_FLAG_WRITE),\n+} ObjectPropertyFlags;\n+\n struct ObjectProperty\n {\n char *name;\n@@ -99,6 +123,7 @@ struct ObjectProperty\n ObjectPropertyInit *init;\n void *opaque;\n QObject *defval;\n+ ObjectPropertyFlags flags;\n };\n \n /**\n@@ -1840,15 +1865,6 @@ ObjectProperty *object_class_property_add_tm(ObjectClass *klass,\n const char *name,\n void (*get)(Object *, struct tm *, Error **));\n \n-typedef enum {\n- /* Automatically add a getter to the property */\n- OBJ_PROP_FLAG_READ = BIT(0),\n- /* Automatically add a setter to the property */\n- OBJ_PROP_FLAG_WRITE = BIT(1),\n- /* Automatically add a getter and a setter to the property */\n- OBJ_PROP_FLAG_READWRITE = (OBJ_PROP_FLAG_READ | OBJ_PROP_FLAG_WRITE),\n-} ObjectPropertyFlags;\n-\n /**\n * object_property_add_uint8_ptr:\n * @obj: the object to add a property to\ndiff --git a/qom/object.c b/qom/object.c\nindex ff8ede8a328e..f5801f4624c8 100644\n--- a/qom/object.c\n+++ b/qom/object.c\n@@ -1233,6 +1233,19 @@ void object_unref(void *objptr)\n }\n }\n \n+static inline void object_property_flags_init(ObjectProperty *prop)\n+{\n+ uint8_t flags = 0;\n+\n+ if (prop->set) {\n+ flags |= OBJ_PROP_FLAG_WRITE;\n+ }\n+ if (prop->get) {\n+ flags |= OBJ_PROP_FLAG_READ;\n+ }\n+ prop->flags |= flags;\n+}\n+\n ObjectProperty *\n object_property_try_add(Object *obj, const char *name, const char *type,\n ObjectPropertyAccessor *get,\n@@ -1279,6 +1292,7 @@ object_property_try_add(Object *obj, const char *name, const char *type,\n prop->set = set;\n prop->release = release;\n prop->opaque = opaque;\n+ object_property_flags_init(prop);\n \n g_hash_table_insert(obj->properties, prop->name, prop);\n return prop;\n@@ -1317,9 +1331,9 @@ object_class_property_add(ObjectClass *klass,\n prop->set = set;\n prop->release = release;\n prop->opaque = opaque;\n+ object_property_flags_init(prop);\n \n g_hash_table_insert(klass->properties, prop->name, prop);\n-\n return prop;\n }\n \n", "prefixes": [ "v2", "02/21" ] }