Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194835/?format=api
{ "id": 2194835, "url": "http://patchwork.ozlabs.org/api/patches/2194835/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-6-zhao1.liu@intel.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210032348.987549-6-zhao1.liu@intel.com>", "list_archive_url": null, "date": "2026-02-10T03:23:32", "name": "[v2,05/21] qom/object: rename object_{class_}property_try_add() to object_{class_}property_add_full()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "dc642eb67f7d57c1ce33000b2ace301ff25fb3c5", "submitter": { "id": 86545, "url": "http://patchwork.ozlabs.org/api/people/86545/?format=api", "name": "Zhao Liu", "email": "zhao1.liu@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260210032348.987549-6-zhao1.liu@intel.com/mbox/", "series": [ { "id": 491594, "url": "http://patchwork.ozlabs.org/api/series/491594/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491594", "date": "2026-02-10T03:23:28", "name": "qom: introduce property flags to track external user input", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491594/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194835/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194835/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=WP6ieVZT;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f95qp54nPz1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 13:59:02 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpdxb-0006Nw-C8; Mon, 09 Feb 2026 21:58:43 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdxa-0006JK-4s\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:58:42 -0500", "from mgamail.intel.com ([198.175.65.18])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhao1.liu@intel.com>)\n id 1vpdxX-00046a-Mo\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 21:58:41 -0500", "from orviesa008.jf.intel.com ([10.64.159.148])\n by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Feb 2026 18:58:38 -0800", "from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.39])\n by orviesa008.jf.intel.com with ESMTP; 09 Feb 2026 18:58:34 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1770692320; x=1802228320;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=w3wF2PJ2NmfCFav9tehjq5GSJZrLiro42nNm6SLBWjc=;\n b=WP6ieVZTcBi+ZhccvDbLLThyjBqacuVkjWxZmis+VmJ/iG4AB2Zsx58F\n +KnzrqN8xnQm/JYg100hLs9XkvEud51SxCT0h3Z9zx9EkT4xqI7hV16gL\n zm40qE9vH6LW7bI1KPlhGMP5XAqNcFKfZiCCtyDHsEcS7cV2OWeY9+sXO\n nQdKdiZhQEYNStCtDEQ+Ri4tJBRBVL5NUcWFypsngDXD1nVIXt+RqOeTK\n SU9NLIYCnFNDdGK/QvB3QqMxXXTzedp5c/x5lXJF+WZL0WwUEwFnl65ay\n 1Q+z6BvXjAd73Uxzhm720PahisVlIVBMRzNI8FAML3CPOBk/LCOeNmFy5 A==;", "X-CSE-ConnectionGUID": [ "hg/zOwx0RhORvWnPNr/+yA==", "A2FODYfKTBuQIL6DWiuJ1Q==" ], "X-CSE-MsgGUID": [ "zE8iLhVPQYOmChsqCFdw3g==", "3/j2jgLfR66TOH3rhBEdYw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11696\"; a=\"71854274\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"71854274\"", "E=Sophos;i=\"6.21,283,1763452800\"; d=\"scan'208\";a=\"211800508\"" ], "X-ExtLoop1": "1", "From": "Zhao Liu <zhao1.liu@intel.com>", "To": "Paolo Bonzini <pbonzini@redhat.com>, =?utf-8?q?Daniel_P_=2E_Berrang?=\n\t=?utf-8?q?=C3=A9?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Markus Armbruster <armbru@redhat.com>,\n Thomas Huth <thuth@redhat.com>, Igor Mammedov <imammedo@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n \"Michael S . Tsirkin\" <mst@redhat.com>,\n BALATON Zoltan <balaton@eik.bme.hu>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Zide Chen <zide.chen@intel.com>, Dapeng Mi <dapeng1.mi@linux.intel.com>,\n Zhao Liu <zhao1.liu@intel.com>, qemu-devel@nongnu.org,\n devel@lists.libvirt.org", "Subject": "[PATCH v2 05/21] qom/object: rename object_{class_}property_try_add()\n to object_{class_}property_add_full()", "Date": "Tue, 10 Feb 2026 11:23:32 +0800", "Message-Id": "<20260210032348.987549-6-zhao1.liu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260210032348.987549-1-zhao1.liu@intel.com>", "References": "<20260210032348.987549-1-zhao1.liu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=198.175.65.18; envelope-from=zhao1.liu@intel.com;\n helo=mgamail.intel.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The suffixes \"_try_add\" and \"_add\" typically distinguish functions based\nsolely on their error-handling behavior.\n\nHowever, the object_{class_}property_try_add() variants now support the\nadditional 'flags' argument. Consequently, naming them based only on\nerror handling no longer accurately reflects the distinction between the\ntwo interface variants.\n\nRename object_{class_}property_try_add() to\nobject_{class_}property_add_full() to indicate that these interfaces\noffer comprehensive argument support, including the new flags.\n\nSigned-off-by: Zhao Liu <zhao1.liu@intel.com>\n---\n include/qom/object.h | 38 ++++++++++++++++++------------------\n qom/object.c | 46 ++++++++++++++++++++++----------------------\n 2 files changed, 42 insertions(+), 42 deletions(-)", "diff": "diff --git a/include/qom/object.h b/include/qom/object.h\nindex 7d8a7be1bad3..30c9f20b1d18 100644\n--- a/include/qom/object.h\n+++ b/include/qom/object.h\n@@ -1087,7 +1087,7 @@ Object *object_ref(void *obj);\n void object_unref(void *obj);\n \n /**\n- * object_property_try_add:\n+ * object_property_add_full:\n * @obj: the object to add a property to\n * @name: the name of the property. This can contain any character except for\n * a forward slash. In general, you should use hyphens '-' instead of\n@@ -1114,17 +1114,17 @@ void object_unref(void *obj);\n * Returns: The #ObjectProperty; this can be used to set the @resolve\n * callback for child and link properties.\n */\n-ObjectProperty *object_property_try_add(Object *obj, const char *name,\n- const char *type,\n- ObjectPropertyAccessor *get,\n- ObjectPropertyAccessor *set,\n- ObjectPropertyRelease *release,\n- ObjectPropertyFlags flags,\n- void *opaque, Error **errp);\n+ObjectProperty *object_property_add_full(Object *obj, const char *name,\n+ const char *type,\n+ ObjectPropertyAccessor *get,\n+ ObjectPropertyAccessor *set,\n+ ObjectPropertyRelease *release,\n+ ObjectPropertyFlags flags,\n+ void *opaque, Error **errp);\n \n /**\n * object_property_add:\n- * Same as object_property_try_add() with @flags hardcoded to 0 and @errp\n+ * Same as object_property_add_full() with @flags hardcoded to 0 and @errp\n * hardcoded to &error_abort.\n *\n * @obj: the object to add a property to\n@@ -1154,7 +1154,7 @@ ObjectProperty *object_property_add(Object *obj, const char *name,\n void object_property_del(Object *obj, const char *name);\n \n /**\n- * object_class_property_try_add:\n+ * object_class_property_add_full:\n * @klass: the object class to add a property to\n * @name: the name of the property. This can contain any character except for\n * a forward slash. In general, you should use hyphens '-' instead of\n@@ -1181,18 +1181,18 @@ void object_property_del(Object *obj, const char *name);\n * Returns: The #ObjectProperty; this can be used to set the @resolve\n * callback for child and link properties.\n */\n-ObjectProperty *object_class_property_try_add(ObjectClass *klass, const char *name,\n- const char *type,\n- ObjectPropertyAccessor *get,\n- ObjectPropertyAccessor *set,\n- ObjectPropertyRelease *release,\n- ObjectPropertyFlags flags,\n- void *opaque, Error **errp);\n+ObjectProperty *object_class_property_add_full(ObjectClass *klass, const char *name,\n+ const char *type,\n+ ObjectPropertyAccessor *get,\n+ ObjectPropertyAccessor *set,\n+ ObjectPropertyRelease *release,\n+ ObjectPropertyFlags flags,\n+ void *opaque, Error **errp);\n \n /**\n * object_class_property_add:\n- * Same as object_class_property_try_add() with @flags hardcoded to 0 and @errp\n- * hardcoded to &error_abort.\n+ * Same as object_class_property_add_full() with @flags hardcoded to 0 and\n+ * @errp hardcoded to &error_abort.\n *\n * @klass: the object class to add a property to\n * @name: the name of the property. This can contain any character except for\ndiff --git a/qom/object.c b/qom/object.c\nindex 543e42cd6f16..c1a1e5ff3fbe 100644\n--- a/qom/object.c\n+++ b/qom/object.c\n@@ -1246,12 +1246,12 @@ static inline void object_property_flags_init(ObjectProperty *prop,\n }\n \n ObjectProperty *\n-object_property_try_add(Object *obj, const char *name, const char *type,\n- ObjectPropertyAccessor *get,\n- ObjectPropertyAccessor *set,\n- ObjectPropertyRelease *release,\n- ObjectPropertyFlags flags,\n- void *opaque, Error **errp)\n+object_property_add_full(Object *obj, const char *name, const char *type,\n+ ObjectPropertyAccessor *get,\n+ ObjectPropertyAccessor *set,\n+ ObjectPropertyRelease *release,\n+ ObjectPropertyFlags flags,\n+ void *opaque, Error **errp)\n {\n ObjectProperty *prop;\n size_t name_len = strlen(name);\n@@ -1265,8 +1265,8 @@ object_property_try_add(Object *obj, const char *name, const char *type,\n for (i = 0; i < INT16_MAX; ++i) {\n char *full_name = g_strdup_printf(\"%s[%d]\", name_no_array, i);\n \n- ret = object_property_try_add(obj, full_name, type, get, set,\n- release, flags, opaque, NULL);\n+ ret = object_property_add_full(obj, full_name, type, get, set,\n+ release, flags, opaque, NULL);\n g_free(full_name);\n if (ret) {\n break;\n@@ -1305,19 +1305,19 @@ object_property_add(Object *obj, const char *name, const char *type,\n ObjectPropertyRelease *release,\n void *opaque)\n {\n- return object_property_try_add(obj, name, type, get, set, release,\n- 0, opaque, &error_abort);\n+ return object_property_add_full(obj, name, type, get, set, release,\n+ 0, opaque, &error_abort);\n }\n \n ObjectProperty *\n-object_class_property_try_add(ObjectClass *klass,\n- const char *name,\n- const char *type,\n- ObjectPropertyAccessor *get,\n- ObjectPropertyAccessor *set,\n- ObjectPropertyRelease *release,\n- ObjectPropertyFlags flags,\n- void *opaque, Error **errp)\n+object_class_property_add_full(ObjectClass *klass,\n+ const char *name,\n+ const char *type,\n+ ObjectPropertyAccessor *get,\n+ ObjectPropertyAccessor *set,\n+ ObjectPropertyRelease *release,\n+ ObjectPropertyFlags flags,\n+ void *opaque, Error **errp)\n {\n ObjectProperty *prop;\n \n@@ -1352,8 +1352,8 @@ object_class_property_add(ObjectClass *klass,\n ObjectPropertyRelease *release,\n void *opaque)\n {\n- return object_class_property_try_add(klass, name, type, get, set, release,\n- 0, opaque, &error_abort);\n+ return object_class_property_add_full(klass, name, type, get, set, release,\n+ 0, opaque, &error_abort);\n }\n \n ObjectProperty *object_property_find(Object *obj, const char *name)\n@@ -1863,9 +1863,9 @@ object_property_try_add_child(Object *obj, const char *name,\n \n type = g_strdup_printf(\"child<%s>\", object_get_typename(child));\n \n- op = object_property_try_add(obj, name, type, object_get_child_property,\n- NULL, object_finalize_child_property, 0,\n- child, errp);\n+ op = object_property_add_full(obj, name, type, object_get_child_property,\n+ NULL, object_finalize_child_property, 0,\n+ child, errp);\n if (!op) {\n return NULL;\n }\n", "prefixes": [ "v2", "05/21" ] }