Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194788/?format=api
{ "id": 2194788, "url": "http://patchwork.ozlabs.org/api/patches/2194788/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260209233234.29802-1-jemarch@gnu.org/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260209233234.29802-1-jemarch@gnu.org>", "list_archive_url": null, "date": "2026-02-09T23:32:34", "name": "[COMMITTED] a68: avoid uninitialized save_expr in a68_bits_shift [PR algol68/124028]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "16d46c8a3fdf9e0abf8528b10993b29a86b94023", "submitter": { "id": 53513, "url": "http://patchwork.ozlabs.org/api/people/53513/?format=api", "name": "Jose E. Marchesi", "email": "jemarch@gnu.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260209233234.29802-1-jemarch@gnu.org/mbox/", "series": [ { "id": 491578, "url": "http://patchwork.ozlabs.org/api/series/491578/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=491578", "date": "2026-02-09T23:32:34", "name": "[COMMITTED] a68: avoid uninitialized save_expr in a68_bits_shift [PR algol68/124028]", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491578/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194788/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194788/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256\n header.s=fencepost-gnu-org header.b=kJriunFh;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256\n header.s=fencepost-gnu-org header.b=kJriunFh", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gnu.org", "sourceware.org; spf=pass smtp.mailfrom=gnu.org", "server2.sourceware.org;\n arc=none smtp.remote-ip=209.51.188.92" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f91GR5Jjbz1xtr\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 10:33:18 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 2004D48F52ED\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 9 Feb 2026 23:33:16 +0000 (GMT)", "from eggs.gnu.org (eggs.gnu.org [209.51.188.92])\n by sourceware.org (Postfix) with ESMTPS id 5FBD748FE0AC;\n Mon, 9 Feb 2026 23:32:48 +0000 (GMT)", "from fencepost.gnu.org ([2001:470:142:3::e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jemarch@gnu.org>)\n id 1vpakJ-0003eW-V8; Mon, 09 Feb 2026 18:32:47 -0500" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 2004D48F52ED", "OpenDKIM Filter v2.11.0 sourceware.org 5FBD748FE0AC" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 5FBD748FE0AC", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 5FBD748FE0AC", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770679968; cv=none;\n b=J3UxiXrUfqNlgVDPbLZX3XHepAysPVo9PcFK4uGXhL4TSKhch5bYnNlrCnOyzSp270BivqNSauzNZicLGC2+kik8ry3EOJxdv+ZJIqFsQUa1FvbvCNdKDwM94dMmtn2DaTdb8j8WylfoffJOLqhP/j61/hsrmGfjKYA5BYB4kZA=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1770679968; c=relaxed/simple;\n bh=1WI6WVY7iGY3bMcdI3q5AdTaw0Stj1uEmJExAMA1+7s=;\n h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version;\n b=hWIwWQiGbs4IGtFrsju6I+HewdwZhnyDJM0pKB7Pc+9HUuWbow8mOFIzhe34ckMsg8wKNClWq3GJ6LjSTXVWv9fdcOgOaQZf9ouiD0m9zA9p0/LFOPD92XW+LVtAU4Wr8xxH0KFp+EDPjZxF5qrZE0HGc8sNd+plzwul20NG+BQ=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;\n s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to:\n references; bh=3z93B69QGX0M5yN7WuH7yCk2ICefcMyrf7E7hvaHR6o=; b=kJriunFhWcUrEY\n gMDMcyfJiz1y2Vljn8xaQ3qopY2NOhZZjaT/RLLTBDa52nzIg+H70mLCxE+LyoRy7zVBRk3Np6olF\n slt9LEY8lWXarsCgmIVcqtEjxwVCEic+FGeniNTuuw68CBBlWnGMzmEihSr1a73y0UNOwLlKGUntI\n 9hGXRputr58H9aGMYm6qqfL38SQkAEdhZitkij0qrv9c9cNNULzmHxdFLblptO7BOjysbJUbvYFI8\n g0qVeZatBjILMMVXO9fu5XYxCixZIFzldl37BfQS6a7jV29SUV9XIX4IPgTzsd5mk0dZupTd2eOBJ\n oY24DI4LcdHyoeyloQOw==;", "From": "\"Jose E. Marchesi\" <jemarch@gnu.org>", "To": "gcc-patches@gcc.gnu.org", "Cc": "algol68@gcc.gnu.org", "Subject": "[COMMITTED] a68: avoid uninitialized save_expr in a68_bits_shift [PR\n algol68/124028]", "Date": "Tue, 10 Feb 2026 00:32:34 +0100", "Message-Id": "<20260209233234.29802-1-jemarch@gnu.org>", "X-Mailer": "git-send-email 2.39.5", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "Signed-off-by: Jose E. Marchesi <jemarch@gnu.org>\n\ngcc/algol68/ChangeLog\n\n\tPR algol68/124028\n\t* a68-low-bits.cc (a68_bits_shift): Avoid uninitialized save_expr.\n\ngcc/testsuite/ChangeLog\n\n\tPR algol68/124028\n\t* algol68/execute/bits-shift-4.a68: New test.\n---\n gcc/algol68/a68-low-bits.cc | 14 ++++++++------\n gcc/testsuite/algol68/execute/bits-shift-4.a68 | 10 ++++++++++\n 2 files changed, 18 insertions(+), 6 deletions(-)\n create mode 100644 gcc/testsuite/algol68/execute/bits-shift-4.a68", "diff": "diff --git a/gcc/algol68/a68-low-bits.cc b/gcc/algol68/a68-low-bits.cc\nindex 81b4f98c4fa..1857b830cb1 100644\n--- a/gcc/algol68/a68-low-bits.cc\n+++ b/gcc/algol68/a68-low-bits.cc\n@@ -283,12 +283,14 @@ a68_bits_shift (NODE_T *p, tree shift, tree bits)\n \t\t\t\t\t\tshift, build_zero_cst (shift_type)),\n \t\t\t\t shifted_right, shifted_left);\n \n- return fold_build3_loc (a68_get_node_location (p),\n-\t\t\t COND_EXPR,\n-\t\t\t TREE_TYPE (bits),\n-\t\t\t fold_build2 (LT_EXPR, TREE_TYPE (abs_shift),\n-\t\t\t\t abs_shift, a68_bits_width (bits_type)),\n-\t\t\t shifted_bits, build_zero_cst (bits_type));\n+ return fold_build2 (COMPOUND_EXPR, TREE_TYPE (bits),\n+\t\t bits,\n+\t\t fold_build3_loc (a68_get_node_location (p),\n+\t\t\t\t COND_EXPR,\n+\t\t\t\t TREE_TYPE (bits),\n+\t\t\t\t fold_build2 (LT_EXPR, TREE_TYPE (abs_shift),\n+\t\t\t\t\t\t abs_shift, a68_bits_width (bits_type)),\n+\t\t\t\t shifted_bits, build_zero_cst (bits_type)));\n }\n \n /* Given two bits values, build an expression that calculates whether A = B. */\ndiff --git a/gcc/testsuite/algol68/execute/bits-shift-4.a68 b/gcc/testsuite/algol68/execute/bits-shift-4.a68\nnew file mode 100644\nindex 00000000000..87188fbf2dd\n--- /dev/null\n+++ b/gcc/testsuite/algol68/execute/bits-shift-4.a68\n@@ -0,0 +1,10 @@\n+begin\n+ int shft := 2;\n+\n+ int i := 12;\n+ bits x = BIN i;\n+ int j := Abs(x Shl 2);\n+ int k := Abs(x Shl shft);\n+\n+ assert (j = k)\n+end\n", "prefixes": [ "COMMITTED" ] }