Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194778/?format=api
{ "id": 2194778, "url": "http://patchwork.ozlabs.org/api/patches/2194778/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260209222207.27448-1-jemarch@gnu.org/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260209222207.27448-1-jemarch@gnu.org>", "list_archive_url": null, "date": "2026-02-09T22:22:07", "name": "[COMMITTED] a68: avoid finalizing free standing proc holes twice", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3f4549f5520605312763855fd89b98a1dab56b93", "submitter": { "id": 53513, "url": "http://patchwork.ozlabs.org/api/people/53513/?format=api", "name": "Jose E. Marchesi", "email": "jemarch@gnu.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260209222207.27448-1-jemarch@gnu.org/mbox/", "series": [ { "id": 491573, "url": "http://patchwork.ozlabs.org/api/series/491573/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=491573", "date": "2026-02-09T22:22:07", "name": "[COMMITTED] a68: avoid finalizing free standing proc holes twice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491573/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194778/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194778/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256\n header.s=fencepost-gnu-org header.b=ERdYl0XD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256\n header.s=fencepost-gnu-org header.b=ERdYl0XD", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gnu.org", "sourceware.org; spf=pass smtp.mailfrom=gnu.org", "server2.sourceware.org;\n arc=none smtp.remote-ip=209.51.188.92" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f8zjN2lbsz1xvb\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 09:23:04 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 5093848F66C6\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 9 Feb 2026 22:23:02 +0000 (GMT)", "from eggs.gnu.org (eggs.gnu.org [209.51.188.92])\n by sourceware.org (Postfix) with ESMTPS id BF24548FDB0F;\n Mon, 9 Feb 2026 22:22:14 +0000 (GMT)", "from fencepost.gnu.org ([2001:470:142:3::e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jemarch@gnu.org>)\n id 1vpZe1-0006nE-M5; Mon, 09 Feb 2026 17:22:14 -0500" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 5093848F66C6", "OpenDKIM Filter v2.11.0 sourceware.org BF24548FDB0F" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org BF24548FDB0F", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org BF24548FDB0F", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770675734; cv=none;\n b=A1u/uBKUZyid0LULUp/GD2CyElXjhfq1sKGVYdZ9c9tLaBLLY+M3+9XNjx6ZcBp3tgyAcj4BkarydY0x7M6sZNF9p8IV47zMaBDcO1m9ktXtymKvwynVPoIJRKTmv3oFluarYGqs8aeAMThx9jzV6yUygmjoqP1lb+xvmiBp/MU=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1770675734; c=relaxed/simple;\n bh=Er0eZZnNd2WLvUf5LSib4hZTzPjm5k7I5jQ4zMLBKno=;\n h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version;\n b=HFz5vQbXvfUTPuaBsKp3bvo9vBiuM4AR9HuYmWEFmeeQlHA60ribY6pDRTu+clQ2mrd5dLbfQRJ2RnocVjcRniPtjuut1vh0kPoJYV6CP9uIoa0MVBNn/Qnu7Y6nA8OntEA8+eOhuh2txEhsBw604o+fDtRXGhSZzLIJuy8GrFI=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;\n s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to:\n references; bh=9XoNkwBOJ5U0PCsh5muvS5HYYnUHbcMZ2yIMwHxKKWI=; b=ERdYl0XD11x5Vf\n aK1bH5wMZeTIVhVU8OOq6YKYY0gmElze8a2t7+rNIBwcgNL5VvU4CsJimMp8i6ZTa70WJ8GS0/SvT\n b5vZyalFWaP8UJ4sZEeIOajrViWRcNZUKzJFCJN4ZvqqoHB/zmqC4RJgEUlZyYCiaYlqSFKxf0ede\n Lv/LMbgzEox3STWdmxW7YIjUfIDZnccRErEYCC/t+s3lmo3r4qwUvN2HtRlByd6MXFBi/XRjNHWbU\n FRiRhlW2D2AudoZPfgaTXSM3hF94Heg+/ubWmMhF6gF80XPcVptuApOIF5wmNZGrt4DFFnVgOOGXy\n PXo4jaP/LcbFqjCK/y+A==;", "From": "\"Jose E. Marchesi\" <jemarch@gnu.org>", "To": "gcc-patches@gcc.gnu.org", "Cc": "algol68@gcc.gnu.org", "Subject": "[COMMITTED] a68: avoid finalizing free standing proc holes twice", "Date": "Mon, 9 Feb 2026 23:22:07 +0100", "Message-Id": "<20260209222207.27448-1-jemarch@gnu.org>", "X-Mailer": "git-send-email 2.39.5", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "Signed-off-by: Jose E. Marchesi <jemarch@gnu.org>\n\ngcc/algol68/ChangeLog\n\n\t* a68-low-holes.cc (a68_wrap_formal_proc_hole): The wrapper is not\n\ta top-level function.\n\t* a68-low-units.cc (a68_lower_formal_hole): Reorder code and\n\tremove spurious comment.\n\ngcc/testsuite/ChangeLog\n\n\t* algol68/compile/formal-hole-1.a68: New test.\n---\n gcc/algol68/a68-low-holes.cc | 2 +-\n gcc/algol68/a68-low-units.cc | 5 ++---\n gcc/testsuite/algol68/compile/formal-hole-1.a68 | 7 +++++++\n 3 files changed, 10 insertions(+), 4 deletions(-)\n create mode 100644 gcc/testsuite/algol68/compile/formal-hole-1.a68", "diff": "diff --git a/gcc/algol68/a68-low-holes.cc b/gcc/algol68/a68-low-holes.cc\nindex 2a6a02a9020..3eca4e4e0b2 100644\n--- a/gcc/algol68/a68-low-holes.cc\n+++ b/gcc/algol68/a68-low-holes.cc\n@@ -164,7 +164,7 @@ a68_wrap_formal_proc_hole (NODE_T *p, tree wrapper)\n }\n DECL_ARGUMENTS (wrapper) = nreverse (DECL_ARGUMENTS (wrapper));\n \n- a68_push_function_range (wrapper, wrapper_ret_type, true /* top_level */);\n+ a68_push_function_range (wrapper, wrapper_ret_type);\n \n /* We need a pointer to a function type. */\n if (!POINTER_TYPE_P (TREE_TYPE (wrapped)))\ndiff --git a/gcc/algol68/a68-low-units.cc b/gcc/algol68/a68-low-units.cc\nindex c5ae0d47328..23f4f22e7c1 100644\n--- a/gcc/algol68/a68-low-units.cc\n+++ b/gcc/algol68/a68-low-units.cc\n@@ -1296,13 +1296,12 @@ a68_lower_formal_hole (NODE_T *p, LOW_CTX_T ctx ATTRIBUTE_UNUSED)\n \t{\n \t decl = a68_make_anonymous_routine_decl (MOID (p));\n \t a68_add_decl (decl);\n-\t a68_wrap_formal_proc_hole (p, decl);\n-\n-\t /* XXX necessary */\n \t a68_add_decl_expr (fold_build1_loc (a68_get_node_location (p),\n \t\t\t\t\t DECL_EXPR,\n \t\t\t\t\t TREE_TYPE (decl),\n \t\t\t\t\t decl));\n+\t a68_wrap_formal_proc_hole (p, decl);\n+\n \t decl = fold_build1 (ADDR_EXPR,\n \t\t\t build_pointer_type (TREE_TYPE (decl)),\n \t\t\t decl);\ndiff --git a/gcc/testsuite/algol68/compile/formal-hole-1.a68 b/gcc/testsuite/algol68/compile/formal-hole-1.a68\nnew file mode 100644\nindex 00000000000..95fe2bc60c7\n--- /dev/null\n+++ b/gcc/testsuite/algol68/compile/formal-hole-1.a68\n@@ -0,0 +1,7 @@\n+{ Freestanding formal hole. }\n+\n+begin\n+ proc msleep = (int ms) void:\n+ proc(bits)int (nest C \"usleep\") (BIN ms);\n+ skip\n+end\n", "prefixes": [ "COMMITTED" ] }