Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194489/?format=api
{ "id": 2194489, "url": "http://patchwork.ozlabs.org/api/patches/2194489/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260209073908.2125178-3-vsementsov@yandex-team.ru/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260209073908.2125178-3-vsementsov@yandex-team.ru>", "list_archive_url": null, "date": "2026-02-09T07:38:59", "name": "[02/10] vhost: use consistent naming for backend handlers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4d0f6df88eefbf8fa90eadbc68477bbfb79fe2a9", "submitter": { "id": 84116, "url": "http://patchwork.ozlabs.org/api/people/84116/?format=api", "name": "Vladimir Sementsov-Ogievskiy", "email": "vsementsov@yandex-team.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260209073908.2125178-3-vsementsov@yandex-team.ru/mbox/", "series": [ { "id": 491471, "url": "http://patchwork.ozlabs.org/api/series/491471/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491471", "date": "2026-02-09T07:38:57", "name": "vhost-user: VHOST_USER_PROTOCOL_F_GPA_ADDRESSES", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491471/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194489/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194489/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=PW99u9DJ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f8c6N6KBcz1xwN\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 09 Feb 2026 18:39:56 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vpLrp-0000q3-Mm; Mon, 09 Feb 2026 02:39:34 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1vpLrh-0000n8-0G\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 02:39:27 -0500", "from forwardcorp1d.mail.yandex.net ([178.154.239.200])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1vpLrb-0004fV-Bq\n for qemu-devel@nongnu.org; Mon, 09 Feb 2026 02:39:23 -0500", "from mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net\n [IPv6:2a02:6b8:c42:65a0:0:640:e1de:0])\n by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id D4E3D80750;\n Mon, 09 Feb 2026 10:39:14 +0300 (MSK)", "from vsementsov-lin (unknown [2a02:6bf:8080:129::1:13])\n by mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id BdLXu72As8c0-HJP9oJY0; Mon, 09 Feb 2026 10:39:14 +0300" ], "X-Yandex-Fwd": "1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1770622754;\n bh=wR1zkaBlJ6m8/QrbNS3UX5TXoWTTPeYfvjxD/qZ1o9c=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=PW99u9DJC5hyCu+fHqUuynazLm5XAjTGfoFq749Z9/1cIgmxaZI2wjW2dOyTFqzRJ\n 73N9IXuiG481M//b4tU6lVATr9EqbqRofqcmF2r90wqz+dCqY36h51eJUc5KSJsmC4\n WCyyTIwPBZQ35KJaCbr6s89f0IZGSDXWOhMeKTX8=", "From": "Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "To": "mst@redhat.com", "Cc": "sgarzare@redhat.com, qemu-devel@nongnu.org, vsementsov@yandex-team.ru,\n d-tatianin@yandex-team.ru", "Subject": "[PATCH 02/10] vhost: use consistent naming for backend handlers", "Date": "Mon, 9 Feb 2026 10:38:59 +0300", "Message-ID": "<20260209073908.2125178-3-vsementsov@yandex-team.ru>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260209073908.2125178-1-vsementsov@yandex-team.ru>", "References": "<20260209073908.2125178-1-vsementsov@yandex-team.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=178.154.239.200;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Most of handlers start from simply .vhost_, except for these\nfour, starting from .vhost_backend_. Let's rename them to be\nconsistent.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n---\n hw/virtio/vhost-backend.c | 6 +++---\n hw/virtio/vhost-user.c | 8 ++++----\n hw/virtio/vhost-vdpa.c | 6 +++---\n hw/virtio/vhost.c | 14 +++++++-------\n include/hw/virtio/vhost-backend.h | 17 ++++++++---------\n 5 files changed, 25 insertions(+), 26 deletions(-)", "diff": "diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c\nindex fea88afc39..caeadd069b 100644\n--- a/hw/virtio/vhost-backend.c\n+++ b/hw/virtio/vhost-backend.c\n@@ -358,9 +358,9 @@ static void vhost_kernel_set_iotlb_callback(struct vhost_dev *dev,\n \n const VhostOps kernel_ops = {\n .backend_type = VHOST_BACKEND_TYPE_KERNEL,\n- .vhost_backend_init = vhost_kernel_init,\n- .vhost_backend_cleanup = vhost_kernel_cleanup,\n- .vhost_backend_memslots_limit = vhost_kernel_memslots_limit,\n+ .vhost_init = vhost_kernel_init,\n+ .vhost_cleanup = vhost_kernel_cleanup,\n+ .vhost_memslots_limit = vhost_kernel_memslots_limit,\n .vhost_net_set_backend = vhost_kernel_net_set_backend,\n .vhost_scsi_set_endpoint = vhost_kernel_scsi_set_endpoint,\n .vhost_scsi_clear_endpoint = vhost_kernel_scsi_clear_endpoint,\ndiff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c\nindex c750b32617..2e58f38ac5 100644\n--- a/hw/virtio/vhost-user.c\n+++ b/hw/virtio/vhost-user.c\n@@ -3118,10 +3118,10 @@ void vhost_user_qmp_status(struct vhost_dev *dev, VirtioStatus *status)\n \n const VhostOps user_ops = {\n .backend_type = VHOST_BACKEND_TYPE_USER,\n- .vhost_backend_init = vhost_user_backend_init,\n- .vhost_backend_cleanup = vhost_user_backend_cleanup,\n- .vhost_backend_memslots_limit = vhost_user_memslots_limit,\n- .vhost_backend_no_private_memslots = vhost_user_no_private_memslots,\n+ .vhost_init = vhost_user_backend_init,\n+ .vhost_cleanup = vhost_user_backend_cleanup,\n+ .vhost_memslots_limit = vhost_user_memslots_limit,\n+ .vhost_no_private_memslots = vhost_user_no_private_memslots,\n .vhost_set_log_base = vhost_user_set_log_base,\n .vhost_set_mem_table = vhost_user_set_mem_table,\n .vhost_set_vring_addr = vhost_user_set_vring_addr,\ndiff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c\nindex 2f8f11df86..fd9e92092d 100644\n--- a/hw/virtio/vhost-vdpa.c\n+++ b/hw/virtio/vhost-vdpa.c\n@@ -1590,8 +1590,8 @@ static bool vhost_vdpa_force_iommu(struct vhost_dev *dev)\n \n const VhostOps vdpa_ops = {\n .backend_type = VHOST_BACKEND_TYPE_VDPA,\n- .vhost_backend_init = vhost_vdpa_init,\n- .vhost_backend_cleanup = vhost_vdpa_cleanup,\n+ .vhost_init = vhost_vdpa_init,\n+ .vhost_cleanup = vhost_vdpa_cleanup,\n .vhost_set_log_base = vhost_vdpa_set_log_base,\n .vhost_set_vring_addr = vhost_vdpa_set_vring_addr,\n .vhost_set_vring_num = vhost_vdpa_set_vring_num,\n@@ -1602,7 +1602,7 @@ const VhostOps vdpa_ops = {\n .vhost_get_features = vhost_vdpa_get_features,\n .vhost_set_owner = vhost_vdpa_set_owner,\n .vhost_set_vring_endian = NULL,\n- .vhost_backend_memslots_limit = vhost_vdpa_memslots_limit,\n+ .vhost_memslots_limit = vhost_vdpa_memslots_limit,\n .vhost_set_mem_table = vhost_vdpa_set_mem_table,\n .vhost_set_features = vhost_vdpa_set_features,\n .vhost_reset_device = vhost_vdpa_reset_device,\ndiff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c\nindex 3ee353dce0..fe63091985 100644\n--- a/hw/virtio/vhost.c\n+++ b/hw/virtio/vhost.c\n@@ -58,7 +58,7 @@ unsigned int vhost_get_max_memslots(void)\n struct vhost_dev *hdev;\n \n QLIST_FOREACH(hdev, &vhost_devices, entry) {\n- max = MIN(max, hdev->vhost_ops->vhost_backend_memslots_limit(hdev));\n+ max = MIN(max, hdev->vhost_ops->vhost_memslots_limit(hdev));\n }\n return max;\n }\n@@ -69,7 +69,7 @@ unsigned int vhost_get_free_memslots(void)\n struct vhost_dev *hdev;\n \n QLIST_FOREACH(hdev, &vhost_devices, entry) {\n- unsigned int r = hdev->vhost_ops->vhost_backend_memslots_limit(hdev);\n+ unsigned int r = hdev->vhost_ops->vhost_memslots_limit(hdev);\n unsigned int cur_free = r - hdev->mem->nregions;\n \n if (unlikely(r < hdev->mem->nregions)) {\n@@ -664,8 +664,8 @@ static bool vhost_section(struct vhost_dev *dev, MemoryRegionSection *section)\n */\n if ((memory_region_get_fd(section->mr) < 0 ||\n !qemu_ram_is_shared(section->mr->ram_block)) &&\n- dev->vhost_ops->vhost_backend_no_private_memslots &&\n- dev->vhost_ops->vhost_backend_no_private_memslots(dev)) {\n+ dev->vhost_ops->vhost_no_private_memslots &&\n+ dev->vhost_ops->vhost_no_private_memslots(dev)) {\n trace_vhost_reject_section(mr->name, 2);\n return false;\n }\n@@ -1677,7 +1677,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,\n r = vhost_set_backend_type(hdev, backend_type);\n assert(r >= 0);\n \n- r = hdev->vhost_ops->vhost_backend_init(hdev, opaque, errp);\n+ r = hdev->vhost_ops->vhost_init(hdev, opaque, errp);\n if (r < 0) {\n goto fail;\n }\n@@ -1694,7 +1694,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,\n goto fail;\n }\n \n- limit = hdev->vhost_ops->vhost_backend_memslots_limit(hdev);\n+ limit = hdev->vhost_ops->vhost_memslots_limit(hdev);\n if (limit < MEMORY_DEVICES_SAFE_MAX_MEMSLOTS &&\n memory_devices_memslot_auto_decision_active()) {\n error_setg(errp, \"some memory device (like virtio-mem)\"\n@@ -1812,7 +1812,7 @@ void vhost_dev_cleanup(struct vhost_dev *hdev)\n g_free(hdev->mem);\n g_free(hdev->mem_sections);\n if (hdev->vhost_ops) {\n- hdev->vhost_ops->vhost_backend_cleanup(hdev);\n+ hdev->vhost_ops->vhost_cleanup(hdev);\n }\n assert(!hdev->log);\n \ndiff --git a/include/hw/virtio/vhost-backend.h b/include/hw/virtio/vhost-backend.h\nindex 57497e197a..aab6bf3ef7 100644\n--- a/include/hw/virtio/vhost-backend.h\n+++ b/include/hw/virtio/vhost-backend.h\n@@ -51,10 +51,9 @@ struct vhost_scsi_target;\n struct vhost_iotlb_msg;\n struct vhost_virtqueue;\n \n-typedef int (*vhost_backend_init)(struct vhost_dev *dev, void *opaque,\n- Error **errp);\n-typedef int (*vhost_backend_cleanup)(struct vhost_dev *dev);\n-typedef int (*vhost_backend_memslots_limit)(struct vhost_dev *dev);\n+typedef int (*vhost_init)(struct vhost_dev *dev, void *opaque, Error **errp);\n+typedef int (*vhost_cleanup)(struct vhost_dev *dev);\n+typedef int (*vhost_memslots_limit)(struct vhost_dev *dev);\n \n typedef int (*vhost_net_set_backend_op)(struct vhost_dev *dev,\n struct vhost_vring_file *file);\n@@ -131,7 +130,7 @@ typedef int (*vhost_crypto_create_session_op)(struct vhost_dev *dev,\n typedef int (*vhost_crypto_close_session_op)(struct vhost_dev *dev,\n uint64_t session_id);\n \n-typedef bool (*vhost_backend_no_private_memslots_op)(struct vhost_dev *dev);\n+typedef bool (*vhost_no_private_memslots_op)(struct vhost_dev *dev);\n \n typedef int (*vhost_get_inflight_fd_op)(struct vhost_dev *dev,\n uint16_t queue_size,\n@@ -166,10 +165,10 @@ typedef int (*vhost_check_device_state_op)(struct vhost_dev *dev, Error **errp);\n \n typedef struct VhostOps {\n VhostBackendType backend_type;\n- vhost_backend_init vhost_backend_init;\n- vhost_backend_cleanup vhost_backend_cleanup;\n- vhost_backend_memslots_limit vhost_backend_memslots_limit;\n- vhost_backend_no_private_memslots_op vhost_backend_no_private_memslots;\n+ vhost_init vhost_init;\n+ vhost_cleanup vhost_cleanup;\n+ vhost_memslots_limit vhost_memslots_limit;\n+ vhost_no_private_memslots_op vhost_no_private_memslots;\n vhost_net_set_backend_op vhost_net_set_backend;\n vhost_net_set_mtu_op vhost_net_set_mtu;\n vhost_scsi_set_endpoint_op vhost_scsi_set_endpoint;\n", "prefixes": [ "02/10" ] }