Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194437/?format=api
{ "id": 2194437, "url": "http://patchwork.ozlabs.org/api/patches/2194437/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/5809356.IbC2pHGDlb@fomalhaut/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<5809356.IbC2pHGDlb@fomalhaut>", "list_archive_url": null, "date": "2026-02-09T00:09:51", "name": "[Ada] Fix too small component size for fixed-point array type incorrectly accepted", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "82ae2eb1685d780698d36f9676096a391dc66341", "submitter": { "id": 78832, "url": "http://patchwork.ozlabs.org/api/people/78832/?format=api", "name": "Eric Botcazou", "email": "botcazou@adacore.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/5809356.IbC2pHGDlb@fomalhaut/mbox/", "series": [ { "id": 491450, "url": "http://patchwork.ozlabs.org/api/series/491450/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=491450", "date": "2026-02-09T00:09:51", "name": "[Ada] Fix too small component size for fixed-point array type incorrectly accepted", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491450/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194437/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194437/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256\n header.s=google header.b=dfxLIOrw;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256\n header.s=google header.b=dfxLIOrw", "sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=adacore.com", "sourceware.org; spf=pass smtp.mailfrom=adacore.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.128.54" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f8Q8P1hqGz1xvc\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 09 Feb 2026 11:11:00 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id C7FCF450A885\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 9 Feb 2026 00:10:58 +0000 (GMT)", "from mail-wm1-f54.google.com (mail-wm1-f54.google.com\n [209.85.128.54])\n by sourceware.org (Postfix) with ESMTPS id 91F6B452C4FB\n for <gcc-patches@gcc.gnu.org>; Mon, 9 Feb 2026 00:09:54 +0000 (GMT)", "by mail-wm1-f54.google.com with SMTP id\n 5b1f17b1804b1-47edd9024b1so29075575e9.3\n for <gcc-patches@gcc.gnu.org>; Sun, 08 Feb 2026 16:09:54 -0800 (PST)", "from fomalhaut.localnet ([2a01:e0a:8d5:d990:e654:e8ff:fe8f:2ce6])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-483206b8bbbsm346469205e9.3.2026.02.08.16.09.52\n for <gcc-patches@gcc.gnu.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 08 Feb 2026 16:09:52 -0800 (PST)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org C7FCF450A885", "OpenDKIM Filter v2.11.0 sourceware.org 91F6B452C4FB" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 91F6B452C4FB", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 91F6B452C4FB", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770595794; cv=none;\n b=UESalRRmzUJ7qi+CFp3CImCcBTrAEwYZrLKXAXyR/ZsDY6zvRjfbRTpY8EblgHhRlKOXmCGdsZ+NKwRLMQc50Umf0P4qOcZno3ecy/0638RSHgRPLp6tEyZEN0j5lg0lMPxePKTEI/bhc1kfWDrB2qvirhK48EfM/L0szQJg2bI=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1770595794; c=relaxed/simple;\n bh=3nZbq9copUtArodsY1kbwKSVctG9iLsBNAtQ9O0dCZQ=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=ce5DsS89c3IP1qmroSfdvc87gjRQdq6vYn8M0fV+/Wg7YTEtFFYpyKvivtrxm4/Bzvavhw6A7rE5IirnHDYnSIPU+fwEQw1HuiQX4eZa2DKEsItwQT1p0ZCzENJAcc60kg0PzKE3Ko5cSVKJ/N7213PFnVu0o9C2O20ceZZ/kZE=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=adacore.com; s=google; t=1770595793; x=1771200593; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:to\n :from:from:to:cc:subject:date:message-id:reply-to;\n bh=GLUBNB7oPVA5hiaZ+hNL3CazuON4/4dEdkvKZi2BM6g=;\n b=dfxLIOrw+i+lspu0UZCn6ez1j90ci8xbTskRafnE/yaYtbjt74DjOxYZLH1IEOIOHp\n iasNAM5oKkz/4eAddWga859BbEe+D19gCPYgNaLvLavAtivFMsF9pqWzejDAYG8xaXYB\n GPQWOUcuJWELTJbHU6QNaqFvnsM5mbBqF+YZkhfYGZOhynCxuqFvNCmV0YMUaPYbDD0i\n bMZVV/1uM2HMFJKQhlJlLCk6grVasf+KLiPehgK5BbF2KJZTJCKB90RhPV8WOT8Pxam/\n XJO9nPaPDIVyqkXZORo4MsW505h7OW6zc53OxNUQxnHNikuw4gNIcIycozaVKWrmhJ+x\n 2Cvw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770595793; x=1771200593;\n h=content-transfer-encoding:mime-version:message-id:date:subject:to\n :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=GLUBNB7oPVA5hiaZ+hNL3CazuON4/4dEdkvKZi2BM6g=;\n b=VoEKiRvLGNHiP0+TAp7i9CLb8d07SfC+cNpnSFGYBaZdm+ADzjX/HMwfxBt9JHGz07\n 6i+9ofGDtQvuBSPQt/mWu+IijNrobjTDWmbPlHstt6h/MTnOvC79HpGP5Cn2p9kpViKK\n IpFR4a0g5dp6WhvuM5nHt39NOnxfcYak0JvKycnhRC46HsNnEWc52I9UBO5TvEznE911\n J+GPaRlFsB1TZpkCAmI5m1D6dpxkqlBMJYGodpOmfFL/svKDYDGQ+a0uZIsiUPH+OqQj\n +/sX/1Y4nMU8XnwNo8iPtxBqlUcNQ/kXTXleUBEnMf0dO5ZtpsCGe2URYjxqaFH+ZmrH\n a4ww==", "X-Gm-Message-State": "AOJu0Yy5kOQS7/kHYeYLHOdJ7ALfr+bQUobU02JM7dLOe0x20l2kazbV\n auy/9TEHQi3VpJQBnlf++sZZpZZPf0L8tz4ty6XwrNa6LXI+9OixcQ8aCS3GMYiYJ2sPb4f82qJ\n i22LLcA==", "X-Gm-Gg": "AZuq6aImdSCVRx0tXWcPjyUCEcU+1YkfA5yQGRCoLWACQly3AiI1w+zZ1ZiE832W+4B\n okMTP6JJSn7vZYgj7/Lu35JF28Gcm+7PMLobRN/N0uk0VAY2EmTth4zGNzkCd0EFv+n9uxJ7dQz\n WyEo9teXnXzpvirvIe4OjneIC+vKpQ8IADTCc2zsiCb30GYETcpfTp6BJJ570idP7ysD4MStJbY\n pDG+QGMaAJWEBy9J/KgnKjJCXvJhfAz/9tUFUHJUz4wFhu217RlVhfc3vgzik4N4oBRMgDH52dp\n a6B+M4ToZGrd0Ik1QBveY5nKOwdKDKTtgj9Q11XVEf5U2OQdSu6LaOAQ759CHyzzZGRNIykDdp5\n OntbfgwQGp3AQ9X0YiXD356QVRJvJnEHO8T9PXK0FP1XMvHxGHQU2jJGtcsusNaN1PiHjpSCG/D\n jtguIPiRkXmp6sc/SPvq7uhH4=", "X-Received": "by 2002:a05:600c:5253:b0:480:6941:d38b with SMTP id\n 5b1f17b1804b1-4832021cdcamr128608175e9.30.1770595793405;\n Sun, 08 Feb 2026 16:09:53 -0800 (PST)", "From": "Eric Botcazou <botcazou@adacore.com>", "X-Google-Original-From": "Eric Botcazou <ebotcazou@adacore.com>", "To": "gcc-patches@gcc.gnu.org", "Subject": "[Ada] Fix too small component size for fixed-point array type\n incorrectly accepted", "Date": "Mon, 09 Feb 2026 01:09:51 +0100", "Message-ID": "<5809356.IbC2pHGDlb@fomalhaut>", "MIME-Version": "1.0", "Content-Type": "multipart/mixed; boundary=\"nextPart2906740.DJkKcVGEfx\"", "Content-Transfer-Encoding": "7Bit", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "This plugs a loophole in the validation of component size aspects/clauses \nspecified for array types, by copying what is done for record types.\n\nTested on x86-64/Linux, applied on the mainline.\n\n\n2026-02-08 Eric Botcazou <ebotcazou@adacore.com>\n Liam Powell <liam@liampwll.com>\n\n\tPR ada/121576\n\t* freeze.adb (Freeze_Array_Type): When the component size is\n\tspecified, check that it is valid when the component type is\n\teither a fixed-point type or a bit-packed array type.\n\n\n2026-02-08 Eric Botcazou <ebotcazou@adacore.com>\n Liam Powell <liam@liampwll.com>\n\n\t* gnat.dg/specs/component_size1.ads: New test.", "diff": "diff --git a/gcc/ada/freeze.adb b/gcc/ada/freeze.adb\nindex c1c6bac1fd6..836d84f6534 100644\n--- a/gcc/ada/freeze.adb\n+++ b/gcc/ada/freeze.adb\n@@ -3645,6 +3645,9 @@ package body Freeze is\n Clause : Node_Id;\n -- Set to Component_Size clause or Atomic pragma, if any\n \n+ Junk : Boolean;\n+ pragma Warnings (Off, Junk);\n+\n Non_Standard_Enum : Boolean := False;\n -- Set true if any of the index types is an enumeration type with a\n -- non-standard representation.\n@@ -3793,6 +3796,21 @@ package body Freeze is\n then\n Complain_CS (\"independent\", Min => True);\n end if;\n+\n+ -- If the component is of a fixed-point type, we must check\n+ -- the size. This is not done until the freeze point since,\n+ -- for fixed-point types, we do not know the size until the\n+ -- type is frozen. Likewise for a bit-packed array type.\n+\n+ if Is_Fixed_Point_Type (Ctyp)\n+ or else Is_Bit_Packed_Array (Ctyp)\n+ then\n+ Clause :=\n+ Get_Attribute_Definition_Clause\n+ (FS, Attribute_Component_Size);\n+ Check_Size\n+ (Expression (Clause), Ctyp, Component_Size (Arr), Junk);\n+ end if;\n end CS_Check;\n \n -- Check for Aliased or Atomic or Full Access or Independent\n", "prefixes": [ "Ada" ] }