Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194322/?format=api
{ "id": 2194322, "url": "http://patchwork.ozlabs.org/api/patches/2194322/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20260208162729.389830-1-dmitry.mityugov@gmail.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260208162729.389830-1-dmitry.mityugov@gmail.com>", "list_archive_url": null, "date": "2026-02-08T16:27:03", "name": "[ovs-dev,v1] configure: Add -Wmissing-[variable-]declarations compiler options.", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "475a33daa261b67962b587b9cc2678f013794292", "submitter": { "id": 92493, "url": "http://patchwork.ozlabs.org/api/people/92493/?format=api", "name": "Dmitry Mityugov", "email": "dmitry.mityugov@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20260208162729.389830-1-dmitry.mityugov@gmail.com/mbox/", "series": [ { "id": 491425, "url": "http://patchwork.ozlabs.org/api/series/491425/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=491425", "date": "2026-02-08T16:27:03", "name": "[ovs-dev,v1] configure: Add -Wmissing-[variable-]declarations compiler options.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491425/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194322/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/2194322/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ovs-dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=SfPiVzog;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)", "smtp1.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key)\n header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601\n header.b=SfPiVzog", "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.a=rsa-sha256 header.s=20230601 header.b=SfPiVzog" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f8Csz5Rhgz1xtr\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 09 Feb 2026 03:27:51 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id BF6888226E;\n\tSun, 8 Feb 2026 16:27:49 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 0sk0XlZ-bK18; Sun, 8 Feb 2026 16:27:48 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id B02C382258;\n\tSun, 8 Feb 2026 16:27:48 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 91E2FC02A4;\n\tSun, 8 Feb 2026 16:27:48 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id B8343C003D\n for <ovs-dev@openvswitch.org>; Sun, 8 Feb 2026 16:27:46 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 93A3140792\n for <ovs-dev@openvswitch.org>; Sun, 8 Feb 2026 16:27:46 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id NG-u6pxi84Sa for <ovs-dev@openvswitch.org>;\n Sun, 8 Feb 2026 16:27:46 +0000 (UTC)", "from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com\n [IPv6:2607:f8b0:4864:20::f2e])\n by smtp4.osuosl.org (Postfix) with ESMTPS id C33F440742\n for <ovs-dev@openvswitch.org>; Sun, 8 Feb 2026 16:27:45 +0000 (UTC)", "by mail-qv1-xf2e.google.com with SMTP id\n 6a1803df08f44-8946e0884afso47253796d6.1\n for <ovs-dev@openvswitch.org>; Sun, 08 Feb 2026 08:27:45 -0800 (PST)", "from localhost.localdomain ([5.8.36.110])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8954c3f01f7sm31685566d6.30.2026.02.08.08.27.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 08 Feb 2026 08:27:43 -0800 (PST)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org B02C382258", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org C33F440742" ], "Received-SPF": "Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::f2e; helo=mail-qv1-xf2e.google.com;\n envelope-from=dmitry.mityugov@gmail.com; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org C33F440742", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1770568064; x=1771172864; darn=openvswitch.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=+0iyf0x0BuLJCoOlRK+IDyhBddu/hJn+Vdk4gusZSaw=;\n b=SfPiVzogXUqSkqz+SO80BE243ij9+hZLtV2/LQy7WT4HQq20v+stoQkUxPwes7APX3\n o3selNHjaHlc3/QmtTTVvJFAh98DzIa4KIDk3jQGQ6L/sdpqIvu/QhsEp/O5nF5XqR4C\n kqD+dn1oQ2VD+xQXY6ACncEwdLD0VRuPx/dq7+u0WswgREKDi7X14z4GKpB0u+/PumCx\n 7aVM3ZApohEwKuIBez37uXBaH6Jq54Ox0wqdN7WYuCIZbMItT1z8X/JiXh8PSPF0uERh\n so6ZxhH0lk+FuD92emZg7cWzYzQjREoF9B3fXN/vs8RbewyqCVIMlEMF6vZm2nysvz8Z\n jU0A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770568064; x=1771172864;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=+0iyf0x0BuLJCoOlRK+IDyhBddu/hJn+Vdk4gusZSaw=;\n b=Du5bmu57XsUtbhB4alKy+QU9mO+ErMCfFXncPO9sB776oqTsrl3czLo5pRf6WR2HHh\n FwevVo/GnRYu0AtXyxeq2LLj60dPIxTUvXrox67xdLu+ahJRCDS7iNGskvM8qj8I6dOt\n Jra3D3ZikOKssHpiOL6rIrPWGGLRpBo/ENXPgSXKKqxSvmkafgIp3tXnQBUWz5FVyFfC\n cxSEA7dOEA7+xnedWQISSlnQronpJyfFgj4DvQ3z/CCHPWnUTgGvJJ1ipZCWCskFDYsL\n JjXAbrqqFLpI0c4Vd+E1uAxr9JGeV8HS03DiQdNu5fZZUA44a0gQScaNJs68yiD+Dp8s\n k5kQ==", "X-Gm-Message-State": "AOJu0YxQ9MKawz7LokOZ4tPdELFJZ0HAcFk7qqMY53CaOFcyLzuKIbC3\n 1yIuZ3bxZPQoQZY9zO234cjU6Ft5meQUMl1Mv2x3NsIt9NswdEJyUqpq3vuPtWJn", "X-Gm-Gg": "AZuq6aLjNdb3DpHJzNCmZ3GnHy9toDY7jSMxBBw9tpBbF1cHffeApDytfPep/TSjQRz\n MxIIg5sO170pSsrUR0es3tfmxQJiTsQN8H/7gtzBKU4VLR24lI5bWImz24mKBhPHCR4uB1h2Peu\n wmHE6XI36InoY5pqxqqLMwHCNUQcez1KjG8R8tUojrP9bx+KgTlTINxU7IXuKARpccy7j2MCrvf\n jw2lrwafM7ubBz8MR1niYqFX+X5fa3L0urVF5OZUQRxp6KNEqeZ0Kqc7r4sjNLAFA8HNMvaqTrY\n Q2RGHNc7I1eFXS1JkHNEpRr19SRUwgwVZxAtEyOYNGtOkmTHrN88unAJ3lajm6Ak+PxdguD7ltB\n L+lhxJHdD4SLqJ3ys1uFN/+qDa0DS2TMgB6lzN+qXYGWJD2POi5+Cl+9kNV0YpTM8OtYs0NxVVh\n twd2qJ36Kz60SxcHF2Ui2MNFAzazY=", "X-Received": "by 2002:a05:6214:405:b0:81b:23d:55a8 with SMTP id\n 6a1803df08f44-8953cd99e46mr127664796d6.59.1770568064082;\n Sun, 08 Feb 2026 08:27:44 -0800 (PST)", "From": "Dmitry Mityugov <dmitry.mityugov@gmail.com>", "To": "ovs-dev@openvswitch.org", "Date": "Sun, 8 Feb 2026 19:27:03 +0300", "Message-ID": "<20260208162729.389830-1-dmitry.mityugov@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Subject": "[ovs-dev] [PATCH v1] configure: Add\n -Wmissing-[variable-]declarations compiler options.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "This patch enables two compiler options, -Wmissing-declarations and\n-Wmissing-variable-declarations, to help minimize visibility of symbols\nused inside a single module, and catch other possible problems like\nunused functions and variables. It also adjusts `_OVS_CHECK_CC_OPTION`\nmacro to work correctly with -Wmissing-variable-declarations option.\n\nThis patch also declares `impl_set_masked_funcs` array in\nlib/odp-execute-avx512.c as `static`, because it isn't used anywhere\nelse.\n\nSigned-off-by: Dmitry Mityugov <dmitry.mityugov@gmail.com>\n---\n acinclude.m4 | 2 +-\n configure.ac | 2 ++\n lib/odp-execute-avx512.c | 2 +-\n 3 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/acinclude.m4 b/acinclude.m4\nindex 586163ef3..599179a31 100644\n--- a/acinclude.m4\n+++ b/acinclude.m4\n@@ -614,7 +614,7 @@ AC_DEFUN([_OVS_CHECK_CC_OPTION], [dnl\n dnl instead of testing for -Wno-<foo>, test for the positive version.\n CFLAGS=\"$CFLAGS $WERROR m4_bpatsubst([$1], [-Wno-], [-W])\"\n AC_COMPILE_IFELSE(\n- [AC_LANG_SOURCE([int x;])],\n+ [AC_LANG_SOURCE([static int x;])],\n [if test -s conftest.err && grep \"unrecognized option\" conftest.err\n then\n ovs_cv_name[]=no\ndiff --git a/configure.ac b/configure.ac\nindex 6f28360a1..56eacbbc7 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -168,6 +168,8 @@ OVS_ENABLE_OPTION([-Wstrict-prototypes])\n OVS_ENABLE_OPTION([-Wold-style-definition])\n OVS_ENABLE_OPTION([-Wmissing-prototypes])\n OVS_ENABLE_OPTION([-Wmissing-field-initializers])\n+OVS_ENABLE_OPTION([-Wmissing-declarations])\n+OVS_ENABLE_OPTION([-Wmissing-variable-declarations])\n OVS_ENABLE_OPTION([-Wthread-safety])\n OVS_ENABLE_OPTION([-fno-strict-aliasing])\n OVS_ENABLE_OPTION([-Wswitch-bool])\ndiff --git a/lib/odp-execute-avx512.c b/lib/odp-execute-avx512.c\nindex 13afe0c79..55af58737 100644\n--- a/lib/odp-execute-avx512.c\n+++ b/lib/odp-execute-avx512.c\n@@ -108,7 +108,7 @@ BUILD_ASSERT_DECL(offsetof(struct ovs_key_ipv6, ipv6_tclass) +\n offsetof(struct ovs_key_ipv6, ipv6_hlimit));\n \n /* Array of callback functions, one for each masked operation. */\n-odp_execute_action_cb impl_set_masked_funcs[__OVS_KEY_ATTR_MAX];\n+static odp_execute_action_cb impl_set_masked_funcs[__OVS_KEY_ATTR_MAX];\n \n static inline void ALWAYS_INLINE\n avx512_dp_packet_resize_l2(struct dp_packet *b, int resize_by_bytes)\n", "prefixes": [ "ovs-dev", "v1" ] }