Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194294/?format=api
{ "id": 2194294, "url": "http://patchwork.ozlabs.org/api/patches/2194294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260208100354.116102-5-heifetz@yandex-team.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260208100354.116102-5-heifetz@yandex-team.com>", "list_archive_url": null, "date": "2026-02-08T10:03:54", "name": "[4/4] hw/usb/core.c: reorder usage and assertion of p->ep", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ad264a6f1660655ffce775d19666900ba385fc08", "submitter": { "id": 92578, "url": "http://patchwork.ozlabs.org/api/people/92578/?format=api", "name": "Sergei Heifetz", "email": "heifetz@yandex-team.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260208100354.116102-5-heifetz@yandex-team.com/mbox/", "series": [ { "id": 491415, "url": "http://patchwork.ozlabs.org/api/series/491415/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491415", "date": "2026-02-08T10:03:53", "name": "Fix a few minor issues reported by Coverity", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491415/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194294/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194294/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.com header.i=@yandex-team.com\n header.a=rsa-sha256 header.s=default header.b=HvRUyCUj;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f83NZ6k2Sz1xvc\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 08 Feb 2026 21:05:18 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vp1eJ-0004Ll-6h; Sun, 08 Feb 2026 05:04:15 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <heifetz@yandex-team.com>)\n id 1vp1eB-0004JX-J7; Sun, 08 Feb 2026 05:04:07 -0500", "from forwardcorp1b.mail.yandex.net\n ([2a02:6b8:c02:900:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <heifetz@yandex-team.com>)\n id 1vp1e6-0001oR-34; Sun, 08 Feb 2026 05:04:06 -0500", "from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net\n [IPv6:2a02:6b8:c24:fa2:0:640:41ee:0])\n by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id 26B0580896;\n Sun, 08 Feb 2026 13:03:58 +0300 (MSK)", "from heifetz-lin.yandex-team.ru (unknown [2a02:6bf:8080:d25::1:35])\n by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net\n (smtpcorp/Yandex) with ESMTPSA id t3Njcn1A4eA0-phArVM8v;\n Sun, 08 Feb 2026 13:03:57 +0300" ], "X-Yandex-Fwd": "1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com;\n s=default; t=1770545037;\n bh=Qsul4O4z95xq9yphmhSiylpmeGjeIrFHxIxrbO2rFYY=;\n h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=HvRUyCUjcCQ3aRa+wlY01og3TEhNpHIduXFAB40A/QxPKrfaRNpc1HWK1RKDyWTLj\n MuXsbG0hGBqw9YMlzp0uxpcIv0OFrOpqOIZzcfFZeDYtG8ZZph9zbyGzc5A7O2L3dj\n /A125ttGlzO2N12VUaOi5mxoNnO5aak2DdMKTFsY=", "From": "Sergei Heifetz <heifetz@yandex-team.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-trivial@nongnu.org", "Subject": "[PATCH 4/4] hw/usb/core.c: reorder usage and assertion of p->ep", "Date": "Sun, 8 Feb 2026 15:03:54 +0500", "Message-Id": "<20260208100354.116102-5-heifetz@yandex-team.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260208100354.116102-1-heifetz@yandex-team.com>", "References": "<20260208100354.116102-1-heifetz@yandex-team.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a02:6b8:c02:900:1:45:d181:df01;\n envelope-from=heifetz@yandex-team.com; helo=forwardcorp1b.mail.yandex.net", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Reorder the code so the assertion of p->ep occurs before it is\nused in the subsequent lines.\n\nSigned-off-by: Sergei Heifetz <heifetz@yandex-team.com>\n---\n hw/usb/core.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/hw/usb/core.c b/hw/usb/core.c\nindex b3f811c513..9572a870cc 100644\n--- a/hw/usb/core.c\n+++ b/hw/usb/core.c\n@@ -423,10 +423,10 @@ void usb_handle_packet(USBDevice *dev, USBPacket *p)\n p->status = USB_RET_NODEV;\n return;\n }\n+ assert(p->ep);\n assert(dev == p->ep->dev);\n assert(dev->state == USB_STATE_DEFAULT);\n usb_packet_check_state(p, USB_PACKET_SETUP);\n- assert(p->ep != NULL);\n \n /* Submitting a new packet clears halt */\n if (p->ep->halted) {\n", "prefixes": [ "4/4" ] }