Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194290/?format=api
{ "id": 2194290, "url": "http://patchwork.ozlabs.org/api/patches/2194290/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260208100354.116102-2-heifetz@yandex-team.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260208100354.116102-2-heifetz@yandex-team.com>", "list_archive_url": null, "date": "2026-02-08T10:03:51", "name": "[1/4] migration/savevm.c: reorder usage and assertion of mis->from_src_file", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "abdbd7e68f5c3ebec1d052b2c69ce1a95920812f", "submitter": { "id": 92578, "url": "http://patchwork.ozlabs.org/api/people/92578/?format=api", "name": "Sergei Heifetz", "email": "heifetz@yandex-team.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260208100354.116102-2-heifetz@yandex-team.com/mbox/", "series": [ { "id": 491415, "url": "http://patchwork.ozlabs.org/api/series/491415/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491415", "date": "2026-02-08T10:03:53", "name": "Fix a few minor issues reported by Coverity", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491415/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194290/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194290/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.com header.i=@yandex-team.com\n header.a=rsa-sha256 header.s=default header.b=zhJB3pwZ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f83Md1fpvz1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 08 Feb 2026 21:04:29 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vp1eD-0004Jy-Eh; Sun, 08 Feb 2026 05:04:09 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <heifetz@yandex-team.com>)\n id 1vp1e9-0004JD-CT; Sun, 08 Feb 2026 05:04:05 -0500", "from forwardcorp1b.mail.yandex.net ([178.154.239.136])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <heifetz@yandex-team.com>)\n id 1vp1e5-0001oI-QV; Sun, 08 Feb 2026 05:04:05 -0500", "from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net\n [IPv6:2a02:6b8:c24:fa2:0:640:41ee:0])\n by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id E81CD80769;\n Sun, 08 Feb 2026 13:03:56 +0300 (MSK)", "from heifetz-lin.yandex-team.ru (unknown [2a02:6bf:8080:d25::1:35])\n by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net\n (smtpcorp/Yandex) with ESMTPSA id t3Njcn1A4eA0-LnXf7XBi;\n Sun, 08 Feb 2026 13:03:56 +0300" ], "X-Yandex-Fwd": "1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com;\n s=default; t=1770545036;\n bh=x2BACitWrsPLZRV91SG2I0BF2s7UC2JexW9F7xC6lbQ=;\n h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=zhJB3pwZq7uD1Gf5w+eJSWNlPrnAfQWxFA9Rl9lY09ZnL3W8hjPOBx8bg4FzRJy/G\n HNbOtncdMYIM0osyWiTqZD5QgIlVJBdCOFiDc7xjM35xi0IYtAvD0HU7CKS9IyJHM2\n W19uDIhwWC3jFoixZq+PiAhkM0777FgO6pggk950=", "From": "Sergei Heifetz <heifetz@yandex-team.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-trivial@nongnu.org", "Subject": "[PATCH 1/4] migration/savevm.c: reorder usage and assertion of\n mis->from_src_file", "Date": "Sun, 8 Feb 2026 15:03:51 +0500", "Message-Id": "<20260208100354.116102-2-heifetz@yandex-team.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260208100354.116102-1-heifetz@yandex-team.com>", "References": "<20260208100354.116102-1-heifetz@yandex-team.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=178.154.239.136;\n envelope-from=heifetz@yandex-team.com; helo=forwardcorp1b.mail.yandex.net", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Reorder the code so the assertion of mis->from_src_file occurs before\nthe call to migration_ioc_unregister_yank_from_file, which dereferences\nit in qemu_file_get_ioc.\n\nFixes: 39675ffffb3394 (\"migration: Move the yank unregister of channel_close out\")\nSigned-off-by: Sergei Heifetz <heifetz@yandex-team.com>\n---\n migration/savevm.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/migration/savevm.c b/migration/savevm.c\nindex 3dc812a7bb..930a3391e3 100644\n--- a/migration/savevm.c\n+++ b/migration/savevm.c\n@@ -2885,13 +2885,14 @@ static bool postcopy_pause_incoming(MigrationIncomingState *mis)\n \n assert(migrate_postcopy_ram());\n \n+ assert(mis->from_src_file);\n+\n /*\n * Unregister yank with either from/to src would work, since ioc behind it\n * is the same\n */\n migration_ioc_unregister_yank_from_file(mis->from_src_file);\n \n- assert(mis->from_src_file);\n qemu_file_shutdown(mis->from_src_file);\n qemu_fclose(mis->from_src_file);\n mis->from_src_file = NULL;\n", "prefixes": [ "1/4" ] }