Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194263/?format=api
{ "id": 2194263, "url": "http://patchwork.ozlabs.org/api/patches/2194263/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260207194801.4128903-1-james.hilliard1@gmail.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260207194801.4128903-1-james.hilliard1@gmail.com>", "list_archive_url": null, "date": "2026-02-07T19:48:00", "name": "[v2,1/1] gpio: sunxi: Don't clear pull settings when setting input", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4f593a9b52a452eb34235191d9a71f39365ee178", "submitter": { "id": 66301, "url": "http://patchwork.ozlabs.org/api/people/66301/?format=api", "name": "James Hilliard", "email": "james.hilliard1@gmail.com" }, "delegate": { "id": 114289, "url": "http://patchwork.ozlabs.org/api/users/114289/?format=api", "username": "apritzel", "first_name": "Andre", "last_name": "Przywara", "email": "andre.przywara@arm.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260207194801.4128903-1-james.hilliard1@gmail.com/mbox/", "series": [ { "id": 491399, "url": "http://patchwork.ozlabs.org/api/series/491399/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=491399", "date": "2026-02-07T19:48:00", "name": "[v2,1/1] gpio: sunxi: Don't clear pull settings when setting input", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491399/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194263/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194263/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=gjYchQXZ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"gjYchQXZ\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=james.hilliard1@gmail.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f7l5n0ZYWz1xtr\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 08 Feb 2026 08:51:24 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 29A1A83B0B;\n\tSat, 7 Feb 2026 22:51:11 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id B5C26838FA; Sat, 7 Feb 2026 20:48:20 +0100 (CET)", "from mail-oi1-x234.google.com (mail-oi1-x234.google.com\n [IPv6:2607:f8b0:4864:20::234])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4A30F83642\n for <u-boot@lists.denx.de>; Sat, 7 Feb 2026 20:48:13 +0100 (CET)", "by mail-oi1-x234.google.com with SMTP id\n 5614622812f47-45f194e9a98so1009981b6e.3\n for <u-boot@lists.denx.de>; Sat, 07 Feb 2026 11:48:13 -0800 (PST)", "from james-x399.localdomain (71-218-105-26.hlrn.qwest.net.\n [71.218.105.26]) by smtp.gmail.com with ESMTPSA id\n 5614622812f47-462feb4fac7sm3707490b6e.15.2026.02.07.11.48.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 07 Feb 2026 11:48:11 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,\n FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1770493692; x=1771098492; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=eSbIC1+1/ry00Tvwe1WeQouhbbevN5sVGdD01haiRsw=;\n b=gjYchQXZLzSMc1CScJ0WHKglM2/SuC2lvBee01F34seYcCSfKcEFzBSRVrdJGksTu0\n t4KW8YXr+5WLQuSDMfsIRpLzLc5GMNgp1rs3IRKfZTGJhiQU/UfvsPWmDjZ5IBVKPHaS\n aAxa9yyDArcMkW/Zho9/VKVXr/kh6mr70ites7O/J4Z+o7riEaaTkn3G8qFCQC/xOUpq\n sUul5jAa7tVgFNNUJJReQZt1dt3M/Ha/I1BqcoZWyjfzcE1IwaID3+IsQtSScqbdngZh\n rftDsigCVlTaFOWnXJNeBJPUvwhhWz42QnQAmj/bWm7B9OFoHHbKJVjmfu7Kkg6tnLOK\n V4zQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770493692; x=1771098492;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=eSbIC1+1/ry00Tvwe1WeQouhbbevN5sVGdD01haiRsw=;\n b=aqS117ST0nVW7/wAsLu1mJ+ASxoD7YYFSfcSu+idMHp6cKig1HsJGMS0jPr5L+riny\n hUdviOrf1GFwHaDMN/HcOnf/fyAWtbqgFT6c0FBYwCd7bBl1VuYb0WNqToNCIIdmqkYK\n qwpDuH46qq/WLaeH54RTgmkkga3p1zY23x3/W4FcTdZAGnedv8QOb4WBtKYnRds4b3Y7\n bx54V8kxbDoUI71bZRHZyQIwh00rYkRuALV6PfQsJCEParqisr3to6XQDfxmmJ7bh1RK\n a9R8q/LFJIKStIPaTJmsy3r6Hypi8AP+OXySXvbJd4ohIXiJEudd8FSGjMzrxS/fLvL8\n C1tA==", "X-Gm-Message-State": "AOJu0YxeNMV05FKgDsRUs9U/qli8VC7ZlUNZ8v3R0y6jQBeYbFBZTI7S\n OiyjqdvkmJDuYcSWPfbDFAogRpcO6jhc/mtpz+Xa5nXdOp/4DLRgUXa5tFnmtA==", "X-Gm-Gg": "AZuq6aJQHKw1nP6XzMpNHai+4UlzSBOiDiAooIWIAD/OZ/ASY1/Ea7uxO7s3xQfrgCa\n FqNLdBcwQPI3/JH/CNSXEx1vMKNUEQ0KeQSIGpDL4HoM28w3WNTxPkfLERbr/H93k4xENPVHl+V\n DJsoBBwvV9y/NNbojp5uqV9XODPyYgmUTO1/Z5NfwzaOhorQ+w0eV1ScjDknQS6e8IucrC+2GKm\n GveQAD22papUhHxH+4faZ33VA1BvBfGOKwgUdTxbqmdWccNSZb9iXXVm5Tj+VT+QnZfz8J2Txmy\n Mq9WPOOIM27aEvlYpbwwYeYLVyS1OQwlbErAURQACRgbto3VBHvHPu3I5Rt+wEwTG/tnbqMpzco\n gIJ2XijbCh136H00xgbl6bvZ8FUFrkqxsrNHvOxp3NYB8/IJk2+2H9uDsSfo5ORgyjIqyogp5MP\n LvgKjgIovBpyh2XiXohweE14yfsbd8LqotvhY+DKTc6AqXMd8NXQ+uwXJ5uYlfcyHZw+waV96Xi\n LTy2b7u4LOZfdIYqPakHc8B7w3TUGgHH8qb1CsY0EeDN+GfdoM=", "X-Received": "by 2002:a05:6808:640f:b0:45c:9f35:8e00 with SMTP id\n 5614622812f47-462fc9e75f7mr3630282b6e.13.1770493691735;\n Sat, 07 Feb 2026 11:48:11 -0800 (PST)", "From": "James Hilliard <james.hilliard1@gmail.com>", "To": "u-boot@lists.denx.de", "Cc": "James Hilliard <james.hilliard1@gmail.com>, Tom Rini <trini@konsulko.com>,\n Andre Przywara <andre.przywara@arm.com>,\n Jernej Skrabec <jernej.skrabec@gmail.com>,\n Samuel Holland <samuel@sholland.org>, Simon Glass <sjg@chromium.org>", "Subject": "[PATCH v2 1/1] gpio: sunxi: Don't clear pull settings when setting\n input", "Date": "Sat, 7 Feb 2026 12:48:00 -0700", "Message-ID": "<20260207194801.4128903-1-james.hilliard1@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Sat, 07 Feb 2026 22:51:09 +0100", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "sunxi_gpio_set_flags() always programs the pull register when\nswitching a pin to input. When neither GPIOD_PULL_UP nor\nGPIOD_PULL_DOWN is requested, this writes 0 (pull disabled)\nand can clobber an existing bias configuration applied via pinctrl.\n\nOnly update the pull configuration when a pull-up or pull-down is\nexplicitly requested, leaving existing pull settings unchanged.\n\nFixes: 35ae126c16a6 (\"gpio: sunxi: Implement .set_flags\")\nSigned-off-by: James Hilliard <james.hilliard1@gmail.com>\n---\nChanges v1 -> v2:\n - remove no local pull variable\n---\n drivers/gpio/sunxi_gpio.c | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/gpio/sunxi_gpio.c b/drivers/gpio/sunxi_gpio.c\nindex 094c45a6927..9acf1c2ecab 100644\n--- a/drivers/gpio/sunxi_gpio.c\n+++ b/drivers/gpio/sunxi_gpio.c\n@@ -295,13 +295,10 @@ static int sunxi_gpio_set_flags(struct udevice *dev, unsigned int offset,\n \t\tsunxi_gpio_set_value_bank(plat->regs, offset, value);\n \t\tsunxi_gpio_set_cfgbank(plat->regs, offset, SUNXI_GPIO_OUTPUT);\n \t} else if (flags & GPIOD_IS_IN) {\n-\t\tu32 pull = 0;\n-\n \t\tif (flags & GPIOD_PULL_UP)\n-\t\t\tpull = 1;\n+\t\t\tsunxi_gpio_set_pull_bank(plat->regs, offset, 1);\n \t\telse if (flags & GPIOD_PULL_DOWN)\n-\t\t\tpull = 2;\n-\t\tsunxi_gpio_set_pull_bank(plat->regs, offset, pull);\n+\t\t\tsunxi_gpio_set_pull_bank(plat->regs, offset, 2);\n \t\tsunxi_gpio_set_cfgbank(plat->regs, offset, SUNXI_GPIO_INPUT);\n \t}\n \n", "prefixes": [ "v2", "1/1" ] }