Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194257/?format=api
{ "id": 2194257, "url": "http://patchwork.ozlabs.org/api/patches/2194257/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/patch/20260207214852.86991-3-arukomoinikova@k2.cloud/", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260207214852.86991-3-arukomoinikova@k2.cloud>", "list_archive_url": null, "date": "2026-02-07T21:48:44", "name": "[ovs-dev,3/8,v2] pinctrl: Add logical switch port service monitor support.", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "1acfce9cea253a728d8e615ce5b37537a6c7bf00", "submitter": { "id": 89461, "url": "http://patchwork.ozlabs.org/api/people/89461/?format=api", "name": "Rukomoinikova Aleksandra", "email": "ARukomoinikova@k2.cloud" }, "delegate": { "id": 94943, "url": "http://patchwork.ozlabs.org/api/users/94943/?format=api", "username": "dceara", "first_name": "Dumitru", "last_name": "Ceara", "email": "dceara@redhat.com" }, "mbox": "http://patchwork.ozlabs.org/project/ovn/patch/20260207214852.86991-3-arukomoinikova@k2.cloud/mbox/", "series": [ { "id": 491397, "url": "http://patchwork.ozlabs.org/api/series/491397/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/list/?series=491397", "date": "2026-02-07T21:48:46", "name": "[ovs-dev,1/8,v2] ovn-nb, ovn-nbctl: Add Logical Switch Port Health Check support.", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491397/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194257/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/2194257/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=k2.cloud header.i=@k2.cloud header.a=rsa-sha256\n header.s=cloudmail header.b=aryChqqh;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)", "smtp1.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=k2.cloud header.i=@k2.cloud header.a=rsa-sha256 header.s=cloudmail\n header.b=aryChqqh", "smtp3.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=k2.cloud", "smtp3.osuosl.org; dkim=pass (1024-bit key,\n unprotected) header.d=k2.cloud header.i=@k2.cloud header.a=rsa-sha256\n header.s=cloudmail header.b=aryChqqh" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f7l3G6zBpz1xvW\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 08 Feb 2026 08:49:14 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 89F3E84116;\n\tSat, 7 Feb 2026 21:49:12 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 2Fp6RPc74jwu; Sat, 7 Feb 2026 21:49:10 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id 90C9083C91;\n\tSat, 7 Feb 2026 21:49:07 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 4DD07C078B;\n\tSat, 7 Feb 2026 21:49:07 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 7E0B5C077F\n for <dev@openvswitch.org>; Sat, 7 Feb 2026 21:49:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 6309D6076F\n for <dev@openvswitch.org>; Sat, 7 Feb 2026 21:49:02 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id z_A6P0jqoe8y for <dev@openvswitch.org>;\n Sat, 7 Feb 2026 21:49:01 +0000 (UTC)", "from mail1.k2.cloud (mail1.k2.cloud [109.73.14.252])\n by smtp3.osuosl.org (Postfix) with ESMTPS id DD9CE605D8\n for <dev@openvswitch.org>; Sat, 7 Feb 2026 21:48:57 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 90C9083C91", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org DD9CE605D8" ], "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=109.73.14.252;\n helo=mail1.k2.cloud; envelope-from=arukomoinikova@k2.cloud;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org DD9CE605D8", "From": "Alexandra Rukomoinikova <arukomoinikova@k2.cloud>", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=k2.cloud;\n s=cloudmail; t=1770500935;\n bh=ME5gc8KPjTOz+TXSQRV4TjA0jjYj8gu25XwGoIipzvI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=aryChqqhze+UrhBTS+IaK2IPBNYzyx39UZwKte7twN9m9ohKCmn49dave0dyIa4BX\n 98iJl3Joe/9xHgLspWEClQQlQ0K4Rv/+Oht33shm/NbfwH2d6CVnnRCetDTxdNlxjH\n GNlDIFv9GAxpJKXDwGEFBhSsQ0lcrqAJklyZ8mT8=", "To": "dev@openvswitch.org", "Cc": "Alexandra Rukomoinikova <arukomoinikova@k2.cloud>", "Date": "Sun, 8 Feb 2026 00:48:44 +0300", "Message-Id": "<20260207214852.86991-3-arukomoinikova@k2.cloud>", "In-Reply-To": "<20260207214852.86991-1-arukomoinikova@k2.cloud>", "References": "<20260207214852.86991-1-arukomoinikova@k2.cloud>", "MIME-Version": "1.0", "Subject": "[ovs-dev] [PATCH ovn 3/8 v2] pinctrl: Add logical switch port\n service monitor support.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Add LSP service monitor type and handle ICMP health checks for\nlogical switch ports in addition to network functions.\n\nSigned-off-by: Alexandra Rukomoinikova <arukomoinikova@k2.cloud>\n---\nv1 --> v2: fixed comments\n---\n controller/pinctrl.c | 63 ++++++++++++++++++----------\n tests/system-ovn.at | 99 ++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 139 insertions(+), 23 deletions(-)", "diff": "diff --git a/controller/pinctrl.c b/controller/pinctrl.c\nindex 7baf6b488..7b80f4725 100644\n--- a/controller/pinctrl.c\n+++ b/controller/pinctrl.c\n@@ -6912,6 +6912,8 @@ enum svc_monitor_type {\n SVC_MON_TYPE_LB,\n /* network function */\n SVC_MON_TYPE_NF,\n+ /* logical switch port */\n+ SVC_MON_TYPE_LSP,\n };\n \n /* Service monitor health checks. */\n@@ -7039,6 +7041,9 @@ sync_svc_monitors(struct ovsdb_idl_txn *ovnsb_idl_txn,\n if (sb_svc_mon->type && !strcmp(sb_svc_mon->type,\n \"network-function\")) {\n mon_type = SVC_MON_TYPE_NF;\n+ } else if (sb_svc_mon->type && !strcmp(sb_svc_mon->type,\n+ \"logical-switch-port\")) {\n+ mon_type = SVC_MON_TYPE_LSP;\n } else {\n mon_type = SVC_MON_TYPE_LB;\n }\n@@ -7103,11 +7108,6 @@ sync_svc_monitors(struct ovsdb_idl_txn *ovnsb_idl_txn,\n }\n }\n } else {\n- if (protocol != SVC_MON_PROTO_TCP &&\n- protocol != SVC_MON_PROTO_UDP) {\n- continue;\n- }\n-\n for (size_t i = 0; i < pb->n_mac && !mac_found; i++) {\n struct lport_addresses laddrs;\n \n@@ -8066,6 +8066,7 @@ static void\n svc_monitor_send_icmp_health_check__(struct rconn *swconn,\n struct svc_monitor *svc_mon)\n {\n+ bool svc_mon_nf = (svc_mon->type == SVC_MON_TYPE_NF) ? true : false;\n uint64_t packet_stub[128 / 8];\n struct dp_packet packet;\n dp_packet_use_stub(&packet, packet_stub, sizeof packet_stub);\n@@ -8112,7 +8113,8 @@ svc_monitor_send_icmp_health_check__(struct rconn *swconn,\n struct ofpbuf ofpacts = OFPBUF_STUB_INITIALIZER(ofpacts_stub);\n enum ofp_version version = rconn_get_version(swconn);\n put_load(svc_mon->dp_key, MFF_LOG_DATAPATH, 0, 64, &ofpacts);\n- put_load(svc_mon->input_port_key, MFF_LOG_OUTPORT, 0, 32, &ofpacts);\n+ put_load(svc_mon_nf ? svc_mon->input_port_key : svc_mon->port_key,\n+ MFF_LOG_OUTPORT, 0, 32, &ofpacts);\n put_load(1, MFF_LOG_FLAGS, MLF_LOCAL_ONLY, 1, &ofpacts);\n struct ofpact_resubmit *resubmit = ofpact_put_RESUBMIT(&ofpacts);\n resubmit->in_port = OFPP_CONTROLLER;\n@@ -8406,24 +8408,32 @@ pinctrl_handle_svc_check(struct rconn *swconn, const struct flow *ip_flow,\n return;\n }\n \n- /* Handle ICMP ECHO REQUEST probes for Network Function services */\n+ /* Handle ICMP ECHO REQUEST probes for Network Function and\n+ * Logical Switch Port services */\n if (in_eth->eth_type == htons(ETH_TYPE_IP)) {\n struct icmp_header *ih = l4h;\n /* It's ICMP packet. */\n- if (ih->icmp_type == ICMP4_ECHO_REQUEST && ih->icmp_code == 0) {\n- uint32_t hash = hash_bytes(&dst_ip_addr, sizeof dst_ip_addr,\n- hash_3words(dp_key, port_key, 0));\n- struct svc_monitor *svc_mon =\n- pinctrl_find_svc_monitor(dp_key, port_key, &dst_ip_addr, 0,\n+ if ((ih->icmp_type == ICMP4_ECHO_REQUEST ||\n+ ih->icmp_type == ICMP4_ECHO_REPLY) && ih->icmp_code == 0) {\n+ int is_echo_request = (ih->icmp_type == ICMP4_ECHO_REQUEST);\n+ struct in6_addr *target_addr = is_echo_request\n+ ? &dst_ip_addr : &ip_addr;\n+ uint32_t hash =\n+ hash_bytes(target_addr, sizeof(*target_addr),\n+ hash_3words(dp_key, port_key, 0));\n+ struct svc_monitor *svc_mon =\n+ pinctrl_find_svc_monitor(dp_key, port_key, target_addr, 0,\n SVC_MON_PROTO_ICMP, hash);\n if (!svc_mon) {\n- static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(\n- 1, 5);\n+ static struct vlog_rate_limit rl =\n+ VLOG_RATE_LIMIT_INIT(1, 5);\n VLOG_WARN_RL(&rl, \"handle service check: Service monitor \"\n- \"not found for ICMP request\");\n+ \"not found for ICMP %s\", is_echo_request ?\n+ \"request\" : \"reply\");\n return;\n }\n- if (svc_mon->type == SVC_MON_TYPE_NF) {\n+ if (svc_mon->type == SVC_MON_TYPE_NF ||\n+ svc_mon->type == SVC_MON_TYPE_LSP) {\n pinctrl_handle_icmp_svc_check(pkt_in, svc_mon);\n }\n return;\n@@ -8431,21 +8441,28 @@ pinctrl_handle_svc_check(struct rconn *swconn, const struct flow *ip_flow,\n } else if (in_eth->eth_type == htons(ETH_TYPE_IPV6)) {\n struct icmp6_data_header *ih6 = l4h;\n /* It's ICMPv6 packet. */\n- if (ih6->icmp6_base.icmp6_type == ICMP6_ECHO_REQUEST &&\n+ if ((ih6->icmp6_base.icmp6_type == ICMP6_ECHO_REQUEST ||\n+ ih6->icmp6_base.icmp6_type == ICMP6_ECHO_REPLY) &&\n ih6->icmp6_base.icmp6_code == 0) {\n- uint32_t hash = hash_bytes(&dst_ip_addr, sizeof dst_ip_addr,\n+ int is_echo_request =\n+ (ih6->icmp6_base.icmp6_type == ICMP6_ECHO_REQUEST);\n+ struct in6_addr *target_addr = is_echo_request\n+ ? &dst_ip_addr : &ip_addr;\n+ uint32_t hash = hash_bytes(target_addr, sizeof(*target_addr),\n hash_3words(dp_key, port_key, 0));\n struct svc_monitor *svc_mon =\n- pinctrl_find_svc_monitor(dp_key, port_key, &dst_ip_addr, 0,\n+ pinctrl_find_svc_monitor(dp_key, port_key, target_addr, 0,\n SVC_MON_PROTO_ICMP, hash);\n if (!svc_mon) {\n- static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(\n- 1, 5);\n+ static struct vlog_rate_limit rl =\n+ VLOG_RATE_LIMIT_INIT(1, 5);\n VLOG_WARN_RL(&rl, \"handle service check: Service monitor \"\n- \"not found for ICMPv6 request\");\n+ \"not found for ICMPv6 %s\", is_echo_request ?\n+ \"request\" : \"reply\");\n return;\n }\n- if (svc_mon->type == SVC_MON_TYPE_NF) {\n+ if (svc_mon->type == SVC_MON_TYPE_NF ||\n+ svc_mon->type == SVC_MON_TYPE_LSP) {\n pinctrl_handle_icmp_svc_check(pkt_in, svc_mon);\n }\n return;\ndiff --git a/tests/system-ovn.at b/tests/system-ovn.at\nindex 82b7e7db5..14c0996a0 100644\n--- a/tests/system-ovn.at\n+++ b/tests/system-ovn.at\n@@ -20993,3 +20993,102 @@ OVS_TRAFFIC_VSWITCHD_STOP([\"/failed to query port patch-.*/d\n /connection dropped.*/d\"])\n AT_CLEANUP\n ])\n+\n+OVN_FOR_EACH_NORTHD_NO_HV([\n+AT_SETUP([Logical Switch Port Health Check])\n+AT_SKIP_IF([test $HAVE_NC = no])\n+\n+ovn_start\n+OVS_TRAFFIC_VSWITCHD_START()\n+ADD_BR([br-int])\n+\n+# Set external-ids in br-int needed for ovn-controller\n+ovs-vsctl \\\n+ -- set Open_vSwitch . external-ids:system-id=hv1 \\\n+ -- set Open_vSwitch . external-ids:ovn-remote=unix:$ovs_base/ovn-sb/ovn-sb.sock \\\n+ -- set Open_vSwitch . external-ids:ovn-encap-type=geneve \\\n+ -- set Open_vSwitch . external-ids:ovn-encap-ip=169.0.0.1 \\\n+ -- set bridge br-int fail-mode=secure other-config:disable-in-band=true\n+\n+# Start ovn-controller\n+start_daemon ovn-controller\n+\n+check ovn-nbctl ls-add ls1\n+\n+ADD_NAMESPACES(lport)\n+ADD_VETH(lport, lport, br-int, \"192.168.0.10\", \"f0:00:0f:01:02:04\", \\\n+ \"192.168.0.1\")\n+NS_EXEC([lport], [ip r del default via 192.168.0.1 dev lport])\n+NS_EXEC([lport], [ip r add default dev lport])\n+NS_EXEC([lport], [ip addr add 2001:db8::10/64 dev lport])\n+NS_EXEC([lport], [ip -6 r add default dev lport])\n+\n+check ovn-nbctl lsp-add ls1 lport -- \\\n+ lsp-set-addresses lport \"f0:00:0f:01:02:04 192.168.0.10 2001:db8::10\"\n+\n+check ovn-nbctl --wait=hv sync\n+\n+check ovn-nbctl lsp-hc-add lport icmp 192.168.0.255 192.168.0.10\n+check_row_count sb:Service_Monitor 1\n+\n+# Wait until the services are set to online.\n+wait_row_count Service_Monitor 1 status=online\n+\n+check ovn-nbctl lsp-hc-add lport tcp 192.168.0.255 4041 192.168.0.10\n+\n+check_row_count sb:Service_Monitor 2\n+\n+# Create one more health check on logical switch port\n+NETNS_DAEMONIZE([lport], [nc -l -k 192.168.0.10 4041], [lport_tcp.pid])\n+\n+# Wait until the services are set to online.\n+wait_row_count Service_Monitor 2 status=online\n+\n+check ovn-nbctl lsp-hc-add lport udp 192.168.0.255 4042 192.168.0.10\n+\n+NETNS_DAEMONIZE([lport], [nc -ulp 4042], [lport_udp.pid])\n+\n+# Wait until the services are set to online.\n+wait_row_count Service_Monitor 3 status=online\n+\n+check ovn-nbctl lsp-hc-del lport\n+\n+# IPv6 ICMP health check (ping6)\n+check ovn-nbctl lsp-hc-add lport icmp 2001:db8::ff 2001:db8::10\n+check_row_count sb:Service_Monitor 1\n+\n+# Wait until the services are set to online.\n+wait_row_count Service_Monitor 1 status=online\n+\n+# IPv6 TCP health check\n+check ovn-nbctl lsp-hc-add lport tcp 2001:db8::ff 4043 2001:db8::10\n+\n+check_row_count sb:Service_Monitor 2\n+\n+# Start IPv6 TCP server\n+NETNS_DAEMONIZE([lport], [nc -6 -l -k 2001:db8::10 4043], [lport_ipv6_tcp.pid])\n+\n+# Wait until the services are set to online.\n+wait_row_count Service_Monitor 2 status=online\n+\n+# IPv6 UDP health check\n+check ovn-nbctl lsp-hc-add lport udp 2001:db8::ff 4044 2001:db8::10\n+check_row_count sb:Service_Monitor 3\n+\n+# Start IPv6 UDP server\n+NETNS_DAEMONIZE([lport], [nc -6 -u -l 2001:db8::10 4044], [lport_ipv6_udp.pid])\n+\n+# Wait until the services are set to online.\n+wait_row_count Service_Monitor 3 status=online\n+\n+killall nc 2>/dev/null || true\n+\n+OVN_CLEANUP_CONTROLLER([hv1])\n+\n+OVN_CLEANUP_NORTHD\n+\n+as\n+OVS_TRAFFIC_VSWITCHD_STOP([\"/failed to query port patch-.*/d\n+/connection dropped.*/d\"])\n+AT_CLEANUP\n+])\n", "prefixes": [ "ovs-dev", "3/8", "v2" ] }