Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194247/?format=api
{ "id": 2194247, "url": "http://patchwork.ozlabs.org/api/patches/2194247/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260207180632.1042754-3-brian.cain@oss.qualcomm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260207180632.1042754-3-brian.cain@oss.qualcomm.com>", "list_archive_url": null, "date": "2026-02-07T18:06:30", "name": "[v2,2/4] target/hexagon: Reject duplex encodings with duplicate dest registers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6e0e6ddb2a45ea8235acb08c96198e0167272585", "submitter": { "id": 89839, "url": "http://patchwork.ozlabs.org/api/people/89839/?format=api", "name": "Brian Cain", "email": "brian.cain@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260207180632.1042754-3-brian.cain@oss.qualcomm.com/mbox/", "series": [ { "id": 491391, "url": "http://patchwork.ozlabs.org/api/series/491391/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491391", "date": "2026-02-07T18:06:28", "name": "Handle some invalid encodings", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491391/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194247/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194247/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=PaSGwpQ4;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=SphfY5Lh;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f7f7x3zrrz1xvj\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 08 Feb 2026 05:07:56 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vomi5-0001UI-45; Sat, 07 Feb 2026 13:07:09 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1vomhz-0001Ta-RX\n for qemu-devel@nongnu.org; Sat, 07 Feb 2026 13:07:04 -0500", "from mx0b-0031df01.pphosted.com ([205.220.180.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1vomhr-0005LM-HI\n for qemu-devel@nongnu.org; Sat, 07 Feb 2026 13:07:01 -0500", "from pps.filterd (m0279868.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 617DlDiI2132297\n for <qemu-devel@nongnu.org>; Sat, 7 Feb 2026 18:06:53 GMT", "from mail-dy1-f198.google.com (mail-dy1-f198.google.com\n [74.125.82.198])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c5xj1938t-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Sat, 07 Feb 2026 18:06:52 +0000 (GMT)", "by mail-dy1-f198.google.com with SMTP id\n 5a478bee46e88-2b708fa4093so9415532eec.0\n for <qemu-devel@nongnu.org>; Sat, 07 Feb 2026 10:06:52 -0800 (PST)", "from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2b855c63152sm4002328eec.25.2026.02.07.10.06.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 07 Feb 2026 10:06:50 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n u8zQ/PgN+M6EU0nqZmhx5VWC/id7HIJ3f/1jOvE3ams=; b=PaSGwpQ4lkZo5Mv0\n CS6A/CdhU6kGgrK9f6x5x5njCuGUybCEgVvsIIIZsbagWGs0ieXx062dLF5bIuVu\n WHOBYd2Tth1PvPdSn0SKwsYo1GsDDb7aUUo/UbB/XZ9h3cZFJaKbqDWW7A25/OpP\n aDAPllv0IHmlmlVVeHG8u0E6OfeheatHFGQRXSGtyY4fuvl3XzsDYl43IFRQIOEy\n ZBM16RtRbouaincS4QDxXT/ONQZfKoD1P3lBckxfLoiLXLiF3S2bpRR59O4WBfVs\n +HcBrHUiN3/TuHomwB9xLLioXC+Evkx273O7eKpX7qD9WeyKEGrMjlZh+8jL33CW\n m0aYHA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1770487612; x=1771092412; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=u8zQ/PgN+M6EU0nqZmhx5VWC/id7HIJ3f/1jOvE3ams=;\n b=SphfY5Lh4c3bUtM1P8s8mrSqMIyLqzVU3vmqG4rdh8IvzlUfRTIFfINLDiPWqMg+mH\n asVfE/oqJpcdBIt6gl0chMuLeFmsOHvAcY/RiwCirur+yjnMWN87VngH8szNloN9VLry\n j9DtKBx7MWYYXjDY9SmNc7WCf4hbObIv8SfewonsRngNfeDL/ZUbDUR/CVVDm+lLleS5\n VSdQ+KBugY5hdvsMkOmOUGPn42u9XT00KZgyJn4RvIRKL/V9tUjPUdVDN3pSGNXXzFt+\n uq8EpvxwLiIb8tLxnqHq5MQvdsgiTlyXB+uNLqdTKuBTqYCoCzgLQoLanh4SLYLYWRFI\n suqA==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770487612; x=1771092412;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=u8zQ/PgN+M6EU0nqZmhx5VWC/id7HIJ3f/1jOvE3ams=;\n b=M606dZXBVbOAdZEv88Ozff6A+1rENJf/b0lh2guY8H5wyf6N1+HFM36CkLCGYkUMR8\n sYl9TRQAYRWbYZZPU4yMaa/u7oci+nR2cH3e/UjTbyTuD8GfMddzVVfe/fxLYctPhL5F\n QnySoibrXPlNbLG97Pgoy3qQX1io+uq9IWeceA2/iepiqM988trH6azUTMlYyff73aja\n mh6S8sqXlvf0hIT7dHmoJi0UPYAtKsNBfuFf05lIcdVqdUe3TujIy2W8eGZ9t0Zhuu8J\n pWKlatLqriURIi7VbvXlrHfkbyZMiBEo94clzbd1tXIwJHY/zjLd8tneexeVn14JXuoL\n N+5Q==", "X-Gm-Message-State": "AOJu0YxB4T1qy/5XZaDkj8N1eBsbeit5QX7gfBY5O7UgnWZVblXmerOM\n y6FT52OML/XvnPnxYCAIq1kb5OQXnJU8tUM/qhsexb/ketGphmaKeNpO9iqEaOmoBy2gJkhMXSJ\n +Tp8LaBebHya9UGIktHC1XRnsck1/5BmrdAQLqxaRFyfenHyMeFoz5wTLvARrIw+SbA==", "X-Gm-Gg": "AZuq6aJWGJOkrLCPT7apsnPUiDMbBs1OK25dKvU9NjfmmjCtsTXynBsy2KCv10I8gZY\n cMV+dppruXs5FSMqG3Rcxp83pLv0W1X2cj4VSCHZds17X+JX5Z5Gls70Sx1N8otZueD5YZJFo/Q\n J8TJRcKZHVsYM81Y5B0QgL/GBLtO8VVYe9L/CH/bX2L9nMXhJCIlDPuZKn6cVZNCEQOTnYtLi72\n 7U+2FvoUpdkMZOo6UMV7NwOczIJ0+YXp3+kHk0r81oUTv4DHwdoGDVNR1oLo/hnBywvJQ95bDbL\n FwWjoSSEhnqupB+6f/lCW5puXjf9sbeUZJhKUf8p+adnTzqtJN3rIpQWA2noqMGhC4aueu9i6w4\n /qmwGaVWqBQ8a0eu2WAKl6ZRNywk05cfbOA5uEwVxfTOBP8wd3GeVpgETOg==", "X-Received": [ "by 2002:a05:693c:2d8c:b0:2b7:1c58:dca6 with SMTP id\n 5a478bee46e88-2b85646d9c4mr4349651eec.6.1770487611539;\n Sat, 07 Feb 2026 10:06:51 -0800 (PST)", "by 2002:a05:693c:2d8c:b0:2b7:1c58:dca6 with SMTP id\n 5a478bee46e88-2b85646d9c4mr4349638eec.6.1770487611030;\n Sat, 07 Feb 2026 10:06:51 -0800 (PST)" ], "From": "Brian Cain <brian.cain@oss.qualcomm.com>", "To": "qemu-devel@nongnu.org", "Cc": "brian.cain@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex@alexrp.com,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>", "Subject": "[PATCH v2 2/4] target/hexagon: Reject duplex encodings with duplicate\n dest registers", "Date": "Sat, 7 Feb 2026 10:06:30 -0800", "Message-Id": "<20260207180632.1042754-3-brian.cain@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260207180632.1042754-1-brian.cain@oss.qualcomm.com>", "References": "<20260207180632.1042754-1-brian.cain@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "X-Proofpoint-GUID": "1ShrdRGY-jCPL8tDYFihl2vi9ZxOhLgn", "X-Proofpoint-ORIG-GUID": "1ShrdRGY-jCPL8tDYFihl2vi9ZxOhLgn", "X-Authority-Analysis": "v=2.4 cv=F/tat6hN c=1 sm=1 tr=0 ts=69877f3c cx=c_pps\n a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22\n a=p0WdMEafAAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=ceJ5jWYMHQCwmun8QzEA:9\n a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22 a=cvBusfyB2V15izCimMoJ:22", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjA3MDE0OSBTYWx0ZWRfXziov73BePCf8\n 1C05VanEmJrrE9M+DVSDZj7qckorTPhVe+2YEWJmtIUKZULDKOaGkUzL7ELuUa83HCZzB5trzhN\n axPGt+wS6Kd9tEDSzkrrmgEozxzFl1LDUxDpKfKyystAnq8a/23lR675LRGlzbnS0lsioF71m4U\n +b4DfeittpBvfC7I0OPoBWe1llXvRy1Q0v2Yo8KPWX3sqViLI8tAjyx6q2R7YRLk7yWgZwwC9DO\n Ex70SFEI1PreMB6a7A1pz624l1SmEvKvwKuO9xC1aY6zQ7exgwxmBl+2fP0k3m6/Oq6CsvwSaU+\n ELluvO1pvHAX5dbyQHcq6qjTzVvVp1QfhbsR+amqwUJVkyXiwuCr73cV/kBF/4LFksOHD3kx0tU\n gwv8fi5RIYy4Wj1xACV62bFIg6r4iwBep3aOSMAUdmnveR9maH+B/5W9hczmg17JPUSbFkMowYZ\n BZTkaDmxeKpzZkBpkXQ==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-06_05,2026-02-05_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n bulkscore=0 adultscore=0 clxscore=1015 malwarescore=0 priorityscore=1501\n suspectscore=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602070149", "Received-SPF": "pass client-ip=205.220.180.131;\n envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "A duplex encoding like 0x00000000 decodes as two loads that both write r0.\n\nAdd a check in decode_insns() after both sub-instructions decode\nsuccessfully to verify they don't write the same destination register.\n\nResolves: https://gitlab.com/qemu-project/qemu/-/issues/2696\nSigned-off-by: Brian Cain <brian.cain@oss.qualcomm.com>\nReviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\n---\n target/hexagon/decode.c | 12 ++++++++++++\n tests/tcg/hexagon/invalid-encoding.c | 29 ++++++++++++++++++++++++++++\n 2 files changed, 41 insertions(+)", "diff": "diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c\nindex 69ba1ec96c..90499fc320 100644\n--- a/target/hexagon/decode.c\n+++ b/target/hexagon/decode.c\n@@ -501,12 +501,24 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t encoding)\n \n /* The slot1 subinsn needs to be in the packet first */\n if (decode_slot1_subinsn(ctx, slot1_subinsn)) {\n+ Insn *slot1_insn = insn;\n insn->generate = opcode_genptr[insn->opcode];\n insn->iclass = iclass_bits(encoding);\n ctx->insn = ++insn;\n if (decode_slot0_subinsn(ctx, slot0_subinsn)) {\n insn->generate = opcode_genptr[insn->opcode];\n insn->iclass = iclass_bits(encoding);\n+ /*\n+ * Check that the two sub-instructions don't write the same\n+ * destination register (e.g., encoding 0x0 decodes as two\n+ * loads both writing R0, which is an invalid packet).\n+ */\n+ if (insn->dest_idx >= 0 && slot1_insn->dest_idx >= 0 &&\n+ insn->regno[insn->dest_idx] ==\n+ slot1_insn->regno[slot1_insn->dest_idx]) {\n+ ctx->insn = --insn;\n+ return 0;\n+ }\n return 2;\n }\n /*\ndiff --git a/tests/tcg/hexagon/invalid-encoding.c b/tests/tcg/hexagon/invalid-encoding.c\nindex 010a5eb741..1bbd312b61 100644\n--- a/tests/tcg/hexagon/invalid-encoding.c\n+++ b/tests/tcg/hexagon/invalid-encoding.c\n@@ -65,6 +65,34 @@ static int test_invalid_duplex(void)\n return sig;\n }\n \n+/*\n+ * Duplex with duplicate destination registers (issue #2696):\n+ * The encoding 0x00000000 decodes as a duplex with parse bits\n+ * [15:14] = 0b00:\n+ * slot1: SL1_loadri_io R0 = memw(R0+#0x0)\n+ * slot0: SL1_loadri_io R0 = memw(R0+#0x0)\n+ *\n+ * Both sub-instructions write R0, which is an invalid packet (duplicate\n+ * destination register). This should raise SIGILL.\n+ */\n+static int test_invalid_dups(void)\n+{\n+ int sig;\n+\n+ asm volatile(\n+ \"r0 = #0\\n\"\n+ \"r1 = ##1f\\n\"\n+ \"memw(%1) = r1\\n\"\n+ \".word 0x00000000\\n\"\n+ \"1:\\n\"\n+ \"%0 = r0\\n\"\n+ : \"=r\"(sig)\n+ : \"r\"(&resume_pc)\n+ : \"r0\", \"r1\", \"memory\");\n+\n+ return sig;\n+}\n+\n int main()\n {\n struct sigaction act;\n@@ -75,6 +103,7 @@ int main()\n assert(sigaction(SIGILL, &act, NULL) == 0);\n \n assert(test_invalid_duplex() == SIGILL);\n+ assert(test_invalid_dups() == SIGILL);\n \n puts(\"PASS\");\n return EXIT_SUCCESS;\n", "prefixes": [ "v2", "2/4" ] }