Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194245/?format=api
{ "id": 2194245, "url": "http://patchwork.ozlabs.org/api/patches/2194245/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260207180632.1042754-4-brian.cain@oss.qualcomm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260207180632.1042754-4-brian.cain@oss.qualcomm.com>", "list_archive_url": null, "date": "2026-02-07T18:06:31", "name": "[v2,3/4] target/hexagon: Return decode failure for invalid non-duplex encodings", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "711970a82eb54464fecbdae60d9f4a67dfe983d0", "submitter": { "id": 89839, "url": "http://patchwork.ozlabs.org/api/people/89839/?format=api", "name": "Brian Cain", "email": "brian.cain@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260207180632.1042754-4-brian.cain@oss.qualcomm.com/mbox/", "series": [ { "id": 491391, "url": "http://patchwork.ozlabs.org/api/series/491391/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491391", "date": "2026-02-07T18:06:28", "name": "Handle some invalid encodings", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/491391/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194245/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194245/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=UPzu8Q3w;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=g2iSfc1h;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f7f7x4PmKz1xvp\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 08 Feb 2026 05:07:56 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vomi9-0001Vf-PW; Sat, 07 Feb 2026 13:07:13 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1vomhz-0001TZ-R2\n for qemu-devel@nongnu.org; Sat, 07 Feb 2026 13:07:04 -0500", "from mx0b-0031df01.pphosted.com ([205.220.180.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1vomhr-0005LY-Cv\n for qemu-devel@nongnu.org; Sat, 07 Feb 2026 13:07:01 -0500", "from pps.filterd (m0279868.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 6174chvk1050589\n for <qemu-devel@nongnu.org>; Sat, 7 Feb 2026 18:06:54 GMT", "from mail-dy1-f198.google.com (mail-dy1-f198.google.com\n [74.125.82.198])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c5xj1938u-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Sat, 07 Feb 2026 18:06:53 +0000 (GMT)", "by mail-dy1-f198.google.com with SMTP id\n 5a478bee46e88-2b708fa4093so9415553eec.0\n for <qemu-devel@nongnu.org>; Sat, 07 Feb 2026 10:06:53 -0800 (PST)", "from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2b855c63152sm4002328eec.25.2026.02.07.10.06.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 07 Feb 2026 10:06:51 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n SGn9Dx9TKhYwyyq6cn6DSMXoUDg7D4YZd5UT23z4be8=; b=UPzu8Q3wpDgI26vz\n zbO24C9sDc4Gd+imdiPebjMx0n3khGuvoT1UkYo6y6jbMsL14bRgmuUgZA7JhS2L\n nyEcJqroAvDyWE1vMSyopde+tl6rUH+mmqOc9qe8inbHkc/+30wIdoVl4+nqB8R/\n a9+bUbjtKhiR0J67JqcHM6Cp7/g0YldotKxwVcFe7I4vcEtX2eEK99PK/1fiFU8w\n ch71oqq1wig0ss2TrI1+o0o6bW8wYbN5dFpCzIRgblGnpDQ6r4NsBjPZLShR6T09\n Uay9/hpebcylmTMXilb/4f0TiS+8m40sAKUbKtO44SzY6DY2fYW16CW6oRw5mpd1\n XDQI8Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1770487613; x=1771092413; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=SGn9Dx9TKhYwyyq6cn6DSMXoUDg7D4YZd5UT23z4be8=;\n b=g2iSfc1hWoVUCm+D7qiNk++SkQQOFK7v9Ql2LX8vT3tVIQL40M7jh19Xcw8KFpleVR\n borkWYzOikd6HeuhQtJnTbVeLAerGFM/OMRqZDHm1ydhEFx9yDK0Yt2CxA14jkuNKAHX\n e8keYbGillc/71mAlJgkRkwqV1MkIH+BwHaU6UscJdcJvfm0M3+b16/pNusfCsceYqmM\n 92rrvaQXAeaR5Z6qut8PQG+9FdrQF5j0NVGUG+WuiHh6D/3HNxLhH87S8XQyPX2JyZ9X\n hpEUpEr3cjuPpAwpW3il41xvS7oz9PvtMnpVWu8/YFk3u75ZN57FkB77+lXXpKKb0ZNE\n 46DA==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770487613; x=1771092413;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=SGn9Dx9TKhYwyyq6cn6DSMXoUDg7D4YZd5UT23z4be8=;\n b=ivJDVSu/TEITVUolk5D3KVMWr4GvQuu/PEco1/HwWBec6p63UyxYxzLwK0JFnrjeia\n sp3SLVMdejOEMGa5H/JmHTsMPgSSrm2XWsMsql8incsLNsLdba5yTZhmqC/d2NNcpOBC\n +5tjm0gYpei+VdDMQXsXAQHmLjArUU4oDR9HUP9q9OsTn9nm1vaWZXQvlFLuhFPtNsWx\n WtE4bkmMhYY/do0cXnqWsxFvfKm14gCmoLcdjaelCOwlKILBP4OPWX2X/nhZcLgaKMkN\n dlXW6bOL1jvemVguz0nvvviHsCxgi6VyFPIHYZyL28ZHByR/p3CgfBkZ5ZdFYv6oJAYo\n U7nA==", "X-Gm-Message-State": "AOJu0YyCJnbVHQE+Wsk05SO4KfD1i3cUOkOxSRpnm888g5+jjsHfF0wq\n siAmM6aRPLI2RvVyWqWL0Q8qmjxvAFcZUdZowfeeop9seX5QYfBW5BKA4mj5X8nnEbDfIhZX4cf\n QVkYtEjNHmp3031s771rSYkvg60PnsmZz2g4X0CwokEcP7SNSf96p1DF4GdKxk1/tjw==", "X-Gm-Gg": "AZuq6aLMi0xp69EGnzN0zc4F/++lLDJFxE/bCZQkWUCmfVyGiEQlzhJeqIj7hk4gwpG\n 78vOSg4G3GAhwpBufDbYl5aaOy0wdmFJF2eeXVPTa8fqW47fCr7N666myzObfuiLbEiROo5sSYG\n dE2rRUstYvoWnFKBJSA1JsCPj59FnnJyyiZ/aLVX+YyQCeGRQheGF3MsWem8tOq2oXx6bvKzAxS\n toSooN494katJXO504d8Us7yovQ3Rop0OI8Wtc4bwmNAhRFUI96x4f/O8VjcZODtgPpL7CGfnvI\n mbj7kJu3OPeWVlZ/6QHd6QySpUfpVBiKoCQ5OO4Llt3disyNUlsTwz+CNRmiLJiiy9Qz1gMhI2d\n ubgMCutu4dtgL63erKAeQfZ/8UzGyHJ9TRLxhnqh1NzwOk+xRJ9XQTG3jqA==", "X-Received": [ "by 2002:a05:7300:e82c:b0:2b8:26b8:3420 with SMTP id\n 5a478bee46e88-2b85646dfcfmr2996063eec.5.1770487612610;\n Sat, 07 Feb 2026 10:06:52 -0800 (PST)", "by 2002:a05:7300:e82c:b0:2b8:26b8:3420 with SMTP id\n 5a478bee46e88-2b85646dfcfmr2996054eec.5.1770487612112;\n Sat, 07 Feb 2026 10:06:52 -0800 (PST)" ], "From": "Brian Cain <brian.cain@oss.qualcomm.com>", "To": "qemu-devel@nongnu.org", "Cc": "brian.cain@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex@alexrp.com,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>", "Subject": "[PATCH v2 3/4] target/hexagon: Return decode failure for invalid\n non-duplex encodings", "Date": "Sat, 7 Feb 2026 10:06:31 -0800", "Message-Id": "<20260207180632.1042754-4-brian.cain@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260207180632.1042754-1-brian.cain@oss.qualcomm.com>", "References": "<20260207180632.1042754-1-brian.cain@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "X-Proofpoint-GUID": "Z-wkv2KEKX0WKULyRiwCpPmh3EaKlWbA", "X-Proofpoint-ORIG-GUID": "Z-wkv2KEKX0WKULyRiwCpPmh3EaKlWbA", "X-Authority-Analysis": "v=2.4 cv=F/tat6hN c=1 sm=1 tr=0 ts=69877f3d cx=c_pps\n a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22\n a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=D67r-eMCZ0zeLs--bqkA:9 a=QEXdDO2ut3YA:10\n a=bBxd6f-gb0O0v-kibOvt:22 a=cvBusfyB2V15izCimMoJ:22", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjA3MDE0OSBTYWx0ZWRfX6lgXRZnCwhgS\n kBmPD4GgCl8LumA7McuVW4f9LMD6BQoxSgG4bvYn25KyjzV2U3cvFjo/YYSiwaaaktztnlXOo/m\n sYzr+P7t2Q+t+H1Hh4lTr7Vvqxm6Fm3IuuvoYXt7CsyMwAjiVxNu/fnt+xt4WM6DrnVdiTCHKZ+\n P2dK5KY0r3w3qY35DCLqYhU7JQEYsNh3xN6/CDT4AKuk/4C0zTv311viQhCixQVjjgBgYO2saif\n wMP60j6g9xsKj9zuRdk8uiZvjukXxg1B+NMjjNgp2W58dHKSJljeLjf8TGJHJEet4nV1XfPPfN3\n P3ufz/TBwunoVJEbgQD2kXrseg5E7bCaE+LLyIA4tbKnG3/m40sw3hgrww4+4bDKNgp29Wu52Ma\n rqwQ/oumy8HxjQs2Lj6aLqItT6uRyyCv2UeZC9F3p7qG5v6DkaqJDNVI2RR5m1Fe1Gr+S5TL4YK\n +u1ACELAoUCFksRer1A==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-06_05,2026-02-05_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n bulkscore=0 adultscore=0 clxscore=1015 malwarescore=0 priorityscore=1501\n suspectscore=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602070149", "Received-SPF": "pass client-ip=205.220.180.131;\n envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "When a non-duplex encoding (parse_bits != 0) fails both decode_normal()\nand decode_hvx(), the decoder hit an unreachable. Instead, handle\nthe decode failure and raise an exception.\n\nSigned-off-by: Brian Cain <brian.cain@oss.qualcomm.com>\nReviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\n---\n target/hexagon/decode.c | 3 ++-\n tests/tcg/hexagon/invalid-encoding.c | 25 +++++++++++++++++++++++++\n 2 files changed, 27 insertions(+), 1 deletion(-)", "diff": "diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c\nindex 90499fc320..ebb4e02a17 100644\n--- a/target/hexagon/decode.c\n+++ b/target/hexagon/decode.c\n@@ -489,7 +489,8 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t encoding)\n insn->iclass = iclass_bits(encoding);\n return 1;\n }\n- g_assert_not_reached();\n+ /* Invalid non-duplex encoding */\n+ return 0;\n } else {\n uint32_t iclass = get_duplex_iclass(encoding);\n unsigned int slot0_subinsn = get_slot0_subinsn(encoding);\ndiff --git a/tests/tcg/hexagon/invalid-encoding.c b/tests/tcg/hexagon/invalid-encoding.c\nindex 1bbd312b61..040a7d9147 100644\n--- a/tests/tcg/hexagon/invalid-encoding.c\n+++ b/tests/tcg/hexagon/invalid-encoding.c\n@@ -93,6 +93,30 @@ static int test_invalid_dups(void)\n return sig;\n }\n \n+/*\n+ * Invalid non-duplex encoding:\n+ * The encoding 0xffffc000 has parse bits [15:14] = 0b11, making it a\n+ * non-duplex instruction and packet end. The remaining bits do not match\n+ * any valid normal or HVX instruction encoding, so this should raise SIGILL.\n+ */\n+static int test_invalid_nonduplex(void)\n+{\n+ int sig;\n+\n+ asm volatile(\n+ \"r0 = #0\\n\"\n+ \"r1 = ##1f\\n\"\n+ \"memw(%1) = r1\\n\"\n+ \".word 0xffffc000\\n\"\n+ \"1:\\n\"\n+ \"%0 = r0\\n\"\n+ : \"=r\"(sig)\n+ : \"r\"(&resume_pc)\n+ : \"r0\", \"r1\", \"memory\");\n+\n+ return sig;\n+}\n+\n int main()\n {\n struct sigaction act;\n@@ -104,6 +128,7 @@ int main()\n \n assert(test_invalid_duplex() == SIGILL);\n assert(test_invalid_dups() == SIGILL);\n+ assert(test_invalid_nonduplex() == SIGILL);\n \n puts(\"PASS\");\n return EXIT_SUCCESS;\n", "prefixes": [ "v2", "3/4" ] }